Re: [edk2-devel] [PATCH V2 1/6] MdePkg/Include: Update definitions of SPI related header files

2023-08-02 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Hi Liming, I think as the ECR already approved as the errata by PIWG, can we just merged the code to save sometime? Thanks Abner > -Original Message- > From: gaoliming > Sent: Wednesday, August 2, 2023 1:41 PM > To: Chang, Abner ; devel@edk2.groups.io

回复: [edk2-devel] [PATCH] Add PCI_EXPRESS_EXTENDED_CAPABILITY_DVSEC_ID

2023-08-02 Thread gaoliming via groups.io
Foster: Please add MdePkg/Include into the commit message subject. The code looks good. Reviewed-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Foster Nong > 发送时间: 2023年8月2日 12:01 > 收件人: devel@edk2.groups.io > 抄送: Foster Nong > 主题: [edk2-devel] [PATCH] Add

Re: [edk2-devel] [PATCH V5 1/3] MdePkg/Include: Add GUID for CERT_RSA3072 and CERT_RSA4096

2023-08-02 Thread Sheng Wei
Hi Gao, Liming, For this patch group, we have got review-by from Yao, Jiewen on patch 2/3(CryptoPkg) and patch 3/3(SecurityPkg). Do you any comments on the patch 1/3 (MdePkg) ? Patch 1/3 is only to add 2 new GUIDs. Could you help to merge it ? Thank you. BR Sheng Wei > -Original Message

[edk2-devel] 回复: [PATCH V2 3/6] MdePkg: Add definitions in DEC for SPI NOR Flash SPDF driver

2023-08-02 Thread gaoliming via groups.io
Abner: I add my comments. > -邮件原件- > 发件人: abner.ch...@amd.com > 发送时间: 2023年8月1日 15:57 > 收件人: devel@edk2.groups.io > 抄送: Michael D Kinney ; Liming Gao > ; Zhiguang Liu ; Abdul > Lateef Attar > 主题: [PATCH V2 3/6] MdePkg: Add definitions in DEC for SPI NOR Flash SPDF > driver > > From: A

Re: [edk2-devel] [PATCH V2 3/6] MdePkg: Add definitions in DEC for SPI NOR Flash SPDF driver

2023-08-02 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] This makes sense to me, I will update it. Thanks Abner > -Original Message- > From: gaoliming > Sent: Wednesday, August 2, 2023 4:06 PM > To: Chang, Abner ; devel@edk2.groups.io > Cc: 'Michael D Kinney' ; 'Zhiguang Liu' > ; Attar, AbdulLateef (Abdul Late

回复: [edk2-devel] [PATCH V5 1/3] MdePkg/Include: Add GUID for CERT_RSA3072 and CERT_RSA4096

2023-08-02 Thread gaoliming via groups.io
Sheng Wei: I gave my comments for the patch 1/3 on this morning. Have you got my response? I just want to confirm whether these two new GUID are in the public UEFI spec or not. Thanks Liming > -邮件原件- > 发件人: Sheng, W > 发送时间: 2023年8月2日 16:04 > 收件人: devel@edk2.groups.io; Gao, Liming >

回复: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL submodule to 3.0.9

2023-08-02 Thread gaoliming via groups.io
Yi: Thanks for your great work to update openssl 3.0. The commit message shows this patch set must catch edk2 202308 stable tag. Right? Edk2 202308 stable tag will start soft feature free from Aug 7th (next Monday). That means this patch set needs to pass code review in one week. Jiwen, Ger

[edk2-devel] Event: TianoCore edk2-test Bug Triage Meeting - Thursday, August 3, 2023 #cal-reminder

2023-08-02 Thread Group Notification
*Reminder: TianoCore edk2-test Bug Triage Meeting* *When:* Thursday, August 3, 2023 10:00pm to 11:00pm (UTC+08:00) Asia/Shanghai *Where:* https://armltd.zoom.us/j/91247522013?pwd=ei9nUndTbG9oWEROS2M1aVREZkpiQT09&from=addon *Organizer:* Edhaya Chandran edhaya.chand...@arm.com ( edhaya.chand...@a

[edk2-devel] Event: TianoCore Community Meeting EMEA/NAMO - Thursday, August 3, 2023 #cal-reminder

2023-08-02 Thread Group Notification
*Reminder: TianoCore Community Meeting EMEA/NAMO* *When:* Thursday, August 3, 2023 8:00am to 9:00am (UTC-07:00) America/Los Angeles *Where:* Microsoft Teams meeting Join on your computer or mobile app Click here to join the meeting Meeting ID: 226 323 011 029 Passcode: hMRCj6 Download Teams | Jo

Re: [edk2-devel] [PATCH v1 1/1] ArmPkg: DefaultExceptionHandlerLib: Do Not Allocate Memory

2023-08-02 Thread Ard Biesheuvel
On Tue, 1 Aug 2023 at 00:04, Oliver Smith-Denny wrote: > > If gST->ConOut is available when Arm's DefaultExceptionHandler > is running, AsciiPrint will get called to attempt to print to > ConOut, in addition to the serial output. > > AsciiPrint calls AsciiInternalPrint in UefiLibPrint.c which > in

Re: [edk2-devel] [PATCH v1 1/1] ArmPkg: DefaultExceptionHandlerLib: Do Not Allocate Memory

2023-08-02 Thread Ard Biesheuvel
On Wed, 2 Aug 2023 at 18:21, Oliver Smith-Denny wrote: > > On 8/2/2023 9:06 AM, Ard Biesheuvel wrote: > > On Tue, 1 Aug 2023 at 00:04, Oliver Smith-Denny > > wrote: > >> > >> If gST->ConOut is available when Arm's DefaultExceptionHandler > >> is running, AsciiPrint will get called to attempt to p

Re: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL submodule to 3.0.9

2023-08-02 Thread Michael D Kinney
Hi Liming, I have added Andrew and Leif to this thread so we can discuss if the release date need to be adjusted. Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of gaoliming > via groups.io > Sent: Wednesday, August 2, 2023 3:07 AM > To: devel@edk2.groups.io; Li, Yi1

Re: [edk2-devel] [PATCH v2 1/6] AlderlakeOpenBoardPkg: Add package and headers

2023-08-02 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Kasbekar, Saloni Sent: Tuesday, August 01, 2023 3:18 PM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Oram, Isaac W ; Chuang, Rosen Subject: [PATCH v2 1/6] AlderlakeOpenBoardPkg: Add

Re: [edk2-devel][edk2-platforms][PATCH V5-2] IpmiFeaturePkg:Provided multiple IPMI interface support in DXE and SMM

2023-08-02 Thread Isaac Oram
Reviewed-by: Isaac Oram -Original Message- From: devel@edk2.groups.io On Behalf Of Arun K via groups.io Sent: Tuesday, July 25, 2023 8:37 AM To: devel@edk2.groups.io; Arun K Cc: Oram, Isaac W ; Desimone, Nathaniel L ; Ramkumar Krishnamoorthi ; Gao, Liming Subject: [edk2-devel][edk2-

Re: [edk2-devel][edk2-platforms][PATCH V5-1] IpmiFeaturePkg:Provided multiple IPMI interface support in PEI

2023-08-02 Thread Isaac Oram
Reviewed-by: Isaac Oram -Original Message- From: Arun K Sent: Tuesday, July 25, 2023 8:36 AM To: devel@edk2.groups.io; Arun K Cc: Oram, Isaac W ; Desimone, Nathaniel L ; Ramkumar Krishnamoorthi ; Gao, Liming Subject: [edk2-devel][edk2-platforms][PATCH V5-1] IpmiFeaturePkg:Provided

Re: [edk2-devel] [PATCH v2 2/6] AlderlakeOpenBoardPkg: Add modules

2023-08-02 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Kasbekar, Saloni Sent: Tuesday, August 01, 2023 3:18 PM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Oram, Isaac W ; Chuang, Rosen Subject: [PATCH v2 2/6] AlderlakeOpenBoardPkg: Add

Re: [edk2-devel] [PATCH v2 3/6] AlderlakeOpenBoardPkg/AlderlakePRvp: Add libraries

2023-08-02 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Kasbekar, Saloni Sent: Tuesday, August 01, 2023 3:18 PM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Oram, Isaac W ; Chuang, Rosen Subject: [PATCH v2 3/6] AlderlakeOpenBoardPkg/Alder

Re: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL submodule to 3.0.9

2023-08-02 Thread Leif Lindholm
I am a little bit nervous about introducing this massive change so late in the cycle, and am not sure whether any deferral of the soft freeze would be sufficient to change that. My preference would be having this introduced right after the stable tag, giving it a full cycle of enforced testing bef

Re: [edk2-devel] [edk2-platforms][PATCH V5-3] IpmiFeaturePkg:Provided multiple IPMI interface support in Library

2023-08-02 Thread Isaac Oram
Pushed as e563c1c528f15d4224103f5c49559df620b5a655 Note I fixed PatchCheck.py issues and committed in an order that doesn't break git bisect. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107471): https://edk2.groups.io/g/devel/message

Re: [edk2-devel] [edk2-platforms][PATCH V5-1] IpmiFeaturePkg:Provided multiple IPMI interface support in PEI

2023-08-02 Thread Isaac Oram
Pushed as 421e64019d4622b049f510ba8eef7c82fba7b32d Note I fixed PatchCheck.py issues and committed in an order that doesn't break git bisect. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107472): https://edk2.groups.io/g/devel/message

Re: [edk2-devel] [edk2-platforms][PATCH V5-2] IpmiFeaturePkg:Provided multiple IPMI interface support in DXE and SMM

2023-08-02 Thread Isaac Oram
Pushed as 3037c13015016f7c398da37eabe33fb0961dc490 Note I fixed PatchCheck.py issues and committed in an order that doesn't break git bisect. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107473): https://edk2.groups.io/g/devel/message

Re: [edk2-devel] [PATCH v2 4/6] AlderlakeOpenBoardPkg: Add ACPI module

2023-08-02 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Kasbekar, Saloni Sent: Tuesday, August 01, 2023 3:18 PM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Oram, Isaac W ; Chuang, Rosen Subject: [PATCH v2 4/6] AlderlakeOpenBoardPkg: Add

Re: [edk2-devel] [PATCH v2 5/6] AlderlakeOpenBoardPkg: Adds the Policy Module

2023-08-02 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Kasbekar, Saloni Sent: Tuesday, August 01, 2023 3:18 PM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Oram, Isaac W ; Chuang, Rosen Subject: [PATCH v2 5/6] AlderlakeOpenBoardPkg: Adds

Re: [edk2-devel] [PATCH v2 6/6] AlderlakeOpenBoardPkg: Add Library Instances

2023-08-02 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Kasbekar, Saloni Sent: Tuesday, August 01, 2023 3:18 PM To: devel@edk2.groups.io Cc: Kasbekar, Saloni ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Oram, Isaac W ; Chuang, Rosen Subject: [PATCH v2 6/6] AlderlakeOpenBoardPkg: Add

[edk2-devel] [PATCH] OvmfPkg/BaseMemEncryptTdxLib: Make SetOrClearSharedBit() handle retry error

2023-08-02 Thread Isaku Yamahata
From: Isaku Yamahata TDG.VP.VMCALL can return TDG.VP.VMCALL_RETRY when the length is too large so that VMM can avoid too long processing time. The caller should retry with the updated starting GPA on the error. Add check TDG.VP.VMCALL_RETRY check. Signed-off-by: Isaku Yamahata --- MdePkg/Inc

Re: [edk2-devel] [PATCH edk2-platforms v1 2/3] Platform/ARM: FVP: Specify TRBE interrupt in MADT GICC

2023-08-02 Thread Jeshua Smith via groups.io
This code depends on ArmReadIdAA64Dfr0(), which as far as I can tell is not present in the EDK2 repo or the patch series mentioned in your 0/3 message. -Original Message- From: devel@edk2.groups.io On Behalf Of Jeshua Smith via groups.io Sent: Tuesday, August 1, 2023 9:38 AM To: devel@e

[edk2-devel] Event: TianoCore Community Meeting - APAC/NAMO - Thursday, August 3, 2023 #cal-reminder

2023-08-02 Thread Group Notification
*Reminder: TianoCore Community Meeting - APAC/NAMO* *When:* Thursday, August 3, 2023 7:30pm to 8:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_Y2M1NDE3ODYtN2M3Yy00MDMxLTk3OWYtMTlkNjhlNWFlMjA2%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e

[edk2-devel] [PATCH V2 01/29] CryptoPkg/openssl: update submodule to openssl-3.0.9

2023-08-02 Thread Li, Yi
From: Gerd Hoffmann Signed-off-by: Yi Li Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Library/OpensslLib/openssl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CryptoPkg/Library/OpensslLib/openssl b/CryptoPkg/Library/OpensslLib/openssl index 70c2912f63..d

[edk2-devel] [PATCH V2 00/29] CryptoPkg: Update OpenSSL submodule to 3.0.9

2023-08-02 Thread Li, Yi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3466 According to https://www.OpenSSL.org/policies/releasestrat.html, OpenSSL Version 1.1.1 will be supported until 2023-09-11 (LTS). Need to upgrade OpenSsl to 3.0.9 before 1.1.1 support stopping. PR: https://github.com/tianocore/edk2/pull/4692

[edk2-devel] [PATCH V2 04/29] CryptoPkg/openssl: add openssl3 configure scripts

2023-08-02 Thread Li, Yi
From: Gerd Hoffmann Rewrite the script to configure openssl 3.0 from scratch. It's two scripts now: * Tiny helper script, dumping the perl configdata as json. * Actual configure.py script, written in python, which copies over the generated files to openssl-gen and updates the OpensslLib*.i

[edk2-devel] [PATCH V2 05/29] CryptoPkg/openssl: UefiAsm.conf update for openssl 3.0

2023-08-02 Thread Li, Yi
From: Gerd Hoffmann New naming convention for the configs: UEFI-${efiarch}-${compiler}. Signed-off-by: Gerd Hoffmann Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Library/OpensslLib/UefiAsm.conf | 41 +++ 1 file changed, 12 insertions(+), 29 deletions(-)

[edk2-devel] [PATCH V2 03/29] CryptoPkg/openssl: update Openssl*.inf files for openssl 3.0

2023-08-02 Thread Li, Yi
From: Gerd Hoffmann The configure workflow as changed, see the commit adding the configure script for details. Adapt the *.inf files to the changes. The configuration define handling has changed a bit. The new configure script will build a single per-arch file list, which simplifies the Accel

[edk2-devel] [PATCH V2 06/29] CryptoPkg/BaseCryptLib: no openssl deprecation warnings please

2023-08-02 Thread Li, Yi
From: Gerd Hoffmann Stop using deprecated interfaces is left as exercise for another day. So please don't warn for now so -Werror builds can work. Signed-off-by: Gerd Hoffmann Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Library/BaseCryptLib/InternalCryptLib.h | 2 ++ 1 file

[edk2-devel] [PATCH V2 07/29] CryptoPkg/BaseCryptLib: adapt CryptSm3.c to openssl 3.0 changes.

2023-08-02 Thread Li, Yi
From: Gerd Hoffmann Functions have been renamed. Signed-off-by: Gerd Hoffmann Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Library/BaseCryptLib/Hash/CryptSm3.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/CryptoPkg/Library/BaseCryptLib/Ha

[edk2-devel] [PATCH V2 08/29] CryptoPkg/BaseCryptLib: drop BIO_* dummy functions

2023-08-02 Thread Li, Yi
From: Gerd Hoffmann openssl 3.0 requires a functional BIO_sprintf() implementation. Signed-off-by: Gerd Hoffmann Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- .../Library/BaseCryptLib/SysCall/CrtWrapper.c | 27 --- .../SysCall/UnitTestHostCrtWrapper.c | 25 -

[edk2-devel] [PATCH V2 14/29] CryptoPkg: Move all UEFI implement of openssl to OpensslStub

2023-08-02 Thread Li, Yi
Signed-off-by: Yi Li Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Library/OpensslLib/OpensslLib.inf | 8 CryptoPkg/Library/OpensslLib/OpensslLibAccel.inf | 8 CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf | 8 CryptoP

[edk2-devel] [PATCH V2 15/29] CryptoPkg: use UEFI provider as default

2023-08-02 Thread Li, Yi
Added UEFI provider which removed unused features to optimize the size of openssl3. Signed-off-by: Yi Li Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Library/OpensslLib/OpensslLib.inf | 1 + .../Library/OpensslLib/OpensslLibAccel.inf| 1 + .../Library/OpensslLib/Opens

[edk2-devel] [PATCH V2 09/29] CryptoPkg/TlsLib: ERR_GET_FUNC is gone

2023-08-02 Thread Li, Yi
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Library/TlsLib/TlsConfig.c | 2 +- CryptoPkg/Library/TlsLib/TlsProcess.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/CryptoPkg/Library/TlsLib/TlsConfig.c

[edk2-devel] [PATCH V2 12/29] CryptoPkg/openssl: store dummy update for openssl 3.0

2023-08-02 Thread Li, Yi
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Signed-off-by: Yi Li Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Library/OpensslLib/ossl_store.c | 156 ++ 1 file changed, 156 insertions(+) diff --git a/CryptoPkg/Library/OpensslLib/ossl_store.c b/Crypto

[edk2-devel] [PATCH V2 11/29] CryptoPkg/openssl: move compiler_flags to buildinf.c

2023-08-02 Thread Li, Yi
From: Gerd Hoffmann Seems with openssl 3.0 this is used by multiple source files, so we get duplicate symbol errors when linking. Fix that by moving compiler_flags from header file to a source file. Signed-off-by: Gerd Hoffmann Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Li

[edk2-devel] [PATCH V2 13/29] CryptoPkg/openssl: adapt EcSm2Null.c for openssl 3.0

2023-08-02 Thread Li, Yi
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Library/OpensslLib/EcSm2Null.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/CryptoPkg/Library/OpensslLib/EcSm2Null.c b/CryptoPkg/Library/OpensslLib/EcSm

[edk2-devel] [PATCH V2 16/29] CryptoPkg: adapt 3.0 change in SslNull.c

2023-08-02 Thread Li, Yi
Type of input params changed in openssl30. Signed-off-by: Yi Li Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Library/OpensslLib/OpensslStub/SslNull.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CryptoPkg/Library/OpensslLib/OpensslStub/SslNull.c b/

[edk2-devel] [PATCH V2 10/29] CryptoPkg/openssl: adapt rand_pool.c to openssl 3.0 changes

2023-08-02 Thread Li, Yi
From: Gerd Hoffmann Some functions have been renamed. Signed-off-by: Gerd Hoffmann Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Library/OpensslLib/rand_pool.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/CryptoPkg/Library/Open

[edk2-devel] [PATCH V2 17/29] CryptoPkg: Add instrinsics to support building openssl3 on IA32 windows

2023-08-02 Thread Li, Yi
This dependency is needed to build openssl lib with openssl3 under IA32 Windows, so added implementation for _alldiv, _aulldiv, _aullrem and _alldvrm instrinsics. Signed-off-by: Yi Li Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- .../Library/IntrinsicLib/Ia32/MathLldiv.asm | 203 +++

[edk2-devel] [PATCH V2 18/29] CryptoPkg: disable C4133 warning in openssl libraries

2023-08-02 Thread Li, Yi
Disable warning as error of C4133: v3_genn.c(101): warning C4133: 'function': incompatible types - from 'ASN1_TYPE *' to 'const ASN1_STRING *'. Signed-off-by: Yi Li Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Library/OpensslLib/OpensslLib.inf | 5 +++-- CryptoPkg/Libr

[edk2-devel] [PATCH V2 19/29] CryptoPkg/TlsLib: use unsigned long for ErrorCode

2023-08-02 Thread Li, Yi
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Library/TlsLib/TlsConfig.c | 3 ++- CryptoPkg/Library/TlsLib/TlsProcess.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/CryptoPkg/Library/TlsLib/TlsConfig.c

[edk2-devel] [PATCH V2 20/29] CryptoPkg: Align with 4096 when build with OpensslFullAccel

2023-08-02 Thread Li, Yi
Should align to 4096 when build ecp_nistz256 related asm files. ecp_nistz256-x86.S Line3: .globl ecp_nistz256_precomputed .align 4096 Signed-off-by: Yi Li Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/CryptoPkg.dsc | 12 ++-- 1 file changed, 6 insertions(+), 6 deletion

[edk2-devel] [PATCH V2 21/29] CryptoPkg: Enable memcpy sys call in RISCV64 build

2023-08-02 Thread Li, Yi
When build Openssl30, compiler optimization may use memcpy() for memory copy. Need enable it in RISCV64 build also. Signed-off-by: Yi Li Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Cryp

[edk2-devel] [PATCH V2 22/29] CryptoPkg: add missing gcc instructions

2023-08-02 Thread Li, Yi
Used when build IA32 CryptoPkg by gcc, the definition of the instructions can be found at: https://gcc.gnu.org/onlinedocs/gccint/Integer-library-routines.html Signed-off-by: Yi Li Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- .../IntrinsicLib/Ia32/MathDivModU64x64.c | 23

[edk2-devel] [PATCH V2 23/29] CryptoPkg: add define of maximum unsigned size_t

2023-08-02 Thread Li, Yi
Used by openssl30 source code. Signed-off-by: Yi Li Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Library/Include/CrtLibSupport.h | 1 + 1 file changed, 1 insertion(+) diff --git a/CryptoPkg/Library/Include/CrtLibSupport.h b/CryptoPkg/Library/Include/CrtLibSupport.h index 94b0

[edk2-devel] [PATCH V2 24/29] CryptoPkg: add implemention of _ftol2_sse() to avoid build error

2023-08-02 Thread Li, Yi
Signed-off-by: Yi Li Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Library/IntrinsicLib/Ia32/MathFtol.c | 12 1 file changed, 12 insertions(+) diff --git a/CryptoPkg/Library/IntrinsicLib/Ia32/MathFtol.c b/CryptoPkg/Library/IntrinsicLib/Ia32/MathFtol.c index 09000c6

[edk2-devel] [PATCH V2 25/29] CryptoPkg: add more dummy implement of openssl for size optimization

2023-08-02 Thread Li, Yi
Add dummy implement of Encoder, Pkcs12 and sslserver. OpenSSL libraries which don't need these features can include these files to reduce the size of output. Signed-off-by: Yi Li Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Library/OpensslLib/OpensslLib.inf | 4 + .../Libra

[edk2-devel] [PATCH V2 27/29] CryptoPkg: remove strcmp to syscall

2023-08-02 Thread Li, Yi
In rare cases the platform may not provide the full IntrinsicLib. But openssl30 build always require strcmp, provide this function by moving it into CrtWrapper.c. Signed-off-by: Yi Li Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c | 9 +++

[edk2-devel] [PATCH V2 29/29] CryptoPkg: remove BN and EC accel for size optimization

2023-08-02 Thread Li, Yi
BN and EC have not been fully tested, and will greatly increase the size of the Crypto driver(>150KB). Signed-off-by: Yi Li Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- .../Library/OpensslLib/OpensslLibAccel.inf| 26 ++ .../OpensslLib/OpensslLibFullAccel.inf| 34 +

[edk2-devel] [PATCH V2 28/29] CryptoPkg/openssl: update CI config for openssl 3.0

2023-08-02 Thread Li, Yi
From: Gerd Hoffmann Signed-off-by: Gerd Hoffmann Signed-off-by: Yi Li Cc: Jiewen Yao Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/CryptoPkg.ci.yaml | 54 + 1 file changed, 43 insertions(+), 11 deletions(-) diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/Crypt

Re: [edk2-devel] [PATCH 01/22] CryptoPkg/openssl: update submodule to openssl-3.0.8

2023-08-02 Thread Li, Yi
Hi Ard, Your feedback already integrated to latest patch series: [PATCH V2 00/29] CryptoPkg: Update OpenSSL submodule to 3.0.9 Thanks for your review, let me know if you have any feedback. Regards, Yi -Original Message- From: devel@edk2.groups.io On Behalf Of Ard Biesheuvel Sent: Frid

Re: [edk2-devel] [PATCH v2] MdeModulePkg/SetupBrowser: Load storage via GetVariable for EfiVarStore

2023-08-02 Thread Dandan Bi
Hi Liming, Yes, with this change, the performance is better than before. Especially for the big formset with lots of configuration, it has better use experience when loading the formset to display. Could you help review this patch? Thanks. Thanks, Dandan -Original Message- From: gaol

[edk2-devel] [PATCH v2] MdeModulePkg: AllocatePages for TranslateBmpToGopBlt

2023-08-02 Thread chitralekha ck
https://bugzilla.tianocore.org/show_bug.cgi?id=4507 AllocatePool limits to allocate memory of 64 KB at most in PEI Phase. AllocatePool() is being avoided due to its 64k allocation size limit when the library is incorporated into a PEI component. change the function debug string to __func__ Cc: Ra

Re: [edk2-devel] [PATCH v2] MdeModulePkg: AllocatePages for TranslateBmpToGopBlt

2023-08-02 Thread Ni, Ray
Please don't mix the two changes in one patch. The two changes are: 1. change to use __func__ 2. AllocatePages > -Original Message- > From: Ck, Chitralekha > Sent: Thursday, August 3, 2023 1:00 PM > To: devel@edk2.groups.io > Cc: Ck, Chitralekha ; Ni, Ray ; > Gao, > Zhichao ; S, Ashraf A

Re: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL submodule to 3.0.9

2023-08-02 Thread Li, Yi
Hi Liming, Yes, we'd better catch edk2 202308 stable tag. If there are new CVE problems after OpenSSL1.1 EOL, we won't get support from the openssl community. Updating to 3.0 ASAP is the best choice. Regards, Yi -Original Message- From: gaoliming Sent: Wednesday, August 2, 2023 6:07

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformConfigDxe: fix can not set one-of option issue.

2023-08-02 Thread Nickle Wang via groups.io
Hi Igor, Thanks for your review. I think this is feasible. Let me try it and provide version 2 patch. Thanks, Nickle > -Original Message- > From: Igor Kulchytskyy > Sent: Monday, July 24, 2023 9:49 AM > To: Nickle Wang ; devel@edk2.groups.io > Cc: Abner Chang ; Nick Ramirez > > Subjec

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller.

2023-08-02 Thread Nickle Wang via groups.io
Hi Make, > I would suggest to remove this `if (EFI_ERROR (Status)) {` block at all. Are you suggesting to not release "ResponseMessage->Body"[1] while error happens because caller will handle this too? [1]: Line 452 - 454 at: https://github.com/tianocore/edk2/pull/4672/files#diff-18a31a76c495b

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishCrtLib: multiple definitions of strncpy.

2023-08-02 Thread Nickle Wang via groups.io
Thanks for your review, Mike! I am ok to remove all duplicated declarations in this file. @Abner Chang, any concern? Thanks, Nickle > -Original Message- > From: Mike Maslenkin > Sent: Saturday, July 22, 2023 8:28 PM > To: devel@edk2.groups.io; Nickle Wang > Cc: Abner Chang ; Igor Kulc

[edk2-devel] [PATCH 1/1] OutOfBandManagement/SpcrFeaturePkg: PCD based IRQ/GSI

2023-08-02 Thread Abdul Lateef Attar via groups.io
From: Abdul Lateef Attar Create a new PCD to hold the IRQ or GSI number for SPCR, with default values of 4. Update the ACPI SPCR table's IRQ value based on PCD. Cc: Sai Chaganty Cc: Isaac Oram Cc: Nate DeSimone Cc: Liming Gao Cc: Abner Chang Signed-off-by: Abdul Lateef Attar Change-Id: I7

Re: [edk2-devel] [PATCH 1/1] OutOfBandManagement/SpcrFeaturePkg: PCD based IRQ/GSI

2023-08-02 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Acked-by: Abner Chang > -Original Message- > From: Abdul Lateef Attar > Sent: Thursday, August 3, 2023 2:35 PM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; Sai > Chaganty ; Isaac Oram > ; Nate DeSimone > ; Liming Gao ; > Chang, A

Re: [edk2-devel] [PATCH edk2-platforms v1 2/3] Platform/ARM: FVP: Specify TRBE interrupt in MADT GICC

2023-08-02 Thread Sami Mujawar
Hi Jeshua, Thank you for the feedback. On Tue, Aug 1, 2023 at 08:38 AM, Jeshua Smith wrote: > > This comment in the code looks wrong: > > + // TRBE Interrupt is PPI 13 on FVP model. > + TrbeInterrupt = 31; I will fix this in the v2 series. Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Grou