Hi Michael,
I updated the commit messages and the EDK II CI passes,
The PR link is as below.
https://github.com/tianocore/edk2/pull/4480
Please help merge, thanks for the helping
On 2023/6/3 14:13, Li, Yong wrote:
> Hi Michael
>
> This is the change to MdePkg/Library/BaseLib/RiscV64.
> Sinc
Currently, Python FMMT tool does not support automatically
select FMMTConf.ini file which saves GuidTool settings.
This patch support this features.
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Signed-off-by: Yuwei Chen
---
BaseTools/Source/Python/FMMT/core/GuidTools.py | 2 +-
1 file changed
On Mon, 5 Jun 2023 at 10:10, Ranbir Singh wrote:
>
> I counted myself as not the right person to decide what all to do if Status
> is not successful. Adding the DEBUG statement from the Coverity aspect
> doesn't count as a fix as RELEASE mode behavior remains the same.
>
> In the comments / desc
On Mon, 5 Jun 2023 at 09:54, Ranbir Singh wrote:
>
> Please read the Coverity report attached in BZ 4204 for more details on
> sign-extension issue.
>
I did read it - explanation below.
> The data types of logic_sector_size_hi and logic_sector_size_lo are UINT16
> and Isn't the return type of
This patch is good to me.
Reviewed-by: Bob Feng
Thanks,
Bob
-Original Message-
From: Chen, Christine
Sent: Tuesday, April 18, 2023 5:53 PM
To: devel@edk2.groups.io
Cc: Rebecca Cran ; Gao, Liming ;
Feng, Bob C
Subject: [Patch V1 1/3] BaseTools: fixing FMMT ShrinkFv issue
1. FvLength
Reviewed-by: Bob Feng
-Original Message-
From: Chen, Christine
Sent: Tuesday, April 18, 2023 5:53 PM
To: devel@edk2.groups.io
Cc: Rebecca Cran ; Feng, Bob C ; Gao,
Liming
Subject: [Patch V1 2/3] BaseTools: FMMT replace output file is not generated
successfully
For replace function,
Reviewed-by: Bob Feng
-Original Message-
From: Chen, Christine
Sent: Tuesday, April 18, 2023 5:55 PM
To: devel@edk2.groups.io
Cc: Rebecca Cran ; Feng, Bob C ; Gao,
Liming
Subject: [Patch V1 3/3] BaseTools: FMMT support ELF UPLD parser
FMMT add new function to support the .elf file pa
I spent some time to verify if the IntelMmSaveStateLib behaves the same as the
default implementation in CpuSmm driver.
The result looks good with following embedded test code in BSPHandler():
for (Cpu = 0; Cpu < mMaxNumberOfCpus; Cpu++) {
DEBUG ((DEBUG_INFO, "Testing SMRAM Read CPU[%d]
On Mon, 5 Jun 2023 at 12:50, Yuquan Wang wrote:
>
> This patchset implements XHCI on sbsa-ref board to replace EHCI.
> As sbsa-ref does not have DRAM below 4G, it cannot utilize EHCI
> that only has 32-bit DMA capablity. Now this board has XHCI as
> an available usb controller with 64-bit DMA capa
On Mon, 5 Jun 2023 at 12:53, wangyuquan1236
wrote:
>
> Sorry for my awkward operations, because I felt the email refused problem
> with devel@edk2.groups.io;
Are you subscribed to the mailing list?
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply
Define the pcd settings for identifying the base address of XHCI
and XHCI's mmio size, and remove relevant EHCI settings.
Signed-off-by: Yuquan Wang
Change-Id: Ic144e7125332de5f2f2151f3b6856bd095c95a58
---
Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 6 +++---
1 file changed, 3 insertions(+), 3 deletio
This patchset implements XHCI on sbsa-ref board to replace EHCI.
As sbsa-ref does not have DRAM below 4G, it cannot utilize EHCI
that only has 32-bit DMA capablity. Now this board has XHCI as
an available usb controller with 64-bit DMA capablity.
Yuquan Wang (3):
Platform/Qemu/SbsaQemu/SbsaQe
As sbsa-ref board uses xhci to replace ehci, the DSDT is updated to match
the platform xhci controller. This also removes previous ehci structure.
Signed-off-by: Yuquan Wang
Change-Id: I7f7d6f69e3091f036ff086722ea5847ba2a1e27c
---
.../Qemu/SbsaQemu/AcpiTables/AcpiTables.inf | 4 +-
Silicon/Q
This registers the non-discoverable XHCI for sbsa-ref.
Signed-off-by: Yuquan Wang
Change-Id: Iace5a04ea6087de6b0d855e84c90b4754a66594a
---
.../SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.c | 40 ++-
.../SbsaQemuPlatformDxe.inf | 2 +
Silicon/Qemu/SbsaQemu/SbsaQemu.
Yes, at the third time I found I need to subscribe this channel, so I succeeded.
Now, I can send the patch normally.
Thanks for your guidance.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#105717): https://edk2.groups.io/g/devel/message
Sorry for my awkward operations, because I felt the email refused problem with
devel@edk2.groups.io; ( devel@edk2.groups.io, )
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#105716): https://edk2.groups.io/g/devel/message/105716
Mute Thi
Add the new section for Secure Boot.
Signed-off-by: Alexander Goncharov
---
OvmfPkg/README | 36
1 file changed, 36 insertions(+)
diff --git a/OvmfPkg/README b/OvmfPkg/README
index 0a408abf01..e106e19818 100644
--- a/OvmfPkg/README
+++ b/OvmfPkg/README
@@ -1
Please read the Coverity report attached in BZ 4204 for more details on
sign-extension issue.
The data types of logic_sector_size_hi and logic_sector_size_lo are UINT16
and Isn't the return type of *sizeof* already unsigned ?
Now I have no means to run Coverity and test further changes.
Anyway, m
I counted myself as not the right person to decide what all to do if
*Status* is not successful. Adding the DEBUG statement from the Coverity
aspect doesn't count as a fix as RELEASE mode behavior remains the same.
In the comments / description, I already mentioned - Assuming, this
non-usage is de
Thanks Ard for adding the explanation.
Ok, so retaining outer cast along with intermediate casting
BlockSize = (UINT32)(((UINT32)(IdentifyData->AtaData.logic_sector_size_hi
<< 16) | IdentifyData->AtaData.logic_sector_size_lo) * sizeof (UINT16));
should be acceptable. I considered outer cast is b
Hi team,
could you please help in analysis over the error which was mentioned::
(Python 3.8.8 on win32) Traceback (most recent call last):
File "C:\gnr\edk2\BaseTools\Source\Python\build\build.py", line 2697, in Main
MyBuild.Launch()
File "C:\gnr\edk2\BaseTools\Source\Python\build\build.
On 2023-06-05 11:51, Ard Biesheuvel wrote:
On Mon, 5 Jun 2023 at 12:50, Yuquan Wang wrote:
This patchset implements XHCI on sbsa-ref board to replace EHCI.
As sbsa-ref does not have DRAM below 4G, it cannot utilize EHCI
that only has 32-bit DMA capablity. Now this board has XHCI as
an availabl
This registers the non-discoverable XHCI for sbsa-ref.
Signed-off-by: Yuquan Wang
---
.../SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.c | 40 ++-
.../SbsaQemuPlatformDxe.inf | 2 +
Silicon/Qemu/SbsaQemu/SbsaQemu.dec| 4 +-
3 files changed, 35 insertion
Define the pcd settings for identifying the base address of XHCI
and XHCI's mmio size, and remove relevant EHCI settings.
Signed-off-by: Yuquan Wang
---
Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Platform/Qemu/SbsaQemu/SbsaQemu.d
This patchset implements XHCI on sbsa-ref board to replace EHCI.
As sbsa-ref does not have DRAM below 4G, it cannot utilize EHCI
that only has 32-bit DMA capablity. Now this board has XHCI as
an available usb controller with 64-bit DMA capablity.
This version(v1) has removed Change-Id from patch
As sbsa-ref board uses xhci to replace ehci, the DSDT is updated to match
the platform xhci controller. This also removes previous ehci structure.
Signed-off-by: Yuquan Wang
---
.../Qemu/SbsaQemu/AcpiTables/AcpiTables.inf | 4 +-
Silicon/Qemu/SbsaQemu/AcpiTables/Dsdt.asl | 125 ++
On Mon, 5 Jun 2023 at 14:48, Yuquan Wang wrote:
>
> This patchset implements XHCI on sbsa-ref board to replace EHCI.
> As sbsa-ref does not have DRAM below 4G, it cannot utilize EHCI
> that only has 32-bit DMA capablity. Now this board has XHCI as
> an available usb controller with 64-bit DMA capa
Fix RedfishClientPkg build errors and typos. The compiler toolchain is GCC5.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Nickle Wang (9):
RedfishClientPkg/ConverterLib: Fix unused-but-set-variable error
RedfishClientPkg/RedfishAddendumLib: Fix build error
RedfishClien
Rename ProvisioningCallback() to GetData() and
OemCallback() to GetOemData() and fix build error
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
.../Library/RedfishAddendumLib/RedfishAddendumLib.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --g
Remove uncessary parameter and fix build error.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
.../EdkIIRedfishResourceConfigLib.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
a/RedfishClientPkg/Library/EdkIIRedfishResour
Follow latest definition of EDKII_REDFISH_VALUE_TYPES and
rename all corresponding variable in RedfishFeatureUtilityLib.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
.../RedfishFeatureUtilityLib.c| 50 +--
1 file changed, 25 insertions(+),
- Fix missing "EFIAPI" build error.
- Fix typos.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
.../Include/Protocol/EdkIIRedfishETagProtocol.h | 2 +-
RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c| 13 -
2 files changed, 9 insertions(+), 6 deletion
Add missing "EFIAPI" and fix build error
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
.../RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/RedfishClientPkg/RedfishConfigLangMapDxe/RedfishConfigLangMapDxe.c
- Fix "variable set but not used" error.
- Fix missing "EFIAPI" error.
- Fix typos.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
.../Features/Bios/v1_0_9/Dxe/BiosDxe.c| 20 ++-
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/Redfish
- Fix "variable set but not used" error.
- Fix missing "EFIAPI" error.
- Fix typos.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
.../Features/Memory/V1_7_1/Dxe/MemoryDxe.c| 19 +++
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/Redfish
- Fix "variable set but not used" error.
- Fix missing "EFIAPI" error.
- Fix typos.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
.../v1_5_0/Dxe/ComputerSystemDxe.c| 19 +++
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git
a/Redfis
RedfishClientPkg is moved from edk2-staging repository to
edk2-redfish-client repository. Update the link in Readme.md
to new location.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
RedfishPkg/Readme.md | 22 +++---
1 file changed, 11 insertions(+), 11 del
Review-by
-Original Message-
From: devel@edk2.groups.io On Behalf Of Sheng, W
Sent: Thursday, May 25, 2023 1:23 PM
To: devel@edk2.groups.io
Cc: Yao, Jiewen ; Wang, Jian J ;
Xu, Min M ; Chen, Zeyi ; Wang, Fiona
Subject: [edk2-devel] [PATCH] SecurityPkg/SecureBoot: Support RSA 512 and RS
Hi, Yuquan
> On Jun 5, 2023, at 16:54, Yuquan Wang wrote:
>
> Define the pcd settings for identifying the base address of XHCI
> and XHCI's mmio size, and remove relevant EHCI settings.
>
> Signed-off-by: Yuquan Wang
> Change-Id: Ic144e7125332de5f2f2151f3b6856bd095c95a58
Please remove Change-
Regardless of the long standing desire to resume involvement
in the project, I'm unable to double the time in a day.
That's why I'm removing myself from sbsa-ref maintainers.
Signed-off-by: Radoslaw Biernacki
---
Maintainers.txt | 1 -
1 file changed, 1 deletion(-)
diff --git a/Maintainers.txt
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Groups.io Inc//Groups.io Calendar//EN
METHOD:PUBLISH
REFRESH-INTERVAL;VALUE=DURATION:PT1H
X-PUBLISHED-TTL:PT1H
CALSCALE:GREGORIAN
BEGIN:VTIMEZONE
TZID:America/Los_Angeles
LAST-MODIFIED:20230407T050750Z
TZURL:https://www.tzurl.org/zoneinfo-outlook/America/Los_An
*Reminder: Tools, CI, Code base construction meeting series*
*When:*
Monday, June 5, 2023
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272f98
*Tools, CI, Code base construction meeting series*
*When:*
Monday, June 5, 2023
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272f988bf-86f1-4
Reviewed by Jenny Huang
-Original Message-
From: devel@edk2.groups.io On Behalf Of Sheng, W
Sent: Tuesday, May 23, 2023 1:11 AM
To: devel@edk2.groups.io
Cc: Ni, Ray ; Chaganty, Rangasai V
; Huang, Jenny ;
Kowalewski, Robert
Subject: [edk2-devel] [PATCH] IntelSiliconPkg/IntelVTdDmarPei
*Reminder: TianoCore Bug Triage - APAC / NAMO*
*When:*
Tuesday, June 6, 2023
6:30pm to 7:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed4
Reviewed-by: Chao Li
Thanks,
Chao
在 2023/6/1 19:19, xianglai 写道:
When 0 address protection is enabled,
0-4k memory needs to be preallocated to
prevent UEFI applications from allocating use,
such as grub.
Cc: Ard Biesheuvel
Cc: Bibo Mao
Cc: Chao Li
Cc: Leif Lindholm
Cc: Liming Gao
Cc: Michael
Hi Ray,
I still haven't seen a calendar invitation. Could you please send one
for us to reserve the slot on our calendars?
Thanks,
Michael
On 6/1/2023 11:09 PM, Michael Kubacki wrote:
Sounds good, thanks for the quick response. Can you please send a
calendar invite when you get a chance?
O
Add Stewards.
I cannot merge PR https://github.com/tianocore/edk2/pull/4478 due to constant
cancelled CI tests.
Could someone help with the situation or help to merge the change? Thanks in
advance.
Best Regards,
Hao Wu
From: devel@edk2.groups.io On Behalf Of Wu, Hao A
Sent: Monday, June 5, 20
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Groups.io Inc//Groups.io Calendar//EN
METHOD:PUBLISH
REFRESH-INTERVAL;VALUE=DURATION:PT1H
X-PUBLISHED-TTL:PT1H
CALSCALE:GREGORIAN
BEGIN:VTIMEZONE
TZID:Asia/Shanghai
LAST-MODIFIED:20230407T050750Z
TZURL:https://www.tzurl.org/zoneinfo-outlook/Asia/Shanghai
X-LIC-
Reviewed-by: Chao Li
Thanks,
Chao
在 2023/6/1 19:20, xianglai 写道:
Fix some errors in the Readme file.
Cc: Ard Biesheuvel
Cc: Bibo Mao
Cc: Chao Li
Cc: Leif Lindholm
Cc: Liming Gao
Cc: Michael D Kinney
Signed-off-by: xianglai li
---
Platform/Loongson/LoongArchQemuPkg/Readme.md | 2 +-
1 file
I just set it up.
It's in https://edk2.groups.io/g/devel/calendar, also in attachment.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael
> Kubacki
> Sent: Tuesday, June 6, 2023 10:14 AM
> To: Ni, Ray ; devel@edk2.groups.io
> Cc: Leif Lindholm ; Ard Biesheuvel
> ; Sami
Sorry for the late response, inline comments below:
> -Original Message-
> From: brit.ches...@amd.com
> Sent: Wednesday, May 17, 2023 6:16 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Gao, Liming
> ; Wu, Hao A ; Ni, Ray
>
> Subject: [PATCH v1 1/1] MdeModulePkg: UsbBusDxe: Build De
This library supports a PeiServicesTablePointerLib implementation
that allows code dependent upon PeiServicesTable to operate in an
isolated execution environment such as within the context of a
host-based unit test framework.
The unit test should initialize the PeiServicesTable database with
any
Reviewed-by: Ray Ni
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Zhiguang Liu
> Sent: Tuesday, June 6, 2023 1:40 PM
> To: devel@edk2.groups.io
> Cc: Liu, Zhiguang ; Kinney, Michael D
> ; Michael Kubacki
> ; Sean Brogan
> Subject: [edk2-devel] [PATCH v2] UnitTestFramewo
Increase max buffer size to support more than 64K.
Signed-off-by: Giri Mudusuru
Cc: Ray Ni
Cc: Zhichao Gao
Cc: Andrew Fish
---
ShellPkg/Application/Shell/Shell.c | 5 +++--
ShellPkg/Library/UefiShellLib/UefiShellLib.c | 19 ++-
ShellPkg/ShellPkg.dec
Backward-compatibility changes:
This patch series removes the SmmCpuFeaturesReadSaveStateRegister
and SmmCpuFeaturesWriteSaveStateRegister interface/function.
SmmReadSaveState() and SmmWriteSaveState() now directly invokes MmSaveStateLib
routines to save/restore registers.
PR: https://gith
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Adds MmSaveStateLib Library class in UefiCpuPkg.dec.
Adds function declaration header file.
Cc: Paul Grimes
Cc: Abner Chang
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Abdul Lateef Attar
Reviewed-by: Abn
From: Abdul Lateef Attar
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Implements MmSaveStateLib Library class for
AMD cpu family.
Cc: Paul Grimes
Cc: Abner Chang
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Signed-off-by: Abdul Lateef Attar
Reviewed-by: Abner Ch
From: Abdul Lateef Attar
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
moves Intel-specific code to the arch-dependent file.
Other processor families might have different
implementation of these functions.
Hence, moving out of the common file.
Cc: Abner Chang
Cc: Paul Grimes
Cc: Eri
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Adds an SMM SMRAM save-state map for AMD processors.
SMRAM save state maps for the AMD processor family are now supported.
Save state map structure is added based on
AMD64 Architecture Programmer's Manual, Volume 2, Section 10.2.
The AMD le
From: Abdul Lateef Attar
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Implements interfaces to read and write save state
registers of AMD's processor family.
Initializes processor SMMADDR and MASK depends
on PcdSmrrEnable flag.
Program or corrects the IP once control returns from SMM.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Implements MmSaveStateLib library interfaces
to read and write save state
registers for Intel processor family.
Moves Intel and AMD common functionality to common area.
Cc: Paul Grimes
Cc: Abner Chang
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Removes SmmCpuFeaturesReadSaveStateRegister and
SmmCpuFeaturesWirteSaveStateRegister function from
SmmCpuFeaturesLib library.
MmSaveStateLib library replaces the functionality of the above
functions.
Platform old/new need to use MmSaveStateL
From: Abdul Lateef Attar
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182
Uses new MmSaveStateLib library instance.
Cc: Paul Grimes
Cc: Abner Chang
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Signed-off-by: Abdul
Hi Ard,
The error is created by this commit
https://github.com/tianocore/edk2/commit/e6447d2a08f5ca585816d093e79a01dad3781f98.
We are investigating and will get back to you soon.
Thanks for merging our patches.
-Nhi
On 6/2/2023 7:48 PM, Ard Biesheuvel wrote:
On Wed, 24 May 2023 at 02:41, M
65 matches
Mail list logo
