(cc Liming)
I'd like to merge this series before the stable tag - any objections?
On Fri, 5 May 2023 at 07:28, Gerd Hoffmann wrote:
>
> An attempt to reduce code duplication a bit. PlatformBootManagerLibGrub
> is an (outdated) copy of PlatformBootManagerLib with some policy
> changes. Add a PC
Hi, Guo Dong
Don't you need to free "Buffer" after Fv->ReadSection() call ?
Regards,
Mike.
On Wed, May 10, 2023 at 6:58 AM Guo Dong wrote:
>
> From: Guo Dong
>
> After moving BDS driver to a new FV for universal UEFI payload,
> the shell boot option path is not correct since it used the BDS
>
Xen and bhyve are placing ACPI tables into system memory. So, they can
share the same code. Therefore, create a new library which searches and
installs ACPI tables from system memory.
Signed-off-by: Corvin Köhne
Acked-by: Gerd Hoffmann
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: A
It's much easier to create configuration dependend ACPI tables for bhyve
than for OVMF. For this reason, don't use the statically created ACPI
tables provided by OVMF. Instead prefer the dynamically created ACPI
tables of bhyve. If bhyve provides no ACPI tables or we are unable to
detect those, fal
This makes the function reuseable by bhyve.
Signed-off-by: Corvin Köhne
Acked-by: Gerd Hoffmann
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Anthony Perard
Cc: Julien Grall
---
.../XenAcpiPlatformDxe/XenAcpiPlatformDxe.inf | 1 -
OvmfPkg/Include/Library/AcpiPlatformLib.h |
EventNames is used to pretty-print debug log messages.
Add #ifdef to only include it in debug builds.
Fixes a clang build failure.
Reported-by: Rebecca Cran
Signed-off-by: Gerd Hoffmann
---
OvmfPkg/VirtioSerialDxe/VirtioSerial.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/OvmfPkg/Virt
On Wed, 10 May 2023 at 09:34, Gerd Hoffmann wrote:
>
> EventNames is used to pretty-print debug log messages.
> Add #ifdef to only include it in debug builds.
> Fixes a clang build failure.
>
> Reported-by: Rebecca Cran
> Signed-off-by: Gerd Hoffmann
Queued up as #4381 - thanks.
> ---
> Ovmf
Ard:
Seemly, this patch set passed code review before the soft feature freeze. So,
I am OK to merge it for this stable tag.
Thanks
Liming
> -邮件原件-
> 发件人: Ard Biesheuvel
> 发送时间: 2023年5月10日 15:13
> 收件人: Gerd Hoffmann ; Liming Gao (Byosoft address)
>
> 抄送: devel@edk2.groups.io; Jordan J
On Wed, May 10, 2023 at 02:48:52AM +, Ni, Ray wrote:
> Gerd,
> My understanding is that when code dereferences memory address, the code
> itself is responsible for
> supplying the sign-extended linear address.
> The page table creation logic still maps the entire linear memory space
> support
> -Original Message-
> From: Wu, Jiaxin
> Sent: Tuesday, May 9, 2023 6:23 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Zeng, Star
> ; Gerd Hoffmann ; Kumar, Rahul R
>
> Subject: [PATCH v1 1/3] UefiCpuPkg/SecCore: Migrate page table to permanent
> memory
>
> Background:
>
On Wed, May 10, 2023 at 01:56:59AM +, Wu, Jiaxin wrote:
> This happens to transfer PEI control to DXE. The paging is created for DXE
> phase,
Ah, ok. The code looks fine then.
> so, here, it's means the cpu running in the ia32 pei. I will refine the
> comments as below:
>
> If cpu has alr
> -Original Message-
> From: Wu, Jiaxin
> Sent: Tuesday, May 9, 2023 6:23 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Zeng, Star
> ; Gerd Hoffmann ; Kumar, Rahul R
>
> Subject: [PATCH v1 2/3] UefiCpuPkg/CpuMpPei: Enable PAE page table if CR0.PG
> is not set
>
> Some sec
Minor comments:
IA32 -> 32bit protected mode.
X64 -> 64bit long mode.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Wu, Jiaxin
> Sent: Tuesday, May 9, 2023 6:23 PM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan ; Gao, Liming
> ; Dong, Eric ; Ni, Ray
> ; Zeng, Star ; Gerd Hof
Update ETag driver and use specific variable GUID. Also fix the typo
in comment.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
RedfishClientPkg/RedfishClientPkg.dec| 2 +-
RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.h | 4 ++--
RedfishClientPkg/RedfishETa
Update Redfish feature core driver to support Redfish resource with
multiple parents. A resource may be presented in different resource and
the link in different resource point to the same location. Also add
interchange data interface in feature core driver so feature core
driver can talk to featur
RedfishLib has no capability to return HTTP header in response.
However, feature driver needs to know the information like "ETag" or
"Location" in HTTP response header per Redfish specification. Add
corresponding function to return HTTP header in response data.
Signed-off-by: Nickle Wang
Cc: Abne
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Wednesday, May 10, 2023 4:24 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
>
> Subject: [edk2-redfish-client][PATCH 1/4] RedfishClientPkg: Update ETag
> dri
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Wednesday, May 10, 2023 4:24 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
>
> Subject: [edk2-redfish-client][PATCH 2/4] RedfishClientPkg: Update Redfish
>
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Wednesday, May 10, 2023 4:24 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
>
> Subject: [edk2-redfish-client][PATCH 3/4] RedfishClientPkg: Update
> RedfishL
On 5/9/23 18:32, Pedro Falcato wrote:
> Clean up error handling using cascading labels + goto.
>
> (port of commit 379b179 + bcab714)
>
> Cc: Jian J Wang
> Cc: Liming Gao
> Cc: Hao A Wu
> Cc: Ray Ni
> Cc: Laszlo Ersek
> Signed-off-by: Pedro Falcato
> ---
> .../Pci/SataControllerDxe/SataCon
On 5/9/23 18:32, Pedro Falcato wrote:
> When a UEFI_DRIVER attempts to open a protocol interface with BY_DRIVER
> attribute that it already has open with BY_DRIVER attribute,
> OpenProtocol() returns EFI_ALREADY_STARTED. This is not an error. The
> UEFI-2.7 spec currently says,
>
>> EFI_ALREADY_ST
On 5/9/23 18:32, Pedro Falcato wrote:
> ASSERT (Private != NULL) already covers this check.
> See commit 81310a6.
>
> Cc: Jian J Wang
> Cc: Liming Gao
> Cc: Hao A Wu
> Cc: Ray Ni
> Cc: Laszlo Ersek
> Cc: Mike Maslenkin
> Signed-off-by: Pedro Falcato
> ---
> .../Pci/SataControllerDxe/SataCo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4431
In Ap relaxed mode, some SMI handlers should call SmmWaitForApArrival() to let
all ap arrive in SmmCpuRendezvous(). But in traditional mode, these SMI
handlers don't need to call SmmWaitForApArrival() again. So it need to be check
cpu syn
Reviewed-by: Ray Ni
> -Original Message-
> From: Li, Zhihao
> Sent: Wednesday, May 10, 2023 4:38 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray
> Subject: [PATCH v1 1/1] UefiCpuPkg/CpuService.c:check cpu sync mode in
> SmmCpuRendezvous()
>
> REF: https://bugzilla.tianocore.or
On 5/9/23 18:32, Pedro Falcato wrote:
> ASSERT (Private != NULL) (where Private = CR(...)) is ineffective as
> CR(Ptr, Type, Member, Sig) either returns Ptr - offsetof(Type, Member),
> or ASSERTS on the signature, so it's unlikely to ever return NULL
> (must be passed a pointer = member's offset, o
On 5/9/23 18:32, Pedro Falcato wrote:
> Replace the OVMF-specific SataControllerDxe (to be later removed) with
> the generic, MdeModulePkg one, for OvmfPkg{Ia32, X64, Ia32X64} platforms.
>
> Cc: Ard Biesheuvel
> Cc: Jiewen Yao
> Cc: Jordan Justen
> Cc: Gerd Hoffmann
> Tested-by: Gerd Hoffmann
On 5/9/23 18:32, Pedro Falcato wrote:
> Replace the OVMF-specific SataControllerDxe (to be later removed) with
> the generic, MdeModulePkg one, for the Microvm platform.
>
> Cc: Ard Biesheuvel
> Cc: Jiewen Yao
> Cc: Jordan Justen
> Cc: Gerd Hoffmann
> Signed-off-by: Pedro Falcato
> ---
> Ovm
On 5/9/23 18:32, Pedro Falcato wrote:
> Replace the OVMF-specific SataControllerDxe (to be later removed) with
> the generic, MdeModulePkg one, for the Bhyve platform.
>
> Cc: Ard Biesheuvel
> Cc: Jiewen Yao
> Cc: Jordan Justen
> Cc: Gerd Hoffmann
> Cc: Rebecca Cran
> Cc: Peter Grehan
> Cc:
On 5/9/23 18:32, Pedro Falcato wrote:
> Now that OvmfPkg/SataControllerDxe and its MdeModulePkg counterpart have
> been unified, and no in-tree uses of the OVMF variant remain, let's
> delete it.
>
> Cc: Ard Biesheuvel
> Cc: Jiewen Yao
> Cc: Jordan Justen
> Cc: Gerd Hoffmann
> Tested-by: Gerd
On 5/10/23 5:23 PM, Corvin Köhne wrote:
It's much easier to create configuration dependend ACPI tables for bhyve
than for OVMF. For this reason, don't use the statically created ACPI
tables provided by OVMF. Instead prefer the dynamically created ACPI
tables of bhyve. If bhyve provides no ACPI ta
On Tue, May 09, 2023 at 06:24:03PM +0100, Pedro Falcato wrote:
> Hi all,
>
> (+CC people vaguely related to the EFI spec, the PML5 implementation
> and kernel EFI boot code)
>
> As a result of the latest 5-level paging patches, I've been looking
> into how tiano supports PML5.
> This raised a que
On Wed, 10 May 2023 at 09:39, Ard Biesheuvel wrote:
>
> On Wed, 10 May 2023 at 09:34, Gerd Hoffmann wrote:
> >
> > EventNames is used to pretty-print debug log messages.
> > Add #ifdef to only include it in debug builds.
> > Fixes a clang build failure.
> >
> > Reported-by: Rebecca Cran
> > Sign
From: Gua Guo
V5: if no other open, it will be final change
- https://github.com/tianocore/edk2/pull/3901
Fix random exception when long run catalog debug message
V4
- https://github.com/tianocore/edk2/pull/3901 - Done
Enhance SwapBytesGuid to use CopyGuid instead of CopyMem, to make impleme
From: Gua Guo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4144
This Library is NULL library of TraceHubDebugSysTLib.
Cc: Michael D Kinney
Cc: Guo Gua
Cc: Chan Laura
Cc: Prakashan Krishnadas Veliyathuparambil
Cc: K N Karthik
Signed-off-by: VictorX Hsu
---
MdePkg/Include/Library/T
From: Gua Guo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4144
This Library provides functions consuming MIPI SYS-T submodule.
Cc: Michael D Kinney
Cc: Guo Gua
Cc: Chan Laura
Cc: Prakashan Krishnadas Veliyathuparambil
Cc: K N Karthik
Signed-off-by: VictorX Hsu
---
.gitmodules
From: Gua Guo
Update reviewers and maintainers for TraceHubDebugSysTlib.
Signed-off-by: VictorX Hsu
---
Maintainers.txt | 18 ++
1 file changed, 18 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index 09d04af27a..30e2d2686d 100644
--- a/Maintainers.txt
+++ b/Main
From: Gua Guo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4144
This Library provides API to dump Trace Hub message.
Cc: Michael D Kinney
Cc: Guo Gua
Cc: Chan Laura
Cc: Prakashan Krishnadas Veliyathuparambil
Cc: K N Karthik
Signed-off-by: VictorX Hsu
---
.../Include/Guid/TraceHub
Firmware chooses to use 5-level paging when the platform using this firmware
claims to boot 5-level paging OS only.
Usually, firmware uses 4-level paging to keep maximum OS compability.
Thanks,
Ray
> -Original Message-
> From: Gerd Hoffmann
> Sent: Wednesday, May 10, 2023 5:18 PM
> To:
On Tue, 9 May 2023 at 19:24, Pedro Falcato wrote:
>
> Hi all,
>
> (+CC people vaguely related to the EFI spec, the PML5 implementation
> and kernel EFI boot code)
>
> As a result of the latest 5-level paging patches, I've been looking
> into how tiano supports PML5.
> This raised a question: Doesn
From: VincentX Ke
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4428
Calculating CRC based on each ACPI table.
Update HWSignature filed in FACS based on CRC while ACPI table changed.
Change-Id: Ic0ca66ff10cda0fbcd0683020fab1bc9aea9b78c
Signed-off-by: VincentX Ke
Cc: Chasel Chiu
Cc: Nate
Hi, Ray
To fix the concern you mentioned.
[Patch V6] updated with https://edk2.groups.io/g/devel/message/104537
Please kindly code review and let me know your suggestion.
Thanks a lot.
Vincent
-Original Message-
From: Ni, Ray
Sent: Monday, May 8, 2023 11:23 AM
To: devel@edk2.groups.io;
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4429
For Ap-Relaxed sync mode, SmmVariableSetVariable() need to let all Aps
arrive to smm before it set the variable. If not, it would return
EFI_ACCESS_DENIED.
Cc: Jian J Wang
Cc: Liming Gao
Signed-off-by: Zhihao Li
---
MdeModulePkg/Unive
On Wed, 10 May 2023 at 01:53, Rebecca Cran wrote:
>
> Set the OBJCOPY path for the CLANGDWARF toolchain to 'llvm-objcopy' to
> override the default of 'echo'.
>
> Signed-off-by: Rebecca Cran
This appears to break the AArch64 CLANGDWARF build.
https://ci.linaro.org/job/leg-virt-tianocore-edk2-up
On Tue, 25 Apr 2023 at 18:04, Sami Mujawar wrote:
>
> Although Kvmtool supports a CFI flash interface, it is currently
> implemented using file backed support on the Host. This scenario
> requires the VMM to be within the trust boundary.
>
> In Confidential Compute Architecture the VMM is outside
On Tue, 25 Apr 2023 at 18:04, Sami Mujawar wrote:
>
> The monitor call conduit is fixed for a platform firmware in
> most scenarios. For a normal virtual machine guest firmware,
> the default conduit is HVC. However, for Arm CCA the Realm
> code must use SMC as the conduit.
>
> To have a common co
On Tue, 25 Apr 2023 at 18:05, Sami Mujawar wrote:
>
> Add ArmCcaDxe for early DXE phase initialisation like setting
> up the monitor call conduit for Realm code
>
> The Realm code should use SMC as the conduit for monitor calls.
> Therefore, set the PcdMonitorConduitHvc to FALSE if the code is
> r
On 5/10/23 05:03, Ard Biesheuvel wrote:
On Wed, 10 May 2023 at 01:53, Rebecca Cran wrote:
Set the OBJCOPY path for the CLANGDWARF toolchain to 'llvm-objcopy' to
override the default of 'echo'.
Signed-off-by: Rebecca Cran
This appears to break the AArch64 CLANGDWARF build.
https://ci.linaro.
On Wed, 10 May 2023 at 14:09, Rebecca Cran wrote:
>
> On 5/10/23 05:03, Ard Biesheuvel wrote:
> > On Wed, 10 May 2023 at 01:53, Rebecca Cran wrote:
> >> Set the OBJCOPY path for the CLANGDWARF toolchain to 'llvm-objcopy' to
> >> override the default of 'echo'.
> >>
> >> Signed-off-by: Rebecca Cra
This reverts commit 11f62f4cc09f16d265da1a737dabfd8ed65f8c00.
While GCC uses objcopy for the OBJCOPY command, it's not needed for the
CLANGDWARF toolchain and can be left as echo.
Signed-off-by: Rebecca Cran
---
BaseTools/Conf/tools_def.template | 4
1 file changed, 4 deletions(-)
diff --
On 5/10/23 06:10, Ard Biesheuvel wrote:
On Wed, 10 May 2023 at 14:09, Rebecca Cran wrote:
On 5/10/23 05:03, Ard Biesheuvel wrote:
On Wed, 10 May 2023 at 01:53, Rebecca Cran wrote:
Set the OBJCOPY path for the CLANGDWARF toolchain to 'llvm-objcopy' to
override the default of 'echo'.
Signed-o
On Wed, 10 May 2023 at 09:41, gaoliming via groups.io
wrote:
>
> Ard:
> Seemly, this patch set passed code review before the soft feature freeze.
> So, I am OK to merge it for this stable tag.
>
Thanks
Gerd,
Could you run this through the CI please? I am getting errors.
https://github.com/t
PR: https://github.com/tianocore/edk2/pull/4384
On 5/10/23 06:31, Rebecca Cran wrote:
This reverts commit 11f62f4cc09f16d265da1a737dabfd8ed65f8c00.
While GCC uses objcopy for the OBJCOPY command, it's not needed for the
CLANGDWARF toolchain and can be left as echo.
Signed-off-by: Rebecca Cran
On Wed, 10 May 2023 at 14:31, Rebecca Cran wrote:
>
> This reverts commit 11f62f4cc09f16d265da1a737dabfd8ed65f8c00.
>
> While GCC uses objcopy for the OBJCOPY command, it's not needed for the
> CLANGDWARF toolchain and can be left as echo.
>
Are you sure you want to change this for IA32 and X86 a
On Wed, 10 May 2023 at 14:33, Ard Biesheuvel wrote:
>
> On Wed, 10 May 2023 at 09:41, gaoliming via groups.io
> wrote:
> >
> > Ard:
> > Seemly, this patch set passed code review before the soft feature freeze.
> > So, I am OK to merge it for this stable tag.
> >
>
> Thanks
>
> Gerd,
>
> Could
On 5/10/23 06:37, Ard Biesheuvel wrote:
On Wed, 10 May 2023 at 14:31, Rebecca Cran wrote:
This reverts commit 11f62f4cc09f16d265da1a737dabfd8ed65f8c00.
While GCC uses objcopy for the OBJCOPY command, it's not needed for the
CLANGDWARF toolchain and can be left as echo.
Are you sure you want
Rename RedfishMemoryCollectionDxe by removing Redfish prefix. Update
memory collection driver to support "Identify" action and also have
code refactoring to support Redfish operation.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
.../RedfishClientComponents.dsc.inc
Rename Memory driver by removing Redfish prefix. Update memory feature
driver and support all properties under Memory schema. Also support
"Identify" action in this driver. Corresponding changes are made to
honor newly introduced library and protocol.
Signed-off-by: Nickle Wang
Cc: Abner Chang
C
Introduce new feature driver to support Computer System Collection
schema. Update corresponding FDF and DSC file to enable this feature
driver.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
.../RedfishClientComponents.dsc.inc | 2 +
RedfishClientPkg/RedfishCli
Introduce new feature driver to support Computer System version 1.5.0
schema. Update corresponding FDF and DSC file to enable this feature
driver.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
.../RedfishClientComponents.dsc.inc |7 +-
RedfishClientPkg/Redfi
Introduce new feature driver to support Bios version 1.0.9 schema.
Update corresponding FDF and DSC file to enable this feature driver.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
.../RedfishClientComponents.dsc.inc | 2 +
RedfishClientPkg/RedfishClientLibs.
On Wed, 10 May 2023 at 14:46, Rebecca Cran wrote:
>
> On 5/10/23 06:37, Ard Biesheuvel wrote:
> > On Wed, 10 May 2023 at 14:31, Rebecca Cran wrote:
> >> This reverts commit 11f62f4cc09f16d265da1a737dabfd8ed65f8c00.
> >>
> >> While GCC uses objcopy for the OBJCOPY command, it's not needed for the
On Wed, 10 May 2023 at 11:18, Ard Biesheuvel wrote:
>
> On Wed, 10 May 2023 at 09:39, Ard Biesheuvel wrote:
> >
> > On Wed, 10 May 2023 at 09:34, Gerd Hoffmann wrote:
> > >
> > > EventNames is used to pretty-print debug log messages.
> > > Add #ifdef to only include it in debug builds.
> > > Fix
[AMD Official Use Only - General]
Please review your commit message in which the characters per line should be <
76.
Reviewed-by:
> -Original Message-
> From: Nickle Wang
> Sent: Wednesday, May 10, 2023 9:04 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
>
> Subj
[AMD Official Use Only - General]
Reviewed-by:
> -Original Message-
> From: Nickle Wang
> Sent: Wednesday, May 10, 2023 9:04 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
>
> Subject: [edk2-redfish-client][PATCH 2/5] RedfishClientPkg: Rename
> Memory feature drive
[AMD Official Use Only - General]
Please check commit message, the line seems too long.
Reviewed-by:
> -Original Message-
> From: Nickle Wang
> Sent: Wednesday, May 10, 2023 9:05 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
>
> Subject: [edk2-redfish-client][PAT
[AMD Official Use Only - General]
Reviewed-by:
> -Original Message-
> From: Nickle Wang
> Sent: Wednesday, May 10, 2023 9:05 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
>
> Subject: [edk2-redfish-client][PATCH 4/5] RedfishClientPkg: Introduce
> Computer System f
[AMD Official Use Only - General]
Reviewed-by:
> -Original Message-
> From: Nickle Wang
> Sent: Wednesday, May 10, 2023 9:05 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
>
> Subject: [edk2-redfish-client][PATCH 5/5] RedfishClientPkg: Introduce Bios
> feature driv
Mike/Liming:
GitHub PR with R-B added: https://github.com/tianocore/edk2/pull/4384
--
Rebecca Cran
On 5/10/23 07:51, Ard Biesheuvel wrote:
On Wed, 10 May 2023 at 14:46, Rebecca Cran wrote:
On 5/10/23 06:37, Ard Biesheuvel wrote:
On Wed, 10 May 2023 at 14:31, Rebecca Cran wrote:
This re
The warnings Clang emits when enabling -Wunneeded-internal-declaration
(which is part of -Wall) are generating false positives for variables
whose size gets taken but are not referenced beyond that.
This may happen legitimately in debug code, so let's disable this
warning for Clang, rather than ti
Reviewed-by: Rebecca Cran
This should go in for the edk2-stable202305 release.
--
Rebecca Cran
On 5/10/23 08:50, Ard Biesheuvel wrote:
The warnings Clang emits when enabling -Wunneeded-internal-declaration
(which is part of -Wall) are generating false positives for variables
whose size get
From: Michael Kubacki
Adds a PCD called "PcdEnableCompressedFspNvsBuffer" that allows the
"FspNvsBuffer" UEFI variable data to be saved as compressed data.
Especially due to the nature of the data saved in this variable, it
compresses well. For example, it has been found to reduce ~63KB
of data
On Wed, 10 May 2023 at 15:54, Ard Biesheuvel wrote:
>
> On Wed, 10 May 2023 at 11:18, Ard Biesheuvel wrote:
> >
> > On Wed, 10 May 2023 at 09:39, Ard Biesheuvel wrote:
> > >
> > > On Wed, 10 May 2023 at 09:34, Gerd Hoffmann wrote:
> > > >
> > > > EventNames is used to pretty-print debug log mes
On Wed, 10 May 2023 at 14:43, Ard Biesheuvel wrote:
>
> On Wed, 10 May 2023 at 14:33, Ard Biesheuvel wrote:
> >
> > On Wed, 10 May 2023 at 09:41, gaoliming via groups.io
> > wrote:
> > >
> > > Ard:
> > > Seemly, this patch set passed code review before the soft feature
> > > freeze. So, I am
Qemu has versioning for sbsa-ref platform. TF-A reads it from provided
DeviceTree and provides as SMC.
This change adds reading platform version into EDK2.
Signed-off-by: Marcin Juszkiewicz
---
Platform/Qemu/SbsaQemu/SbsaQemu.dsc| 3 +++
.../SbsaQemuPlatformDxe/SbsaQemuPlatform
Reviewed-by: Isaac Oram
-Original Message-
From: mikub...@linux.microsoft.com
Sent: Wednesday, May 10, 2023 8:02 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Oram, Isaac W ; Gao,
Liming ; Dong, Eric ; Gudla,
Raghava
Subject: [edk2-platforms][PATCH v4 1/1] M
HI Marcin,
On Wed, 10 May 2023 at 17:08, Marcin Juszkiewicz
wrote:
>
> Qemu has versioning for sbsa-ref platform. TF-A reads it from provided
> DeviceTree and provides as SMC.
>
> This change adds reading platform version into EDK2.
>
> Signed-off-by: Marcin Juszkiewicz
> ---
> Platform/Qemu/Sb
On 5/10/23 09:08, Marcin Juszkiewicz wrote:
+ Result = ArmCallSmc0(SIP_FUNCTION_ID(1), &Major, &Minor, NULL);
There should be space before the opening parenthesis.
Also, it would be nice to avoid a magic number - i.e. define what
SIP_FUNCTION_ID(1) is.
--
Rebecca Cran
-=-=-=-=-=-=-=-=
Fix setting I2cStatus in MvI2cEnableConf.
Signed-off-by: Rebecca Cran
---
Silicon/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Silicon/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c
b/Silicon/Marvell/Drivers/I2c/MvI2cDxe/MvI2cDxe.c
index b
Qemu has versioning for sbsa-ref platform. TF-A reads it from provided
DeviceTree and provides as SMC.
This change adds reading platform version into EDK2.
Signed-off-by: Marcin Juszkiewicz
---
Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 3 +++
.../SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.c
W dniu 10.05.2023 o 17:40, Marcin Juszkiewicz via groups.io pisze:
Qemu has versioning for sbsa-ref platform. TF-A reads it from provided
DeviceTree and provides as SMC.
This change adds reading platform version into EDK2.
TF-A side of change:
https://review.trustedfirmware.org/c/TF-A/trusted
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael
> Kubacki
> Sent: Wednesday, May 10, 2023 8:02 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Oram, Isaac W ;
> Gao, Liming ; Dong, Eric ;
> Gu
On 5/10/23 09:40, Marcin Juszkiewicz wrote:
@@ -26,6 +36,9 @@ InitializeSbsaQemuPlatformDxe (
EFI_STATUS Status;
UINTN Size;
VOID* Base;
+ UINTN Major;
+ UINTN Mi
Patch merged:
https://github.com/tianocore/edk2-platforms/commit/dbd802cd273ad1b51be46ca09a58a15e4b70863f
Thanks,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael
> Kubacki
> Sent: Wednesday, May 10, 2023 8:02 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chas
Series Reviewed-by: Michael D Kinney
Liming, this code review started well before the soft freeze. It has now
passed review.
We should include this in this stable-tag release.
Mike
> -Original Message-
> From: Guo, Gua
> Sent: Wednesday, May 10, 2023 2:20 AM
> To: devel@edk2.groups
Qemu has versioning for sbsa-ref platform. TF-A reads it from provided
DeviceTree and provides as SMC.
This change adds reading platform version into EDK2.
Signed-off-by: Marcin Juszkiewicz
---
Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 3 ++
.../SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.c
Thanks a lot Mike for your detail reviewing and providing better implementation
suggestions!
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael D
> Kinney
> Sent: Wednesday, May 10, 2023 9:00 AM
> To: Guo, Gua ; devel@edk2.groups.io; Gao, Liming
>
> Cc: Kinney, Mi
Can we schedule the meeting for Wednesday 5/17? I will be out the
following week and would like to attend.
Thanks :)
On 5/9/2023 7:59 AM, Oliver Smith-Denny wrote:
On 5/8/2023 11:59 PM, Ard Biesheuvel wrote:
On Tue, 9 May 2023 at 04:04, Kinney, Michael D
wrote:
I would prefer next week as
On 5/10/23 10:06, Marcin Juszkiewicz wrote:
+ Result = ArmCallSmc0 (SIP_SVC_VERSION, &Major, &Minor, NULL);
+ if (Result == SMC_ARCH_CALL_SUCCESS)
+ {
+Result = PcdSet32S (PcdPlatformVersionMajor, Major);
+ASSERT_EFI_ERROR (Result);
+Result = PcdSet32S (PcdPlatformVersi
I ran my script that tries to build all Arm platforms in edk2-platforms
(with the exception of known broken ones) with the GCC5/GCC toolchain,
and noticed a new breakage since I last ran it a few months ago.
Building JunoPkg for ARM doesn't work.
I also noticed it passes both -march=armv7-a an
Hi Rebecca,
On Wed, 10 May 2023 at 18:23, Rebecca Cran wrote:
>
> I ran my script that tries to build all Arm platforms in edk2-platforms
> (with the exception of known broken ones) with the GCC5/GCC toolchain,
> and noticed a new breakage since I last ran it a few months ago.
>
> Building JunoPk
On Wed, May 10, 2023 at 10:18 AM Gerd Hoffmann wrote:
>
> On Tue, May 09, 2023 at 06:24:03PM +0100, Pedro Falcato wrote:
> > Hi all,
> >
> > (+CC people vaguely related to the EFI spec, the PML5 implementation
> > and kernel EFI boot code)
> >
> > As a result of the latest 5-level paging patches,
On Wed, May 10, 2023 at 10:34 AM Ni, Ray wrote:
>
> Firmware chooses to use 5-level paging when the platform using this firmware
> claims to boot 5-level paging OS only.
>
> Usually, firmware uses 4-level paging to keep maximum OS compability.
Hi Ray,
So, what happens if I don't enable LA57, ha
Thanks Nate for the comprehensive proposal!
Since I found SetLargeVariable only used in SaveMemoryConfig DXE driver now, so
how about we fix this issue first to unblock the verification on server
platform. And after that, we can handle the case you mentioned.
-Original Message-
From: De
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4438
The main dispatch loop in PeiDispatcher() goes through each FV and
calls DiscoverPeimsAndOrderWithApriori() to search Apriori file to
reorder all PEIMs then do the PEIM dispatched.
DiscoverPeimsAndOrderWithApriori() calculates Apriori fil
On Wed, May 10, 2023 at 10:41 AM Ard Biesheuvel wrote:
>
> On Tue, 9 May 2023 at 19:24, Pedro Falcato wrote:
> >
> > Hi all,
> >
> > (+CC people vaguely related to the EFI spec, the PML5 implementation
> > and kernel EFI boot code)
> >
> > As a result of the latest 5-level paging patches, I've be
Thanks. Yes, that fixes it.
I also tried running the build script with CLANGDWARF, and it seems to
have found some valid problems with
Platform/ARM/Library/ArmShellCmdRunAxf/RunAxf.c
/home/bcran/src/uefi/edk2-platforms/Platform/ARM/Library/ArmShellCmdRunAxf/RunAxf.c:216:11:
error: variable
(cc Leif)
On Wed, 10 May 2023 at 18:52, Rebecca Cran wrote:
>
> Thanks. Yes, that fixes it.
>
>
> I also tried running the build script with CLANGDWARF, and it seems to
> have found some valid problems with
> Platform/ARM/Library/ArmShellCmdRunAxf/RunAxf.c
>
Seems to me like an excellent opportu
On Wed, May 10, 2023 at 18:54:04 +0200, Ard Biesheuvel wrote:
> (cc Leif)
>
> On Wed, 10 May 2023 at 18:52, Rebecca Cran wrote:
> >
> > Thanks. Yes, that fixes it.
> >
> >
> > I also tried running the build script with CLANGDWARF, and it seems to
> > have found some valid problems with
> > Platfo
Qemu has versioning for sbsa-ref platform. TF-A reads it from provided
DeviceTree and provides as SMC.
This change adds reading platform version into EDK2.
Signed-off-by: Marcin Juszkiewicz
---
Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 3 +++
.../SbsaQemuPlatformDxe/SbsaQemuPlatformDxe.c
W dniu 10.05.2023 o 18:14, Rebecca Cran pisze:
Sorry, but there are new problems.
No problem. Thanks for reviewing.
There should be a space before the parenthesis in the 'DEBUG' line.
No problem. I hope that one day someone will run source formatter on
whole edk2-platforms so it would be
1 - 100 of 170 matches
Mail list logo
