On 5/10/23 10:06, Marcin Juszkiewicz wrote:
+  Result = ArmCallSmc0 (SIP_SVC_VERSION, &Major, &Minor, NULL);
+  if (Result == SMC_ARCH_CALL_SUCCESS)
+  {
+        Result = PcdSet32S (PcdPlatformVersionMajor, Major);
+        ASSERT_EFI_ERROR (Result);
+        Result = PcdSet32S (PcdPlatformVersionMinor, Minor);
+        ASSERT_EFI_ERROR (Result);
+  }
+
+  Major = PcdGet32 (PcdPlatformVersionMajor);
+  ASSERT_EFI_ERROR (Major);
+  Minor = PcdGet32 (PcdPlatformVersionMinor);
+  ASSERT_EFI_ERROR (Minor);
+
+  DEBUG((DEBUG_INFO, "Platform version: %d.%d\n", Major, Minor));
+
    return EFI_SUCCESS;
  }

Sorry, but there are new problems.

There should be a space before the parenthesis in the 'DEBUG' line.

PcdGet32 doesn't return a RETURN_STATUS or EFI_STATUS, so ASSERT_EFI_ERROR is incorrect.


--

Rebecca Cran



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#104586): https://edk2.groups.io/g/devel/message/104586
Mute This Topic: https://groups.io/mt/98809146/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to