Add more Redfish resource for EDK2 Redfish development.
- Add two more systems to profile.
- Add BIOS, Memory and Log service to profile.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
.../redfish/v1/$metadata/index.xml| 6 +-
.../index.json
I just give RB for this because it was already reviewed before.
Reviewed-by: Abner Chang < abner.ch...@amd.com >
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#103839): https://edk2.groups.io/g/devel/message/103839
Mute This Topic: https
I just give RB for this because it was already reviewed before.
Reviewed-by: Abner Chang < abner.ch...@amd.com >
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#103840): https://edk2.groups.io/g/devel/message/103840
Mute This Topic: https
Add Redfish-Profile-Simulator license information in README.md
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
README.md | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/README.md b/README.md
index 4dfa2c6..478f319 100644
--- a/README.md
+++ b/README.
- Add HTTPs support
- Add ETAG support
- Change default credential to admin/pwd123456
- Add HTTP methods on BIOS managed resource.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
.../redfishProfileSimulator.py| 92 --
.../v1sim/redfishURIs.py
This is to add several features to Redfish-Profile-Simulator for
EDK2 Redfish client development.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Nickle Wang (4):
Redfish-Profile-Simulator: Add more features
Redfish-Profile-Simulator: HTTP methods on Memory Collection
Re
Add POST and PATCH methods on Memory collection and resource.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
.../v1sim/redfishURIs.py | 25 +++
.../v1sim/systems.py | 43 +++
2 files changed, 68 insertio
Add ETAG support on Memory resource.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
Tools/Redfish-Profile-Simulator/v1sim/systems.py | 13 +
1 file changed, 13 insertions(+)
diff --git a/Tools/Redfish-Profile-Simulator/v1sim/systems.py
b/Tools/Redfish-Profile
Add requirements.txt for the required python module
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
Tools/Redfish-Profile-Simulator/requirements.txt | 2 ++
1 file changed, 2 insertions(+)
create mode 100644 Tools/Redfish-Profile-Simulator/requirements.txt
diff --git a/To
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Tuesday, May 2, 2023 3:36 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
>
> Subject: [edk2-redfish-client][PATCH] Update README.md
>
> Caution: This messag
[AMD Official Use Only - General]
I have no more comments on this patch set as we already reviewed it on
edk2-staging.
For whole patch set.
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Tuesday, May 2, 2023 3:51 PM
> To: devel@edk2.groups.io
> Cc: Chang, Ab
Hi Abner,
Sorry, but I don't have a tianocore bugzilla account.
Please help me to file it on BZ.
Thanks,
- Tinh
On 29/04/2023 10:35, Chang, Abner wrote:
[AMD Official Use Only - General]
Hi Tinh,
Could you please also create a BZ ticket for tracking this? Thus this
information will be al
Hi Abner,
On 29/04/2023 10:22, Chang, Abner wrote:
[AMD Official Use Only - General]
Hi Tinh,
Below is my comments,
-Original Message-
From: Tinh Nguyen
Sent: Friday, April 28, 2023 12:00 PM
To: devel@edk2.groups.io
Cc: patc...@amperecomputing.com; michael.d.kin...@intel.com;
gaolim
[AMD Official Use Only - General]
> -Original Message-
> From: Tinh Nguyen
> Sent: Tuesday, May 2, 2023 4:10 PM
> To: Chang, Abner ; Tinh Nguyen
> ; devel@edk2.groups.io
> Cc: patc...@amperecomputing.com; michael.d.kin...@intel.com;
> gaolim...@byosoft.com.cn; zhiguang@intel.com
> S
[AMD Official Use Only - General]
Ok, here it is.
Please put BZ# 4344 in the commit message.
https://bugzilla.tianocore.org/show_bug.cgi?id=4434
Regards,
Abner
> -Original Message-
> From: Tinh Nguyen
> Sent: Tuesday, May 2, 2023 4:09 PM
> To: Chang, Abner ; Tinh Nguyen
> ; devel@edk2.
V2 delta changes:
Split the patch in two for Platform/ARM/N1Sdp and Silicon/ARM/NeoverseN1Soc
sahil (2):
Platform/ARM/N1Sdp: Fix RemoteDdrSize cast
Silicon/ARM/NeoverseN1Soc: Fix RemoteDdrSize cast
Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
| 2
RemoteDdrSize calculation wraps around when booting N1Sdp in
multichip mode. Casting it to UINT64 to fix the issue.
Signed-off-by: sahil
Change-Id: Ic51269a8d67669684a5f056701cfbef6beb23da2
---
Platform/ARM/N1Sdp/ConfigurationManager/ConfigurationManagerDxe/ConfigurationManager.c
| 2 +-
1 fil
RemoteDdrSize calculation wraps around when booting N1Sdp in
multichip mode. Casting it to UINT64 to fix the issue.
Signed-off-by: sahil
---
Silicon/ARM/NeoverseN1Soc/Library/PlatformLib/PlatformLibMem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Silicon/ARM/NeoverseN1So
Hi Sahil,
Thank you for this fix.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 02/05/2023 09:32 am, sahil wrote:
V2 delta changes:
Split the patch in two for Platform/ARM/N1Sdp and Silicon/ARM/NeoverseN1Soc
sahil (2):
Platform/ARM/N1Sdp: Fix RemoteDdrSize cast
Silicon/ARM/Neo
Merged as d39c665fe302..35a84b1838ba
Thanks.
Sami Mujawar
On 02/05/2023 09:32 am, sahil wrote:
V2 delta changes:
Split the patch in two for Platform/ARM/N1Sdp and Silicon/ARM/NeoverseN1Soc
sahil (2):
Platform/ARM/N1Sdp: Fix RemoteDdrSize cast
Silicon/ARM/NeoverseN1Soc: Fix RemoteDdrS
Hi Chasel,
Apologies, spent last week at Linaro Connect with little time to follow
the list.
If we're seeing this purely as a wrapper on libfdt, then it shouldn't
need to provide additional functionality on top of what it provides.
My initial impression was that this library was attempting to
On 5/2/23 00:35, Yao, Jiewen wrote:
Have you evaluated size impact with this new compiler option? Especially crypto
library.
Bigger? Smaller?
The increase in size when we disable LTO doesn't seem too bad:
With LTO:
-rwxrwxr-x 1 bcran bcran 13M May 2 08:11
CryptoDxe_41A491D1-A972-468B-A29
Merged https://github.com/tianocore/edk2/pull/4325
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Gerd
> Hoffmann
> Sent: Thursday, April 27, 2023 12:24 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Pawel Polawski
> ; Oliver Steffen ; Yao,
> Jiewen ; Gerd Hoffmann
>
Thanks. The patch loos good to me.
Would you please share with us, how you validate the patch?
> -Original Message-
> From: Liu, Linus
> Sent: Tuesday, April 11, 2023 5:55 PM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen ; FST-FIR-PRC p...@intel.com>; FST FIR Server ; Chu, Maggie
>
>
Change from v1:
- Separate the commit for the IPMI SSIF header and IPMI SSIF PCDs
- Correct some indent and comment style.
- Change the PCDs name for a more readable.
- Support KCS/SMIC Interface Capabilities too.
Tinh Nguyen (3):
MdePkg/IndustryStandard: Add definitions for IPMI SSIF
Specification reference:
https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/ipmi-second-gen-interface-spec-v2-rev1-1.html
Signed-off-by: Tinh Nguyen
---
MdePkg/Include/IndustryStandard/IpmiSsif.h | 98
1 file changed, 98 insertions(+)
diff --git a/MdePkg/Inc
This change adds new PCDs for IPMI SSIF.
Specification reference:
https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/ipmi-second-gen-interface-spec-v2-rev1-1.html
Signed-off-by: Tinh Nguyen
---
MdePkg/MdePkg.dec | 26
1 file changed, 26 insertions(+)
diff -
This adds more definitions for the IPMI Get System Interface
Capabilities command.
Signed-off-by: Tinh Nguyen
Reviewed-by: Abner Chang
---
MdePkg/Include/IndustryStandard/IpmiNetFnApp.h | 46
1 file changed, 46 insertions(+)
diff --git a/MdePkg/Include/IndustryStandard/Ipm
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Oram, Isaac W
> Sent: Tuesday, March 7, 2023 4:16 PM
> To: devel@edk2.groups.io
> Cc: Oram, Isaac W ; Desimone, Nathaniel L
> ; Chiu, Chasel
> Subject: [edk2-devel][edk2-platforms][PATCH V1 1/1]
> WhitleyOpenBoardP
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Oram, Isaac W
> Sent: Wednesday, March 15, 2023 6:18 AM
> To: devel@edk2.groups.io
> Cc: Oram, Isaac W ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Gao, Liming ;
> Dong, Eric
> Subject: [edk2-devel][edk2-platforms]
Hi Jiewen
I add this patch into MTLS platform and collect the log.
The below is before adding patch and after adding patch. There is no warring
message.
Before
InstallProtocolInterface: 09576E91-6D3F-11D2-8E39-00A0C969723B 67E4C490
InstallProtocolInterface: 330D4706-F2A0-4E4F-A369-B66FA8D54385
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
BTW, I don't see maintainers are CCed in the commit message. Not sure if this
is acceptable as usually we can see who are the maintainers in the commit
message (either in patch email or git commit history) instead of looking at Cc
in
[AMD Official Use Only - General]
Acked-by: Abner Chang
> -Original Message-
> From: Tinh Nguyen
> Sent: Wednesday, May 3, 2023 1:49 AM
> To: devel@edk2.groups.io
> Cc: patc...@amperecomputing.com; michael.d.kin...@intel.com;
> gaolim...@byosoft.com.cn; zhiguang@intel.com; Chang, Ab
That only proves that you did change the interface. But that cannot prove you
change it right.
Have you done any function test? For example:
1) The HDD password feature still works?
2) The variable is really locked?
> -Original Message-
> From: Liu, Linus
> Sent: Wednesday, May 3, 2023
[AMD Official Use Only - General]
Ah sorry, one thing I missed. Please check feedback below.
> -Original Message-
> From: Chang, Abner
> Sent: Wednesday, May 3, 2023 9:13 AM
> To: Tinh Nguyen ;
> devel@edk2.groups.io
> Cc: patc...@amperecomputing.com; michael.d.kin...@intel.com;
> gaolim.
[AMD Official Use Only - General]
Hi Tinh,
Thanks for this effort. I have no problem with this patch set but you still
have to get R-B from maintainers. Two feedbacks here,
- Please put BZ # in commit message in the patch 1/3-3/3.
Ex: BZ#: 4434 - Add IPMI SSIF definitions
- As the feedback I g
I applied the patch and tested it. The UEFI Shell command "acpiview"
reports an error. I enabled the "acpiview" command with the patch:
diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc
index d0d2712c5662..0c04e4834cf7 100644
--- a/OvmfPkg/Bhyve/BhyveX64.dsc
+++ b/OvmfPkg/Bhy
Reviewed-by: Rebecca Cran
On 4/17/23 06:11, Corvin Köhne wrote:
It's much easier to create configuration dependend ACPI tables for bhyve
than for OVMF. For this reason, don't use the statically created ACPI
tables provided by OVMF. Instead prefer the dynamically created ACPI
tables of bhyve. I
Thanks Leif!
To align with your suggestion I think we can define below MACROs in FdtLib.h.
Library consumers can use those MACROs to convert structure data between Big
endian and Little endian. (better readability)
Mike, what do you think?
Thanks,
Chasel
//
// Definitions for transferring FD
From: VincentX Ke
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4428
Calculating CRC based on each ACPI table.
Update HWSignature filed in FACS based on CRC while ACPI table changed.
Change-Id: Ic0ca66ff10cda0fbcd0683020fab1bc9aea9b78c
Signed-off-by: VincentX Ke
Cc: Chasel Chiu
Cc: Nate
Hi, Ray
Update patch and fix your concern in the patch v5.
Please let me know if there is any suggestion. Thanks.
[Patch v5] https://edk2.groups.io/g/devel/message/103877
BR,
Vincent
-Original Message-
From: Ni, Ray
Sent: Friday, April 28, 2023 11:55 AM
To: Ke, VincentX ; devel@edk2.gro
I don't think the macros that are identical to BaseLib functions help.
My preference if for caller of FdtLib to know use SwapBytesxx() as needed.
Mike
> -Original Message-
> From: Chiu, Chasel
> Sent: Tuesday, May 2, 2023 7:35 PM
> To: devel@edk2.groups.io; quic_llind...@quicinc.com; Ki
On Fri, Apr 28, 2023 at 02:50:04PM +, Michael Brown wrote:
> On 28/04/2023 14:38, Gerd Hoffmann wrote:
> > I suspect the windows boot loader does something fishy here, but I can't
> > proof it, I have not yet pinned down the exact location where interrupts
> > get enabled while running at IPL=T
43 matches
Mail list logo
