[edk2-devel] [PATCH v3 0/3] OvmfPkg/PlatformInitLib: move mmconfig to 0xe0000000

v3: - drop OvmfXen.dsc changes (Anthony). - add rb tags. - rebase to latest master. v2: - rebase to latest master. Gerd Hoffmann (3): OvmfPkg/PlatformInitLib: update address space layout comment OvmfPkg/PlatformInitLib: move mmconfig to 0xe000 OvmfPkg/PlatformInitLib: simplify mtrr s

[edk2-devel] [PATCH v3 2/3] OvmfPkg/PlatformInitLib: move mmconfig to 0xe0000000

Also swap the ordering of 32bit PCI MMIO window on q35, i.e. use the room between end of low memory and the start of the mmconfig bar. With a typical configuration on modern qemu with gigabyte-aligned memory the MMIO window start at 0x800, sized 1532 MB. In case there is memory present above

[edk2-devel] [PATCH v3 1/3] OvmfPkg/PlatformInitLib: update address space layout comment

Move the commment up so it is placed just before the address space calculations start. Also add q35 memory layout. Signed-off-by: Gerd Hoffmann Reviewed-by: Anthony PERARD --- OvmfPkg/Library/PlatformInitLib/Platform.c | 36 -- 1 file changed, 19 insertions(+), 17 deletions

[edk2-devel] [PATCH v3 3/3] OvmfPkg/PlatformInitLib: simplify mtrr setup

With the new mmconfig location at 0xe000 above the 32-bit PCI MMIO window we don't have to special-case the mmconfig xbar any more. We'll just add a mtrr uncachable entry starting at MMIO window base and ending at 4GB. Update comments to match reality. Signed-off-by: Gerd Hoffmann Reviewed-

Re: [edk2-devel] [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid

Hi Jianyong, Thank you for this fix. The subject line should have the package name as prefix followed by the short description for the patch e.g. "ArmVirtPkg: xxx". Other than that, this change looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 28/03/2023, 04:28, "Jianyon

Re: [edk2-devel] [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid

Hi Jianyong, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 28/03/2023, 08:45, "Sunil V L" mailto:suni...@ventanamicro.com>> wrote: On Tue, Mar 28, 2023 at 03:28:25AM +, Jianyong Wu wrote: > Add Ard Biesheuvel mailto:a...@kernel.org>> and Sunil V L > mailto:suni.

Re: [edk2-devel] [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid

Hi Sami, I have never added CI for CloudHv. So, should I add it? Also, I will update this patch based on your comment and send the second version. Thanks, Jianyong > -Original Message- > From: Sami Mujawar > Sent: 2023年3月28日 15:52 > To: Sunil V L ; Jianyong Wu > > Cc: devel@edk2.grou

Re: [edk2-devel] [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid

Hi Jianyong, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 28/03/2023, 09:17, "Jianyong Wu" mailto:jianyong...@arm.com>> wrote: Hi Sami, I have never added CI for CloudHv. So, should I add it? [SAMI] I think you can prepare the patch that adds the CI support and pu

Re: [edk2-devel] [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid

Hi Sami, Inline replay. > -Original Message- > From: Sami Mujawar > Sent: 2023年3月28日 16:34 > To: Jianyong Wu > Cc: devel@edk2.groups.io; Ard Biesheuvel ; > suni...@ventanamicro.com > Subject: Re: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid > > Hi Jianyong, > > Please find my

[edk2-devel] [PATCH v2] ArmVirtPkg: can't find gUefiOvmfPkgTokenSpaceGuid

commit f13264b34 introduces a bug for CloudHv as OvmfPkg/OvmfPkg.dec is missing in CloudHvHasAcpiDtDxe.inf which leads to gUefiOvmfPkgTokenSpaceGuid found nowhere when build. Reviewed-by: Sami Mujawar Signed-off-by: Jianyong Wu --- ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf

Re: [edk2-devel] [PATCH v3 0/3] OvmfPkg/PlatformInitLib: move mmconfig to 0xe0000000

On Tue, 28 Mar 2023 at 09:34, Gerd Hoffmann wrote: > > v3: > - drop OvmfXen.dsc changes (Anthony). > - add rb tags. > - rebase to latest master. > v2: > - rebase to latest master. > > Gerd Hoffmann (3): > OvmfPkg/PlatformInitLib: update address space layout comment > OvmfPkg/PlatformInitLi

Re: [edk2-devel] [PATCH v2] ArmVirtPkg: can't find gUefiOvmfPkgTokenSpaceGuid

Hi Ard, This patch fixes a build break for the CloudHv firmware. Can you let me know if I can merge this patch, please? Regards, Sami Mujawar On 28/03/2023, 10:11, "Jianyong Wu" mailto:jianyong...@arm.com>> wrote: commit f13264b34 introduces a bug for CloudHv as OvmfPkg/OvmfPkg.dec is missin

[edk2-devel] Contribution process for containers repo?

The CONTRIBUTING.md file in https://github.com/tianocore/containers says that GitHub Pull Requests are used for contributions. I was wondering if that's correct, or if patches should be sent to this mailing list instead (or in addition)? Thanks. Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Group

Re: [edk2-devel] [PATCH 2/3] BaseTools/Conf/tools_def: Fix CLANGDWARF_IA32_X64

Hi all, > On 28. Mar 2023, at 07:38, gaoliming wrote: > Patrick: > I prefer to override this option in DSC instead of the change in > tools_def.txt. A DSC override to fix *binary corruption* of an unknown cause? It is ridiculous this can even happen silently, even though it’s unclear which co

Re: [edk2-devel] [PATCH 1/9] ArmVirtPkg: Add CpuPageTableLib required by DxeIpl in DSC

My mistake... Pls ignore the patch set. I'll remove the patch of ArmVirtPkg in next version patch set. Thanks, Dun -Original Message- From: Gerd Hoffmann Sent: Tuesday, March 28, 2023 2:54 PM To: Tan, Dun Cc: devel@edk2.groups.io; Ard Biesheuvel ; Leif Lindholm ; Sami Mujawar ; Ni,

Re: [edk2-devel] [PATCH v1 1/1] Define security policy in SECURITY.md file for repository

Reviewed-by: Rebecca Cran On 3/9/23 12:43 PM, Kun Qin wrote: From: Sean Brogan Create SECURITY.md security policy for tianocore edk2 leveraging CVD and the Github Private Vulnerability Reporting process. Co-authored-by: Sean Brogan Signed-off-by: Kun Qin --- SECURITY.md | 33 +++

Re: [edk2-devel] [PATCH v4 8/9] ManageabilityPkg: Add IpmiProtocol to Manageability Package

Hi Abner, The DXE and PEI modules should work on aarch64. Please see my suggestion below. On 3/22/2023 9:48 AM, Chang, Abner via groups.io wrote: From: Abner Chang Add Ipmi Protocol/Ppi/SMM modules to ManageabilityPkg. Signed-off-by: Abner Chang Cc: Liming Gao Cc: Isaac Oram Cc: Nate DeS

Re: [edk2-devel] [PATCH v4 2/9] ManageabilityPkg: Initial package

Hi Abner,  How can I include this package into flash description? May we lack the FDF file? We can refer to AdvanceFeaturePkg, could have PreMemory.fdf and PostMemory.fdf BTW, Please add PCDs to the feature configuration; this will be very useful when other transport drivers are supported.

Re: [edk2-devel] [PATCH v2] ArmVirtPkg: can't find gUefiOvmfPkgTokenSpaceGuid

On Tue, 28 Mar 2023 at 12:11, Sami Mujawar wrote: > > Hi Ard, > > This patch fixes a build break for the CloudHv firmware. > Can you let me know if I can merge this patch, please? > Yes, please go ahead Reviewed-by: Ard Biesheuvel > > On 28/03/2023, 10:11, "Jianyong Wu"

Re: [edk2-devel] [PATCH 0/6] Substract TME-MK KEY_ID_BITS from CPU max PA

Gerd, Tom, Can you please review this patch series? thanks, ray From: devel@edk2.groups.io on behalf of Ni, Ray Sent: Wednesday, March 22, 2023 7:56:44 AM To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH 0/6] Substract TME-MK KEY_ID_BITS from CPU max PA

Re: [edk2-devel] [PATCH 0/6] Substract TME-MK KEY_ID_BITS from CPU max PA

Mike, Eric, Ca you kindly review? thanks, ray From: devel@edk2.groups.io on behalf of Ni, Ray Sent: Wednesday, March 22, 2023 7:56:44 AM To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH 0/6] Substract TME-MK KEY_ID_BITS from CPU max PA Ray Ni (6): MdeP

Re: [edk2-devel] Contribution process for containers repo?

Hi Rebecca, I've seen pull requests used and I don't recall patches being sent to the mailing list. A change may need integration work in the edk2 repo and, of course, a patch is sent to the list for that. Thanks, Michael On 3/28/2023 6:35 AM, Rebecca Cran wrote: The CONTRIBUTING.md file i

Re: [edk2-devel] [PATCH v3] RedfishPkg/RedfishPlatformCredentialIpmiLib: IPMI implementation

Hi Nickle, It looks good except one small question I would like to raise. Please check my comment below. Thank you, Igor -Original Message- From: Nickle Wang Sent: Monday, March 27, 2023 9:42 PM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy ; Nick Ramirez Subject: [EXTERNA

Re: [edk2-devel] [PATCH v4 1/1] ArmPkg/SmbiosMiscDxe: Adjust the priority of getting firmware version

On Mon, Mar 27, 2023 at 01:35:43 +0700, Tinh Nguyen wrote: > The BIOS Firmware Version in the SMBIOS Type 0 can be fetched from > the fixed PcdFirmwareVersionString or platform specific OemMiscLib. > In fact, the support from OemMiscLib comes into play when the firmware > version may be modified at

Re: [edk2-devel] Contribution process for containers repo?

On 3/28/23 8:24 AM, Michael Kubacki wrote: I've seen pull requests used and I don't recall patches being sent to the mailing list. A change may need integration work in the edk2 repo and, of course, a patch is sent to the list for that. Thanks. I've opened https://github.com/tianocore/cont

[edk2-devel] Open PRs in the edk2-basetools repo (e.g. fixing very outdated/broken readme.md)

Could people take a look at the outstanding pull requests on https://github.com/tianocore/edk2-basetools please? I just wasted time updating the readme.md file because it's very outdated and has broken links - only to find someone else fixed those issues in September last year and created htt

Re: [edk2-devel] [PATCH v1 0/1] Define security policy in SECURITY.md file for repository

Reviewed-by: Kevin D Davis @insyde.com>KevinInsyde SoftwareOn Mar 27, 2023, at 5:26 PM, Demeter, Miki via groups.io wrote: Ack   Need to get this acked by others in infosec too     --  Miki Demeter (she/her/Miki) Security Researcher / FW Developer FST Intel Corporation

[edk2-devel] [PATCH v2 01/13] OvmfPkg: Replace static struct initialization with ZeroMem call

Replace the static struct initialization with a call to ZeroMem to avoid generating a call to memset in certain build configurations. Signed-off-by: Rebecca Cran Reviewed-by: Gerd Hoffmann Reviewed-by: Oliver Smith-Denny --- OvmfPkg/Library/PlatformInitLib/MemDetect.c | 4 +++- 1 file changed,

[edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC

Update the toolchain definitions: - Delete the CLANG35 and CLANG38 toolchains, and replace CLANG38 with CLANGDWARF, updating it to support ARM and AARCH64 in addition to X64 and IA32. - Remove GCC48 and GCC49. - Remove VS2008, VS2010, VS2012 and VS2013. - Remove EBC compiler definitions. Full

[edk2-devel] [PATCH v2 02/13] CryptoPkg: Add CLANGDWARF and remove CLANG35 and CLANG38 compiler flags

With the removal of CLANG35 and CLANG38 and the update of the CLANGDWARF toolchain definition in Conf/tools_def.txt update the compiler flags in BaseCryptLib and OpensslLib. Signed-off-by: Rebecca Cran Reviewed-by: Oliver Smith-Denny --- CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf

[edk2-devel] [PATCH v2 03/13] BaseTools: Update CLANGDWARF toolchain and remove CLANG35 and CLANG38

Update the CLANGDWARF toolchain definition with the settings from CLANG38, and delete the CLANG35 and CLANG38 toolchains. The CLANG35 and CLANG38 toolchains were added for compatibility with ARM's proprietary clang-based toolchain. Things have since moved on, and with the latest clang version bein

[edk2-devel] [PATCH v2 04/13] BaseTools: Remove VS2008, 2010, 2012 and 2013 toolchain definitions

With recent changes, Visual Studio versions older than VS2015 are unable to build EDK2 code. To avoid confusion, remove VS2008, 2010, 2012 and 2013 toolchain definitions from Conf/tools_def.template, leaving only versions that can be used to successfully build firmware. Signed-off-by: Rebecca Cra

[edk2-devel] [PATCH v2 05/13] BaseTools: Remove VS2008-VS2013 remnants

Remove remnants of Visual Studio 2008-2013 support from Conf/tools_def.txt and various batch scripts. Signed-off-by: Rebecca Cran Reviewed-by: Oliver Smith-Denny --- BaseTools/Conf/tools_def.template | 12 BaseTools/Scripts/SetVisualStudio.bat | 22 +-- BaseTools/Scripts/ShowEnviro

[edk2-devel] [PATCH v2 06/13] MdePkg: Remove VS2008-VS2013 remnants

Since Visual Studio versions older than VS2015 are no longer supported, remove mention of them from MdePkg. Signed-off-by: Rebecca Cran Reviewed-by: Oliver Smith-Denny --- MdePkg/Include/Ia32/ProcessorBind.h | 8 ++-- MdePkg/Include/X64/ProcessorBind.h | 8 ++-- 2 files changed, 4 inse

[edk2-devel] [PATCH v2 08/13] BaseTools: Remove unused IPHONE_TOOLS and SOURCERY_CYGWIN_TOOLS defs

Remove the unused IPHONE_TOOLS and SOURCERY_CYGWIN_TOOLS definitions from Conf/tools_def.template. Signed-off-by: Rebecca Cran Reviewed-by: Oliver Smith-Denny --- BaseTools/Conf/tools_def.template | 4 1 file changed, 4 deletions(-) diff --git a/BaseTools/Conf/tools_def.template b/BaseTo

[edk2-devel] [PATCH v2 09/13] BaseTools: Remove EBC (EFI Byte Code) compiler definitions

The edk2-stable202302 release was the last to support building EFI Byte Code drivers. Since the Intel EFI Byte Code Compiler is no longer available, a decision has been made to remove support for EBC from edk2. Remove the definitions for Intel's EBC compiler from Conf/tools_def.template. Signed-o

[edk2-devel] [PATCH v2 07/13] edksetup.bat: Remove VS2008-VS2013 remnants

Since Visual Studio versions older than VS2015 are no longer supported, remove mention of them from edksetup.bat. Signed-off-by: Rebecca Cran Reviewed-by: Oliver Smith-Denny --- edksetup.bat | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/edksetup.bat b/edksetup.bat ind

[edk2-devel] [PATCH v2 10/13] OvmfPkg: Use Xcode5 version of CpuExceptionHandlerLib for CLANGDWARF

The CLANGDWARF toolchain has the same problem as XCODE5 linking CpuExceptionHandlerLib. So, use the Xcode5SecPeiCpuExceptionHandlerLib.inf when building with the CLANGDWARF toolchain. Since the difference is that the non-Xcode5 version uses `mov` while the Xcode5 version uses `lea`, they can be me

[edk2-devel] [PATCH v2 12/13] BaseTools: Remove unused CYGWIN_ defines from tools_def.txt.template

Signed-off-by: Rebecca Cran --- BaseTools/Conf/tools_def.template | 4 1 file changed, 4 deletions(-) diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template index 3a60fe9b5965..fc1cda24bedf 100755 --- a/BaseTools/Conf/tools_def.template +++ b/BaseTools/Conf/tool

[edk2-devel] [PATCH v2 13/13] Bump tools_def.txt VERSION to 3.0

Bump tools_def.txt VERSION to 3.0 for the deletion of VS2008-VS2013, CLANG35, CLANG38, GCC48, GCC49 and the renaming of GCC5 to GCC. Signed-off-by: Rebecca Cran --- BaseTools/Conf/tools_def.template | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/BaseTools/Conf/tools_def.te

[edk2-devel] [PATCH v2 11/13] Delete GCC48 and GCC49 toolchains and rename GCC5 to GCC

Signed-off-by: Rebecca Cran --- UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc | 4 +- IntelFsp2Pkg/Tools/Tests/QemuFspPkg.dsc | 12 +- CryptoPkg/Library/OpensslLib/OpensslLib.inf | 2 +- CryptoPkg/Library/OpensslLib/Op

Re: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC

Hi Rebecca, Thanks for respining this. On Tue, 28 Mar 2023 at 19:31, Rebecca Cran wrote: > > Update the toolchain definitions: > > - Delete the CLANG35 and CLANG38 toolchains, and replace CLANG38 with > CLANGDWARF, updating it to support ARM and AARCH64 in addition to X64 > and IA32. > As I

Re: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC

On 3/28/23 11:57 AM, Ard Biesheuvel wrote: As I have indicated before, I am strongly in favor of these changes. However, using LLD with X86 and GNU ld with ARM is not what I would like to see here: not only is it a bad idea for a single toolchain definition to deviate in this manner between arc

[edk2-devel] [PATCH v2 0/2] SEV-SNP guest support fixes

This patch series provides some fixes around AP creation: - An erratum on AMD hardware requires that a VMSA not be aligned on a 2MB boundary. To work around this issue, allocate 2 pages of memory and using the page that is not 2MB aligned and freeing the other. - When parking APs after exitin

[edk2-devel] [PATCH v2 1/2] UefiCpuPkg/MpInitLib: Reuse VMSA allocation to avoid unreserved allocation

https://bugzilla.tianocore.org/show_bug.cgi?id=4353 When parking the APs on exiting from UEFI, a new page allocation is made. This allocation, however, does not end up being marked reserved in the memory map supplied to the OS. To avoid this, re-use the VMSA by clearing the VMSA RMP flag, updating

[edk2-devel] [PATCH v2 2/2] UefiCpuPkg/MpInitLib: Ensure SEV-SNP VMSA allocations are not 2MB aligned

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4353 Due to AMD erratum #1467, an SEV-SNP VMSA should not be 2MB aligned. To work around this issue, allocate two pages instead of one. Because of the way that page allocation is implemented, always try to use the second page. If the second page i

Re: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC

On Tue, 28 Mar 2023 at 20:01, Rebecca Cran wrote: > > On 3/28/23 11:57 AM, Ard Biesheuvel wrote: > > > > > As I have indicated before, I am strongly in favor of these changes. > > However, using LLD with X86 and GNU ld with ARM is not what I would > > like to see here: not only is it a bad idea fo

[edk2-devel] [PATCH] IntelFsp2Pkg: LoadMicrocodeDefault() causing unnecessary delay.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4391 FSP should support the scenario that CPU microcode already loaded before calling LoadMicrocodeDefault(), in this case it should return directly without spending more time. Also the LoadMicrocodeDefault() should only attempt to load one versi

Re: [edk2-devel] [PATCH v2 2/2] UefiCpuPkg/MpInitLib: Ensure SEV-SNP VMSA allocations are not 2MB aligned

On 3/28/23 13:09, Lendacky, Thomas via groups.io wrote: BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4353 Due to AMD erratum #1467, an SEV-SNP VMSA should not be 2MB aligned. To work around this issue, allocate two pages instead of one. Because of the way that page allocation is implemente

Re: [edk2-devel] [Patch 04/12] UnitTestFrameworkPkg/ReadMe.md: Add gmock documentation

In reviewing the README, I found a few items that need to be updated. * Fix FunctionMockLib example of the MockUefiLib declaration to align with the design code * Fix FunctionMockLib Mocks header file location paths in the tables * Fix FunctionMockLib Mocks example (and description) of the MockUe

Re: [edk2-devel] [PATCH v7 09/12] ShellPkg: Fix conditionally uninitialized variables

A couple comments below, thanks! On 3/24/2023 3:30 PM, Michael Kubacki wrote: From: Michael Kubacki Fixes CodeQL alerts for CWE-457: https://cwe.mitre.org/data/definitions/457.html Cc: Erich McMillan Cc: Michael D Kinney Cc: Michael Kubacki Cc: Ray Ni Cc: Zhichao Gao Co-authored-by: Eric

Re: [edk2-devel] [PATCH v7 00/12] Enable New CodeQL Queries

With comments and for the patchset: Reviewed-by: Oliver Smith-Denny Thanks! On 3/24/2023 3:30 PM, Michael Kubacki wrote: From: Michael Kubacki Adds queries for the following: 1. cpp/conditionallyuninitializedvariable 2. cpp/pointer-overflow-check 3. cpp/overrunning-write 4. cpp/overrunning

Re: [edk2-devel] [PATCH v5 2/3] MdePkg: add SBI-based SerialPortLib for RISC-V

Sec isn't a good fit, because it has implications on the environment, which is why the contribution also includes a separate SecPei variant as well. In naming, I followed other edk2 examples such as ./EmbeddedPkg/Library/PrePiExtractGuidedSectionLib and ./EmbeddedPkg/Library/PrePiMemoryAllocati

Re: [edk2-devel] [PATCH v5 2/3] MdePkg: add SBI-based SerialPortLib for RISC-V

I agree that moving into EmbeddedPkg does not make sense. EmbeddedPkg is very old without many updates. That package is not the best to use for examples. I think you are suggesting that there is a difference in a library that runs in an SEC env with intent to hand off to PEI and a library that r

Re: [edk2-devel] [PATCH v5 2/3] MdePkg: add SBI-based SerialPortLib for RISC-V

So I'd be in support of formally defining a PrePi prefix. If we go with Sec, then we'd have to come up with some other way of disambiguating "hand off to PEI" vs "hand off to DXE", and it seems like PrePi is already that. What do you entail the process to be followed here? Is there value in defi

Re: [edk2-devel] [PATCH v5 2/3] MdePkg: add SBI-based SerialPortLib for RISC-V

From looking at the details of your libs, it is not related to DXE. It is SEC with no writable globals, or SEC with writable globals. Both libs could be used in an SEC implementation that hands off to PEI or DXE. You current proposed names are: * SecPeiRiscVSerialPortLibSbi * PrePiDxeRiscVSerial

Re: [edk2-devel] [PATCH v5 2/3] MdePkg: add SBI-based SerialPortLib for RISC-V

Thanks for the in-depth proposal, this is undoubtedly going to be very helpful for future reference. Will rework and resend. A -Original Message- From: Kinney, Michael D Sent: Tuesday, March 28, 2023 4:26 PM To: Warkentin, Andrei ; devel@edk2.groups.io Cc: Gao, Liming ; Liu, Zhiguang

Re: [edk2-devel] [PATCH v2 01/13] OvmfPkg: Replace static struct initialization with ZeroMem call

Reviewed-by: Jiewen Yao > -Original Message- > From: Rebecca Cran > Sent: Wednesday, March 29, 2023 1:31 AM > To: devel@edk2.groups.io; Oliver Smith-Denny ; > Jiang, Guomin ; Lu, Xiaoyu1 > ; Wang, Jian J ; Yao, Jiewen > ; Ard Biesheuvel ; > Justen, Jordan L ; Gerd Hoffmann > ; Feng, Bob

Re: [edk2-devel] [PATCH v2 01/13] OvmfPkg: Replace static struct initialization with ZeroMem call

Reviewed-by: Michael D Kinney > -Original Message- > From: Yao, Jiewen > Sent: Tuesday, March 28, 2023 3:40 PM > To: Rebecca Cran ; devel@edk2.groups.io; Oliver > Smith-Denny ; Jiang, Guomin > ; Lu, Xiaoyu1 ; Wang, Jian J > ; Ard Biesheuvel > ; Justen, Jordan L ; > Gerd Hoffmann ; Fe

Re: [edk2-devel] [PATCH v2 17/17] MdeModulePkg: Enable forward edge CFI in mem attributes table

On 3/27/2023 4:01 AM, Ard Biesheuvel wrote: The memory attributes table has been extended with a flag that indicates whether or not the OS is permitted to map the EFI runtime code regions with strict enforcement for IBT/BTI landing pad instructions. Given that the PE/COFF spec now defines a DllC

Re: [edk2-devel] [PATCH v2 00/17] Enable BTI support in memory attributes table

For the patchset: Reviewed-by: Oliver Smith-Denny Thanks! On 3/27/2023 4:00 AM, Ard Biesheuvel wrote: Implement version 2 of the memory attributes table, which now contains a flag informing the OS whether or not code regions may be mapped with CFI mitigations such as IBT or BTI enabled.

Re: [edk2-devel] [PATCH v7 09/12] ShellPkg: Fix conditionally uninitialized variables

On 3/28/2023 12:24 PM, Michael Kubacki wrote: Hi Oliver, Thanks for taking time to look through the series. I responded inline. Thanks, Michael On 3/28/2023 2:49 PM, Oliver Smith-Denny wrote: A couple comments below, thanks! On 3/24/2023 3:30 PM, Michael Kubacki wrote: From: Michael Kubacki

[edk2-devel] CLI way of checking PR CI status

For a while I've been irritated at having to open a web browser to check the status of CI tasks for my GitHub PRs. Fortunately I mentioned on the UEFI Talkbox channel about wanting to write a tool that uses the GitHub API to query the status, and JoeyV pointed out that the 'gh' tool (https://

回复: [edk2-devel] [PATCH v2 00/13] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38,GCC48,GCC49, rename GCC5 to GCC, update CLANGDWARF, delete VS 2008-2013, EBC

Rebecca: > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Rebecca Cran > 发送时间: 2023年3月29日 1:31 > 收件人: devel@edk2.groups.io; Oliver Smith-Denny ; > Guomin Jiang ; Xiaoyu Lu ; > Jian J Wang ; Jiewen Yao ; > Ard Biesheuvel ; Jordan Justen > ; Gerd Hoffmann ; Bob Feng > ; Liming Gao ; Andrew > Fish ;

Re: [edk2-devel] [PATCH v3] RedfishPkg/RedfishPlatformCredentialIpmiLib: IPMI implementation

> Igor: Since we get here when Status is success, then "Data" buffer will be > allocated in that case. > Should we free that buffer before return? Thanks for catching this issue, Igor. Version 4 is under CI testing. I will send it out soon. Regards, Nickle > -Original Message- > From:

Re: [edk2-devel] [PATCH v4 2/9] ManageabilityPkg: Initial package

[AMD Official Use Only - General] Hi Tinh, See my response below, > -Original Message- > From: devel@edk2.groups.io On Behalf Of Tinh > Nguyen via groups.io > Sent: Tuesday, March 28, 2023 8:37 PM > To: devel@edk2.groups.io; Chang, Abner > Cc: Liming Gao ; Isaac Oram > ; Nate DeSimone >

Re: [edk2-devel] [PATCH 1/3] RedfishPkg/JsonLib: address coverity issue

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Tuesday, March 28, 2023 1:59 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [PATCH 1/3] RedfishPkg/JsonLib: address coverity issu

Re: [edk2-devel] [PATCH 2/3] RedfishPkg: Redfish discover driver improvement

[AMD Official Use Only - General] Hi Nickle, I found that we had defined the Host IP address format in Redfish\Incluode\IndustryStandard\RedfishHostInterface.h #define REDFISH_HOST_INTERFACE_HOST_IP_ADDRESS_FORMAT_UNKNOWN 0x00 #define REDFISH_HOST_INTERFACE_HOST_IP_ADDRESS_FORMAT_IP4 0x01

Re: [edk2-devel] [PATCH 3/3] RedfishPkg: fix config handler driver issues

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Tuesday, March 28, 2023 1:59 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [PATCH 3/3] RedfishPkg: fix config handler driver iss

Re: [edk2-devel] [PATCH 2/3] RedfishPkg: Redfish discover driver improvement

Yes, let me handle this in version 2 patch. Thanks! Regards, Nickle > -Original Message- > From: Chang, Abner > Sent: Wednesday, March 29, 2023 10:12 AM > To: Nickle Wang ; devel@edk2.groups.io > Cc: Igor Kulchytskyy ; Nick Ramirez > Subject: RE: [PATCH 2/3] RedfishPkg: Redfish discover

Re: [edk2-devel] [PATCHv2 1/1] MdeModulePkg/Ahci: Skip retry for non-transient errors

Reviewed-by: Baraneedharan Anbazhagan mailto:anbazha...@hp.com>> From: devel@edk2.groups.io On Behalf Of Wu, Hao A via groups.io Sent: Monday, March 27, 2023 9:03 PM To: Albecki, Mateusz ; devel@edk2.groups.io Cc: Ni, Ray ; Chang, Hunter ; Anbazhagan, Baraneedharan Subject: Re: [edk2-devel] [

[edk2-devel] [PATCH] MdePkg Smbios.h: Update Smbios Misc Slot Information Definition

Current name is too generic to conflict with module local definition. Update name with the the specific prefix name. Signed-off-by: Liming Gao Cc: Michael D Kinney Cc: Zhiguang Liu --- MdePkg/Include/IndustryStandard/SmBios.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-)

[edk2-devel] [edk2-platforms][PATCH v2 0/9] Support Ampere Altra Max processor

This patchset adds support for Ampere Altra Max processor and updates for some bugfixes. Changes since v1: + Improved readability per Leif's feedback, such as: Add helper functions. split out the supports, bugfixes, and code refactor. Tinh Nguyen (1): JadePkg: ACPI: Support ACPI tables for

[edk2-devel] [edk2-platforms][PATCH v2 1/9] AmpereAltraPkg: Correct PCIe Devmap

From: Vu Nguyen This corrects the high devmap of Root Complex (RC) that should be fetched from a high bifurcation. Signed-off-by: Nhi Pham --- .../Ampere/AmpereAltraPkg/Drivers/PcieInitPei/PcieInitPei.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Silicon/Ampere/Am

[edk2-devel] [edk2-platforms][PATCH v2 2/9] AmpereAltraPkg: Correct PCIe memory attribute

From: Vu Nguyen This fixes the memory attribute of the first RC Type B (RCB0). Signed-off-by: Nhi Pham --- Silicon/Ampere/AmpereAltraPkg/Include/Platform/Ac01.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/Ampere/AmpereAltraPkg/Include/Platform/Ac01.h b/Silicon/

[edk2-devel] [edk2-platforms][PATCH v2 3/9] JadePkg: PCIe: Add delay after releasing PERST

From: Vu Nguyen According to PCIe specification, following exit from a Conventional Reset, some devices may require additional time before they are able to respond to Requests they receive, so this patch adds a delay after releasing the PERST signal. Signed-off-by: Nhi Pham --- .../Ampere/Jade

[edk2-devel] [edk2-platforms][PATCH v2 5/9] AmpereAltraPkg: Update Ampere Core/Cluster profile

From: Vu Nguyen This updates the number of cores and clusters to add support for the Ampere Altra Max processor. Signed-off-by: Nhi Pham --- Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 6 +++--- Silicon/Ampere/AmpereAltraPkg/Include/Platform/Ac01.h | 5 - 2 files changed, 7 ins

[edk2-devel] [edk2-platforms][PATCH v2 4/9] AmpereAltraPkg: Update Ampere specific platform PCIe core

From: Vu Nguyen This patch updates the following: - Check End Point configuration space is accessible or not before getting its capability. - Add new function to check PCIe card is present or not. - Set CRS (Configuration Request Retry Status) to follow PCIe specifications. Signed-off-by: Nh

[edk2-devel] [edk2-platforms][PATCH v2 6/9] Ampere: PCIe: Add PHY preset NVParams for Ampere Altra Max

From: Vu Nguyen This adds PHY preset NVParams definition for each Root complex to support Ampere Altra Max platform. Signed-off-by: Nhi Pham --- .../AmpereAltraPkg/Include/NVParamDef.h | 36 +-- 1 file changed, 34 insertions(+), 2 deletions(-) diff --git a/Silicon/Ampere

[edk2-devel] [edk2-platforms][PATCH v2 7/9] Ampere: PCIe: Add support for Ampere Altra Max

From: Vu Nguyen This updates the platform specific PCIe modules to add support for Ampere Altra Max processor which features 128 PCIe Gen4 lanes (distributed across eight x16 RCAs) using 32 controllers. Signed-off-by: Nhi Pham --- .../Library/BoardPcieLib/BoardPcieLib.c | 75 +++- .../D

[edk2-devel] [edk2-platforms][PATCH v2 8/9] AmpereAltraPkg: Support get SubNUMA node region for Ampere silicons

From: Vu Nguyen This change helps to update the following: - Add logic to get SubNUMA node region for Ampere silicons (Altra and Altra Max processor) as a common API in AmpereCpuLibCommon. - Leverage the added API of AmpereCpuLibCommon accordingly. Signed-off-by: Nhi Pham --- .../Include/Lib

Re: [edk2-devel] [edk2-platforms][PATCH 0/2] Support Ampere Altra Max processor

Hi Leif, Sorry to have kept you waiting. I was not able to send the v2 out sooner than I wanted as the large refactor changes has been well-tested. I have just sent the v2. I hope all your comments are addressed. Thanks so much. Nhi On 1/13/2023 11:25 AM, Nhi Pham wrote: This patchset adds

[edk2-devel] [PATCH V1 1/1] OvmfPkg/PlatformPei: Skip PlatformInitEmuVariableNvStore in SEV guest

From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4379 PlatformInitEmuVariableNvStore is called to initialize the EmuVariableNvStore with the content pointed by PcdOvmfFlashNvStorageVariableBase. This is because when OVMF is launched with -bios parameter, UEFI variables will be p

[edk2-devel] [PATCH v4] RedfishPkg/RedfishPlatformCredentialIpmiLib: IPMI implementation

This library follows Redfish Host Interface specification and use IPMI command to get bootstrap account credential(NetFn 2Ch, Command 02h) from BMC. RedfishHostInterfaceDxe will use this credential for the following communication between BIOS and BMC. Signed-off-by: Nickle Wang Cc: Abner Chang C

[edk2-devel] [PATCH v2 0/3] Fix variety issues in RedfishPkg

Fix variety issues in RedfishPkg, including coverity issue, typo, coding bugs and improve driver binding code flow in RedfishDiscoverDxe driver. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Nickle Wang (3): RedfishPkg/JsonLib: address coverity issue Re

[edk2-devel] [PATCH v2 1/3] RedfishPkg/JsonLib: address coverity issue

Fix implicit conversion issue in JsonLib. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Abner Chang --- RedfishPkg/Library/JsonLib/JsonLib.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/RedfishPkg/Library/JsonLib/JsonLi

[edk2-devel] [PATCH v2 2/3] RedfishPkg: Redfish discover driver improvement

Bug fix: - function stack fault - properly handle "SubnetAddrInfoIPv6" when there is no IPv6 support - copy-n-paste error in RedfishGetHostInterfaceProtocolData() - fix typo Enhancement: - Redfish discover driver now can configure host IP address based on the information from SMBIOS type 42 recor

[edk2-devel] [PATCH v2 3/3] RedfishPkg: fix config handler driver issues

Bug fix: - function stack fault - config handler driver requires the dependency of Redfish Credential Protocol - incorrect caller id installation when failed to perform init() - fix typo Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez Reviewed-by: Abner Chang

Re: [edk2-devel] [PATCH v2 2/3] RedfishPkg: Redfish discover driver improvement

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Wednesday, March 29, 2023 2:14 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [PATCH v2 2/3] RedfishPkg: Redfish discover driver