Hi Jianyong,

Thank you for this fix.

The subject line should have the package name as prefix followed by the short 
description for the patch e.g. "ArmVirtPkg: xxx".
Other than that, this change looks good to me.

Reviewed-by: Sami Mujawar <[email protected]>

Regards,

Sami Mujawar

On 28/03/2023, 04:28, "Jianyong Wu" <[email protected] 
<mailto:[email protected]>> wrote:


Add Ard Biesheuvel <[email protected] <mailto:[email protected]>> and Sunil V L 
<[email protected] <mailto:[email protected]>> to cc list.


> -----Original Message-----
> From: Jianyong Wu <[email protected] <mailto:[email protected]>>
> Sent: 2023年2月17日 14:48
> To: [email protected] <mailto:[email protected]>; Sami Mujawar 
> <[email protected] <mailto:[email protected]>>
> Cc: Jianyong Wu <[email protected] <mailto:[email protected]>>
> Subject: [PATCH] CloudHv: can't find gUefiOvmfPkgTokenSpaceGuid
>
> commit f13264b34 introduces a bug for CloudHv as OvmfPkg/OvmfPkg.dec is
> missing in CloudHvHasAcpiDtDxe.inf which leads to
> gUefiOvmfPkgTokenSpaceGuid found nowhere.
>
> Signed-off-by: Jianyong Wu <[email protected] <mailto:[email protected]>>
> ---
> ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git
> a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
> b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
> index 7cad40e11f..6ff80b24d0 100644
> --- a/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
> +++ b/ArmVirtPkg/CloudHvPlatformHasAcpiDtDxe/CloudHvHasAcpiDtDxe.inf
> @@ -23,6 +23,7 @@
> EmbeddedPkg/EmbeddedPkg.dec
> MdeModulePkg/MdeModulePkg.dec
> MdePkg/MdePkg.dec
> + OvmfPkg/OvmfPkg.dec
>
> [LibraryClasses]
> BaseLib
> --
> 2.17.1





IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#102015): https://edk2.groups.io/g/devel/message/102015
Mute This Topic: https://groups.io/mt/97023835/21656
Group Owner: [email protected]
Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to