On Wed, 15 Mar 2023 at 19:31, Leif Lindholm wrote:
>
> On Mon, Mar 13, 2023 at 18:16:47 +0100, Ard Biesheuvel wrote:
> > Expose the protocol introduced in v2.10 that permits the caller to
> > manage mapping permissions in the page tables.
>
> Nitpicks and a question:
>
> > Signed-off-by: Ard Biesh
Look like create Case2 and Case3 behavior. It looks good from my view point.
Just minor request, In commit message please use "UniversalPayload" but
"Universalpayload"
Case1: > "python UefiPayloadPkg/UniversalPayloadBuild.py", output UefiUpl.elf
Case2: > "python UefiPayloadPkg/UniversalPayloadB
+ Rebecca
Could you kindly help me in reviewing this patch?
Thanks,
- Tinh
On 13/03/2023 13:43, Tinh Nguyen wrote:
The BIOS Firmware Version in the SMBIOS Type 0 can be fetched from
the fixed PcdFirmwareVersionString or platform specific OemMiscLib.
In fact, the support from OemMiscLib comes
On Thu, 16 Mar 2023 at 08:19, Ard Biesheuvel wrote:
>
> On Wed, 15 Mar 2023 at 19:31, Leif Lindholm wrote:
> >
> > On Mon, Mar 13, 2023 at 18:16:47 +0100, Ard Biesheuvel wrote:
> > > Expose the protocol introduced in v2.10 that permits the caller to
> > > manage mapping permissions in the page ta
On Thu, Mar 16, 2023 at 10:27:48 +0100, Ard Biesheuvel wrote:
> On Thu, 16 Mar 2023 at 08:19, Ard Biesheuvel wrote:
> >
> > On Wed, 15 Mar 2023 at 19:31, Leif Lindholm
> > wrote:
> > >
> > > On Mon, Mar 13, 2023 at 18:16:47 +0100, Ard Biesheuvel wrote:
> > > > Expose the protocol introduced in v
On Wed, Mar 15, 2023 at 10:25:25AM +0100, Gerd Hoffmann wrote:
> On Wed, Mar 15, 2023 at 02:41:19PM +0530, Sunil V L wrote:
> > Add support for building RiscVVirtQemu platform in CI.
> >
> > Cc: Ard Biesheuvel
> > Cc: Jiewen Yao
> > Cc: Jordan Justen
> > Cc: Gerd Hoffmann
> > Signed-off-by: Su
Given Leif's comments, I was expecting a new version with some changes.
--
Rebecca Cran
On 3/16/23 2:30 AM, Tinh Nguyen via groups.io wrote:
+ Rebecca
Could you kindly help me in reviewing this patch?
Thanks,
- Tinh
On 13/03/2023 13:43, Tinh Nguyen wrote:
The BIOS Firmware Version in th
On Mon, Mar 13, 2023 at 18:16:57 +0100, Ard Biesheuvel wrote:
> Implement the ARM version of a NULL class library that can be overlaid
> on top of the DXE core to equip it right from its launch with an
> implementation of the CPU arch protocol member that sets type and
> permission attributes on me
On Mon, Mar 13, 2023 at 18:16:59 +0100, Ard Biesheuvel wrote:
> Deal with DRAM memory potentially being mapped with non-executable
> permissions, by mapping the DXE core code sections explicitly before
> launch.
Could you add a note about why LoadPeCoffImage/LoadDxeCoreFromFfsFile
are made private
On Mon, Mar 13, 2023 at 18:17:03 +0100, Ard Biesheuvel wrote:
> The AArch64 ARM architecture supports a hardware enforcement mode for
> mutual exclusion between code and data: any page that is mapped writable
> is implicitly non-executable as well.
>
> This means that remapping part of a runtime i
On Thu, 16 Mar 2023 at 14:33, Leif Lindholm wrote:
>
> On Mon, Mar 13, 2023 at 18:16:59 +0100, Ard Biesheuvel wrote:
> > Deal with DRAM memory potentially being mapped with non-executable
> > permissions, by mapping the DXE core code sections explicitly before
> > launch.
>
> Could you add a note
On Mon, Mar 13, 2023 at 18:17:08 +0100, Ard Biesheuvel wrote:
> Currently, we invoke ApplyMemoryProtectionPolicy() after
> CoreInternalFreePages() has returned successfully, in order to update
> the memory permission attributes of the region to match the policy for
> EfiConventionalMemory.
>
> The
On Thu, 16 Mar 2023 at 14:51, Leif Lindholm wrote:
>
> On Mon, Mar 13, 2023 at 18:17:08 +0100, Ard Biesheuvel wrote:
> > Currently, we invoke ApplyMemoryProtectionPolicy() after
> > CoreInternalFreePages() has returned successfully, in order to update
> > the memory permission attributes of the re
Hi Ard,
For all the patches I haven't explicitly asked any questions about:
Reviewed-by: Leif Lindholm
On Mon, Mar 13, 2023 at 18:16:36 +0100, Ard Biesheuvel wrote:
> Link: https://bugzilla.tianocore.org/show_bug.cgi?id=4369
>
> This v5 now covers a lot more ground, and has ballooned quite
> s
On 2023-03-16 13:50, Ard Biesheuvel wrote:
On Thu, 16 Mar 2023 at 14:33, Leif Lindholm wrote:
On Mon, Mar 13, 2023 at 18:16:59 +0100, Ard Biesheuvel wrote:
Deal with DRAM memory potentially being mapped with non-executable
permissions, by mapping the DXE core code sections explicitly before
l
On Thu, 16 Mar 2023 at 14:27, Leif Lindholm wrote:
>
> On Mon, Mar 13, 2023 at 18:16:57 +0100, Ard Biesheuvel wrote:
> > Implement the ARM version of a NULL class library that can be overlaid
> > on top of the DXE core to equip it right from its launch with an
> > implementation of the CPU arch pr
On Thu, 16 Mar 2023 at 14:46, Leif Lindholm wrote:
>
> On Mon, Mar 13, 2023 at 18:17:03 +0100, Ard Biesheuvel wrote:
> > The AArch64 ARM architecture supports a hardware enforcement mode for
> > mutual exclusion between code and data: any page that is mapped writable
> > is implicitly non-executab
On Thu, Mar 16, 2023 at 02:58:07PM +0100, Fiona Ebner wrote:
> Hi,
> after upgrading to edk2-stable202211 recently, we got user reports[0]
> about QEMU virtual machines with '-cpu host' on AMD Ryzen hosts not
> booting correctly anymore. A workaround seems to be assigning more
> memory to the VM.
On 2023-03-16 14:00, Ard Biesheuvel wrote:
On Thu, 16 Mar 2023 at 14:51, Leif Lindholm wrote:
On Mon, Mar 13, 2023 at 18:17:08 +0100, Ard Biesheuvel wrote:
Currently, we invoke ApplyMemoryProtectionPolicy() after
CoreInternalFreePages() has returned successfully, in order to update
the memory
From: KasimX Liu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4375
add '-pb' command of build bios with exist PreUniversalpayload file.
'-e' command of olny build the Universalpayloadentry file.
Cc: Guo Dong
Cc: Ray Ni
Cc: James Lu
Cc: Gua Guo
Signed-off-by: KasimX Liu
---
Uef
Hi,
after upgrading to edk2-stable202211 recently, we got user reports[0]
about QEMU virtual machines with '-cpu host' on AMD Ryzen hosts not
booting correctly anymore. A workaround seems to be assigning more
memory to the VM.
I was able to reproduce the issue locally (with QEMU 7.2 and an Ubuntu
Well, in this form, it complicates our workflow and adds no value. NACK from
Pedro and me till there at least is CI.
Best regards,
Marvin
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101283): https://edk2.groups.io/g/devel/message/101
Is this still a requirement since Laszlo's departure from the project?
I seem to recall it was him who made it a sticking point of moving to a
GitHub PR workflow originally with the requirement to have emails of
everything.
--
Rebecca Cran
On 3/15/23 4:34 PM, Michael D Kinney wrote:
Hi
Tan:
I rebase this PR https://github.com/tianocore/edk2/pull/4127 again. It will be
merged now.
Thanks
Liming
发件人: devel@edk2.groups.io 代表 Sheng Lean Tan
发送时间: 2023年3月16日 0:41
收件人: devel@edk2.groups.io; Ni, Ray
抄送: gaoliming
主题: Re: [edk2-devel] 回复: [edk2-devel] [PATCH 1/3] MdeModulePk
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Abdul Lateef Attar
> Sent: Wednesday, March 15, 2023 3:11 PM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) ; Ard
> Biesheuvel ; Leif Lindholm
> ; Chang, Abner
> Subject: [PATCH
[AMD Official Use Only - General]
Hi Abdul, one comment below,
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Abdul
> Lateef Attar via groups.io
> Sent: Wednesday, March 15, 2023 3:11 PM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) ; Ard
> Biesheuvel
Reviewed-by: Abner Chang < abner.ch...@amd.com >
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101288): https://edk2.groups.io/g/devel/message/101288
Mute This Topic: https://groups.io/mt/97622709/21656
Group Owner: devel+ow...@edk2.grou
[AMD Official Use Only - General]
Please add Michael Kinney in CC.
Thanks
Abner
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Abdul
> Lateef Attar via groups.io
> Sent: Wednesday, March 15, 2023 3:11 PM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef)
On Thu, Feb 09, 2023 at 08:45:07AM -0700, Rebecca Cran wrote:
> __FUNCTION__ is a pre-standard extension that gcc and Visual C++ among
> others support, while __func__ was standardized in C99.
>
> Since it's more standard, replace __FUNCTION__ with __func__ throughout
> MdePkg.
>
> Signed-off-by:
Signed-off-by: Yi Li
---
CryptoPkg/Library/OpensslLib/OpensslLib.inf | 2 +-
CryptoPkg/Library/OpensslLib/OpensslStub/uefiprov.c | 8 ++--
2 files changed, 3 insertions(+), 7 deletions(-)
diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf
b/CryptoPkg/Library/OpensslLib/Openssl
Signed-off-by: Yi Li
---
CryptoPkg/Library/OpensslLib/OpensslLib.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/CryptoPkg/Library/OpensslLib/OpensslLib.inf
b/CryptoPkg/Library/OpensslLib/OpensslLib.inf
index 47a045ef66..8641cd2521 100644
--- a/CryptoPkg/Library/OpensslLi
Please check the patch series if interested.
PR: https://github.com/tianocore/edk2-staging/pull/359
Latest size data:
Binaries:
CryptoDxeFull -> 1.7%17KB (New)
CryptoDxe 14% -> 10.10% 82KB
CryptoSmm
Signed-off-by: Yi Li
---
.../Library/BaseCryptLib/RsaPkcs7Tests.c | 145 +++---
1 file changed, 120 insertions(+), 25 deletions(-)
diff --git a/CryptoPkg/Test/UnitTest/Library/BaseCryptLib/RsaPkcs7Tests.c
b/CryptoPkg/Test/UnitTest/Library/BaseCryptLib/RsaPkcs7Tests.c
index 8b46
Signed-off-by: Yi Li
---
CryptoPkg/Readme-OpenSSL3.0.md | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/CryptoPkg/Readme-OpenSSL3.0.md b/CryptoPkg/Readme-OpenSSL3.0.md
index 3d4afa8ac1..85ed37b61d 100644
--- a/CryptoPkg/Readme-OpenSSL3.0.md
+++ b/CryptoPkg/Readme-OpenSSL
Signed-off-by: Yi Li
---
.../Library/OpensslLib/OpensslLibFull.inf | 171 +-
1 file changed, 90 insertions(+), 81 deletions(-)
diff --git a/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf
b/CryptoPkg/Library/OpensslLib/OpensslLibFull.inf
index 35d3d9bda9..8cea86e6f0 100644
-
Signed-off-by: Yi Li
---
CryptoPkg/Readme-OpenSSL3.0.md | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/CryptoPkg/Readme-OpenSSL3.0.md b/CryptoPkg/Readme-OpenSSL3.0.md
index 8a0fc6afb0..3d4afa8ac1 100644
--- a/CryptoPkg/Readme-OpenSSL3.0.md
+++ b/CryptoPkg/
Hi folks,
Can I get a review for the changes to MdePkg.dsc to include the new libs on
RISC-V? That's the minor thing preventing this patch set from being merged 😊.
A
-Original Message-
From: Warkentin, Andrei
Sent: Friday, March 10, 2023 11:05 AM
To: devel@edk2.groups.io
Cc: Warkentin
What is the definition of "PrePI"? That is not a prefix I have seen used
before.
Mike
> -Original Message-
> From: Warkentin, Andrei
> Sent: Thursday, March 16, 2023 9:53 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Liu, Zhiguang
> Subject: RE: [PATCH v5 2/
PrePi refers to a SEC-like stage in a Tiano implementation that skips the PEI
stage. Reasons for skipping PEI usually center around memory initialization
being done at an earlier stage of firmware initialization - for example, prior
or part of TF-A firmware on AArch64 or prior or part of SBI imp
Adds AMD/BoardPkg to support MinPlatformPkg framework.
Adds AMD/PlatformPkg, which provide supporting modules and libraries for AMD
based platform.
PR: https://github.com/tianocore/edk2-platforms/pull/69
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Abner Chang
Cc: Michael D Kinney
Abdul Lateef
Adds initial DEC and DSC file for BoardPkg and PlatformPkg packages,
which supports AMD processor family based boards and platforms.
Signed-off-by: Abdul Lateef Attar
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Abner Chang
Cc: Michael D Kinney
Reviewed-by: Abner Chang
---
Platform/AMD/BoardPkg
Adds PCI hotplug init protocol implementation.
Signed-off-by: Abdul Lateef Attar
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Abner Chang
---
Platform/AMD/PlatformPkg/PlatformPkg.dec | 16 +
Platform/AMD/PlatformPkg/PlatformPkg.dsc | 23 ++
.../PlatformPkg/PciHotPlug/PciHotPlugInit.in
Adds SetCacheMtrrLib library for AMD processor based boards.
This library sets MTRR value or various memory ranges.
Signed-off-by: Abdul Lateef Attar
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Abner Chang
---
Platform/AMD/BoardPkg/BoardPkg.dsc| 10 ++
.../SetCacheMtrrLib/SetCacheMt
From: Abdul Lateef Attar
Adds maintainers for AMD/BoardPkg and AMD/PlatformPkg.
Signed-off-by: Abdul Lateef Attar
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Abner Chang
---
Maintainers.txt | 6 ++
1 file changed, 6 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index 747191
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4377
Fix below warnings generated by NASM X64 build:
/X64/FspHelper.iii:26: warning: signed dword value exceeds bounds
/X64/FspHelper.iii:35: warning: signed dword value exceeds bounds
/X64/FspApiEntryT.iii:320: warning: dword data exceeds bounds
Adds initial DEC and DSC file for BoardPkg and PlatformPkg packages,
which supports AMD processor family based boards and platforms.
Signed-off-by: Abdul Lateef Attar
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Abner Chang
Cc: Michael D Kinney
Reviewed-by: Abner Chang
---
Platform/AMD/BoardPkg
Adds PCI hotplug init protocol implementation.
Signed-off-by: Abdul Lateef Attar
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Abner Chang
Cc: Michael D Kinney
---
Platform/AMD/PlatformPkg/PlatformPkg.dec | 16 +
Platform/AMD/PlatformPkg/PlatformPkg.dsc | 23 ++
.../PlatformPkg/PciHot
Resending with correct email
Adds AMD/BoardPkg to support MinPlatformPkg framework.
Adds AMD/PlatformPkg, which provide supporting modules and libraries for AMD
based platform.
PR: https://github.com/tianocore/edk2-platforms/pull/69
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Abner Chang
Cc: Mi
Adds SetCacheMtrrLib library for AMD processor based boards.
This library sets MTRR value or various memory ranges.
Signed-off-by: Abdul Lateef Attar
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Abner Chang
Cc: Michael D Kinney
---
Platform/AMD/BoardPkg/BoardPkg.dsc| 10 ++
.../SetC
From: Abdul Lateef Attar
Adds maintainers for AMD/BoardPkg and AMD/PlatformPkg.
Signed-off-by: Abdul Lateef Attar
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Abner Chang
Cc: Michael D Kinney
---
Maintainers.txt | 6 ++
1 file changed, 6 insertions(+)
diff --git a/Maintainers.txt b/Mainta
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Abdul Lateef Attar
> Sent: Friday, March 17, 2023 2:50 PM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) ; Ard
> Biesheuvel ; Leif Lindholm
> ; Chang, Abner ;
> Michael D Kinney
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Abdul Lateef Attar
> Sent: Friday, March 17, 2023 2:50 PM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) ; Ard
> Biesheuvel ; Leif Lindholm
> ; Chang, Abner ;
> Michael D Kinney
[AMD Official Use Only - General]
Acked-by: Abner Chang
> -Original Message-
> From: Abdul Lateef Attar
> Sent: Friday, March 17, 2023 2:50 PM
> To: devel@edk2.groups.io
> Cc: Attar, AbdulLateef (Abdul Lateef) ; Attar,
> AbdulLateef (Abdul Lateef) ; Ard Biesheuvel
> ; Leif Lindholm ;
>
[AMD Official Use Only - General]
Hi Abdul,
I had gave reviewed-by to all patches. Let's wait for the reviewed-by given by
maintainers for the updates of Maintainers.txt.
Thanks
Abner
> -Original Message-
> From: Abdul Lateef Attar
> Sent: Friday, March 17, 2023 2:50 PM
> To: devel@edk2
54 matches
Mail list logo
