Adds initial DEC and DSC file for BoardPkg and PlatformPkg packages,
which supports AMD processor family based boards and platforms.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Abner Chang
Signed-off-by: Abdul Lateef Attar
---
Platform/AMD/BoardPkg/BoardPkg.dec | 18 ++
Pla
Adds PCI hotplug init protocol implementation.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Abner Chang
---
Platform/AMD/PlatformPkg/PlatformPkg.dec | 16 +
Platform/AMD/PlatformPkg/PlatformPkg.dsc | 23 ++
.../PlatformPkg/PciHotPlug/PciHotPlugInit.inf | 41 +++
.../PlatformPkg/PciHot
From: Abdul Lateef Attar
Adds maintainers for AMD/BoardPkg and AMD/PlatformPkg.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Abner Chang
---
Maintainers.txt | 6 ++
1 file changed, 6 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index 747191366070..bb8ab643e090 100644
--- a/M
Adds AMD/BoardPkg to support MinPlatformPkg framework.
Adds AMD/PlatformPkg, which provide supporting modules
and libraries for AMD based platform.
PR: https://github.com/tianocore/edk2-platforms/pull/68
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Abner Chang https://edk2.groups.io/g/devel/message
Adds SetCacheMtrrLib library for AMD processor based boards.
This library sets MTRR value or various memory ranges.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Abner Chang
---
Platform/AMD/BoardPkg/BoardPkg.dsc| 10 ++
.../SetCacheMtrrLib/SetCacheMtrrLib.inf | 37 +
.../Li
Python/Python3.6.8: migration of edk2module from chipsec repo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4161
This patch merges the enhancements done by chipsec
tool to edk2 module into edk2-libc repo.
The chipsec enhancements can be used for various
other Python based tools to access pl
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4161
This patch merges the enhancements done by chipsec
tool to edk2 module into edk2-libc repo.
The chipsec enhancements can be used for various
other Python based tools to access platform registers.
These enhancements providing a set of APIs to
Hi Ray,Again - any update on this. Thanks.On 13. Mar 2023, at 12:49, Lean Sheng Tan wrote:Hi Ray,What is your thought on this?Best Regards,Lean Sheng Tan9elements GmbH, Kortumstraße 19-21, 44787 Bochum, GermanyEmail: sheng@9elements.comPhone: +49 234 68 94 188Mobile: +49 176 76 113842Register
Hi Gerd,
I got a page-fault in CpuIo2Dxe.dll when using edk2-stable202211 ovmf with
qemu-kvm:
X64 Exception Type - 0E(#PF - Page-Fault) CPU Apic ID -
ExceptionData - 000B I:0 R:1 U:0 W:1 P:1 PK:0 SS:0 SGX:0
RIP - 7F2CB5E8, CS - 0038, RFLAGS
Add support for building RiscVVirtQemu platform in CI.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Signed-off-by: Sunil V L
---
.../.azurepipelines/Ubuntu-GCC5.yml | 9 +
OvmfPkg/PlatformCI/QemuBuild.py | 37 +++
2 files
What’s the meaning of “have both options”?
If you want to support two cases, put the logic in your platform specific Logo
driver.
This Logo driver is just for reference.
From: devel@edk2.groups.io On Behalf Of Sean Rhodes
Sent: Friday, March 10, 2023 9:43 PM
To: Ni, Ray
Cc: devel@edk2.groups.io
On Wed, Mar 15, 2023 at 02:41:19PM +0530, Sunil V L wrote:
> Add support for building RiscVVirtQemu platform in CI.
>
> Cc: Ard Biesheuvel
> Cc: Jiewen Yao
> Cc: Jordan Justen
> Cc: Gerd Hoffmann
> Signed-off-by: Sunil V L
Acked-by: Gerd Hoffmann
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links:
Hi Ray,
The Address could be not 4k align, "&
IA32_MAP_ATTRIBUTE_PAGE_TABLE_BASE_ADDRESS_MASK" is to clear the low 12 bit to
avoid impact the attribute.
I think it is needed
Thanks
Zhiguang
> -Original Message-
> From: Ni, Ray
> Sent: Wednesday, March 15, 2023 2:43 PM
> To: Tan, Dun ;
OK. Then Reviewed-by: Ray Ni
> -Original Message-
> From: Liu, Zhiguang
> Sent: Wednesday, March 15, 2023 5:26 PM
> To: Ni, Ray ; Tan, Dun ;
> devel@edk2.groups.io
> Cc: Dong, Eric ; Kumar, Rahul R
>
> Subject: RE: [Patch V2 14/14] UefiCpuPkg: Modify UnitTest code since tested
> API is
Hi,
> Bug 4373 - Got Page-Fault in CpuIo2Dxe.dll when using edk2-stable202211 ovmf
> with qemi-kvm
> https://bugzilla.tianocore.org/show_bug.cgi?id=4373
>
> Do you have any idea?
Replied in bugzilla.
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent
Thanks for the comments. Will change the code and add the comments in next
version patch.
Thanks,
Dun
-Original Message-
From: Ni, Ray
Sent: Wednesday, March 15, 2023 2:02 PM
To: Tan, Dun ; devel@edk2.groups.io
Cc: Dong, Eric ; Kumar, Rahul R ;
Gerd Hoffmann
Subject: RE: [Patch V2 09/
Thanks for the comments. I'll split this patch and remove the unneeded 'if'
condition check.
Thanks,
Dun
-Original Message-
From: Ni, Ray
Sent: Wednesday, March 15, 2023 2:09 PM
To: Tan, Dun ; devel@edk2.groups.io
Cc: Dong, Eric ; Kumar, Rahul R ;
Gerd Hoffmann ; Liu, Zhiguang
Subject
I'll modify the comments and add a new patch to initialize MapMask to 0.
Thanks for the comment.
Thanks,
Dun
-Original Message-
From: Ni, Ray
Sent: Wednesday, March 15, 2023 2:36 PM
To: Tan, Dun ; devel@edk2.groups.io
Cc: Liu, Zhiguang ; Dong, Eric ;
Kumar, Rahul R
Subject: RE: [Patch
Thanks Ray for the comments. Will create a new patch to split the
RandomBoolean() and simplify the code loop in random test
Thanks,
Dun
-Original Message-
From: Ni, Ray
Sent: Wednesday, March 15, 2023 1:49 PM
To: Tan, Dun ; devel@edk2.groups.io
Cc: Dong, Eric ; Kumar, Rahul R ;
Gerd Ho
I'll add more comments and modify the code to set 4 PDPTE entries. Also will
add unit test code check the MustBeZero fields for PAE paging.
Thanks for the comments.
Thanks,
Dun
-Original Message-
From: Ni, Ray
Sent: Wednesday, March 15, 2023 2:24 PM
To: Tan, Dun ; devel@edk2.groups.io
Thanks for the comments. Will do the code change in next version patch set.
Thanks,
Dun
-Original Message-
From: Ni, Ray
Sent: Wednesday, March 15, 2023 1:34 PM
To: Tan, Dun ; devel@edk2.groups.io
Cc: Dong, Eric ; Kumar, Rahul R ;
Gerd Hoffmann
Subject: RE: [Patch V2 05/14] UefiCpuPkg/
Hi,
> Rework the BaseTools Makefiles removing the 'BUILD_' prefix (BUILD_CC
> and BUILD_CXX) and using the standard name 'LDFLAGS' instead of
> 'LFLAGS'. This allows clang to be used by running
> 'make -C BaseTools CC=clang CXX=clang++'.
Hmm, not sure this is a good idea. I suspect there was s
On Thu, Feb 16, 2023 at 08:51:00PM -0700, Rebecca Cran wrote:
> In https://bugzilla.tianocore.org/show_bug.cgi?id=2842 clang support was
> added by having users specify "make CXX=llvm" when building BaseTools.
>
> Improve the detection of when a user wants to use the clang toolchain:
> instead of
On Thu, Feb 16, 2023 at 08:51:01PM -0700, Rebecca Cran wrote:
> clang 17 defaults to C++17, where the 'register' keyword is deprecated
> and the warning changed to an error. To avoid build errors, compile
> against C++14 by specifying '-std=c++14' in CXXFLAGS.
Acked-by: Gerd Hoffmann
-=-=-=-=-
Ray, it's merged to edk2 repo.
-Original Message-
From: Ni, Ray
Sent: Wednesday, March 15, 2023 9:12 AM
To: Palomino Sosa, Guillermo A ; Kinney,
Michael D ; Feng, Bob C ;
Gao, Liming ; devel@edk2.groups.io
Cc: Chen, Christine ; Oram, Isaac W
; Sean Brogan ;
a...@kernel.org
Subject: R
Looking at adding support for Risc-V for UPL. In the process realised
there are several initialisation sequences which need not be part of
common UPL entry flow. The flow should be agnostic to both BL and Arch
with required hooks provided along the boot path. This patch set
addresses 2 such instanc
Looking at adding support for Risc-V for UPL. In the process realised
there are several initialisation sequences which need not be part of
common UPL entry flow. The flow should be agnostic to both BL and Arch
with required hooks provided along the boot path. This patch set
addresses 2 such instanc
According to UPL spec BL should initialize FP init meaning UPL
does not need to initialize it. Besides this is arch specific init
and needs to be moved out of UPL common flow. In order to not break
current BL implementations, for now just moving the init to later
point of time but for both x32 and
8259 is very arch specific programming. It needs to be moved out to
the respective arch flow. Added in both x64 and x32 paths
Test: Able to boot UEFI shell with Coreboot Tianocore payload on
x86 qemu
Cc: Guo Dong
Cc: Ray Ni
Cc: Sean Rhodes
Cc: James Lu
Cc: Gua Guo
Signed-off-by: Dhaval Shar
Adds MM_STANDALONE_CORE and MM_STANDALONE FFS file
construction rules.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by: Isaac Oram
---
.../MinPlatformPkg/Include/Fdf/RuleInclude.fdf| 15 +++
1 file changed, 15 insertions(+)
diff --git a/Platform/
HI Ray,
I think it is a reasonable request to have the EDK II logo driver support
multiple standards for the logo location. Especially if they are documented in
public specifications.
The additional conditions of supporting a logo larger than the display
resolution also looks like a good corn
Hi Liming/ Ray,
Could you help to merge?
Thanks.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101235): https://edk2.groups.io/g/devel/message/101235
Mute This Topic: https://groups.io/mt/97487045/21656
Group Owner: devel+ow...@edk2.grou
Hi all,
Can someone please help to review this?
Thanks.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101236): https://edk2.groups.io/g/devel/message/101236
Mute This Topic: https://groups.io/mt/97421035/21656
Group Owner: devel+ow...@ed
I think the right reviewer was not added.
Added them.
On Wed, 15 Mar 2023 at 17:46, Sheng Lean Tan via groups.io wrote:
> Hi all,
> Can someone please help to review this?
> Thanks.
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (
adding the right reviewers.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101238): https://edk2.groups.io/g/devel/message/101238
Mute This Topic: https://groups.io/mt/97421037/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: ht
Added Zhichao.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101239): https://edk2.groups.io/g/devel/message/101239
Mute This Topic: https://groups.io/mt/97421038/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.gr
On Tue, Mar 14, 2023 at 19:29:39 +0100, Ard Biesheuvel wrote:
> On Tue, 14 Mar 2023 at 19:13, Leif Lindholm wrote:
> >
> > On Mon, Mar 13, 2023 at 18:16:44 +0100, Ard Biesheuvel wrote:
> > > Currently, the ARM MMU page table logic will break down any block entry
> > > that overlaps with the region
On Mon, Mar 13, 2023 at 18:16:45 +0100, Ard Biesheuvel wrote:
> In preparation for introducing an implementation of the EFI memory
> attributes protocol that is shared between ARM and AArch64, unify the
> existing code that converts a page table descriptor into a
> EFI_MEMORY_xxx bitfield, so it ca
On Mon, Mar 13, 2023 at 18:16:47 +0100, Ard Biesheuvel wrote:
> Expose the protocol introduced in v2.10 that permits the caller to
> manage mapping permissions in the page tables.
Nitpicks and a question:
> Signed-off-by: Ard Biesheuvel
> ---
> ArmPkg/Drivers/CpuDxe/CpuDxe.c | 2 +
>
This is a proposal to enable the GitHub PR feature on the edk2-platforms
repository and enable branch protections that would require maintainers
to set a 'push' label to merge change into edk2-platforms. The same
process that is already in place on the edk2 repository.
The initial change would no
(Rebased series and resending due to merge conflict with previous
submission.)
Here are a number of fixes related to OVMF handling of the SEV-SNP
Confidential Computing blob and CPUID table.
Patch #1 is a fix for recently-reported issue that can cause
significant problems with some SEV-SNP guest
The SEV-SNP Confidential Computing blob contains metadata that should
remain accessible for the life of the guest. Allocate it as
EfiACPIReclaimMemory to ensure the memory isn't overwritten by the guest
operating system later.
Reported-by: Dov Murik
Suggested-by: Dov Murik
Reviewed-by: Dov Murik
The Confidential Computing blob defined here is intended to match the
definition defined by linux guest kernel. Previously, both definitions
relied on natural alignment, but that relies on both OVMF and kernel
being compiled as 64-bit. While there aren't currently any plans to
enable SNP support fo
CPUID leaf 0xD sub-leafs 0x0 and 0x1 contain cumulative sizes for the
enabled XSave areas. Those sizes are calculated by tallying up all the
other sub-leafs that contain per-area size information for XSave areas
that are currently enabled in XCr0/XSS. The current check has the logic
inverted. Fix t
Currently OVMF tries to rely on the base size advertised via the CPUID
table entries corresponding to leaf 0xD, sub-leafs 0x0/0x1. This will
generally work for KVM guests, but might not for other SEV-SNP
hypervisor implementations. Make the handling more robust by simply
using the base area size do
Hi,
Why does the title mention X64? From what I can see, PIE is unaffected for X64
(and we really want it to be).
Best regards,
Marvin
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101249): https://edk2.groups.io/g/devel/message/10124
Hi Mike,
Could this be extended to allow for a full PR workflow, if the package
maintainers would prefer so? We would like to utilise this for Ext4Pkg. It
could be considered a trial. :)
Best regards,
Marvin
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
Hi Marvin,
One of the long standing requirements for tianocore is to have a history of all
patch series and all
code review activity archived in the mailing list.
Adopting the full PR workflow right now for even a portion of edk2-platforms
would have a gap in the
history of patch series and rev
On Wed, 15 Mar 2023 at 23:16, Marvin Häuser wrote:
>
> Hi,
>
> Why does the title mention X64? From what I can see, PIE is unaffected for
> X64 (and we really want it to be).
>
Why?
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101252
> On 15. Mar 2023, at 23:51, Ard Biesheuvel wrote:
>
> On Wed, 15 Mar 2023 at 23:16, Marvin Häuser wrote:
>>
>> Hi,
>>
>> Why does the title mention X64? From what I can see, PIE is unaffected for
>> X64 (and we really want it to be).
>>
>
> Why?
Why what? By “PIE is unaffected for X64”
On Wed, 15 Mar 2023 at 23:57, Marvin Häuser wrote:
>
>
> > On 15. Mar 2023, at 23:51, Ard Biesheuvel wrote:
> >
> > On Wed, 15 Mar 2023 at 23:16, Marvin Häuser wrote:
> >>
> >> Hi,
> >>
> >> Why does the title mention X64? From what I can see, PIE is unaffected for
> >> X64 (and we really want
Did you make sure the change would really fix the issue?
Just add the DEPX would only make sure the protocol is installed but not
installed to the image handle. The return value would be still error code.
And the issue is still there.
The HII image related protocol should not be the MUST have for
Ramkumar Krishnamoorthi would like to recall the message,
"[edk2-platfoms][PATCH V1] WhitleySiliconPkg : Resolve boot errors when
synching to edk2-stable202302".
-The information contained in this message may be confidential and proprietary
to American Megatrends (AMI). This communication is int
Move REDFISH_FEATURE_ARRAY_TYPE_CONFIG_LANG and
REDFISH_FEATURE_ARRAY_TYPE_CONFIG_LANG_LIST from
RedfishFeatureUtilityLib.h to
EdkIIRedfishInterchangeData.h. Also, remove
unnecessary jansson.h in RedfishDataTypeDef.h.
Signed-off-by: Simon Wang
Cc: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytsky
Ramkumar Krishnamoorthi would like to recall the message,
"[edk2-platfoms][PATCH V1] WhitleySiliconPkg : Resolve boot errors when
synching to edk2-stable202302".
-The information contained in this message may be confidential and proprietary
to American Megatrends (AMI). This communication is int
Subject: [edk2-platfoms][PATCH V1] WhitleySiliconPkg : Resolve boot errors when
synching to edk2-stable202302
Fix to resolve the boot error - Rearrange the enum constants
TypeJunctionCity and TypeAowanda in PlatformInfoTypes.h
according to PcdBoardId value.
Cc: Harikrishna Doppalapudi
Cc: Sures
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4364
Currently, the length of type EFI_HOB_TYPE_GUID_EXTENSION is not checked
because it is variable length data. This might give a chance to an buffer
overflow issue.
Fix this by checking the HobLength of EFI_HOB_GUID_TYPE to make sure that
it
Subject: [edk2-platfoms][PATCH V1] WhitleySiliconPkg : Resolve boot errors when
synching to edk2-stable202302
Fix to resolve the boot error - Rearrange the enum constants
TypeJunctionCity and TypeAowanda in PlatformInfoTypes.h
according to PcdBoardId value.
Cc: Harikrishna Doppalapudi
Cc: Sures
58 matches
Mail list logo
