I'll add more comments and modify the code to set 4 PDPTE entries. Also will
add unit test code check the MustBeZero fields for PAE paging.
Thanks for the comments.
Thanks,
Dun
-----Original Message-----
From: Ni, Ray <ray...@intel.com>
Sent: Wednesday, March 15, 2023 2:24 PM
To: Tan, Dun <dun....@intel.com>; devel@edk2.groups.io
Cc: Dong, Eric <eric.d...@intel.com>; Kumar, Rahul R <rahul.r.ku...@intel.com>;
Gerd Hoffmann <kra...@redhat.com>
Subject: RE: [Patch V2 11/14] UefiCpuPkg/CpuPageTableLib: Enable PAE paging
> + if (PagingMode == PagingPae) {
> + //
> + // These fields of PAE paging PDPTE should be 0 according to SDM.
> + //
1. can you update comments to explain such as:
"These fields are treated as ReadWrite, .... by the common map logic. So they
might be set to 1."
> + TopPagingEntry.PdptePae.Bits.MustBeZero = 0;
> + TopPagingEntry.PdptePae.Bits.MustBeZero2 = 0;
2. Above code sets the CR3 value. You should update the 4 PDPTE entries.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101224): https://edk2.groups.io/g/devel/message/101224
Mute This Topic: https://groups.io/mt/97469487/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
