Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process

Is this regression? I remember I tried the S3 on real silicon with the patch change, don't see the issue in normal boot work flow. The only difference what I did is to trigger S3 in the BIOS shell, but it does covered the SmmRestoreCpu test. Now, I'm trying to reproduce the issue on ovmf, and

Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process

On Fri, Mar 10, 2023 at 09:19:04AM +, Wu, Jiaxin wrote: > Is this regression? I remember I tried the S3 on real silicon with the patch > change, don't see the issue in normal boot work flow. The only difference > what I did is to trigger S3 in the BIOS shell, but it does covered the > SmmRes

Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process

I will have a try with the command. For BIOS shell trigger S3, it just needs a simple application to provide the ACPI FACS waking vector, then write the power management control address at offset 4. Another way is that shell MM command can achieve the trigger action, for example like: mm -io

Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process

Gerd, Could you help confirm whether this is regression in OVMF before I set up the enviroment? Thanks, Jiaxin > -Original Message- > From: Wu, Jiaxin > Sent: Friday, March 10, 2023 6:18 PM > To: kra...@redhat.com > Cc: devel@edk2.groups.io; Ni, Ray ; Dong, Eric > ; Zeng, Star ; Laszlo

Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process

On Fri, Mar 10, 2023 at 10:29:30AM +, Wu, Jiaxin wrote: > Gerd, > > Could you help confirm whether this is regression in OVMF before I set up the > enviroment? What exactly? > > > > Run qemu command is: > > > > qemu-system-x86_64 -bios > > > C:\Dev\Code\edk2\Build\Ovmf3264\DEBUG_VS2015x86\F

Re: [edk2-devel] 回复: [edk2-devel] [PATCH 1/3] MdeModulePkg/BmBoot: Skip removable media if it is not present

Thanks Liming and Ray for looking into this. It was really frustrating that no one bothers to reply after keep pinging for months. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100996): https://edk2.groups.io/g/devel/message/100996 Mute

Re: [edk2-devel] [RFC] [staging/CryptoLibrary] Openssl1.1 replacement proposal

Hello We have created initial POC version CryptoPkg upgrade. OpenSSL 3.0 POC: https://github.com/tianocore/edk2-staging/blob/OpenSSL11_EOL/CryptoPkg/Readme-OpenSSL3.0.md The size is reduced a lots. But it still exceeds some platforms. MbedTls 3.0 POC: https://github.com/tianocore/edk2-staging/b

[edk2-devel] [PATCH 1/2] UefiCpuPkg/PiSmmCpuDxeSmm: drop support for obsolete processors

It's highly unlikely the code ever runs on processors which are almost 30 years old. Drop the code handling them. Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=4345 Signed-off-by: Gerd Hoffmann --- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 20 +--- 1 file changed,

[edk2-devel] [PATCH 0/2] UefiCpuPkg/PiSmmCpuDxeSmm: drop support for obsolete processors, fix error handling

Gerd Hoffmann (2): UefiCpuPkg/PiSmmCpuDxeSmm: drop support for obsolete processors UefiCpuPkg/PiSmmCpuDxeSmm: fix error handling UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 22 +- 1 file changed, 9 insertions(+), 13 deletions(-) -- 2.39.2 -=-=-=-=-=-=-=-=-=-=-=- G

[edk2-devel] [PATCH 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: fix error handling

ASSERT() is not proper handling of allocation failures, it gets compiled out on RELEASE builds. Print a message and enter dead loop instead. Signed-off-by: Gerd Hoffmann --- UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/UefiCpuPkg/PiSmmCpuD

Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of the Logo

Hi Ray > You can return a carefully-calculated X/Y value to make the logo at MS preferred position. As we discussed before, we need to have both options. Thanks Sean On Wed, 8 Mar 2023 at 09:01, Ni, Ray wrote: > Maybe I didn’t explain my idea clearly. > > That is: > >

Re: [edk2-devel] [RFC] [staging/CryptoLibrary] Openssl1.1 replacement proposal

On Fri, Mar 10, 2023 at 12:28:54PM +, Yao, Jiewen wrote: > Hello > We have created initial POC version CryptoPkg upgrade. > > OpenSSL 3.0 POC: > https://github.com/tianocore/edk2-staging/blob/OpenSSL11_EOL/CryptoPkg/Readme-OpenSSL3.0.md > The size is reduced a lots. But it still exceeds some

Re: [edk2-devel] [RFC] [staging/CryptoLibrary] Openssl1.1 replacement proposal

Hi Gerd I have asked in my previous email in Feb 11, 20 - https://edk2.groups.io/g/devel/message/100040 > Hi Gerd > If you don't mind, please submit your latest openssl-3.0 patch to the staging > for broader evaluation and improvement. Unfortunately, I do not see any response or action. The stag

Re: [edk2-devel] [PATCH v2 2/4] DynamicTablesPkg: Add SMBIOS table dispatcher

Hi Sami Response inline.[GM] Best Regards Girish On 3/9/2023 3:41 AM, Sami Mujawar wrote: External email: Use caution opening links or attachments Hi Girish, Thank you for your feedback. Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 08/03/2023, 17:41, "Girish M

Re: [edk2-devel] [PATCH v2 2/4] DynamicTablesPkg: Add SMBIOS table dispatcher

Hi Girish, On 10/03/2023 04:23 pm, Girish Mahadevan wrote: Hi Sami Response inline.[GM] Best Regards Girish On 3/9/2023 3:41 AM, Sami Mujawar wrote: External email: Use caution opening links or attachments Hi Girish, Thank you for your feedback. Please find my response inline marked [SAM

Re: [edk2-devel] [PATCH v1 0/6] Add Raspberry Pi Support to EmulatorPkg

Hello Nate, On Mon, 6 Mar 2023 at 01:22, Nate DeSimone wrote: > > This patch series is the result of a fun weekend project that I > did in my spare time. It implements the changes nessesary for > EmulatorPkg to run on the Raspberry Pi. It should also work on > other 32-bit ARM systems, but I only

[edk2-devel] [PATCH 0/2] SEV-SNP guest support fixes

This patch series provides some fixes around AP creation: - An erratum on AMD hardware requires that a VMSA not be aligned on a 2MB boundary. To work around this issue, allocate 2 pages of memory and using the page that is not 2MB aligned and freeing the other. - When parking APs after exitin

[edk2-devel] [PATCH 1/2] UefiCpuPkg/MpInitLib: Ensure SEV-SNP VMSA allocations are not 2MB aligned

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4353 Due to an erratum, an SEV-SNP VMSA cannot be 2MB aligned. To work around this issue, allocate two pages instead of one. Because of the way that page allocation is implemented, always try to use the second page. If the second page is not 2MB a

[edk2-devel] [PATCH 2/2] UefiCpuPkg/MpInitLib: Reuse VMSA allocation to avoid unreserved allocation

https://bugzilla.tianocore.org/show_bug.cgi?id=4353 When parking the APs on exiting from UEFI, a new page allocation is made. This allocation, however, does not end up being marked reserved in the memory map supplied to the OS. To avoid this, re-use the VMSA by clearing the VMSA RMP flag, updating

[edk2-devel] [PATCH v5 0/3] RISC-V SBI-backed SerialLib

Hello, Here are three patches that provide a SerialLib backed by SBI console. Both legacy and DBCN mechanisms are supported in various execution environments and have been tested with UART and HTIF consoles. MdePkg reviewers: please review MdePkg.dsc changes. This is also available at https://

[edk2-devel] [PATCH v5 1/3] MdePkg: BaseRiscVSbiLib: make more useful to consumers

Add a few more definitions and make SbiCall and TranslateError usable (not static) by library users. Cc: Daniel Schaefer Acked-by: Gerd Hoffmann Reviewed-by: Sunil V L Signed-off-by: Andrei Warkentin --- MdePkg/Include/Library/BaseRiscVSbiLib.h | 40 ++-- MdePkg/Librar

[edk2-devel] [PATCH v5 3/3] OvmfPkg: RiscVVirt: Add missing SerialPortInitialize to Sec

If the SerialPortLib had any initialization needed, this would be skipped in the RiscVVirt Sec. Follow the example seen elsewhere (ArmVirtPkg PrePi). Seen with BaseSerialPortLibRiscVSbi not using DBCN in Sec, yet using DBCN elsewhere. Cc: Daniel Schaefer Reviewed-by: Sunil V L Signed-off-by: An

[edk2-devel] [PATCH v5 2/3] MdePkg: add SBI-based SerialPortLib for RISC-V

These are implementations of SerialPortLib using SBI console services. - SecPeiRiscVSerialPortLibSbi is appropriate for SEC/PEI (XIP) environments - PrePiDxeRiscVSerialPortLibSbi is appropriate for PrePI/DXE environments Tested with: - Qemu RiscVVirt (non-DBCN case, backed by UART) - TinyEMU + Ris

Re: [edk2-devel] [PATCH 0/2] SEV-SNP guest support fixes

On 3/10/23 11:03, Tom Lendacky wrote: This patch series provides some fixes around AP creation: - An erratum on AMD hardware requires that a VMSA not be aligned on a 2MB boundary. To work around this issue, allocate 2 pages of memory and using the page that is not 2MB aligned and freeing t

Re: [edk2-devel] [PATCH 1/1] DynamicTablesPkg/SsdtCpuTopology: Allow multi-packages topologies

Reviewed-by: Jeff Brasen > -Original Message- > From: pierre.gond...@arm.com > Sent: Thursday, March 9, 2023 8:33 AM > To: devel@edk2.groups.io > Cc: Sami Mujawar ; Alexei Fedorov > ; Jeff Brasen > Subject: [PATCH 1/1] DynamicTablesPkg/SsdtCpuTopology: Allow multi- > packages topologies

Re: 回复: [edk2-devel] [PATCH 1/1] MdePkg: Add DDR5 SPD defs to IndustryStandard per JESD400-5A.01

I decided on a different name because DDR5 is quite specific about not being mainly about SDRAM: for example NVDIMM appears to have an equal place in the SPD definition. -- Rebecca Cran On 3/9/23 8:08 PM, gaoliming wrote: Rebecca: Why new file name is not SdramSpdDdr5.h? Thanks Liming

Re: [edk2-devel] 回复: [PATCH 0/3] BaseTools: Fix doc block location and formatting; run uncrustify

I'm not aware of a tool: I converted the comments manually. -- Rebecca Cran On 3/9/23 7:57 PM, gaoliming wrote: Rebecca: I think these changes are good. Reviewed-by: Liming Gao Besides, which tool is used to convert function comments to Doxygen format? Thanks Liming -邮件原件- 发

Re: 回复: [edk2-devel] [PATCH 1/2] MdePkg: Update Base.h to be compliant with C11

Yes. Now that the MdePkg change has been reviewed and will be committed, I'll proceed with submitting patches for the other packages. -- Rebecca Cran On 3/9/23 7:45 PM, gaoliming wrote: Rebecca: This patch pass code review. It can be merged now. The second change to using __func__ is on

Re: [edk2-devel] [PATCH v2] CryptoPkg/OpensslLib: Upgrade OpenSSL to 1.1.1t

Thank you all. -- Miki Demeter (she/her/Miki) Security Researcher / FW Developer FST Intel Corporation Co-Chair, Network of Intel African-Ancestry(NIA) - Oregon NIA-Oregon Portland Women in Tech Best Speaker miki.deme...@intel.com

[edk2-devel] [PATCH v4 02/12] BaseTools/PatchCheck.py: Add PCCTS to tab exemption list

From: Michael Kubacki Purdue Compiler Construction Tool Set (PCCTS) source code was copied/ pasted into BaseTools/Source/C/VfrCompile/Pccts/. The code contains tab characters instead of spaces. PatchCheck.py gives an error on modifications to files that contain tabs. This change adds that dire

[edk2-devel] [PATCH v4 03/12] BaseTools/VfrCompile: Fix potential buffer overwrites

From: Michael Kubacki While more portable methods exist to handle these cases, this change does not attempt to do more than fix the immediate problem and follow the conventions already established in this code. `snprintf()` is introduced as the minimum improvement apart from making the buffers l

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialIpmiLib: IPMI implementation

Hi Nickle, See my comments below the text. Thank you, Igor -Original Message- From: Nickle Wang Sent: Wednesday, March 8, 2023 2:21 AM To: devel@edk2.groups.io Cc: Abner Chang ; Igor Kulchytskyy ; Nick Ramirez Subject: [EXTERNAL] [PATCH] RedfishPkg/RedfishPlatformCredentialIpmiLib: IPMI

Re: [edk2-devel] [PATCH v4 07/12] NetworkPkg: Fix conditionally uninitialized variables

Reviewed-by: Michael D Kinney > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Friday, March 10, 2023 10:43 AM > To: devel@edk2.groups.io > Cc: Erich McMillan ; Wu, Jiaxin > ; Maciej Rabeda > ; Kinney, Michael D > ; Michael Kubacki > ; Siyuan Fu > Subject: [PATCH v4

Re: [edk2-devel] [PATCH v4 10/12] UefiCpuPkg: Fix conditionally uninitialized variables

> -Original Message- > From: devel@edk2.groups.io On Behalf Of Michael Kubacki > Sent: Friday, March 10, 2023 10:43 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Erich McMillan > ; Kinney, Michael D > ; Michael Kubacki ; > Kumar, Rahul R > ; Ni, Ray > Subject: [edk2-devel] [PATCH v

[edk2-devel] [PATCH v2] MdePkg/BaseCacheMaintenanceLib: RISC-V: Fix instruction cache not been invalidated

When the range instruction cache invalidating not supported, the whole instruction cache should be invalidated instead. Signed-off-by: Tuan Phan --- V2: - Format with uncrustify. MdePkg/Library/BaseCacheMaintenanceLib/RiscVCache.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-)

Re: [edk2-devel] [PATCH 0/7] RISC-V: Add MMU support

Hi Andrei, Here it is: https://github.com/pttuan/edk2/tree/tphan/riscv_mmu On Thu, Mar 9, 2023 at 1:34 PM Warkentin, Andrei wrote: > Hi Tuan, > > > > Could you share a GitHub link to a branch with the patch set? Somehow my > email client is mangling one of your patches where it’s all one giant l