I decided on a different name because DDR5 is quite specific about not
being mainly about SDRAM: for example NVDIMM appears to have an equal
place in the SPD definition.
--
Rebecca Cran
On 3/9/23 8:08 PM, gaoliming wrote:
Rebecca:
Why new file name is not SdramSpdDdr5.h?
Thanks
Liming
-----邮件原件-----
发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Rebecca Cran
发送时间: 2023年2月14日 23:37
收件人: Kinney, Michael D <michael.d.kin...@intel.com>;
devel@edk2.groups.io; Gao, Liming <gaolim...@byosoft.com.cn>
抄送: 'Liming Gao' <liming....@intel.com>; Liu, Zhiguang
<zhiguang....@intel.com>
主题: Re: [edk2-devel] [PATCH 1/1] MdePkg: Add DDR5 SPD defs to
IndustryStandard per JESD400-5A.01
On 2/10/23 11:01, Kinney, Michael D wrote:
We usually do not include basetype includes from .h files in
Protocol/PPI/GUID/IndustryStandard.
This is because we always get base types from AutoGen.h and from C/H files
in modules/libs
That have to include top level include files for their module type. Base.h,
PiPei.h, PiDxe,h, Uefi.h.
Also UINT8 is available from Base.h that does not assume UEFI or PI env.
Thanks. I've sent out a v2 patch with the include line removed.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101016): https://edk2.groups.io/g/devel/message/101016
Mute This Topic: https://groups.io/mt/97512395/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
