[edk2-devel] [PATCH v2 1/4] DynamicTablesPkg: Define a SMBIOS Structure/Table type

SMBIOS Structure Types 0 through 127 (7Fh) are reserved for and defined by the SMBIOS specification. Types 128 through 256 (80h to FFh) are available for system and OEM-specific information. Therefore, define a new type 'SMBIOS_TABLE_TYPE' that represents a SMBIOS structure type and include it in

[edk2-devel] [PATCH v2 0/4] DynamicTablesPkg: Introduce SMBIOS dispatcher

Some SMBIOS tables have dependencies on other SMBIOS tables. These dependencies are established using handles pointing to the dependent SMBIOS tables. This requires the dependent SMBIOS table to be installed before the parent SMBIOS table can be installed. To facilitate dynamic SMBIOS table genera

[edk2-devel] [PATCH v2 2/4] DynamicTablesPkg: Add SMBIOS table dispatcher

Some SMBIOS structure/table fields have dependency on other SMBIOS structures/tables. These dependencies are established using handles pointing to the dependent tables. A SMBIOS table handle can be obtained by either installing a SMBIOS table or by allocating a handle, which requires complex manag

[edk2-devel] [PATCH v2 4/4] DynamicTablesPkg: Add Ordered dispatch support for SMBIOS tables

Some SMBIOS tables do not have a fixed dependency and can depend on any other SMBIOS tables. Therefore, the SMBIOS dispatcher cannot define a fixed sequence for dispatching these tables. A possible solution is to defer the dispatch of such SMBIOS tables towards the end, assuming that the dependent

[edk2-devel] [PATCH v2 3/4] DynamicTablesPkg: Update SMBIOS dispatcher dependency table

Update the SMBIOS table dispatcher dependency table to add the table dependencies for SMBIOS table Type 19, Type 20, Type 27, Type 35 and Type 37. The SMBIOS table Type 35 can have dependency on 6 other SMBIOS tables. Therefore, increase the MAX_SMBIOS_DEPENDENCY to 6, and also update the SMBIOS t

Re: [edk2-devel] [PATCH 2/2] DynamicTablesPkg: Add Smbios Type17 Table generator

Hi Girish, Apologies for the delay in reply. Please find my response marked inline as [SAMI]. Regards, Sami Mujawar On 28/01/2023 12:09 am, Girish Mahadevan wrote: Hi Sami Sorry for the long silence. I've sent you v2 of the patch (only framework not the Type17) which includes a link to a g

Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/BmBoot: Skip removable media if it is not present

Seriously, what is the hold up here? did Sean not following the process? Did he miss anything? it just doesn’t make sense to keep ignoring this patch for half year for no reason. Is there a way to voice up a about this? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to th

Re: [edk2-devel] [PATCH] MdeModulePkg/Logo: Add a PCD to control the position of the Logo

Same here. Seriously, what is the hold up here? did Sean not following the process? Did he miss anything? it just doesn’t make sense to keep ignoring this patch for half year for no reason. Is there a way to voice up a about this? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages

Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/BmBoot: Skip removable media if it is not present

M: Jian J Wang jian.j.w...@intel.com [jwang36] M: Liming Gao gaolim...@byosoft.com.cn [lgao4] Jian and Liming are maintainers of MdeModulePkg. The patch passed my review. Either of them can help to merge the patch. I guess Liming migh

Re: [edk2-devel] [PATCH] MdeModulePkg/Logo: Add a PCD to control the position of the Logo

It also doesn’t give good impression on edk2 if the reviewers continue to ignore review requests after such a long time. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100842): https://edk2.groups.io/g/devel/message/100842 Mute This Topi

Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of the Logo

Maybe I didn’t explain my idea clearly. That is: You can get the screen resolution in the code that produces Logo protocol. You can return a carefully-calculated X/Y value to make the logo at MS preferred position. From: devel@edk2.groups.io On Behalf Of Ni, Ray

Re: [edk2-devel] [PATCH] MdeModulePkg/Logo: Add a PCD to control the position of the Logo

On 8. Mar 2023, at 09:55, Sheng Lean Tan wrote: Same here. Seriously, what is the hold up here? did Sean not following the process? Did he miss anything? it just doesn’t make sense to keep ignoring this patch for half year for no reason. Is there a way to voice up a about this? -=-=-=-=-=-=

[edk2-devel] [PATCH v1 1/1] CI: Use Fedora-37 (gcc12) image for Linux jobs

Switch to the new Fedora-37 CI docker image, and with it to gcc12, for Linux jobs. Signed-off-by: Oliver Steffen --- .azurepipelines/templates/defaults.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.azurepipelines/templates/defaults.yml b/.azurepipelines/templates/defa

[edk2-devel] [PATCH v1 0/1] CI: Use Fedora 37 / GCC 12 for Linux jobs

Switch the CI (Linux) to use GCC 12 providied by a new Fedora 37 based container image. New container image: https://github.com/tianocore/containers/pull/60 Test PR: https://github.com/tianocore/edk2/pull/4108 Oliver Steffen (1): CI: Use Fedora-37 (gcc12) image for Linux jobs .azurepipeline

[edk2-devel] [Patch V2 00/14] Fix issues in CpuPageTableLib

In the V2 patch set 1. Add more commit message about the 'Fix the non-1:1 mapping issue' patch 2. Add patches to enable PAE paing in CpuPageTable Lib and add random test for PAE paging 3. Add patches to add OUTPUT IsModified parameter for PageTableMap() and modify random test for this parameter 4

[edk2-devel] [Patch V2 01/14] UefiCpuPkg/CpuPageTableLib: Remove unneeded 'if' condition

Remove unneeded 'if' condition in CpuPageTableLib code. The deleted code is in the code branch for present non-leaf parent entry. So the 'if' check for (ParentPagingEntry->Pnle.Bits.Present == 0) is always FALSE. Signed-off-by: Dun Tan Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann

[edk2-devel] [Patch V2 02/14] UefiCpuPkg/CpuPageTableLib: Add check for input Length

Add check for input Length in PageTableMap (). Return RETURN_SUCCESS when input Length is 0. Signed-off-by: Dun Tan Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann --- UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c | 4 1 file changed, 4 insertions(+) diff --git a/Uefi

[edk2-devel] [Patch V2 03/14] UefiCpuPkg/CpuPageTableLib: Fix the non-1:1 mapping issue

In previous code logic, when splitting a leaf parent entry to smaller granularity child page table, if the parent entry Attribute&Mask(without PageTableBaseAddress field) is equal to the input attribute&mask(without PageTableBaseAddress field), the split process won't happen. This may lead to failu

[edk2-devel] [Patch V2 04/14] UefiCpuPkg/CpuPageTableLib: Fix issue when splitting leaf entry

When splitting leaf parent entry to smaller granularity, create child page table before modifing parent entry. In previous code logic, when splitting a leaf parent entry, parent entry will point to a null 4k memory before child page table is created in this 4k memory. When the page table to be modi

[edk2-devel] [Patch V2 05/14] UefiCpuPkg/CpuPageTebleLib: Check Mask and Attr in PageTableMap

When creating new page table or mapping not-present range in existing page table, we need to make sure all the non-reserved fields of input Mask are not 0 and Present field of input Attribute is 1. Signed-off-by: Dun Tan Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann --- UefiCpuP

[edk2-devel] [Patch V2 06/14] UefiCpuPkg/CpuPageTableLib: Add manual test to check Mask and Attr

Add manual test case to check input Mask and Attribute. When creating new page table or mapping not-present range in existing page table, all the non-reserved fields of Mask and Present bit of Attribute should not be 0. Signed-off-by: Dun Tan Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd H

[edk2-devel] [Patch V2 07/14] UefiCpuPkg/CpuPageTableLib:Modify RandomTest to check Mask/Attr

Modify RandomTest to check invalid input. When creating new page table or mapping not-present range in existing page table, if any non-reserved field of Mask or Present bit of Attribute in generated random MapEntry are 0, the return status of PageTableMap () should be RETURN_INVALID_PARAMETER. Sig

[edk2-devel] [Patch V2 08/14] UefiCpuPkg/CpuPageTableLib: Enable non-1:1 mapping in random test

Enable non-1:1 mapping in random test. In previous test, non-1:1 test will fail due to the non-1:1 mapping issue in CpuPageTableLib and invalid Input Mask when creating new page table or mapping not-present range. Now these issue have been fixed. Signed-off-by: Dun Tan Cc: Eric Dong Cc: Ray Ni

[edk2-devel] [Patch V2 09/14] UefiCpuPkg/CpuPageTableLib: Add OUTPUT IsModified parameter.

Add OUTPUT IsModified parameter in PageTableMap() to indicate if page table has been modified. With this parameter, caller can know if need to call FlushTlb when the page table is in CR3. Signed-off-by: Dun Tan Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann --- UefiCpuPkg/Include

[edk2-devel] [Patch V2 10/14] UefiCpuPkg/CpuPageTableLib: Modify RandomTest to check IsModified

Modify RandomTest to check if parameter IsModified of PageTableMap() correctlly indicates whether input page table is modified or not. Signed-off-by: Dun Tan Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Zhiguang Liu --- UefiCpuPkg/Library/CpuPageTableLib/UnitTest/RandomTes

[edk2-devel] [Patch V2 12/14] UefiCpuPkg/CpuPageTableLib: Add RandomTest for PAE paging

Add RandomTest for PAE paging. Signed-off-by: Dun Tan Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann --- UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTestHost.c | 2 ++ UefiCpuPkg/Library/CpuPageTableLib/UnitTest/RandomTest.c | 3 +-- UefiCpuP

[edk2-devel] [Patch V2 11/14] UefiCpuPkg/CpuPageTableLib: Enable PAE paging

Remove the limitation check for PagingPae to enable creating or updating PAE page table in CpuPageTableLib. The origin code is naturally adapted for PAE paging. Signed-off-by: Dun Tan Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann --- UefiCpuPkg/Library/CpuPageTableLib/CpuPageTab

[edk2-devel] [Patch V2 13/14] UefiCpuPkg: Fix IA32 build failure in CpuPageTableLib.inf

From: Zhiguang Liu The definition of IA32_MAP_ATTRIBUTE has 64 bits, and one of the bit field PageTableBaseAddress is from bit 12 to bit 52. This means if the compiler treats the 64bits value as two UINT32 value, the field PageTableBaseAddress spans two UINT32 value. That's why when building in N

[edk2-devel] [Patch V2 14/14] UefiCpuPkg: Modify UnitTest code since tested API is changed

From: Zhiguang Liu Last commit changed the CpuPageTableLib API PageTableMap, unit test code should also be modified. Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Signed-off-by: Zhiguang Liu --- UefiCpuPkg/Library/CpuPageTableLib/UnitTest/CpuPageTableLibUnitTestHost.c | 38 ++---

Re: [edk2-devel] [PATCH 2/6] UefiCpuPkg/CpuPageTableLib: Fix the non-1:1 mapping issue

Thanks for the comments Gerd. More detailed commit message has been added in V2 patch set. Thanks, Dun -Original Message- From: devel@edk2.groups.io On Behalf Of Gerd Hoffmann Sent: Monday, March 6, 2023 3:14 PM To: devel@edk2.groups.io; Tan, Dun Cc: Dong, Eric ; Ni, Ray ; Kumar, Rahul

[edk2-devel] [PATCH v2 edk2-platforms] Platform/ARM: Add build docs for Arm plats FVP and Juno

This patch updates the documentation for building Arm platforms. Signed-off-by: Jose Marinho Cc: Sami Mujawar Cc: Samer El-Haj-Mahmoud --- Notes: v2: - Rebased with upstream edk2-platforms master [Jose] Platform/ARM/Readme.md | 329 +--- 1 file changed, 292 insert

Re: [edk2-devel] [PATCH v2 edk2-platforms] Platform/ARM: Add build docs for Arm plats FVP and Juno

The GitHub branch with the patch can be seen at https://github.com/jmarinho/edk2-platforms/tree/arm_platform_docs_v2 > -Original Message- > From: Jose Marinho > Sent: 08 March 2023 11:59 > To: devel@edk2.groups.io > Cc: Jose Marinho ; nd ; > ardb+tianoc...@kernel.org; Thomas Abraham ; >

[edk2-devel] [edk2-platforms][PATCH V2 0/8] Introduce ManageabilityPkg

From: Abner Chang edk2 ManageabilityPkg is introduced to provide edk2 drivers and libraries for industry platform management standards, such as PLDM (Platform Level Data Model), MCTP (Management Component Transfer Protocol), IPMI (Intelligent Platform Management Interface) and others. The framewo

[edk2-devel] [edk2-platforms][PATCH V2 2/8] ManageabilityPkg: Initial package

From: Abner Chang Initial commit of ManageabilityPkg Signed-off-by: Abner Chang Cc: Liming Gao Cc: Isaac Oram Cc: Nate DeSimone Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Igor Kulchytskyy Reviewed-by: Abdul Lateef Attar --- .../ManageabilityPkg/ManageabilityPkg.dec | 18 + .

[edk2-devel] [edk2-platforms][PATCH V2 3/8] ManageabilityPkg: Add NULL ManageabilityTransportLib

From: Abner Chang The NULL instance of ManageabilityTransportLib library. Signed-off-by: Abner Chang Cc: Liming Gao Cc: Isaac Oram Cc: Nate DeSimone Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Abdul Lateef Attar --- .../ManageabilityPkg/ManageabilityPkg.dec | 9 + .../ManageabilityPkg

[edk2-devel] [edk2-platforms][PATCH V2 4/8] ManageabilityPkg: Add ManageabilityTransportHelperLib

From: Abner Chang The helper functions library facilitates reducing duplicated code in the manageability transport library instances. Signed-off-by: Abner Chang Cc: Liming Gao Cc: Isaac Oram Cc: Nate DeSimone Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Abdul Lateef Attar --- .../Manageabili

[edk2-devel] [edk2-platforms][PATCH V2 5/8] ManageabilityPkg/ManageabilityTransportKcsLib

From: Abner Chang This is the KCS manageability transport library instance follows the design guidance described in Readme file under ManageabilityPkg. Signed-off-by: Abner Chang Cc: Liming Gao Cc: Isaac Oram Cc: Nate DeSimone Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Igor Kulchytskyy --

[edk2-devel] [edk2-platforms][PATCH V2 7/8] ManageabilityPkg: Add IpmiProtocol to Manageability Package

From: Abner Chang Add Ipmi Protocol/Ppi/SMM modules to ManageabilityPkg. Signed-off-by: Abner Chang Cc: Liming Gao Cc: Isaac Oram Cc: Nate DeSimone Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Igor Kulchytskyy --- Features/ManageabilityPkg/Include/Dsc/Manageability.dsc | 7 +++ 1 file

[edk2-devel] [edk2-platforms][PATCH V2 6/8] ManageabilityPkg: Implement Ipmi Protocol/Ppi

From: Abner Chang Add Ipmi Protocol/Ppi/SMM implementations. The underlying implementation of transport interface depends on the binded ManageabilityTransportLib. Signed-off-by: Abner Chang Cc: Liming Gao Cc: Isaac Oram Cc: Nate DeSimone Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Igor Kulc

[edk2-devel] [edk2-platforms][PATCH V2 8/8] edk2-platforms: Maintainers.txt

From: Abner Chang Add maintainer and reviewer of ManageabilityPkg. Signed-off-by: Abner Chang Cc: Abdul Lateef Attar Cc: Leif Lindholm Cc: Michael D Kinney Cc: Liming Gao Cc: Isaac Oram Cc: Nickle Wang Reviewed-by: Michael D Kinney --- Maintainers.txt | 11 +-- 1 file changed, 9

[edk2-devel] [PATCH V2] MdePkg/Include: Add IPMI KCS definitions

From: Abner Chang BZ #4354 This change adds definitions for IPMI KCS. Spec ref: https://www.intel.com/content/www/us/en/products/docs/servers/ipmi/ipmi-second-gen-interface-spec-v2-rev1-1.html Signed-off-by: Abner Chang Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Nickle Wang C

Re: [edk2-devel] [PATCH V2] MdePkg/Include: Add IPMI KCS definitions

[AMD Official Use Only - General] In V2 , CompletionCode is removed from structure IPMI_KCS_RESPONSE_HEADER, because it is returned in the response data. Thanks Abner > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, > Abner via groups.io > Sent: Wednesday, March 8,

Re: [edk2-devel] [PATCH v4 00/11] ArmPkg: implement EFI memory attributes protocol

My mistake - the DEBUG_PROPERTY_DEBUG_CLEAR_MEMORY_ENABLED feature is why FreePagesWithProtectionAttributesTestCase might fail. To make the clear memory feature more compatible with the memory attribute protocol, can you add a check to DebugClearMemoryEnabled() on free and clear EFI_MEMORY_RP

Re: [edk2-devel] [PATCH v2 2/4] DynamicTablesPkg: Add SMBIOS table dispatcher

Hi Sami Thanks for v2, I will apply these to my tree and test it out. One small comment before I review/test the patch train inline (prefixed by [GM]) Best Regards Girish On 3/8/2023 1:16 AM, Sami Mujawar wrote: External email: Use caution opening links or attachments Some SMBIOS structure

Re: [edk2-devel] [edk2 0/7] v3 Assorted fixes to core RISC-V and RiscVVirt

On Mon, Mar 06, 2023 at 03:26:08PM -0600, Andrei Warkentin wrote: > Dear all, > > Please find the following patches for your reviewing pleasure. Sunil > suggested I put these into a single patch set, instead of sending > out these separately. > > This patch set is also available at > https://git

Re: [edk2-devel] [PATCH v2 1/1] DynamicTablesPkg: Add SMBIOS table generation

Hi Sami, Thanks for your response. I will update my patch series based on v2 of your dispatcher code and point you to v3. (mid/late next week) Can you also merge the Smbios String related patch (the SmbiosStringLibrary). It works well. (I think I've ack'd that patch). My responses inline [

Re: [edk2-devel] [PATCH v1 1/1] CI: Use Fedora-37 (gcc12) image for Linux jobs

Reviewed-by: Michael Kubacki On 3/8/2023 4:48 AM, Oliver Steffen wrote: Switch to the new Fedora-37 CI docker image, and with it to gcc12, for Linux jobs. Signed-off-by: Oliver Steffen --- .azurepipelines/templates/defaults.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[edk2-devel] [PATCH edk2-platforms v2 0/3] IpmiFeaturePkg: fix IPMI GetSelfTest command response

This patchset fixes "Get Self Test Results" IPMI command response processing. The first patch just makes a fix. The second patch removes a transfer buffer from IPMI instance data as a preparation of further improvement. It's not clear why a buffer of a maximum size used for all commands. For the co

[edk2-devel] [PATCH edk2-platforms v2 1/3] IpmiFeaturePkg: fix IPMI GetSelfTest command response parsing

Byte 0 of a response contains completion code for the command. So, the examined data starts from byte 1. It's easy to make a mistake here since specification counts response data from 1. For the "Get Self Test Results" command Intelligent Platform Management Interface Specification v2.0 rev 1.1 pa

[edk2-devel] [PATCH edk2-platforms v2 3/3] IpmiFeaturePkg: refine GetSelfTest function

Use predefined type while accessing IPMI command returned data instead of raw byte array. Signed-off-by: Mike Maslenkin Cc: Isaac Oram Cc: Nate DeSimone Cc: Liming Gao --- .../IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-)

[edk2-devel] [PATCH edk2-platforms v2 2/3] IpmiFeaturePkg: remove buffer temporary buffer from BMC instance structure

There is no point to have temporary buffer in BMC instance data used only for synchronous IPMI command as a transfer buffer. Using local variables make things much simpler. Signed-off-by: Mike Maslenkin Cc: Isaac Oram Cc: Nate DeSimone Cc: Liming Gao --- .../GenericIpmi/Common/IpmiBmc.c

Re: [edk2-devel] [PATCH 7/7] OvmfPkg/RiscVVirt: Enable MMU with SV39 mode

First of all, it's great to see MMU support. I look forward to testing this patch set and reporting back as it ties in well with the OpRom emulation work we've been doing. Why default to Sv39? Why not probe and set up the max mode allowable by the hardware? The overhead for doing so is minimal,

回复: [edk2-devel] [PATCH 1/3] MdeModulePkg/BmBoot: Skip removable media if it is not present

Ray: You also have access to merge the patch. Sure, I can help merge this patch. Thanks Liming 发件人: devel@edk2.groups.io 代表 Ni, Ray 发送时间: 2023年3月8日 16:58 收件人: devel@edk2.groups.io; Tan, Lean Sheng 抄送: Wang, Jian J ; Gao, Liming 主题: Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/BmBoot: Skip

Re: [edk2-devel] [PATCH 1/2] MdePkg: modify the wrong 'AcpiId' to 'ApicId' in MpWakeupStructure

Thanks for the fix. Reviewed-by: Zhiguang Liu > -Original Message- > From: devel@edk2.groups.io On Behalf Of duntan > Sent: Friday, March 3, 2023 3:26 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Liu, Zhiguang ; Ni, > Ray > Subject: [edk2-devel] [PATCH 1/2] Md

Re: [edk2-devel] [PATCH 2/2] MdePkg: add define for Multiprocessor Wakeup Structure Version

Hi Dun, Do you mean the mailbox version? Here is from spec MailBox Version | Version of the mailbox. 0 for this version of the spec. If so, I suggest the macro name should be EFI_ACPI_6_4_MULTIPROCESSOR _WAKEUP_MAILBOX _STRUCTURE_VERSION Thanks Zhiguang > -Original Message- > F

Re: [edk2-devel] [PATCH 2/2] MdePkg: add define for Multiprocessor Wakeup Structure Version

Thanks for the comments Zhiguang. Will update the macro name in V2 patch. Thanks, Dun -Original Message- From: Liu, Zhiguang Sent: Thursday, March 9, 2023 10:24 AM To: Tan, Dun ; devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming ; Ni, Ray Subject: RE: [PATCH 2/2] MdePkg: add de

[edk2-devel] [PATCH v5 2/3] UsbNetworkPkg/UsbCdcEcm: Add USB Cdc ECM devices support

This driver provides UEFI driver for USB CDC ECM device Signed-off-by: Richard Ho Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Cc: Michael Kubacki Cc: Zhiguang Liu Cc: Liming Gao Cc: Rebecca Cran Reviewed-by: Tony Lo --- UsbNetworkPkg/UsbCdcEcm/ComponentName.c | 170 + Usb

[edk2-devel] [PATCH v5 3/3] UsbNetworkPkg/UsbCdcNcm: Add USB Cdc NCM devices support

This driver provides UEFI driver for USB CDC NCM device Signed-off-by: Richard Ho Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Cc: Michael Kubacki Cc: Zhiguang Liu Cc: Liming Gao Cc: Rebecca Cran Reviewed-by: Tony Lo --- UsbNetworkPkg/UsbCdcNcm/ComponentName.c | 170 UsbN

Re: [edk2-devel] [PATCH edk2-platforms v2 0/3] IpmiFeaturePkg: fix IPMI GetSelfTest command response

Series Reviewed-by: Isaac Oram -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#100893): https://edk2.groups.io/g/devel/message/100893 Mute This Topic: https://groups.io/mt/97485240/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe

[edk2-devel] [PATCH] Maintainers: Add 'Yuwei Chen' as BaseTools maintainer.

Add myself as maintainer for the BaseTools Pkg. Cc: Michael D Kinney Cc: Bob Feng Cc: Liming Gao Signed-off-by: Yuwei Chen --- Maintainers.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Maintainers.txt b/Maintainers.txt index d4607a..463d9567e1 100644 --- a/Mainta

Re: [edk2-devel] [PATCH edk2-platforms v2 0/3] IpmiFeaturePkg: fix IPMI GetSelfTest command response

Pushed as 90ea518edf..95b58f71d9 From: devel@edk2.groups.io On Behalf Of Isaac Oram Sent: Wednesday, March 8, 2023 6:43 PM To: Mike Maslenkin ; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH edk2-platforms v2 0/3] IpmiFeaturePkg: fix IPMI GetSelfTest command response Series Reviewed-by:

[edk2-devel] [Patch V2 0/2] Modify defination for MpWakeupStructure

In the V2 patch set: Change macro name for mailbox version to EFI_ACPI_6_4_MULTIPROCESSOR_WAKEUP_MAILBOX_STRUCTURE_VERSION Dun Tan (2): MdePkg: modify the wrong 'AcpiId' to 'ApicId' in MpWakeupStructure MdePkg: Add define for MultiprocessorWakeupMailboxStructure Version MdePkg/Include/Indus

[edk2-devel] [Patch V2 1/2] MdePkg: modify the wrong 'AcpiId' to 'ApicId' in MpWakeupStructure

modify the wrong 'AcpiId' to 'ApicId' of MpWakeupStructure defination in Acpi64.h. Signed-off-by: Dun Tan Cc: Michael D Kinney Cc: Liming Gao Reviewed-by: Zhiguang Liu --- MdePkg/Include/IndustryStandard/Acpi64.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdePkg/Inclu

[edk2-devel] [Patch V2 2/2] MdePkg: Add define for MultiprocessorWakeupMailboxStructure Version

Add define for MMultiprocessorWakeupMailboxStructure Version. The version for Mailbox Structure in Spec6.4 is 0. Signed-off-by: Dun Tan Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Ray Ni --- MdePkg/Include/IndustryStandard/Acpi64.h | 5 + 1 file changed, 5 insertions(+) dif

Re: [edk2-devel] [Patch V2 2/2] MdePkg: Add define for MultiprocessorWakeupMailboxStructure Version

Reviewed-by: Zhiguang Liu > -Original Message- > From: Tan, Dun > Sent: Thursday, March 9, 2023 11:12 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Liu, Zhiguang ; Ni, > Ray > Subject: [Patch V2 2/2] MdePkg: Add define for > MultiprocessorWakeupMailboxStructure

Re: [edk2-devel] [Patch V2 2/2] MdePkg: Add define for MultiprocessorWakeupMailboxStructure Version

> -Original Message- > From: Tan, Dun > Sent: Thursday, March 9, 2023 11:12 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Liu, Zhiguang ; Ni, > Ray > Subject: [Patch V2 2/2] MdePkg: Add define for > MultiprocessorWakeupMailboxStructure Version > > Add define f

[edk2-devel] [Patch V3 0/2] Modify defination for MpWakeupStructure

In V3 patch: Modify wrong naming in commit message Dun Tan (2): MdePkg: modify the wrong 'AcpiId' to 'ApicId' in MpWakeupStructure MdePkg: Add define for MultiprocessorWakeupMailboxStructure Version MdePkg/Include/IndustryStandard/Acpi64.h | 7 ++- 1 file changed, 6 insertions(+), 1 dele

Re: [edk2-devel] [Patch V2 2/2] MdePkg: Add define for MultiprocessorWakeupMailboxStructure Version

Thanks Ray. Updated in V3 patch set. Thanks, Dun -Original Message- From: Ni, Ray Sent: Thursday, March 9, 2023 11:19 AM To: Tan, Dun ; devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming ; Liu, Zhiguang Subject: RE: [Patch V2 2/2] MdePkg: Add define for MultiprocessorWakeupMail

[edk2-devel] [Patch V3 1/2] MdePkg: modify the wrong 'AcpiId' to 'ApicId' in MpWakeupStructure

modify the wrong 'AcpiId' to 'ApicId' of MpWakeupStructure defination in Acpi64.h. Signed-off-by: Dun Tan Cc: Michael D Kinney Cc: Liming Gao Reviewed-by: Zhiguang Liu --- MdePkg/Include/IndustryStandard/Acpi64.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdePkg/Inclu

[edk2-devel] [Patch V3 2/2] MdePkg: Add define for MultiprocessorWakeupMailboxStructure Version

Add define for MultiprocessorWakeupMailboxStructure Version. The version for Mailbox Structure in Spec6.4 is 0. Signed-off-by: Dun Tan Cc: Michael D Kinney Cc: Liming Gao Reviewed-by: Zhiguang Liu Cc: Ray Ni --- MdePkg/Include/IndustryStandard/Acpi64.h | 5 + 1 file changed, 5 insertions

Re: [edk2-devel] [PATCH edk2-platforms 1/2] QemuOpenBoardPkg: Redo PCI bus initialization

We are doing some work to enable CI on edk2-platforms and would like to add QemuOpenBoardPkg to the CI list. I do think that this will become more active over time. Is there a V2 coming? If so, I found a compiler issue with VS2019 and VS2015. It doesn't like the local variable PlatformData hav

[edk2-devel] [PATCH 1/1] Platform/RISC-V/PlatformPkg: Get privileged mode from PCD

From: qinhaijun The privileged mode of next booting stage is forced to S-mode,there change it getting from PcdPeiCorePrivilegeMode PCD. Signed-off-by: qinhaijun --- Platform/RISC-V/PlatformPkg/Universal/Sec/SecMain.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Platf

[edk2-devel] [PATCH 0/1] Get privileged mode from PCD

From: qinhaijun The privileged mode of next booting stage is forced to S-mode,there change it getting from PcdPeiCorePrivilegeMode PCD. qinhaijun (1): Platform/RISC-V/PlatformPkg: Get privileged mode from PCD Platform/RISC-V/PlatformPkg/Universal/Sec/SecMain.c | 4 ++-- 1 file changed, 2 ins

[edk2-devel] Building edk2 for qcs610

Hello, I'm trying to build Yocto image for QCS610. The image includes edk2 package, and building that package fails with following trace. I'm using tagged version: LE.UM.6.2.4.r1-13000-QCS610.0 Do you have any suggestions on what goes wrong? Or should I try with different version. Looking at co

[edk2-devel] [PATCH] BaseTools: Update for riscv64 default compiling option

From: Yong Li The code size of the efi binaries on riscv64 is almost twice bigger than on aarch64. The difference almost comes from the -Os compared to the aarch64 parts. This patch updates compiling flag to align with aarch64 one, with this the riscv64 efi binaries size will be similar to aarch6

Re: [edk2-devel] [PATCH v1 1/1] CI: Use Fedora-37 (gcc12) image for Linux jobs

Thanks!, Oliver. Reviewed-by: Sunil V L On Wed, Mar 08, 2023 at 10:48:55AM +0100, Oliver Steffen wrote: > Switch to the new Fedora-37 CI docker image, and with it to gcc12, for > Linux jobs. > > Signed-off-by: Oliver Steffen > --- > .azurepipelines/templates/defaults.yml | 2 +- > 1 file chan

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialIpmiLib: IPMI implementation

[AMD Official Use Only - General] Hi Nickle, My comments in below, > -Original Message- > From: Nickle Wang > Sent: Wednesday, March 8, 2023 3:21 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [PATCH] RedfishPkg/RedfishPlatformCredentialI

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialIpmiLib: IPMI implementation

Hi Abner, Thanks for your review. >> + // >> + // Get bootstrap credential from variable first // Status = >> + GetBootstrapAccountCredentialsFromVariable (*UserId, *Password); if >> + (!EFI_ERROR (Status)) { >> +return EFI_SUCCESS; >> + } > I think the process should keep going if th

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformCredentialIpmiLib: IPMI implementation

[AMD Official Use Only - General] > -Original Message- > From: Nickle Wang > Sent: Thursday, March 9, 2023 1:49 PM > To: Chang, Abner ; devel@edk2.groups.io > Cc: Igor Kulchytskyy ; Nick Ramirez > > Subject: RE: [PATCH] RedfishPkg/RedfishPlatformCredentialIpmiLib: IPMI > implementation

Re: [edk2-devel] [PATCH v5 2/3] UsbNetworkPkg/UsbCdcEcm: Add USB Cdc ECM devices support

Tested on Mt Jade Platform (with enableratelimiting true) Tested-by: Tinh Nguyen Thanks, Tinh On 09/03/2023 09:40, RichardHo [何明忠] via groups.io wrote: This driver provides UEFI driver for USB CDC ECM device Signed-off-by: Richard Ho Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney

Re: [edk2-devel] [Patch V3 0/2] Modify defination for MpWakeupStructure

Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of duntan > Sent: Thursday, March 9, 2023 11:40 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [Patch V3 0/2] Modify defination for > MpWakeupStructure > > In V3 patch: > Modify wrong naming in commit

[edk2-devel] [PATCH v6 2/3] UsbNetworkPkg/UsbCdcEcm: Add USB Cdc ECM devices support

This driver provides UEFI driver for USB CDC ECM device Signed-off-by: Richard Ho Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Cc: Michael Kubacki Cc: Zhiguang Liu Cc: Liming Gao Cc: Rebecca Cran Tested-by: Tinh Nguyen Reviewed-by: Tony Lo --- UsbNetworkPkg/UsbCdcEcm/UsbCdcEcm

[edk2-devel] [PATCH v6 3/3] UsbNetworkPkg/UsbCdcNcm: Add USB Cdc NCM devices support

This driver provides UEFI driver for USB CDC NCM device Signed-off-by: Richard Ho Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Cc: Michael Kubacki Cc: Zhiguang Liu Cc: Liming Gao Cc: Rebecca Cran Tested-by: Tinh Nguyen Reviewed-by: Tony Lo --- UsbNetworkPkg/UsbCdcNcm/UsbCdcNcm