Thanks for the comments Zhiguang. Will update the macro name in V2 patch.
Thanks,
Dun
-----Original Message-----
From: Liu, Zhiguang <zhiguang....@intel.com>
Sent: Thursday, March 9, 2023 10:24 AM
To: Tan, Dun <dun....@intel.com>; devel@edk2.groups.io
Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Gao, Liming
<gaolim...@byosoft.com.cn>; Ni, Ray <ray...@intel.com>
Subject: RE: [PATCH 2/2] MdePkg: add define for Multiprocessor Wakeup Structure
Version
Hi Dun,
Do you mean the mailbox version?
Here is from spec
MailBox Version | Version of the mailbox. 0 for this version of the
spec.
If so, I suggest the macro name should be EFI_ACPI_6_4_MULTIPROCESSOR
_WAKEUP_MAILBOX _STRUCTURE_VERSION
Thanks
Zhiguang
> -----Original Message-----
> From: Tan, Dun <dun....@intel.com>
> Sent: Friday, March 3, 2023 3:26 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Gao, Liming
> <gaolim...@byosoft.com.cn>; Liu, Zhiguang <zhiguang....@intel.com>;
> Ni, Ray <ray...@intel.com>
> Subject: [PATCH 2/2] MdePkg: add define for Multiprocessor Wakeup
> Structure Version
>
> Add define for Multiprocessor Wakeup Structure Version. The version
> for MpWakeupStructure in Spec6.4 is 0.
>
> Signed-off-by: Dun Tan <dun....@intel.com>
> Cc: Michael D Kinney <michael.d.kin...@intel.com>
> Cc: Liming Gao <gaolim...@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang....@intel.com>
> Cc: Ray Ni <ray...@intel.com>
> ---
> MdePkg/Include/IndustryStandard/Acpi64.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/MdePkg/Include/IndustryStandard/Acpi64.h
> b/MdePkg/Include/IndustryStandard/Acpi64.h
> index 16c2faaaf2..4920939bdc 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi64.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi64.h
> @@ -601,6 +601,11 @@ typedef struct {
> UINT64 MailBoxAddress;
> } EFI_ACPI_6_4_MULTIPROCESSOR_WAKEUP_STRUCTURE;
>
> +///
> +/// Multiprocessor Wakeup Structure Version (as defined in ACPI 6.4
> +spec.) /// #define
> +EFI_ACPI_6_4_MULTIPROCESSOR_WAKEUP_STRUCTURE_REVISION 0x0
> +
> ///
> /// Multiprocessor Wakeup Mailbox Structure ///
> --
> 2.31.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#100889): https://edk2.groups.io/g/devel/message/100889
Mute This Topic: https://groups.io/mt/97357624/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
