Re: [edk2-devel] [PATCH v4 2/3] UsbNetworkPkg/UsbCdcEcm: Add USB Cdc ECM devices support

Hi Richard, Please check my inline comment Could you apply this to the NCM driver? It looks like they share the same logic. Thanks, Tinh On 18/02/2023 16:47, RichardHo [何明忠] via groups.io wrote: + +/** + Check if the USB CDC Data(UsbIo) installed and return USB CDC Data Handle. + + @par

[edk2-devel] [PATCH 1/3] BaseTools/Conf/tools_def: Fix linking using CLANGDWARF_IA32_X64

The clang toolchain might default to fPIE/fPIC, which prevents lld from linking the objects into a binary. Specify -fno-pie -fno-pic as done on GCC to fix linking. Test: Building the Universal Payload using the command 'python UefiPayloadPkg/UniversalPayloadBuild.py -a IA32' actually works. Sign

[edk2-devel] [PATCH 2/3] BaseTools/Conf/tools_def: Fix CLANGDWARF_IA32_X64

Drop the "-z max-page-size=0x40" option as it causes the ELF header to overflow into the .text section, causing undefined behaviour. With high optimization level it corrupts essential code and the binary would crash. It might work with low optimization level though. As the default is to use Oz and

[edk2-devel] [PATCH 3/3] ShellPkg/TftpDynamicCommand.inf: Add missing DEPEX

Add protocol gEfiHiiPackageListProtocolGuid to DEPEX to make sure it's present before using it. Fixes ASSERTION seen on DEBUG build. Signed-off-by: Patrick Rudolph --- ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff -

Re: [edk2-devel] [PATCH 2/3] BaseTools/Conf/tools_def: Fix CLANGDWARF_IA32_X64

Reviewed-by: Sean Rhodes On Mon, 6 Mar 2023 at 08:38, Patrick Rudolph wrote: > Drop the "-z max-page-size=0x40" option as it causes the ELF > header to overflow into the .text section, causing undefined > behaviour. > > With high optimization level it corrupts essential code and > the binary wo

Re: [edk2-devel] [PATCH 3/3] ShellPkg/TftpDynamicCommand.inf: Add missing DEPEX

Reviewed-by: Sean Rhodes On Mon, 6 Mar 2023 at 08:38, Patrick Rudolph wrote: > Add protocol gEfiHiiPackageListProtocolGuid to DEPEX > to make sure it's present before using it. > > Fixes ASSERTION seen on DEBUG build. > > Signed-off-by: Patrick Rudolph > --- > ShellPkg/DynamicCommand/TftpDyna

[edk2-devel] [edk2-platforms][PATCH 1/2] PlatformPayloadFeaturePkg.dsc: Add missing packages

Add package that are required to build PlatformPayloadFeaturePkg. Test: Running python Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.py generates a FV. Signed-off-by: Patrick Rudolph Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4359 --- Features/Intel/PlatformPayloa

[edk2-devel] [edk2-platforms][PATCH 2/2] PlatformPayloadFeaturePkg.py: Add Linux support

- Use OS specific path seperator instead of hardcoding ';' - Fix case of build artifact FV/PLATFORMPAYLOAD.Fv Test: python Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.py works on Linux. Signed-off-by: Patrick Rudolph Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4358

Re: [edk2-devel] [PATCH] MdeModulePkg/Logo: Add a PCD to control the position of the Logo

This patch has been pending for ages, can someone help to review? Thank you. Best Regards, *Lean Sheng Tan* 9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany Email: sheng@9elements.com Phone: *+49 234 68 94 188 <+492346894188>* Mobile: *+49 176 76 113842 <+4917676113842>* Registered

Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/BmBoot: Skip removable media if it is not present

@Jian J Wang Any update on this? Anything needs to be done from our side? Thanks. Best Regards, *Lean Sheng Tan* 9elements GmbH, Kortumstraße 19-21, 44787 Bochum, Germany Email: sheng@9elements.com Phone: *+49 234 68 94 188 <+492346894188>* Mobile: *+49 176 76 113842 <+4917676113842>* Reg

Re: [edk2-devel] [PATCH] UefiCpuPkg: Calculate DisplayFamily correctly

Reviewed-by: Star Zeng -Original Message- From: devel@edk2.groups.io On Behalf Of Zhiguang Liu Sent: Thursday, March 2, 2023 9:27 AM To: devel@edk2.groups.io Cc: Liu, Zhiguang ; Dong, Eric ; Ni, Ray ; Kumar, Rahul R ; Gerd Hoffmann Subject: [edk2-devel] [PATCH] UefiCpuPkg: Calculate D

Re: [edk2-devel] [PATCH] UefiCpuPkg: Calculate DisplayFamily correctly

BTW, look like wrong Bugzilla ID is used in commit message, please correct it when merging the patch. -Original Message- From: devel@edk2.groups.io On Behalf Of Zeng, Star Sent: Monday, March 6, 2023 6:35 PM To: devel@edk2.groups.io; Liu, Zhiguang Cc: Dong, Eric ; Ni, Ray ; Kumar, Rahul

Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process

On Tue, Feb 21, 2023 at 09:48:54AM +0100, Gerd Hoffmann wrote: > On Mon, Feb 20, 2023 at 01:14:33AM +, Ni, Ray wrote: > > I expect Gerd at least acknowledges all patches for UefiCpuPkg. Following > > three haven't got: > > * [PATCH v9 3/6] UefiCpuPkg/SmmBaseHob.h: Add SMM Base HOB Data > > *

Re: [edk2-devel] [PATCH] UefiCpuPkg: Calculate DisplayFamily correctly

Handling of ExtendedModelId field has the same problem. This patch could be improved to fix that too. On Mon, Mar 6, 2023 at 1:37 PM Zeng, Star wrote: > > BTW, look like wrong Bugzilla ID is used in commit message, please correct it > when merging the patch. > > -Original Message- > From

Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process

Gerd, Thanks for reporting. Can you kindly share the reproduce steps? Jiaxin, Can you look into this? Thanks, Ray > -Original Message- > From: devel@edk2.groups.io On Behalf Of Gerd > Hoffmann > Sent: Monday, March 6, 2023 7:13 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Wu, Jiaxin ;

Re: [edk2-devel] [PATCH] UefiCpuPkg: Calculate DisplayFamily correctly

ExtendedModelId field should use shift. So I believe nothing wrong there. > -Original Message- > From: Mike Maslenkin > Sent: Monday, March 6, 2023 7:14 PM > To: devel@edk2.groups.io; Zeng, Star > Cc: Liu, Zhiguang ; Dong, Eric > ; Ni, Ray ; Kumar, Rahul R > ; Gerd Hoffmann > Subject: R

Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process

On Mon, Mar 06, 2023 at 11:43:12AM +, Ni, Ray wrote: > Gerd, > Thanks for reporting. Can you kindly share the reproduce steps? (1) build OvmfPkgIa32X64.dsc with SMM_REQUIRE=TRUE (2) boot linux guest using the firmware build. (3) suspend: use 'echo mem > /sys/power/state' on linux guest

Re: [edk2-devel] [PATCH] UefiCpuPkg: Calculate DisplayFamily correctly

There is no problem with current implementation. My proposal was to re-write code in this way: DisplayModel = Eax.Bits.Model; if ((Eax.Bits.FamilyId == 0x06) || (Eax.Bits.FamilyId == 0x0f)) { DisplayModel += (Eax.Bits.ExtendedModelId << 4); } This is exactly matches spec without knowled

Re: [edk2-devel] [PATCH] UefiCpuPkg: Calculate DisplayFamily correctly

[AMD Official Use Only - General] We don’t have that pseudo code in AMD APM, so either way is ok. Acked-by: Abner Chang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Mike > Maslenkin via groups.io > Sent: Monday, March 6, 2023 9:37 PM > To: devel@edk2.groups.io; ray...

Re: [edk2-devel] [PATCH v3 0/4] ArmPkg/SecurityPkg: Fixes for ArmTrngLib/RngDxe

Hello Jiewen, Jian, Do these patches in this set look ok to you ? - SecurityPkg/RngDxe: Correctly update mAvailableAlgoArrayCount - SecurityPkg/RngDxe: Conditionally install EFI_RNG_PROTOCOL - SecurityPkg/RngDxe: Fix Rng algo selection for Arm Regards, Pierre On 2/10/23 10:26, PierreGondois via

Re: [edk2-devel][PATCH V1 1/1] BaseTools: Generate compile information in build report

Hi guys, can we submit the pull request or do you have comments on it? https://github.com/tianocore/edk2-basetools/pull/88 Thanks -Original Message- From: Palomino Sosa, Guillermo A Sent: Tuesday, February 28, 2023 10:00 PM To: Ni, Ray ; Kinney, Michael D ; devel@edk2.groups.io; a...@k

Re: [edk2-devel] [PATCH v3 0/4] ArmPkg/SecurityPkg: Fixes for ArmTrngLib/RngDxe

Hi Pierre I don’t have strong opinion. For ARM specific patch, would you please get R-B from ARM expert? I think we need to wait for the response from Ard to confirm. > -Original Message- > From: Pierre Gondois > Sent: Monday, March 6, 2023 11:38 PM > To: devel@edk2.groups.io > Cc: Lei

[edk2-devel] [edk2-libc Patch 0/1] edk2-libc: migration of edk2module from chipsec repo

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4161 This patch merges the enhancements done by chipsec tool to edk2 module into edk2-libc repo. The chipsec enhancements can be used for various other Python based tools to access platform registers. These enhancements providing a set of APIs to

[edk2-devel] [edk2-libc Patch 1/1] Python/Python3.6.8: migration of edk2module from chipsec repo

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4161 This patch merges the enhancements done by chipsec tool to edk2 module into edk2-libc repo. The chipsec enhancements can be used for various other Python based tools to access platform registers. These enhancements providing a set of APIs to

Re: [edk2-devel] [PATCH v3 0/4] ArmPkg/SecurityPkg: Fixes for ArmTrngLib/RngDxe

On Mon, 6 Mar 2023 at 16:42, Yao, Jiewen wrote: > > Hi Pierre > I don’t have strong opinion. > > For ARM specific patch, would you please get R-B from ARM expert? > > I think we need to wait for the response from Ard to confirm. > These patches SecurityPkg/RngDxe: Correctly update mAvailableAl

Re: [edk2-devel] [edk2-libc Patch 1/1] Python/Python3.6.8: migration of edk2module from chipsec repo

On 3/6/23 8:43 AM, Ajay Kadapathri wrote: +EFI_STATUS +GuidToStr ( + IN EFI_GUID *guid, + IN OUT UINT8 *str_buffer + ) +/*++ + +Routine Description: + This function prints a GUID to a buffer + +Arguments: + guid - Pointer to a GUID + str_buffer - Pointer to a str buffer + +Returns: +

Re: [edk2-devel] [PATCH 1/2] MdePkg: Update Base.h to be compliant with C11

Now that edk2-stable202302 has been released, I'd like to get this patch series committed. -- Rebecca Cran On 2/9/23 8:45 AM, Rebecca Cran wrote: With the introduction of the use of _Static_assert, edk2 requires a C11 compatible compiler. Update Include/Base.h to be compliant with C11. As o

Re: [edk2-devel] [PATCH v3 0/4] ArmPkg/SecurityPkg: Fixes for ArmTrngLib/RngDxe

Hello Jiewen, Ard, Thanks for the review. On 3/6/23 17:22, Ard Biesheuvel wrote: On Mon, 6 Mar 2023 at 16:42, Yao, Jiewen wrote: Hi Pierre I don’t have strong opinion. For ARM specific patch, would you please get R-B from ARM expert? I think we need to wait for the response from Ard to conf

[edk2-devel] [PATCH] MdePkg/BaseCacheMaintenanceLib: RISC-V: Fix instruction cache not been invalidated

When the range instruction cache invalidating not supported, the whole instruction cache should be invalidated instead. Signed-off-by: Tuan Phan --- MdePkg/Library/BaseCacheMaintenanceLib/RiscVCache.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/MdePkg/Library/BaseCach

Re: [edk2-devel] [edk2-platforms][PATCH 2/8] ManageabilityPkg: Initial package

[Public] Looks good. Reviewed-by: Abdul Lateef Attar -Original Message- From: Chang, Abner Sent: Friday, March 3, 2023 1:10 PM To: devel@edk2.groups.io Cc: Liming Gao ; Isaac Oram ; Nate DeSimone ; Attar, AbdulLateef (Abdul Lateef) ; Nickle Wang ; Igor Kulchytskyy Subject: [edk2-p

[edk2-devel] ACPI port help

Hello all, Is this a good place to seek help about porting acpi related issues? -- * * * Go Green: Kindly don't print this unless so required.* * * *Established U/S 3 of UGC Act and Accredited by NBA of  AICTE and NAAC of UGC* Visit us @ *http://www.kiit.ac.in

[edk2-devel] [PATCH] Platform/Loongson: Allow building with stack protector support

Some toolchains have stack protection enabled by default, so without the appropriate library included the build will fail with missing symbols during link. Cc: Bibo Mao Cc: Xianglai li Cc: Chao Li Cc: Leif Lindholm Cc: Michael D Kinney Signed-off-by: WANG Xuerui --- Platform/Loongson/LoongA

[edk2-devel] [PATCH 0/7] RISC-V: Add MMU support

This series adds MMU support for RISC-V. Only SV39/48/57 modes are supported and tested. The MMU is required to support setting page attribute which is the first basic step to support security booting on RISC-V. There are three parts: 1. Add MMU core to UefiCpuPkg. MMU will be enabled during CpuDx

[edk2-devel] [PATCH 1/7] MdePkg/BaseLib: RISC-V: Support getting satp register value

Add an API to retrieve satp register value. Signed-off-by: Tuan Phan --- MdePkg/Include/Library/BaseLib.h | 5 + MdePkg/Library/BaseLib/RiscV64/RiscVMmu.S | 8 2 files changed, 13 insertions(+) diff --git a/MdePkg/Include/Library/BaseLib.h b/MdePkg/Include/Library/BaseLib.

[edk2-devel] [PATCH 2/7] MdePkg/Register: RISC-V: Add satp mode bits shift definition

The satp mode bits shift is used cross modules. It should be defined in one place. Signed-off-by: Tuan Phan --- MdePkg/Include/Register/RiscV64/RiscVEncoding.h | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/MdePkg/Include/Register/RiscV64/RiscVEncoding.h b/MdePkg/Inc

[edk2-devel] [PATCH 3/7] UefiCpuPkg: RISC-V: Support MMU with SV39/48/57 mode

During CpuDxe initialization, MMU will be setup based on the value get from the PCD satp mode. Default is bare mode. Signed-off-by: Tuan Phan --- UefiCpuPkg/CpuDxeRiscV64/CpuDxe.c | 10 +- UefiCpuPkg/CpuDxeRiscV64/CpuDxe.h | 1 + UefiCpuPkg/CpuDxeRiscV64/CpuDxeRiscV64.inf |

[edk2-devel] [PATCH 5/7] OvmfPkg/VirtNorFlashDxe: Not add memory space if it exists

The flash base address can be added to GCD before this driver run. So only add it if it has not been done. Signed-off-by: Tuan Phan --- OvmfPkg/VirtNorFlashDxe/VirtNorFlashDxe.c | 25 +++ 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/OvmfPkg/VirtNorFlashDxe/V

[edk2-devel] [PATCH 4/7] OvmfPkg/RiscVVirt: VirtNorFlashPlatformLib: Fix wrong flash size

The size should be for single region, not the whole firmware FD. Signed-off-by: Tuan Phan --- .../Library/VirtNorFlashPlatformLib/VirtNorFlashStaticLib.c| 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/OvmfPkg/RiscVVirt/Library/VirtNorFlashPlatformLib/VirtNorFlashStatic

[edk2-devel] [PATCH 6/7] OvmfPkg/RiscVVirt: SEC: Add IO memory resource hob for platform devices

Normally, DXE driver would add device resource to GCD before start using. But some key resources such as uart, flash base address are being accessing directly in some core modules. Those resources should be populated to HOB in SEC phase so they are added to GCD before anyone can access them. Sign

[edk2-devel] [PATCH 7/7] OvmfPkg/RiscVVirt: Enable MMU with SV39 mode

As MMU will be enabled in CpuDxe, remove the code that set up satp mode in SEC phase. Enable SV39 as default mode. Signed-off-by: Tuan Phan --- OvmfPkg/RiscVVirt/RiscVVirt.dsc.inc | 1 + OvmfPkg/RiscVVirt/Sec/Memory.c | 17 - 2 files changed, 1 insertion(+), 17 deletions(-

Re: [edk2-devel] [PATCH v3 0/4] ArmPkg/SecurityPkg: Fixes for ArmTrngLib/RngDxe

On Mon, 6 Mar 2023 at 18:09, Pierre Gondois wrote: > > Hello Jiewen, Ard, > Thanks for the review. > > On 3/6/23 17:22, Ard Biesheuvel wrote: > > On Mon, 6 Mar 2023 at 16:42, Yao, Jiewen wrote: > >> > >> Hi Pierre > >> I don’t have strong opinion. > >> > >> For ARM specific patch, would you pleas

Re: [edk2-devel] [PATCH 5/7] OvmfPkg/VirtNorFlashDxe: Not add memory space if it exists

On Mon, 6 Mar 2023 at 18:33, Tuan Phan wrote: > > The flash base address can be added to GCD before this driver run. > So only add it if it has not been done. > How do you end up in this situation? You cannot skip this registration, as it is required to get the region marked as EFI_MEMORY_RUNTIM

[edk2-devel] [edk2 0/7] v3 Assorted fixes to core RISC-V and RiscVVirt

Dear all, Please find the following patches for your reviewing pleasure. Sunil suggested I put these into a single patch set, instead of sending out these separately. This patch set is also available at https://github.com/andreiw/edk2-rv-wip/tree/patchset-1 Andrei Warkentin (7): OvmfPkg: Risc

[edk2-devel] [edk2 1/7] OvmfPkg: RiscVVirt: add SATA support

Tested with a PCIe pass-thru'd AHCI controller. Cc: Sunil V L Cc: Jiewen Yao Cc: Ard Biesheuvel Signed-off-by: Andrei Warkentin --- OvmfPkg/RiscVVirt/RiscVVirtQemu.dsc | 7 +++ OvmfPkg/RiscVVirt/RiscVVirtQemu.fdf | 7 +++ 2 files changed, 14 insertions(+) diff --git a/OvmfPkg/RiscVVi

[edk2-devel] [edk2 2/7] MdePkg: BasePeCoffLib: Allow AArch64 and x64 images in ImageFormatSupported

ARM64 and X64 may allow such foreign images to be used when driver implementing EDKII_PECOFF_IMAGE_EMULATOR_PROTOCOL is present. Cc: Sunil V L Cc: Daniel Schaefer Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Andrei Warkentin --- MdePkg/Library/BasePeCoffLib/RiscV/PeCo

[edk2-devel] [edk2 3/7] MdePkg: BaseLib: don't log in RISCV InternalSwitchStack

InternalSwitchStack may be called with a TPL high enough for a DebugLib implementation to assert. Other arch implementations don't log either. Cc: Daniel Schaefer Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Reviewed-by: Sunil V L Signed-off-by: Andrei Warkentin --- MdePkg/Library/

[edk2-devel] [edk2 4/7] MdePkg: BaseCpuLib: Fix RISCV CpuSleep symbol name.

CpuSleep, not _CpuSleep. Cc: Daniel Schaefer Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Reviewed-by: Sunil V L Signed-off-by: Andrei Warkentin --- MdePkg/Library/BaseCpuLib/RiscV/Cpu.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdePkg/Library/BaseCpuLi

[edk2-devel] [edk2 5/7] MdeModulePkg: Dxe: add RISCV64 to mMachineTypeInfo

This fixes messages like: "Image type AARCH64 can't be loaded on UEFI system" Cc: Daniel Schaefer Cc: Liming Gao Cc: Jian J Wang Reviewed-by: Sunil V L Signed-off-by: Andrei Warkentin --- MdeModulePkg/Core/Dxe/Image/Image.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[edk2-devel] [edk2 6/7] [PATCH v2] UefiCpuPkg: CpuTimerDxeRiscV64: fix tick duration accounting

The TimerDxe implementation doesn't account for the physical time passed due to timer handler execution or (perhaps even more importantly) time spent with interrupts masked. Other implementations (e.g. like the Arm one) do. If the timer tick is always incremented at a fixed rate, then you can slow

[edk2-devel] [edk2 7/7] [PATCH v3] UefiCpuPkg: BaseRiscV64CpuExceptionHandlerLib: clean up exception handling

RegisterCpuInterruptHandler did not allow setting exception handlers for anything beyond the timer IRQ. Beyond that, it didn't meet the spec around handling of inputs. RiscVSupervisorModeTrapHandler now will invoke set handlers for both exceptions and interrupts. Two arrays of handlers are maintai

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, March 6, 2023 #cal-reminder

*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, March 6, 2023 4:30pm to 5:30pm (UTC-08:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1753761 ) *Description:* TianoCo

[edk2-devel] Now: Tools, CI, Code base construction meeting series - Monday, March 6, 2023 #cal-notice

*Tools, CI, Code base construction meeting series* *When:* Monday, March 6, 2023 4:30pm to 5:30pm (UTC-08:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1753761 ) *Description:* TianoCore communi

Re: [edk2-devel] [PATCH] UefiCpuPkg: Calculate DisplayFamily correctly

Yes, the bugzilla link should be https://bugzilla.tianocore.org/show_bug.cgi?id=4348 Will correct it when merge the patch. Thanks Star for catching this Thanks Zhiguang > -Original Message- > From: Zeng, Star > Sent: Monday, March 6, 2023 6:37 PM > To: devel@edk2.groups.io; Zeng, Star ;

Re: [edk2-devel] [PATCH] Platform/Loongson: Allow building with stack protector support

Reviewed-by: Chao Li Thanks, Chao 在 2023/3/5 12:40, WANG Xuerui 写道: Some toolchains have stack protection enabled by default, so without the appropriate library included the build will fail with missing symbols during link. Cc: Bibo Mao Cc: Xianglai li Cc: Chao Li Cc: Leif Lindholm Cc: Michae

Re: [edk2-devel] [PATCH v4 0/9] merge UefiCpuPkg/UefiCpuLib to MdePkg/CpuLib

Hi Gerd, Could you help review this patch set? Thanks Thanks Zhiguang > -Original Message- > From: devel@edk2.groups.io On Behalf Of > Zhiguang Liu > Sent: Tuesday, February 28, 2023 9:50 AM > To: Gerd Hoffmann ; devel@edk2.groups.io > Cc: Ard Biesheuvel ; Yao, Jiewen > ; Justen, Jordan

Re: [edk2-devel] [PATCH] UefiCpuPkg: Calculate DisplayFamily correctly

@Liu, Zhiguang, can you check if Mike's suggestion "+" instead of "|" is more matching to SDM? If yes, we can create another code patch. > -Original Message- > From: Mike Maslenkin > Sent: Monday, March 6, 2023 9:37 PM > To: devel@edk2.groups.io; Ni, Ray > Subject: Re: [edk2-devel] [PA

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, March 7, 2023 #cal-reminder

*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Tuesday, March 7, 2023 6:30pm to 7:30pm (UTC-08:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed

Re: [edk2-devel] [PATCH] UefiCpuPkg: Calculate DisplayFamily correctly

Yes, I think Mike's comment is good and more align with SDM. Will send another version of patch. Thanks Zhiguang > -Original Message- > From: Ni, Ray > Sent: Tuesday, March 7, 2023 9:51 AM > To: Mike Maslenkin ; devel@edk2.groups.io; > Liu, Zhiguang > Subject: RE: [edk2-devel] [PATCH]

[edk2-devel] [edk2-libc Patch 0/2] Python/Python3.6.8: migration of edk2module from chipsec repo

Python/Python3.6.8: migration of edk2module from chipsec repo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4161 This patch merges the enhancements done by chipsec tool to edk2 module into edk2-libc repo. The chipsec enhancements can be used for various other Python based tools to access pl

[edk2-devel] [edk2-libc Patch 1/2] Python/Python3.6.8: migration of edk2module from chipsec repo

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4161 This patch merges the enhancements done by chipsec tool to edk2 module into edk2-libc repo. The chipsec enhancements can be used for various other Python based tools to access platform registers. These enhancements providing a set of APIs to

[edk2-devel] [edk2-libc Patch 2/2] Incorporated review comments

Cc: Rebecca Cran Cc: Michael D Kinney Cc: Jayaprakash N Signed-off-by: Ajay Kadapathri --- .../PyMod-3.6.8/Modules/edk2module.c | 26 +-- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/AppPkg/Applications/Python/Python-3.6.8/PyMod-3.6.8/Modules/edk2mo

[edk2-devel] [PATCH v2] UefiCpuPkg: Calculate DisplayFamily correctly

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4348 Per SDM: DisplayFamily = Extended_Family_ID + Family_ID. DisplayModelID = (Extended_Model_ID << 4) + Family_ID. Correct the related code. Cc: Eric Dong Reviewed-by: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Reviewed-by: Star Zeng Cc: Mi

Re: [edk2-devel] [PATCH v2] UefiCpuPkg: Calculate DisplayFamily correctly

Reviewed-by: Ray Ni > -Original Message- > From: Liu, Zhiguang > Sent: Tuesday, March 7, 2023 2:32 PM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang ; Dong, Eric > ; Ni, Ray ; Kumar, Rahul R > ; Gerd Hoffmann ; Zeng, > Star ; Mike Maslenkin > Subject: [PATCH v2] UefiCpuPkg: Calculate Di

Re: [edk2-devel] [PATCH v2] UefiCpuPkg: Calculate DisplayFamily correctly

On Tue, Mar 07, 2023 at 02:31:36PM +0800, Zhiguang Liu wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4348 > > Per SDM: > DisplayFamily = Extended_Family_ID + Family_ID. > DisplayModelID = (Extended_Model_ID << 4) + Family_ID. > Correct the related code. > > Cc: Eric Dong > Reviewe

Re: [edk2-devel] [PATCH v4 0/9] merge UefiCpuPkg/UefiCpuLib to MdePkg/CpuLib

On Tue, Feb 28, 2023 at 01:50:12AM +, Liu, Zhiguang wrote: > Hi Gerd, > > Yes, just like you said, no code logic modified, just relocation. > > And thanks for your suggestion, but since it is a simple code change, but > contains too many patches, if it is ok for you, I don't plan to send the

Re: [edk2-devel] [PATCH 0/4] CryptoPkg/BaseCryptLib: avoid certain openssl library calls

Hi, Ping. Code freeze is over, can we merge this now? thanks, Gerd On Wed, Feb 15, 2023 at 08:15:32AM +, Yao, Jiewen wrote: > Reviewed-by: Jiewen Yao > > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of Gerd > > Hoffmann > > Sent: Tuesday, February 14, 2023 3:

[edk2-devel] [PATCH v2 0/3] OvmfPkg/PlatformInitLib: move mmconfig to 0xe0000000

v2: - rebase to latest master. Gerd Hoffmann (3): OvmfPkg/PlatformInitLib: update address space layout comment OvmfPkg/PlatformInitLib: move mmconfig to 0xe000 OvmfPkg/PlatformInitLib: simplify mtrr setup OvmfPkg/AmdSev/AmdSevX64.dsc| 2 +- OvmfPkg/IntelTdx/IntelTdxX6

[edk2-devel] [PATCH v2 3/3] OvmfPkg/PlatformInitLib: simplify mtrr setup

With the new mmconfig location at 0xe000 above the 32-bit PCI MMIO window we don't have to special-case the mmconfig xbar any more. We'll just add a mtrr uncachable entry starting at MMIO window base and ending at 4GB. Update comments to match reality. Signed-off-by: Gerd Hoffmann --- Ovmf

[edk2-devel] [PATCH v2 1/3] OvmfPkg/PlatformInitLib: update address space layout comment

Move the commment up so it is placed just before the address space calculations start. Also add q35 memory layout. Signed-off-by: Gerd Hoffmann --- OvmfPkg/Library/PlatformInitLib/Platform.c | 36 -- 1 file changed, 19 insertions(+), 17 deletions(-) diff --git a/OvmfPkg/Lib

[edk2-devel] [PATCH v2 2/3] OvmfPkg/PlatformInitLib: move mmconfig to 0xe0000000

Also swap the ordering of 32bit PCI MMIO window on q35, i.e. use the room between end of low memory and the start of the mmconfig bar. With a typical configuration on modern qemu with gigabyte-aligned memory the MMIO window start at 0x800, sized 1532 MB. In case there is memory present above

Re: [edk2-devel] [Patch V4 0/8] Put APs in 64 bit mode before handoff to OS.

Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of > Yuanhao Xie > Sent: Wednesday, March 1, 2023 2:10 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [Patch V4 0/8] Put APs in 64 bit mode before handoff > to OS. > > The purpose of this patch series

Re: [edk2-devel] [PATCH v2] UefiCpuPkg: Calculate DisplayFamily correctly

Reviewed-by: Star Zeng -Original Message- From: Liu, Zhiguang Sent: Tuesday, March 7, 2023 2:32 PM To: devel@edk2.groups.io Cc: Liu, Zhiguang ; Dong, Eric ; Ni, Ray ; Kumar, Rahul R ; Gerd Hoffmann ; Zeng, Star ; Mike Maslenkin Subject: [PATCH v2] UefiCpuPkg: Calculate DisplayFamily

Re: [edk2-devel] [PATCH] MdePkg/Include: Add IPMI KCS definitions

Hi Abner, Any plan to support SMBUS system interface (ssif)? - Tinh On 03/03/2023 09:31, Chang, Abner via groups.io wrote: From: Abner Chang BZ #4354 This change adds definitions for IPMI KCS. Signed-off-by: Abner Chang Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Nickle Wan

Re: [edk2-devel] [PATCH v3 0/4] ArmPkg/SecurityPkg: Fixes for ArmTrngLib/RngDxe

I don’t mind, please go ahead. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard > Biesheuvel > Sent: Tuesday, March 7, 2023 12:22 AM > To: Yao, Jiewen > Cc: Pierre Gondois ; devel@edk2.groups.io; Leif > Lindholm ; Sami Mujawar ; > Wang, Jian J > Subject: Re: [edk2-deve