Re: [edk2-devel] [PATCH V1 1/7] OvmfPkg: Add Tdx measurement data structure in WorkArea

On Wed, Jan 18, 2023 at 01:41:15AM +, Xu, Min M wrote: > On January 17, 2023 7:26 PM, Gerd Hoffmann wrote: > > So the measurement is done early and the hashes are stored to create the > > event log entries later, correct? > Yes. > > > > Why both TdHob and CFV are handled this way? It should b

Re: [edk2-devel] [PATCH V1 1/7] OvmfPkg: Add Tdx measurement data structure in WorkArea

On January 18, 2023 4:05 PM, Gerd Hoffmann wrote: > On Wed, Jan 18, 2023 at 01:41:15AM +, Xu, Min M wrote: > > On January 17, 2023 7:26 PM, Gerd Hoffmann wrote: > > > So the measurement is done early and the hashes are stored to create > > > the event log entries later, correct? > > Yes. > > >

Re: [edk2-devel] [PATCH v2 2/2] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

Quoting Ard Biesheuvel (2023-01-18 08:34:32) > On Wed, 18 Jan 2023 at 07:37, Oliver Steffen wrote: > > > > On Tue, Jan 17, 2023 at 3:57 PM Ard Biesheuvel wrote: > >> > >> On Tue, 17 Jan 2023 at 13:48, Oliver Steffen wrote: > >> > > >> > Hi Ard, Hi everyone, > >> > > >> > Thanks for the work! > >

[edk2-devel] [PATCH V1 1/1] MdeModulePkg: EfiUnacceptedMemoryType is not allowed in AllocatePool

From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4315 MemoryType of EfiUnacceptedMemoryType should not be allocated in AllocatePool. Instead it should return EFI_INVALID_PARAMETER. Cc: Liming Gao Cc: Dandan Bi Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Gerd Hof

Re: [edk2-devel] [PATCH v2 2/2] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

On Wed, 18 Jan 2023 at 09:28, Oliver Steffen wrote: > > Quoting Ard Biesheuvel (2023-01-18 08:34:32) > > On Wed, 18 Jan 2023 at 07:37, Oliver Steffen wrote: > > > > > > On Tue, Jan 17, 2023 at 3:57 PM Ard Biesheuvel wrote: > > >> > > >> On Tue, 17 Jan 2023 at 13:48, Oliver Steffen wrote: > > >>

Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix SMM code hangs when InitPaging

On Wed, Jan 18, 2023 at 01:13:43AM +, Zhiguang Liu wrote: > Thanks all for reviewing, and I will send a new version to address the > comment. > > As for Gerd's question, let me explain. > Let's see one example, that the CPU has SizeOfMemorySpace >48, but the CPU > doesn't enable 5 level pagi

Re: [edk2-devel] [PATCH V2 1/1] OvmfPkg/AcpiPlatformDxe: Measure ACPI table from QEMU in TDVF

On Tue, Jan 17, 2023 at 08:57:32PM +0800, Min Xu wrote: > From: Min M Xu > > https://bugzilla.tianocore.org/show_bug.cgi?id=4245 > > The ACPI tables are downloaded from QEMU. From the security perspective > they should be measured and extended before installation. So that they > can be audited l

Re: [edk2-devel] [PATCH V2 1/1] OvmfPkg/BaseMemEncryptTdxLib: Refactor error handle of SetOrClearSharedBit

On Wed, Jan 18, 2023 at 07:52:32AM +0800, Min Xu wrote: > From: Min M Xu > > The previous implementation of SetOrClearSharedBit doesn't handle the > error correctly. In this patch SetOrClearSharedBit is changed to return > error code so that the caller can handle it. Acked-by: Gerd Hoffmann

Re: [edk2-devel] [PATCH v2] UefiCpuPkg: Fix SMM code hangs when InitPaging

On Wed, Jan 18, 2023 at 09:23:48AM +0800, Zhiguang Liu wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4246 > > In function InitPaging, NumberOfPml5Entries is calculated by below code > NumberOfPml5Entries = (UINTN)LShiftU64 (1, SizeOfMemorySpace - 48); > If the SizeOfMemorySpace is l

Re: [edk2-devel] [PATCH V1 1/1] MdeModulePkg: EfiUnacceptedMemoryType is not allowed in AllocatePool

On Wed, Jan 18, 2023 at 04:41:58PM +0800, Min Xu wrote: > From: Min M Xu > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4315 > > MemoryType of EfiUnacceptedMemoryType should not be allocated in > AllocatePool. Instead it should return EFI_INVALID_PARAMETER. Acked-by: Gerd Hoffmann -

Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix SMM code hangs when InitPaging

Hi Gerd, Let's check the code in InitPaging. If 5LevelPaging is disabled, Pml5 points to a local variable. Pml5[1] shouldn't be used. UINT64Pml5Entry; UINT64*Pml5; if (!Enable5LevelPaging) { Pml5Entry = (UINTN)mSmmProfileCr3 | IA32_PG_P; Pml5 = &Pml5En

[edk2-devel] [PATCH v1 0/2] Fix boot failure caused by loop abortion

A goto following an error check may cause boot failure, because the function that returns the status is supposed to be called for all the possible Puns in the SCSI channel. This patch removes the check and the goto so that the while loop will continue to run until all devices are scanned. The cha

[edk2-devel] [PATCH v1 1/2] MdeModulePkg: Fix bug in ScsiBusDxe/ScsiBus.c

A while loop in SCSIBusDriverBindingStart() is supposed to scan all the possible Puns in the SCSI channel by calling ScsiScanCreateDevice() for each of them. Therefore, we should not abort the loop even when one of the Puns is disconnected. The following is one of the scenarios. SCSIBusDriverBind

[edk2-devel] [PATCH v1 2/2] MdeModulePkg: Clean up unused Status.

Logically, the while loop that contains ScsiScanCreateDevice() should continue regardless what the returned Status is, because the purpose of the while loop is to scan all possible Puns in the SCSI channel. Without this fix, some static analyzer may complain about the unused return value. Cc: Ard

Re: [edk2-devel] [PATCH v2 2/2] ArmVirtPkg/ArmVirtQemu: Avoid early ID map on ThunderX

On Wed, 18 Jan 2023 at 09:48, Ard Biesheuvel wrote: > > On Wed, 18 Jan 2023 at 09:28, Oliver Steffen wrote: > > > > Quoting Ard Biesheuvel (2023-01-18 08:34:32) > > > On Wed, 18 Jan 2023 at 07:37, Oliver Steffen wrote: > > > > > > > > On Tue, Jan 17, 2023 at 3:57 PM Ard Biesheuvel wrote: > > >

[edk2-devel] [PATCH v3 0/5] Simplify SMM Relocation Process

The default SMBASE for the x86 processor is 0x3. When SMI happens, CPU runs the SMI handler at SMBASE+0x8000. Also, the SMM save state area is within SMBASE+0x1. One of the SMM initialization from CPU perspective is to relocate and program the new SMBASE (in TSEG range) for each CPU thread

[edk2-devel] [PATCH v3 1/5] UefiCpuPkg/SmmBaseHob.h: Add SMM Base HOB Data

The default SMBASE for the x86 processor is 0x3. When SMI happens, CPU runs the SMI handler at SMBASE+0x8000. Also, the SMM save state area is within SMBASE+0x1. One of the SMM initialization from CPU perspective is to relocate and program the new SMBASE (in TSEG range) for each CPU thread

[edk2-devel] [PATCH v3 2/5] UefiCpuPkg/PiSmmCpuDxeSmm: Fix invalid InitializeMpSyncData call

No need call InitializeMpSyncData during normal boot SMI init, because mSmmMpSyncData is NULL at that time. mSmmMpSyncData is allocated in InitializeMpServiceData, which is invoked after normal boot SMI init (SmmRelocateBases). Cc: Eric Dong Cc: Ray Ni Cc: Zeng Star Cc: Laszlo Ersek Cc: Gerd H

[edk2-devel] [PATCH v3 3/5] UefiCpuPkg/PiSmmCpuDxeSmm: Consume SMM Base Hob for SmBase info

PiSmmCpuDxeSmm shall retrieve the SMBASE addresses from SMM Base Hob and installs the SMI handler at [SMBASE+8000h] for each processor instead of relocating SMM Base addresses from SMRAM again if SMM Base Hob existed. With SMM Base Hob, PiSmmCpuDxeSmm does not need the RSM instruction to reload th

[edk2-devel] [PATCH v3 4/5] UefiCpuPkg/SmmCpuFeaturesLib: Skip SMBASE configuration

This patch is to avoid configure SMBASE if SmBase relocation has been done. If gSmmBaseHobGuid found, means SmBase info has been relocated and recorded in the SmBase array. No need to do the relocation in SmmCpuFeaturesInitializeProcessor(). Cc: Eric Dong Cc: Ray Ni Cc: Zeng Star Cc: Laszlo Ers

[edk2-devel] [PATCH v3 5/5] OvmfPkg/SmmCpuFeaturesLib: Skip SMBASE configuration

This patch is to avoid configure SMBASE if SmBase relocation has been done. If gSmmBaseHobGuid found, means SmBase info has been relocated and recorded in the SmBase array. No need to do the relocation in SmmCpuFeaturesInitializeProcessor(). Cc: Eric Dong Cc: Ray Ni Cc: Zeng Star Cc: Laszlo Ers

Re: [edk2-devel] [PATCH V1 1/1] MdeModulePkg: EfiUnacceptedMemoryType is not allowed in AllocatePool

Reviewed-by: Jiewen Yao > -Original Message- > From: Xu, Min M > Sent: Wednesday, January 18, 2023 4:42 PM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Gao, Liming > ; Bi, Dandan ; Aktas, > Erdem ; James Bottomley ; > Yao, Jiewen ; Gerd Hoffmann ; > Tom Lendacky ; Michael Roth > > Subje

Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix SMM code hangs when InitPaging

On Wed, Jan 18, 2023 at 09:12:09AM +, Zhiguang Liu wrote: > Hi Gerd, > > Let's check the code in InitPaging. > If 5LevelPaging is disabled, Pml5 points to a local variable. Pml5[1] > shouldn't be used. > > UINT64Pml5Entry; > UINT64*Pml5; > if (!Enable5LevelPaging) { >

Re: [edk2-devel] [PATCH V3 0/4] Introduce Separate-Fv in OvmfPkg/IntelTdx

This series has broken the ArmVirtQemuKernel build (see below). Please fix or revert. : In function ‘RelocatePeCoffImage’:

Re: [edk2-devel] [PATCH v3 1/5] UefiCpuPkg/SmmBaseHob.h: Add SMM Base HOB Data

Hi, > +#pragma pack(1) > +typedef struct { > + /// > + /// Describes the Number of all max supported processors. > + /// > + UINT64NumberOfProcessors; > + /// > + /// Pointer to SmBase address for each Processors. > + /// > + UINT64SmBase[]; > +} SMM_BASE_HOB_DATA; > +#pragma pac

Re: [edk2-devel] [PATCH v2] OvmfPkg/PlatformInitLib: catch QEMU's CPU hotplug reg block regression

On 1/18/23 08:25, Gerd Hoffmann wrote: > On Tue, Jan 17, 2023 at 05:43:53PM +0100, Ard Biesheuvel wrote: >> On Tue, 17 Jan 2023 at 13:37, Gerd Hoffmann wrote: >>> >>> Hi, >>> >> In particular the firmware makes no further decisions based on >> whether QEMU advertized some of these featur

Re: [edk2-devel] [PATCH v3 3/5] UefiCpuPkg/PiSmmCpuDxeSmm: Consume SMM Base Hob for SmBase info

> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > index f723b1d253..a39d8528db 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > @@ -57,11 +57,10 @@ SMM_CPU_PRIVATE_DATA *gSmmCpuP

Re: [edk2-devel] [PATCH V3 0/4] Introduce Separate-Fv in OvmfPkg/IntelTdx

Hey Ard I am worried about the CI for ArmVirtPkg. Can we add such ArmVirtPkg build into CI? I feel disappointed that a simple build error cannot be caught by CI. Hey Min/Ard I think the reason is that the API in EmbeddedPkg/PrePiLib library is changed. That makes it compatible. It is a bad idea

Re: [edk2-devel] [PATCH v3 5/5] OvmfPkg/SmmCpuFeaturesLib: Skip SMBASE configuration

On Wed, Jan 18, 2023 at 05:56:20PM +0800, Jiaxin Wu wrote: > This patch is to avoid configure SMBASE if SmBase relocation has been > done. If gSmmBaseHobGuid found, means SmBase info has been relocated > and recorded in the SmBase array. No need to do the relocation in > SmmCpuFeaturesInitializePro

[edk2-devel] [PATCH v3 0/2] BoardModulePkg: BoardBdsHookLib GCC fix

From: Abdul Lateef Attar PR : https://github.com/tianocore/edk2-platforms/pull/55/ V3 delta changes: Addressed below review comments from Isaac Patch 1: Platform/Intel/BoardModulePkg/Library/BoardBdsHookLib/BoardBdsHookLib.c Line 168: Don't we need to free buffer on this path? Lines 655, 1

[edk2-devel] [PATCH v3 1/2] BoardModulePkg: Copy device path before processing

GCC compiler puts the DevicePath PCDs to the read-only section. During boot if try to process the device path after PtrGetPtr it throws a page fault exception. Hence making a local copy using DuplicateDevicePath() to avoid the page fault exception. Cc: Oram Isaac W Cc: Eric Dong Cc: Liming Gao

[edk2-devel] [PATCH v3 2/2] BoardModulePkg: Adds PCD to load UEFI Shell image

From: Abdul Lateef Attar defines two PCDs, PcdShellFile and PcdShellFileDesc, which holds the GUID and description of the UEFI shell file to be loaded. A PCDs based solution gives flexibility to the user to load different images, by just overriding the DSC file. The user can load a diagnostic i

Re: [edk2-devel] [PATCH v2] OvmfPkg/PlatformInitLib: catch QEMU's CPU hotplug reg block regression

Hi, > ... you could introduce a new fw_cfg boolean switch (and explain it in > the hang message) that meant: "I know what this QEMU bug is, I > understand its consequences are obscure, risky, and far-reaching in > OVMF, I've been warned, I know what I'm doing". That's a relatively > small additi

Re: [edk2-devel] [PATCH v2] OvmfPkg/PlatformInitLib: catch QEMU's CPU hotplug reg block regression

On Wed, 18 Jan 2023 at 12:50, Laszlo Ersek wrote: > > On 1/18/23 08:25, Gerd Hoffmann wrote: > > On Tue, Jan 17, 2023 at 05:43:53PM +0100, Ard Biesheuvel wrote: > >> On Tue, 17 Jan 2023 at 13:37, Gerd Hoffmann wrote: > >>> > >>> Hi, > >>> > >> In particular the firmware makes no further dec

Re: [edk2-devel] [PATCH v2] OvmfPkg/PlatformInitLib: catch QEMU's CPU hotplug reg block regression

On 1/18/23 14:10, Ard Biesheuvel wrote: > On Wed, 18 Jan 2023 at 12:50, Laszlo Ersek wrote: >> >> On 1/18/23 08:25, Gerd Hoffmann wrote: >>> On Tue, Jan 17, 2023 at 05:43:53PM +0100, Ard Biesheuvel wrote: On Tue, 17 Jan 2023 at 13:37, Gerd Hoffmann wrote: > > Hi, > In

Re: [edk2-devel] [PATCH v2] OvmfPkg/PlatformInitLib: catch QEMU's CPU hotplug reg block regression

On 1/18/23 14:10, Gerd Hoffmann wrote: > Hi, > >> ... you could introduce a new fw_cfg boolean switch (and explain it in >> the hang message) that meant: "I know what this QEMU bug is, I >> understand its consequences are obscure, risky, and far-reaching in >> OVMF, I've been warned, I know what

Re: [edk2-devel] [PATCH V3 0/4] Introduce Separate-Fv in OvmfPkg/IntelTdx

On Wed, Jan 18, 2023 at 12:07:52PM +, Yao, Jiewen wrote: > Hey Ard > I am worried about the CI for ArmVirtPkg. > Can we add such ArmVirtPkg build into CI? CI builds one of the ArmVirtPkg configs (ArmVirtQemu.dsc specifically), the other ones are not covered right now. take care, Gerd -=-

[edk2-devel] [PATCH] OvmfPkg: Report proper address space width for Cloud Hypervisor

From: Sebastien Boeuf The address space width isn't properly calculated when the platform is Cloud Hypervisor. The function PlatformAddressWidthFromCpuid() must not be invoked with the QemuQuirk boolean set to true in the Cloud Hypervisor case. Relying on the host bridge identifier, we can set t

Re: [edk2-devel] [OVMF] What would be the best way to make PcdPciMmio64Size dynamic?

On Tue, 2023-01-17 at 15:38 +0100, kra...@redhat.com wrote: > On Tue, Jan 17, 2023 at 02:10:08PM +, Boeuf, Sebastien wrote: > > Hi, > > > > Looking at the hardcoded limitation provided by PcdPciMmio64Size > > (32GiB), I was wondering what would be the best approach to make > > this a > > bit m

Re: [edk2-devel] [PATCH v3 5/5] OvmfPkg/SmmCpuFeaturesLib: Skip SMBASE configuration

Gerd, I think comments from patch #1 explains: # The default SMBASE for the x86 processor is 0x3. When SMI happens, CPU + runs the SMI handler at SMBASE+0x8000. Also, the SMM save state area is within + SMBASE+0x1. + + One of the SMM initialization from CPU perspective is to relocate an

Re: [edk2-devel] [PATCH v3 1/5] UefiCpuPkg/SmmBaseHob.h: Add SMM Base HOB Data

Gerd, In another mail with title "MdePkg: Remove Itanium leftover data structure", we are discussing the HOB EFI_SEC_PLATFORM_INFORMATION_RECORD2 that helps share the BIST information with CpuDxe driver. That HOB is of format: ( ) +. Very similar to the format of SMM_BASE_HOB_DATA: + So, if we

Re: [edk2-devel] [PATCH v2] x86/efi: Safely enable unaccepted memory in UEFI

(cc'ing some folks whom I've discussed this with off-list today) Full discussion here: https://lore.kernel.org/linux-efi/20230113212926.2904735-1-dionnagl...@google.com/ On Mon, 16 Jan 2023 at 23:46, Tom Lendacky wrote: > > On 1/16/23 15:22, Dave Hansen wrote: > > On 1/16/23 02:56, Gerd Hoffmann

Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix SMM code hangs when InitPaging

> > > And for the CpuPageTableLib, I think the API don't provide the > > interface to split 2MB-page page table into 4KB-page, which is the > > function wants to do. > > I think that is handled by the library automatically. You can request > address ranges being mapped with specific attributes (

Re: [edk2-devel] [PATCH V3 0/4] Introduce Separate-Fv in OvmfPkg/IntelTdx

On Wed, 18 Jan 2023 at 14:43, Gerd Hoffmann wrote: > > On Wed, Jan 18, 2023 at 12:07:52PM +, Yao, Jiewen wrote: > > Hey Ard > > I am worried about the CI for ArmVirtPkg. > > Can we add such ArmVirtPkg build into CI? > > CI builds one of the ArmVirtPkg configs (ArmVirtQemu.dsc specifically), >

Re: [edk2-devel] [PATCH v2] x86/efi: Safely enable unaccepted memory in UEFI

On Wed, 18 Jan 2023 at 16:41, Dave Hansen wrote: > > On 1/18/23 07:09, Ard Biesheuvel wrote: > > However, I guess we're at a point where SEV and TDX really want > > different solutions, so I think divergence might be the way to > > proceed. > > I don't think they want different things really. > >

Re: [edk2-devel] [PATCH V3 0/4] Introduce Separate-Fv in OvmfPkg/IntelTdx

I think it is feasible. For example, https://github.com/tianocore/edk2/tree/master/OvmfPkg/PlatformCI includes multiple xxxBuild.py. Each GetDscName() will return different dsc. But https://github.com/tianocore/edk2/tree/master/ArmVirtPkg/PlatformCI only includes one xxxBuild.py. As long as w

[edk2-devel] RE : Build Error after adding GLOBAL_REMOVE_IF_UNREFERENCED in CryptoPkg's CryptTs.c file

Hi, We are facing Build error in Old platforms after adding GLOBAL_REMOVE_IF_UNREFERENCED in CryptoPkg's CryptTs.c file in edk202211 tag. GLOBAL_REMOVE_IF_UNREFERENCED macro is defined in MdePkg/Include/Base.h // // The Microsoft* C compiler can removed references to unreferenced data item

Re: [edk2-devel] [PATCH 1/2] BoardModulePkg: Copy device path before processing

[AMD Official Use Only - General] Hi Isaac, Please see inline for my reply. [Abdul] Thanks AbduL -Original Message- From: Oram, Isaac W Sent: 18 January 2023 02:01 To: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef) Cc: Dong, Eric ; Gao, Liming Subject: RE: [edk2-devel] [PA

Re: [edk2-devel] [PATCH v2] x86/efi: Safely enable unaccepted memory in UEFI

On 1/18/23 07:09, Ard Biesheuvel wrote: > However, I guess we're at a point where SEV and TDX really want > different solutions, so I think divergence might be the way to > proceed. I don't think they want different things really. TDX doesn't need this protocol. It sounds like SEV does need it,

Re: [edk2-devel] [PATCH V3 0/4] Introduce Separate-Fv in OvmfPkg/IntelTdx

On Wed, 18 Jan 2023 at 17:41, Yao, Jiewen wrote: > > I think it is feasible. > > For example, https://github.com/tianocore/edk2/tree/master/OvmfPkg/PlatformCI > includes multiple xxxBuild.py. Each GetDscName() will return different dsc. > > But https://github.com/tianocore/edk2/tree/master/ArmVir

[edk2-devel] [PATCH v3 0/6] Adds AmdSmmCpuFeaturesLib for AMD Family

V3 delta changes: Addressed review comments from Abner Chang. PR: https://github.com/tianocore/edk2/pull/3925 Cc: Paul Grimes Cc: Garrett Kirkendall Cc: Abner Chang Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Abdul Lateef Attar (6):

[edk2-devel] [PATCH v3 2/6] UefiCpuPkg: Adds SmmSmramSaveStateLib library class

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 Adds SmmSmramSaveStateLib Library class in UefiCpuPkg.dec. Adds function declaration header file. Cc: Paul Grimes Cc: Garrett Kirkendall Cc: Abner Chang Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Signed-off-by: Abdul

[edk2-devel] [PATCH v3 3/6] UefiCpuPkg: Implements SmmSmramSaveStateLib library class

From: Abdul Lateef Attar BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 Implements SmmSmramSaveStateLib Library class for AMD cpu family. Cc: Paul Grimes Cc: Garrett Kirkendall Cc: Abner Chang Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Signed-off-by: Abdul Latee

[edk2-devel] [PATCH v3 4/6] UefiCpuPkg/SmmCpuFeaturesLib: Restructure arch-dependent code

From: Abdul Lateef Attar BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 moves Intel-specific code to the arch-dependent file. Other processor families might have different implementation of these functions. Hence, moving out of the common file. Cc: Abner Chang Cc: Garrett Kirkendall

[edk2-devel] [PATCH v3 5/6] UefiCpuPkg: Initial implementation of AMD's SmmCpuFeaturesLib

From: Abdul Lateef Attar BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 Adds initial defination for AMD's SmmCpuFeaturesLib library implementation. All function's body either empty or just returns value. Its initial skeleton of library implementation. Cc: Paul Grimes Cc: Garrett Kirke

[edk2-devel] [PATCH v3 6/6] UefiCpuPkg: Implements SmmCpuFeaturesLib for AMD Family

From: Abdul Lateef Attar BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 Implements interfaces to read and write save state registers of AMD's processor family. Initializes processor SMMADDR and MASK depends on PcdSmrrEnable flag. Program or corrects the IP once control returns from SMM.

[edk2-devel][edk2-platforms][PATCH V1 1/1] AdvancedFeaturePkg: Improve sample build instructions

Make the Windows build example current working directory based instead of arbitrary. Cc: Sai Chaganty Cc: Nate DeSimone Cc: Liming Gao Cc: Rebecca Cran Signed-off-by: Isaac Oram --- Features/Intel/AdvancedFeaturePkg/Readme.md | 14 -- 1 file changed, 8 insertions(+), 6 deletions(

[edk2-devel] Request for access to create edk2-staging branch

Hi, I would like to request write access to edk2-staging repository to create a new staging branch for Intel's product intercept for HTTP Proxy feature. Currently HttpProxy (https://github.com/tianocore/edk2-staging/tree/HttpProxy) is used as a staging branch for the code first process to enabl

Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] Features/Intel: Prepare for edk2-platforms CI

New patch here since I had already pushed. https://edk2.groups.io/g/devel/message/98829 Thanks, Isaac -Original Message- From: devel@edk2.groups.io On Behalf Of Rebecca Cran Sent: Friday, January 13, 2023 6:46 AM To: devel@edk2.groups.io; Oram, Isaac W Cc: Chaganty, Rangasai V ; Desim

Re: [edk2-devel][edk2-platforms][PATCH V1 0/2] Update Si support

Series Pushed as 6c1ab0c4a1..3b368b33e9 -Original Message- From: Desimone, Nathaniel L Sent: Tuesday, January 17, 2023 5:27 PM To: Oram, Isaac W ; devel@edk2.groups.io Cc: Chiu, Chasel Subject: RE: [edk2-devel][edk2-platforms][PATCH V1 0/2] Update Si support Good work Isaac! For the s

Re: [edk2-devel] [PATCH v3 0/2] BoardModulePkg: BoardBdsHookLib GCC fix

Series Reviewed-by: Isaac Oram -Original Message- From: devel@edk2.groups.io On Behalf Of Abdul Lateef Attar via groups.io Sent: Wednesday, January 18, 2023 5:04 AM To: devel@edk2.groups.io Cc: Abdul Lateef Attar ; Oram, Isaac W ; Dong, Eric ; Gao, Liming Subject: [edk2-devel] [PATCH

Re: [edk2-devel] [PATCH v3 0/2] BoardModulePkg: BoardBdsHookLib GCC fix

Series Pushed as 3b368b33e9..201514e6f5 -Original Message- From: devel@edk2.groups.io On Behalf Of Isaac Oram Sent: Wednesday, January 18, 2023 4:30 PM To: devel@edk2.groups.io; abdat...@amd.com Cc: Abdul Lateef Attar ; Dong, Eric ; Gao, Liming Subject: Re: [edk2-devel] [PATCH v3 0/2] B

回复: [edk2-devel] [PATCH V4 1/3] MdePkg/IndustryStandard: Update IPMI definitions

Abner: Thanks for your confirmation. I suggest you mention this change in the commit message. Reviewed-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Chang, Abner > via groups.io > 发送时间: 2023年1月18日 14:06 > 收件人: gaoliming ; devel@edk2.groups.io > 抄送: 'Michael

回复: [edk2-devel] [PATCH V1 1/1] MdeModulePkg: EfiUnacceptedMemoryType is not allowed in AllocatePool

Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Yao, Jiewen > 发送时间: 2023年1月18日 18:04 > 收件人: Xu, Min M ; devel@edk2.groups.io > 抄送: Gao, Liming ; Bi, Dandan > ; Aktas, Erdem ; James > Bottomley ; Gerd Hoffmann ; Tom > Lendacky ; Michael Roth > > 主题: Re: [edk2-devel] [PATC

Re: [edk2-devel] [PATCH V4 1/3] MdePkg/IndustryStandard: Update IPMI definitions

[AMD Official Use Only - General] > -Original Message- > From: gaoliming > Sent: Thursday, January 19, 2023 9:08 AM > To: devel@edk2.groups.io; Chang, Abner > Cc: 'Michael D Kinney' ; 'Zhiguang Liu' > ; 'Nickle Wang' ; 'Igor > Kulchytskyy' ; 'Isaac Oram' ; > 'Nate DeSimone' > Subject:

[edk2-devel][edk2-platforms][PATCH V2 1/1] AdvancedFeaturePkg: Improve sample build instructions

V1: Make the Windows build example current working directory based instead of arbitrary. V2: Fix case mismatch in edk2 repo local name. Cc: Sai Chaganty Cc: Nate DeSimone Cc: Liming Gao Cc: Rebecca Cran Signed-off-by: Isaac Oram --- Features/Intel/AdvancedFeaturePkg/Readme.md | 14 --

Re: [edk2-devel] [PATCH V3 0/4] Introduce Separate-Fv in OvmfPkg/IntelTdx

I will submit a patch-set to fix it soon. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ard > Biesheuvel > Sent: Wednesday, January 18, 2023 7:08 PM > To: Yao, Jiewen ; Xu, Min M > Cc: Gerd Hoffmann ; devel@edk2.groups.io; Leif > Lindholm ; Ard Biesheuvel > ; Abner Chang

[edk2-devel] [PATCH V1 0/2] Add back FfsFindSectionData in EmbeddedPkg

Commit c673216 introduces FFS_CHECK_SECTION_HOOK and add it as the second input parameter in FfsFindSectionData. This change breaks the build of ArmVirtPkg. To fix this issue, the new version of FfsFindSectionData is renamed as FfsFindSectionDataWithHook. Then the original FfsFindSectionData is add

[edk2-devel] [PATCH V1 1/2] EmbeddedPkg: Rename FfsFindSectionData as FfsFindSectionDataWithHook

From: Min M Xu Commit c673216f53 introduces FFS_CHECK_SECTION_HOOK and add it as the second input parameter in FfsFindSectionData. This change breaks the build of ArmVirtPkg. To fix this issue, the new version of FfsFindSectionData is renamed as FfsFindSectionDataWithHook in this patch. In the fo

[edk2-devel] [PATCH V1 2/2] EmbeddedPkg: Add back FfsFindSectionData

From: Min M Xu In commit c673216f53 a new input parameter is added in FfsFindSectionData. That change breaks the build of ArmVirtPkg. In this patch FfsFindSectionData is added back. It calls FfsFindSectionDataWithHook with a NULL hook. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Abner Chang Cc:

Re: [edk2-devel] [PATCH V1 0/2] Add back FfsFindSectionData in EmbeddedPkg

Thanks for the quick update. Reviewed-by: Jiewen Yao > -Original Message- > From: Xu, Min M > Sent: Thursday, January 19, 2023 9:51 AM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Leif Lindholm > ; Ard Biesheuvel ; > Abner Chang ; Daniel Schaefer > ; Gerd Hoffmann ; Aktas, > Erdem ; Jam

[edk2-devel] [PATCH V2 00/10] Enable Tdx measurement in OvmfPkgX64

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243 Tdx measurement (RTMR based measurement) is enabled in OvmfPkg/IntelTdx. This patch-set enables the feature in OvmfPkgX64 as well. Patch #1: Introduce TDX_MEASUREMETNS_DATA in SEC_TDX_WORK_AREA. That is because the RTMR measurement of Td

[edk2-devel] [PATCH V2 01/10] OvmfPkg: Add Tdx measurement data structure in WorkArea

From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243 >From the perspective of security any external input should be measured and extended to some registers (TPM PCRs or TDX RTMR registers). There are below 2 external input in a Td guest: - TdHob - Configuration FV (CFV) TdH

[edk2-devel] [PATCH V2 02/10] OvmfPkg/IntelTdx: Add TdxHelperLibNull

From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243 TdxHelperLib provides below helper functions for a td-guest. - TdxHelperProcessTdHob - TdxHelperMeasureTdHob - TdxHelperMeasureCfvImage - TdxHelperBuildGuidHobForTdxMeasurement TdxHelperLibNull is the NULL instance of Td

[edk2-devel] [PATCH V2 03/10] OvmfPkg/IntelTdx: Add SecTdxHelperLib

From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243 TdxHelperLib provides below helper functions for a td-guest. - TdxHelperProcessTdHob - TdxHelperMeasureTdHob - TdxHelperMeasureCfvImage - TdxHelperBuildGuidHobForTdxMeasurement SecTdxHelperLib is the SEC instance of TdxH

[edk2-devel] [PATCH V2 04/10] OvmfPkg/IntelTdx: Implement other helper functions in SecTdxHelperLib

From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243 TdxHelperLib provides below helper functions for a td-guest. - TdxHelperProcessTdHob - TdxHelperMeasureTdHob - TdxHelperMeasureCfvImage - TdxHelperBuildGuidHobForTdxMeasurement This patch implements below helper function

[edk2-devel] [PATCH V2 05/10] OvmfPkg/IntelTdx: Add PeiTdxHelperLib

From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243 TdxHelperLib provides below helper functions for a td-guest. - TdxHelperProcessTdHob - TdxHelperMeasureTdHob - TdxHelperMeasureCfvImage - TdxHelperBuildGuidHobForTdxMeasurement PeiTdxHelperLib is the PEI instance of TdxH

[edk2-devel] [PATCH V2 06/10] OvmfPkg/PeilessStartupLib: Build GuidHob for Tdx measurements

From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243 With the introduction of TdxHelperBuildGuidHobForTdxMeasurement in TdxHelperLib PeilessStartup should also be updated. It should call TdxHelperBuildGuidHobForTdxMeasurement to build the GuidHob for Tdx measurement. The depre

[edk2-devel] [PATCH V2 07/10] OvmfPkg/IntelTdx: Update tdx measurement in SEC phase

From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243 After TdxHelperLib is instroduced, the SecMain.c in IntelTdx is updated with the new functions provided by TdxHelperLib. Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Gerd Hoffmann Cc: Tom Lendacky Cc: Michael

[edk2-devel] [PATCH V2 08/10] OvmfPkg: Enable Tdx measurement in OvmfPkgX64

From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243 This patch enables Tdx measurement in OvmfPkgX64 with below changes: 1) TDX_ENABLE is introduced in OvmfPkgX64.dsc. This flag indicates if Intel TDX is enabled in OvmfPkgX64. Its default value is FALSE. 2) Update SecMain.c

[edk2-devel] [PATCH V2 09/10] OvmfPkg/PlatformPei: Build GuidHob for Tdx measurement

From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243 TdxHelperBuildGuidHobForTdxMeasurement is called in PlatformPei to build GuidHob for Tdx measurement. Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Gerd Hoffmann Cc: Tom Lendacky Cc: Michael Roth Signed-off-by

[edk2-devel] [PATCH V2 10/10] OvmfPkg/PlatformInitLib: Delete the ProcessTdxHobList()

From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4243 ProcessTdxHobList is moved to TdxHelperLib and is renamed as TdxHelperProcessTdHob(). So the duplicated codes are deleted in PlatformInitLib. Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Gerd Hoffmann Cc: Tom L

Re: [edk2-devel] [PATCH V4 1/3] MdePkg/IndustryStandard: Update IPMI definitions

[AMD Official Use Only - General] Merged. > -Original Message- > From: gaoliming > Sent: Thursday, January 19, 2023 9:08 AM > To: devel@edk2.groups.io; Chang, Abner > Cc: 'Michael D Kinney' ; 'Zhiguang Liu' > ; 'Nickle Wang' ; 'Igor > Kulchytskyy' ; 'Isaac Oram' ; > 'Nate DeSimone' > S

Re: [edk2-devel] [PATCH v3 3/6] UefiCpuPkg: Implements SmmSmramSaveStateLib library class

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Abdul Lateef Attar > Sent: Thursday, January 19, 2023 1:01 AM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; > Grimes, Paul ; Kirkendall, Garrett > ; Chang, Abner ; > Eric Dong

Re: [edk2-devel] [PATCH V3 0/3] Add NULL IpmiCommandLib instance

[AMD Official Use Only - General] Merged. > -Original Message- > From: gaoliming > Sent: Wednesday, January 18, 2023 1:10 PM > To: devel@edk2.groups.io; Chang, Abner > Cc: 'Jian J Wang' ; 'Nickle Wang' > ; 'Igor Kulchytskyy' ; 'Isaac Oram' > ; 'Nate DeSimone' > > Subject: 回复: [edk2-dev

Re: [edk2-devel] [PATCH v3 1/6] MdePkg: Adds AMD SMRAM save state map

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Abdul Lateef Attar > Sent: Thursday, January 19, 2023 1:01 AM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; > Grimes, Paul ; Kirkendall, Garrett > ; Chang, Abner ; > Michael D

Re: [edk2-devel] [PATCH v3 2/6] UefiCpuPkg: Adds SmmSmramSaveStateLib library class

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Abdul Lateef Attar > Sent: Thursday, January 19, 2023 1:01 AM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; > Grimes, Paul ; Kirkendall, Garrett > ; Chang, Abner ; > Eric Dong

Re: [edk2-devel] [PATCH v3 4/6] UefiCpuPkg/SmmCpuFeaturesLib: Restructure arch-dependent code

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Abdul > Lateef Attar via groups.io > Sent: Thursday, January 19, 2023 1:01 AM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; Chang, > Abner ; K

Re: [edk2-devel] [PATCH v3 5/6] UefiCpuPkg: Initial implementation of AMD's SmmCpuFeaturesLib

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Abdul Lateef Attar > Sent: Thursday, January 19, 2023 1:01 AM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; > Grimes, Paul ; Kirkendall, Garrett > ; Chang, Abner ; > Eric Dong

Re: [edk2-devel] [PATCH v3 6/6] UefiCpuPkg: Implements SmmCpuFeaturesLib for AMD Family

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Abdul Lateef Attar > Sent: Thursday, January 19, 2023 1:01 AM > To: devel@edk2.groups.io > Cc: Attar, AbdulLateef (Abdul Lateef) ; > Grimes, Paul ; Kirkendall, Garrett > ; Chang, Abner ; > Eric Dong

Re: [edk2-devel] [PATCH v3 0/6] Adds AmdSmmCpuFeaturesLib for AMD Family

[AMD Official Use Only - General] Hi Abdul, Thanks for contributing this and addressing the comments. Please just add the review tag to each commit message and send out the V4. So maintainers know AMD has agreed with this change. We still need maintainers to review this patch set and merge it i

[edk2-devel] [PATCH 1/1] UefiCpuPkg: Fix typo in filenames in Test/UnitTest/EfiMpServicesPpiProtocol

Fix the spelling of EfiMpServicesUnitTestCommon in Test/UnitTest/EfiMpServicesPpiProtocol. Signed-off-by: Rebecca Cran --- UefiCpuPkg/Test/UnitTest/EfiMpServicesPpiProtocol/EdkiiPeiMpServices2PpiPeiUnitTest.inf | 4 ++-- UefiCpuPkg/Test/UnitTest/EfiMpServicesPpiProt

Re: [edk2-devel] [PATCH v1 1/2] MdeModulePkg: Fix bug in ScsiBusDxe/ScsiBus.c

Thanks for the patch, inline comments below: > -Original Message- > From: Yuan Yu > Sent: Wednesday, January 18, 2023 5:14 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Gao, Liming > ; Wu, Hao A ; Ni, Ray > ; C, sivaparvathi > Subject: [PATCH v1 1/2] MdeModulePkg: Fix bug in Scsi

Re: [edk2-devel] [PATCH v3 1/5] UefiCpuPkg/SmmBaseHob.h: Add SMM Base HOB Data

On Wed, Jan 18, 2023 at 03:06:11PM +, Ni, Ray wrote: > Gerd, > In another mail with title "MdePkg: Remove Itanium leftover data structure", > we are discussing the HOB EFI_SEC_PLATFORM_INFORMATION_RECORD2 that helps > share the BIST information with CpuDxe driver. > That HOB is of format: (

Re: [edk2-devel] [PATCH v3 5/5] OvmfPkg/SmmCpuFeaturesLib: Skip SMBASE configuration

On Wed, Jan 18, 2023 at 02:37:11PM +, Ni, Ray wrote: > Gerd, > I think comments from patch #1 explains: Not, it doesn't. We are running in circles. I keep asking about the producer, you are answering that saying what the consumer should do. So, you apparently want do SMM initialization earl

Re: [edk2-devel] [edk2-non-osi][PATCH V2] ASpeed/ASpeedGopBinPkg: Update X64/AArch Gop UEFI Driver

On Wed, 18 Jan 2023 at 02:19, Isaac Oram wrote: > > Reviewed-by: Isaac Oram > NAK This version updates VERSION_STRING not INF_VERSION INF_VERSION must be 1.29 VERSION_STRING can be anything you like > -Original Message- > From: Tommy Huang > Sent: Tuesday, January 17, 2023 4:39 PM >

Re: [edk2-devel] [PATCH] OvmfPkg: Report proper address space width for Cloud Hypervisor

On Wed, Jan 18, 2023 at 03:20:15PM +0100, sebastien.bo...@intel.com wrote: > From: Sebastien Boeuf > > The address space width isn't properly calculated when the platform is > Cloud Hypervisor. The function PlatformAddressWidthFromCpuid() must not > be invoked with the QemuQuirk boolean set to tr

Re: [edk2-devel] [PATCH V1 0/2] Add back FfsFindSectionData in EmbeddedPkg

On Thu, Jan 19, 2023 at 09:51:06AM +0800, Min Xu wrote: > Commit c673216 introduces FFS_CHECK_SECTION_HOOK and add it as the > second input parameter in FfsFindSectionData. This change breaks the build > of ArmVirtPkg. To fix this issue, the new version of FfsFindSectionData > is renamed as FfsFind