Re: [edk2-devel] [Patch 1/1] RedfishPkg: Remove overlapping private include path in DEC file

2022-12-06 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Michael D Kinney > Sent: Tuesday, December 6, 2022 8:45 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Nickle Wang > ; Igor Kulchytskyy > Subject: [Patch 1/1] RedfishPkg: Remove overlapping priv

Re: [edk2-devel] [edk2-platform][PATCH 1/1] MdeModulePkg: SdMmcPciHcDxe: Fix issue that SD1.0 cards can't be recognized

2022-12-06 Thread Wu, Hao A
Hello, The proposed patch will cause CI test failure: https://github.com/tianocore/edk2/pull/3724. Could you help to resolve them? May I know what kind of tests have been performed for this patch? Have you tried with non SD1.0 cards and make sure that they still work fine after the patch? Also

Re: [edk2-devel] [PATCH] UsbNetworkPkg: add USB network devices support

2022-12-06 Thread RichardHo [何明忠] via groups . io
Hi Rebecca, Thanks for your response. I will fixed it next. Thanks, Richard -Original Message- From: Rebecca Cran Sent: 2022年12月5日 11:15 AM To: devel@edk2.groups.io; Richard Ho (何明忠) Cc: Andrew Fish ; Leif Lindholm ; Michael D Kinney ; Michael Kubacki ; Zhiguang Liu ; Liming Gao ; T

Re: [edk2-devel] [PATCH 2/2] EmulatorPkg: Record Argc, Argv and Envp in EmuThunk Ppi

2022-12-06 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Liu, Zhiguang > Sent: Tuesday, December 6, 2022 1:42 PM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang ; Andrew Fish ; > Ni, Ray > Subject: [PATCH 2/2] EmulatorPkg: Record Argc, Argv and Envp in EmuThunk > Ppi > > Record Argc, Argv and E

Re: [edk2-devel] [PATCH] EmulatorPkg: Remove unnecessary dependency on EmbeddedPkg

2022-12-06 Thread Ni, Ray
Thanks for the cleaning up. Reviewed-by: Ray Ni > -Original Message- > From: Liu, Zhiguang > Sent: Tuesday, December 6, 2022 1:30 PM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang ; Andrew Fish ; > Ni, Ray > Subject: [PATCH] EmulatorPkg: Remove unnecessary dependency on > EmbeddedPkg >

Re: [edk2-devel] [PATCH 1/2] EmulatorPkg: Add persistent memory in EmuThunkPpi

2022-12-06 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Liu, Zhiguang > Sent: Tuesday, December 6, 2022 1:41 PM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang ; Andrew Fish ; > Ni, Ray > Subject: [PATCH 1/2] EmulatorPkg: Add persistent memory in EmuThunkPpi > > The persistent memory is for PE

回复: [edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, December 6, 2022 #cal-reminder

2022-12-06 Thread gaoliming via groups.io
Few issues are submitted. This week meeting is cancelled. Thanks Liming 发件人: devel@edk2.groups.io 代表 Group Notification 发送时间: 2022年12月6日 10:30 收件人: devel@edk2.groups.io 主题: [edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, December 6, 2022 #cal-reminder Reminder: TianoC

[edk2-devel] [PATCH 0/3] Fix some typos

2022-12-06 Thread Dongdong Zhang
Hi all, My focus was fixing typos in comments. Most of them were found by spellchecker. There are many similar spelling mistakes, so to avoid involving too many modules at once, only the files in the 'ArmPkg', 'ArmPlatformPkg' and 'ArmVirtPkg' directories were modified this time. Dongdong Zhang

[edk2-devel] Access non-SMRAM memory regions from SMM

2022-12-06 Thread asallan3
Hi, I'm aware theres been implemented a PCD `gUefiCpuPkgTokenSpaceGuid.PcdCpuSmmRestrictedMemoryAccess` that blocks access to "any" type of non-SMRAM memory after SmmReadyToLock. But I ran some tests and found out I can access some memory regions outside SMRAM, like address 0xFFFD0 for instance

[edk2-devel] [PATCH 3/3] ArmVirtPkg: Fix typos

2022-12-06 Thread Dongdong Zhang
Fix some typos in ArmVirtPkg directory. Signed-off-by: Dongdong Zhang --- ArmVirtPkg/ArmVirt.dsc.inc | 2 +- .../Library/CloudHvVirtMemInfoLib/CloudHvVirtMemInfoLib.c | 2 +- ArmVirtPkg/Library/QemuVirtMemInfoLib/QemuVirtMemInfoLib.c | 2 +- 3 file

[edk2-devel] [PATCH 2/3] ArmPlatformPkg: Fix typos

2022-12-06 Thread Dongdong Zhang
Fix some typos in ArmPlatformPkg directory. Signed-off-by: Dongdong Zhang --- ArmPlatformPkg/ArmPlatformPkg.dec | 2 +- ArmPlatformPkg/Include/Library/LcdPlatformLib.h | 2 +- ArmPlatformPkg/Library/ArmMaliDp/ArmMaliDp.c| 2 +- ArmPlatformPkg/Library/PL111Lcd/PL111Lcd.c |

[edk2-devel] [PATCH] Maintainer.txt: add myself as reviewer for bhyve's OvmfPkg

2022-12-06 Thread Corvin Köhne
Signed-off-by: Corvin Köhne Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Cc: devel@edk2.groups.io --- Maintainers.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Maintainers.txt b/Maintainers.txt index 7e98083685..3ea9a4cca6 100644 --- a/Maintainers.txt +++ b/Maintainers.txt

[edk2-devel] [PATCH 1/3] ArmPkg: Fix typos

2022-12-06 Thread Dongdong Zhang
Fix some typos in ArmPkg directory. Signed-off-by: Dongdong Zhang --- ArmPkg/Drivers/ArmScmiDxe/ScmiDxe.c | 2 +- ArmPkg/Include/Library/OemMiscLib.h | 2 +- ArmPkg/Library/ArmDisassemblerLib/ThumbDisassembler.c | 6 +++--- ArmPkg/Library/Arm

[edk2-devel] [PATCH v2] Maintainer.txt: add myself as reviewer for bhyve's OvmfPkg

2022-12-06 Thread Corvin Köhne
Signed-off-by: Corvin Köhne Reviewed-by: Rebecca Cran Reviewed-by: Peter Grehan Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Cc: devel@edk2.groups.io --- Maintainers.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Maintainers.txt b/Maintainers.txt index 7e98083685..3ea9a4cc

[edk2-devel] [edk2-platform][PATCH 1/1] MdeModulePkg: SdMmcPciHcDxe: Fix issue that SD1.0 cards can't be recognized

2022-12-06 Thread Chevron Li
From: "Chevron Li (WH)" SD1.0 cards don't support CMD8 and CMD6 CMD8 result can be used to distinguish the card is SD1.0 or not. CMD8 result can be used to decide following CMD6 is sent or skip. Cc: Hao A Wu Cc: Ray Ni Cc: Jian J Wang Cc: Liming Gao Signed-off-by: Chevron Li ---

[edk2-devel] 回复: [edk2-platform][PATCH 1/1] MdeModulePkg: SdMmcPciHcDxe: Fix issue that SD1.0 cards can't be recognized

2022-12-06 Thread Chevron Li (WH)
Thanks for your response. I will update patch later according to your suggestions. Answer your questions below. BR, Chevron > -邮件原件- > 发件人: Wu, Hao A > 发送时间: Tuesday, December 6, 2022 16:28 > 收件人: Chevron Li (WH) ; > devel@edk2.groups.io > 抄送: Ni, Ray ; Wang, Jian J ; Gao, > Liming ; S

Re: [edk2-devel] [PATCH v4 1/1] MdePkg/BaseRngLib: Add a smoketest for RDRAND and check CPUID

2022-12-06 Thread Pedro Falcato
Hi, Ping. Is there a blocker here? Pedro -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#97028): https://edk2.groups.io/g/devel/message/97028 Mute This Topic: https://groups.io/mt/95207204/21656 Group Owner: devel+ow...@edk2.groups.io Un

[edk2-devel] [PATCH v1 0/5] Adds AmdSmmCpuFeaturesLib

2022-12-06 Thread Abdul Lateef Attar via groups.io
Implements SmmCpuFeaturesLib library class for AMD processor family. Adds AMD processor families processor save state registers. Implements required functions. Handles S3 save state from SMM. PR: https://github.com/tianocore/edk2/pull/3726 Cc: Paul Grimes Cc: Garrett Kirkendall Cc: Abner Chang

[edk2-devel] [PATCH v1 1/5] UefiCpuPkg/SmmCpuFeaturesLib: Restructure arch-dependent code

2022-12-06 Thread Abdul Lateef Attar via groups.io
From: Abdul Lateef Attar BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 moves Intel-specific code to the arch-dependent file. Other processor families might have different implementation of these functions. Hence, moving out of the common file. Cc: Abner Chang Cc: Garrett Kirkendall

[edk2-devel] [PATCH v1 3/5] UefiCpuPkg: Initial implementation of AMD's SmmCpuFeaturesLib

2022-12-06 Thread Abdul Lateef Attar via groups.io
From: Abdul Lateef Attar BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 Adds initial defination for AMD's SmmCpuFeaturesLib library implementation. All function's body either empty or just returns value. Its initial skeleton of library implementation. Cc: Paul Grimes Cc: Garrett Kirke

[edk2-devel] [PATCH v1 5/5] UefiCpuPkg/AmdSmmCpuFeaturesLib: Handles S3 save state

2022-12-06 Thread Abdul Lateef Attar via groups.io
From: Abdul Lateef Attar BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 Handles S3 save state restore condition. Implements SmmCpuFeaturesCompleteSmmReadyToLock() to sync all processor and update S3 resume entry point. Cc: Paul Grimes Cc: Garrett Kirkendall Cc: Abner Chang Cc: Eric

[edk2-devel] [PATCH v1 4/5] UefiCpuPkg: Implements SmmCpuFeaturesLib for AMD Family

2022-12-06 Thread Abdul Lateef Attar via groups.io
From: Abdul Lateef Attar BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4182 Implements interfaces to read and write save state registers of AMD's processor family. Initializes processor SMMADDR and MASK depends on PcdSmrrEnable flag. Program or corrects the IP once control returns from SMM.

[edk2-devel] [PATCH v2 0/1] MdeModulePkg: Put USB DEBUGs that occur for bulk timeouts under VERBOSE

2022-12-06 Thread Rebecca Cran
*Changes between v1 and v2* Only switch to DEBUG_VERBOSE for EFI_TIMEOUT errors. Test Pull Request: https://github.com/tianocore/edk2/pull/3705 --- MdeModulePkg: Put USB DEBUGs that occur for bulk timeouts under VERBOSE With the pending commit of UsbNetworkPkg, it will become common for Us

[edk2-devel] [PATCH v2 1/1] MdeModulePkg: Put USB DEBUGs that occur for bulk timeouts under VERBOSE

2022-12-06 Thread Rebecca Cran
With the pending commit of UsbNetworkPkg, it will become common for UsbBulkTransfer calls to timeout, given that the drivers are called from MnpSystemPoll every MNP_SYS_POLL_INTERVAL milliseconds: the drivers check for network packets by calling UsbBulkTransfer with a timeout of 1ms. Avoid console

Re: [edk2-devel] [Patch 1/1] RedfishPkg: Remove overlapping private include path in DEC file

2022-12-06 Thread Igor Kulchytskyy via groups.io
Reviewed-by: Igor Kulchytskyy mailto:abner.ch...@amd.com>> Get Outlook for Android From: Chang, Abner Sent: Tuesday, December 6, 2022 3:23:56 AM To: Michael D Kinney ; devel@edk2.groups.io Cc: Nickle Wang ; Igor Kulchytskyy Subject: [EXT

Re: [edk2-devel] [Patch 1/2] OvmfPkg: Change default to disable MptScsi and PvScsi

2022-12-06 Thread dann frazier
On Tue, Dec 06, 2022 at 06:56:49AM +0100, Gerd Hoffmann wrote: > On Mon, Dec 05, 2022 at 04:36:15PM -0700, dann frazier wrote: > > On Tue, Jul 26, 2022 at 12:46:39PM -0700, Michael D Kinney wrote: > > > The email addresses for the reviewers of the MptScsi and > > > PvScsi are no longer valid. Disa

Re: [edk2-devel] [Patch 1/2] OvmfPkg: Change default to disable MptScsi and PvScsi

2022-12-06 Thread Mike Maslenkin
Greetings All! As I can see LSI_SCSI_ENABLE related to LSI LSI_53C895A_PCI_DEVICE_ID Vid/Did 0x1000:0x0012. I guess it is some old Megaraid adapter. A patch mentioned above set MPT_SCSI_ENABLE=FALSE, that removed support for LSI 53C1030 and SAS1068. These SCSI controllers were emulated by VMwar

[edk2-devel] MdeModulePkg/UefiBootManagerLib: Use hob size to process MemoryTypeInfo

2022-12-06 Thread Anbazhagan, Baraneedharan via groups.io
Current code relies on last entry in hob to be MaxMemoryType enum value which keeps changing on new memory type definition. If the HOB is created by binaries built with older Edk2, current code leads to hang which could be avoided by using hob size. Signed-off-by: Baraneedharan Anbazhagan anbazha

Re: [edk2-devel] [PATCH v4] NetworkPkg/WifiProfileSync: Add WiFi profile sync protocol support

2022-12-06 Thread Clark-williams, Zachary
Hey Maciej and All, Is there any update in ability to review this patch for Wifi Profile Sync Protocol and Wifi Connection Manager? Thank you, Zack -Original Message- From: devel@edk2.groups.io On Behalf Of Clark-williams, Zachary Sent: Wednesday, November 2, 2022 8:58 AM To: Rabeda,

Re: [edk2-devel] [PATCH v4] NetworkPkg/WifiProfileSync: Add WiFi profile sync protocol support

2022-12-06 Thread Clark-williams, Zachary
++ Michal's coverage Michal and Lukasz -Original Message- From: Clark-williams, Zachary Sent: Tuesday, December 6, 2022 10:38 AM To: devel@edk2.groups.io; Clark-williams, Zachary ; Rabeda, Maciej ; Zimmer, Vincent ; Luo, Heng ; Kuo, Scottie ; Kuo, Ted ; Dutkiewicz, Michal ; Wu, Jiaxi

回复: [edk2-devel] feature flag change notifications

2022-12-06 Thread gaoliming via groups.io
Dann: I base on new features to collect the incompatible changes, and add them into the updated notes. If you find any missing, please send the mail to me. Thanks Liming > -邮件原件- > 发件人: Kinney, Michael D > 发送时间: 2022年12月6日 9:22 > 收件人: devel@edk2.groups.io; dann.fraz...@canonical.c

回复: [edk2-devel] [PATCH] MdePkg/UnitTestHostBaseLib: Remove HOST_APPLICATION limitation

2022-12-06 Thread gaoliming via groups.io
Zhiguang and Ray: Thanks for your sharing. It is OK to use UnitTestHostBaseLib in emulator platform. Please also update the file header in module inf to describe this usage. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Zhiguang Liu > 发送时间: 2022年12月5日 13:53 > 收件人: Ni, Ray ;

[edk2-devel] 回复: [PATCH] MdePkg: Update new Form Browser Action Request

2022-12-06 Thread gaoliming via groups.io
Robert: Will you also update SetupBrowser to support this new action? Thanks Liming > -邮件原件- > 发件人: Robert Phelps > 发送时间: 2022年11月9日 4:13 > 收件人: devel@edk2.groups.io > 抄送: michael.d.kin...@intel.com; gaolim...@byosoft.com.cn; > zhiguang@intel.com > 主题: [PATCH] MdePkg: Update new For

Re: [edk2-devel] [PATCH v2 1/1] MdeModulePkg: Put USB DEBUGs that occur for bulk timeouts under VERBOSE

2022-12-06 Thread Wu, Hao A
Reviewed-by: Hao A Wu Will wait a couple of days before merging to see if comments from other reviewers. Best Regards, Hao Wu > -Original Message- > From: Rebecca Cran > Sent: Tuesday, December 6, 2022 10:31 PM > To: devel@edk2.groups.io; Gao, Liming ; Ni, > Ray ; Wang, Jian J ; Wu, Ha

[edk2-devel] 回复: [edk2][PATCH 0/2] Add Events introduced in UEFI 2.9

2022-12-06 Thread gaoliming via groups.io
Robert: EFI_EVENT_GROUP_AFTER_READY_TO_BOOT should be trig in Edk2\MdeModulePkg\Library\UefiBootManagerLib like ReadyToBoot event. Thanks Liming > -邮件原件- > 发件人: Kinney, Michael D > 发送时间: 2022年11月9日 6:45 > 收件人: devel@edk2.groups.io; rob...@ami.com; Kinney, Michael D > > 抄送: Gao, Limin

Re: [edk2-devel] [PATCH] MdePkg/UnitTestHostBaseLib: Remove HOST_APPLICATION limitation

2022-12-06 Thread Zhiguang Liu
Hi Liming, Sure, I will update the patch Thanks Zhiguang > -Original Message- > From: devel@edk2.groups.io On Behalf Of > gaoliming via groups.io > Sent: Wednesday, December 7, 2022 9:02 AM > To: devel@edk2.groups.io; Liu, Zhiguang ; Ni, Ray > > Cc: Kinney, Michael D > Subject: 回复: [ed

Re: [edk2-devel] feature flag change notifications

2022-12-06 Thread dann frazier
Hi Mike, Thanks for the consideration. I think the release notes are a sufficient starting point. -dann On Mon, Dec 5, 2022 at 6:22 PM Kinney, Michael D wrote: > > Hi Dann, > > These are reasonable requests. > > Adding Liming Gao who is currently responsible for the edk2 releases. > > Let's

Re: [edk2-devel] feature flag change notifications

2022-12-06 Thread dann frazier
Hi Liming, Thank you, that is appreciated. Going forward I'll let you know if I trip over any not already documented. -dann On Tue, Dec 6, 2022 at 5:59 PM gaoliming via groups.io wrote: > > Dann: > I base on new features to collect the incompatible changes, and add them > into the update

回复: [edk2-devel] [PATCH v2 4/4] MdePkg: Signal AfterReadyToBoot after ReadyToBoot

2022-12-06 Thread gaoliming via groups.io
Dionna: I add my comments below. > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Dionna Glaze > via groups.io > 发送时间: 2022年11月9日 5:16 > 收件人: devel@edk2.groups.io > 抄送: Dionna Glaze ; Michael D Kinney > ; Ard Biesheuvel ; Gerd > Hoffman ; Jiewen Yao > 主题: [edk2-devel] [PATCH v2 4/4] MdePkg: Si

回复: [edk2-devel] [PATCH v7 1/2] tools_def: remove GCC_IA32_CC_FLAGS/GCC_X64_CC_FLAGS

2022-12-06 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Gerd > Hoffmann > 发送时间: 2022年11月30日 17:44 > 收件人: devel@edk2.groups.io > 抄送: Alexey Kardashevskiy ; Liming Gao > ; Erdem Aktas ; > Pawel Polawski ; Jordan Justen > ; Ard Biesheuvel ; > Yuwei Chen ; Tom Lendacky > ; James Bott

回复: [edk2-devel] [PATCH v7 2/2] tools_def: add -fno-omit-frame-pointer to GCC48_{IA32,X64}_CC_FLAGS

2022-12-06 Thread gaoliming via groups.io
Gerd: I have no comments for this change. Acked-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Brian J. > Johnson > 发送时间: 2022年12月2日 0:18 > 收件人: devel@edk2.groups.io; kra...@redhat.com > 抄送: Alexey Kardashevskiy ; Liming Gao > ; Erdem Aktas ; > Pawel Polawski ; J

[edk2-devel] [PATCH v2] MdePkg/UnitTestHostBaseLib: Remove HOST_APPLICATION limitation

2022-12-06 Thread Zhiguang Liu
Remove HOST_APPLICATION limitation for UnitTestHostBaseLib, so that this library can be used as BaseLib by Emulator. Also, add some missing files Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Ray Ni Signed-off-by: Zhiguang Liu --- MdePkg/Library/BaseLib/UnitTestHostBaseLib.inf | 9 ++

回复: [edk2-devel] [PATCH 1/1] MdePkg: Fix typos and spacing in Library/PerformanceLib.h

2022-12-06 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Rebecca Cran > 发送时间: 2022年11月29日 20:23 > 收件人: devel@edk2.groups.io; Michael D Kinney > ; Liming Gao ; > Zhiguang Liu > 抄送: Rebecca Cran > 主题: [edk2-devel] [PATCH 1/1] MdePkg: Fix typos and spacing in > Library/PerformanceL

回复: [edk2-devel] [PATCH 1/1] MdePkg: Fix typo of EFI_INVALID_PARAMETER in Protocol/UsbIo.h

2022-12-06 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Rebecca Cran > 发送时间: 2022年11月29日 20:27 > 收件人: devel@edk2.groups.io; Michael D Kinney > ; Liming Gao ; > Zhiguang Liu > 抄送: Rebecca Cran > 主题: [edk2-devel] [PATCH 1/1] MdePkg: Fix typo of > EFI_INVALID_PARAMETER in Protocol

Re: [edk2-devel] [edk2-platform][PATCH V2 1/1] MdeModulePkg: SdMmcPciHcDxe: Fix issue that SD1.0 cards can't be recognized

2022-12-06 Thread Wu, Hao A
Sorry, The proposed patch still causes CI test failure: https://github.com/tianocore/edk2/pull/3724. Could you help to follow steps 10 and 11 in the below wiki page: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process#the-developer-process-for-the-edk-ii-project to m

回复: [edk2-devel] [PATCH v4 1/1] MdePkg/BaseRngLib: Add a smoketest for RDRAND and check CPUID

2022-12-06 Thread gaoliming via groups.io
Pedro: To keep the same behavior, I suggest to only update BaseRngLibConstructor() API with TestRdRand, don't touch other APIs. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Pedro Falcato > 发送时间: 2022年11月23日 6:31 > 收件人: devel@edk2.groups.io > 抄送: Pedro Falcato ; Michael D Kinney

回复: [edk2-devel] [PATCH ovmf 1/5] MdePkg/Register/Amd: Define all bits from MSR_SEV_STATUS_REGISTER

2022-12-06 Thread gaoliming via groups.io
Alexey: > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Alexey > Kardashevskiy via groups.io > 发送时间: 2022年12月1日 10:35 > 收件人: devel@edk2.groups.io > 抄送: Ard Biesheuvel ; Jiewen Yao > ; Jordan Justen ; Gerd > Hoffmann ; Brijesh Singh ; > Erdem Aktas ; James Bottomley > ; Min Xu ; Tom Lendacky > ;

Re: [edk2-devel] [PATCH 4/4] MdeModulePkg/UsbBusDxe: Adjust the MaxPacketLength to real world values

2022-12-06 Thread Wu, Hao A
I have concern for this patch. It will make the implementation of XhcControlTransfer() no longer following the UEFI specification requirements on the EFI_USB2_HC_PROTOCOL.ControlTransfer() service: Section 17.1.7 of UEFI spec Release 2.10: EFI_INVALID_PARAMETER is returned if one of the fo

Re: [edk2-devel] [PATCH 3/4] MdeModulePkg/BmBoot: Skip removable media if it is not present

2022-12-06 Thread Wu, Hao A
Hello, Could you help to co-work with BDS modules reviewers for reviewing this patch? py BaseTools/Scripts/GetMaintainer.py 294ce61c3b1a63c89bd16a78f8e8b40e889dac5a MdeModulePkg/Library/UefiBootManagerLib/BmBoot.c Jian J Wang Liming Gao Zhichao Gao Ray Ni devel@edk2.groups.io Best

回复: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] FW: [PATCH] ShellPkg: Displaying SMBIOS Type38 fields in formatted manner

2022-12-06 Thread gaoliming via groups.io
Prakash: Please update the commit message title that should start with package name. The code logic looks good. Thanks Liming 发件人: devel@edk2.groups.io 代表 Prakash K via groups.io 发送时间: 2022年12月5日 14:28 收件人: Prakash K ; devel@edk2.groups.io 主题: Re: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-

Re: [edk2-devel] [Patch 1/1] RedfishPkg: Remove overlapping private include path in DEC file

2022-12-06 Thread Nickle Wang via groups.io
Reviewed-by: Nickle Wang Regards, Nickle From: devel@edk2.groups.io On Behalf Of Igor Kulchytskyy via groups.io Sent: Tuesday, December 6, 2022 10:32 PM To: Chang, Abner ; Michael D Kinney ; devel@edk2.groups.io Cc: Nickle Wang Subject: Re: [edk2-devel] [Patch 1/1] RedfishPkg: Remove overlap

Re: [edk2-devel] [PATCH v4 1/1] MdePkg/BaseRngLib: Add a smoketest for RDRAND and check CPUID

2022-12-06 Thread Pedro Falcato
> Pedro: > To keep the same behavior, I suggest to only update > BaseRngLibConstructor() API with TestRdRand, don't touch other APIs. Liming, the point is to fix the library's broken behavior, as previously discussed in the ML, and documented in the commit message and the bugzilla. Only updating

Re: [edk2-devel] [PATCH v2 4/4] MdePkg: Signal AfterReadyToBoot after ReadyToBoot

2022-12-06 Thread Dionna Glaze via groups.io
On Tue, Dec 6, 2022 at 5:26 PM gaoliming wrote: > > Dionna: > I add my comments below. > > > -邮件原件- > > 发件人: devel@edk2.groups.io 代表 Dionna Glaze > > via groups.io > > 发送时间: 2022年11月9日 5:16 > > 收件人: devel@edk2.groups.io > > 抄送: Dionna Glaze ; Michael D Kinney > > ; Ard Biesheuvel ; Gerd

[edk2-devel] [PATCH 1/1] OvmfPkg/PlatformInitLib: pass through reservations from qemu

2022-12-06 Thread Gerd Hoffmann
qemu uses the etc/e820 fw_cfg file not only for memory, but also for reservations. Handle reservations by adding resource descriptor hobs for them. A typical qemu configuration has a small reservation between lapic and flash: # sudo cat /proc/iomem [ ... ] fee0-fee00fff : Local APIC

Re: [edk2-devel] [Patch 1/2] OvmfPkg: Change default to disable MptScsi and PvScsi

2022-12-06 Thread Gerd Hoffmann
Hi, > A patch mentioned above set MPT_SCSI_ENABLE=FALSE, that removed > support for LSI 53C1030 and SAS1068. > These SCSI controllers were emulated by VMware, Parallels and I guess > VitualBox. > This is generic setup for VMware VMs, as far as I remember. > So the booting of such VMs (probably