Gerd:
I have no comments for this change. Acked-by: Liming Gao
<gaolim...@byosoft.com.cn>
Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Brian J.
> Johnson
> 发送时间: 2022年12月2日 0:18
> 收件人: devel@edk2.groups.io; kra...@redhat.com
> 抄送: Alexey Kardashevskiy <a...@ozlabs.ru>; Liming Gao
> <gaolim...@byosoft.com.cn>; Erdem Aktas <erdemak...@google.com>;
> Pawel Polawski <ppola...@redhat.com>; Jordan Justen
> <jordan.l.jus...@intel.com>; Ard Biesheuvel <ardb+tianoc...@kernel.org>;
> Yuwei Chen <yuwei.c...@intel.com>; Tom Lendacky
> <thomas.lenda...@amd.com>; James Bottomley <j...@linux.ibm.com>;
> Oliver Steffen <ostef...@redhat.com>; Jiewen Yao <jiewen....@intel.com>;
> Min Xu <min.m...@intel.com>; Brijesh Singh <brijesh.si...@amd.com>; Bob
> Feng <bob.c.f...@intel.com>
> 主题: Re: [edk2-devel] [PATCH v7 2/2] tools_def: add
> -fno-omit-frame-pointer to GCC48_{IA32,X64}_CC_FLAGS
>
> OK. Doesn't look like a big impact.
>
> Thanks,
> Brian J. Johnson
> -------- Original Message --------
> From: Gerd Hoffmann [mailto:kra...@redhat.com]
> Sent: Thursday, December 1, 2022 at 2:38 AM
> To: Brian J. Johnson <brian.john...@hpe.com>
> Cc: devel@edk2.groups.io, Alexey Kardashevskiy <a...@ozlabs.ru>, Liming
> Gao <gaolim...@byosoft.com.cn>, Erdem Aktas <erdemak...@google.com>,
> Pawel Polawski <ppola...@redhat.com>, Jordan Justen
> <jordan.l.jus...@intel.com>, Ard Biesheuvel <ardb+tianoc...@kernel.org>,
> Yuwei Chen <yuwei.c...@intel.com>, Tom Lendacky
> <thomas.lenda...@amd.com>, James Bottomley <j...@linux.ibm.com>,
> Oliver
> Steffen <ostef...@redhat.com>, Jiewen Yao <jiewen....@intel.com>, Min Xu
> <min.m...@intel.com>, Brijesh Singh <brijesh.si...@amd.com>, Bob Feng
> <bob.c.f...@intel.com>
> Subject: [edk2-devel] [PATCH v7 2/2] tools_def: add
> -fno-omit-frame-pointer to GCC48_{IA32,X64}_CC_FLAGS
>
> On Wed, Nov 30, 2022 at 01:28:42PM -0600, Brian J. Johnson wrote:
> > Gerd,
> >
> > Sorry, gotta ask: does this make much difference in the size of the
> > compiled code? That's a constraint on many real-hardware X64 platforms,
> > especially for 32-bit code.
>
> Quick test with OvmfPkg/OvmfPkgIa32X64.dsc (sec/pei ia32, dxe x64):
>
> master branch:
>
> FV Space Information
> SECFV [11%Full] 212992 (0x34000) total, 23728 (0x5cb0) used, 189264
> (0x2e350) free
> PEIFV [34%Full] 917504 (0xe0000) total, 319416 (0x4dfb8) used, 598088
> (0x92048) free
> DXEFV [49%Full] 12582912 (0xc00000) total, 6268032 (0x5fa480) used,
> 6314880 (0x605b80) free
> FVMAIN_COMPACT [98%Full] 1753088 (0x1ac000) total, 1725328 (0x1a5390)
> used, 27760 (0x6c70) free
>
> with patch applied:
>
> FV Space Information
> SECFV [11%Full] 212992 (0x34000) total, 23728 (0x5cb0) used, 189264
> (0x2e350) free
> PEIFV [34%Full] 917504 (0xe0000) total, 319416 (0x4dfb8) used, 598088
> (0x92048) free
> DXEFV [50%Full] 12582912 (0xc00000) total, 6335936 (0x60adc0) used,
> 6246976 (0x5f5240) free
> FVMAIN_COMPACT [99%Full] 1753088 (0x1ac000) total, 1738176 (0x1a85c0)
> used, 14912 (0x3a40) free
>
> So slightly more for 64-bit code.
>
> take care,
> Gerd
>
>
>
>
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#97053): https://edk2.groups.io/g/devel/message/97053
Mute This Topic: https://groups.io/mt/95507700/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
