Re: [edk2-devel] [PATCH v1] From: Mateusz Mówka Subject: [edk2-libc] Add strnlen function wrapper

Hi, I'd like to know what's the status of the review? Mateusz -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#96728): https://edk2.groups.io/g/devel/message/96728 Mute This Topic: https://groups.io/mt/92932922/21656 Group Owner: devel+ow..

[edk2-devel] [PATCH v7 2/2] tools_def: add -fno-omit-frame-pointer to GCC48_{IA32,X64}_CC_FLAGS

Fixes problems due to code assuming it runs with frame pointers and thus updates rbp / ebp registers when switching stacks. Signed-off-by: Gerd Hoffmann --- BaseTools/Conf/tools_def.template | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/BaseTools/Conf/tools_def.template

[edk2-devel] [PATCH v7 0/2] Fix stack switching.

Gerd Hoffmann (2): tools_def: remove GCC_IA32_CC_FLAGS/GCC_X64_CC_FLAGS tools_def: add -fno-omit-frame-pointer to GCC48_{IA32,X64}_CC_FLAGS BaseTools/Conf/tools_def.template | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) -- 2.38.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links:

[edk2-devel] [PATCH v7 1/2] tools_def: remove GCC_IA32_CC_FLAGS/GCC_X64_CC_FLAGS

They are not used anywhere. Remove them. Signed-off-by: Gerd Hoffmann --- BaseTools/Conf/tools_def.template | 2 -- 1 file changed, 2 deletions(-) diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template index c4e4c7ded0af..73f95b2a3a9f 100755 --- a/BaseTools/Conf/to

[edk2-devel] [edk2-platforms][PATCH V2 1/1] Silicon/ARM/NeoverseN1Soc: Update CCIX PNP ID

There is no need for a separate ID for CCIX host bridge, therefore reusing PCIe PNP ID for CCIX. Signed-off-by: sahil --- Notes: v2: - removed licence fix, to be pushed separately [Leif Lindholm] Silicon/ARM/NeoverseN1Soc/Library/PciHostBridgeLib/PciHostBridgeLib.c | 4 ++-- 1 file cha

Re: [edk2-devel] [edk2-platforms][PATCH V2 1/1] Silicon/ARM/NeoverseN1Soc: Update CCIX PNP ID

Acked-by: Samer El-Haj-Mahmoud > -Original Message- > From: devel@edk2.groups.io On Behalf Of sahil via > groups.io > Sent: Wednesday, November 30, 2022 5:29 AM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Leif Lindholm > ; Sami Mujawar ; Sahil > > Subject: [edk2-devel] [edk2-platf

[edk2-devel] Event: TianoCore edk2-test Bug Triage Meeting - Thursday, December 1, 2022 #cal-reminder

*Reminder: TianoCore edk2-test Bug Triage Meeting* *When:* Thursday, December 1, 2022 10:00pm to 11:00pm (UTC+08:00) Asia/Shanghai *Where:* https://armltd.zoom.us/j/91247522013?pwd=ei9nUndTbG9oWEROS2M1aVREZkpiQT09&from=addon *Organizer:* Edhaya Chandran edhaya.chand...@arm.com ( edhaya.chand...

Re: [edk2-devel] [PATCH v7 1/6] CI: make Python version configurable

This distributes the Python version (as a default value) across several files - ">=3.10.6". For maintainability, we'd like to manage versioning more centrally to reduce likelihood of misses on updates. You could potentially adjust it such that the default does not specify a version, put the Py

[edk2-devel] [PATCH v1 1/1] CryptPkg: Enable CryptoPkg BaseCryptLib ParallelHash for PEI and DXE

From: Zhihao Li REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4097 The BaseCryptLib in the CryptoPkg currently supports ParallelHash algorithm for SMM. The MP Services PPI and MP Services Protocol could be used to enable ParallelHash in PEI and DXE versions of the BaseCryptLib. Cc: Jiewen

[edk2-devel] [edk2-staging][PATCH] edk2-staging/RedfishClientPkg: Fix GCC build error

Fix below GCC build error: 1) "Head" dereference issue. 2) "BooleanArrayBuffer" uninitialized variable issue. 3) Multiple definition of mRedfishVariableGuid. 4) Multiple definition of medfishResourceConfigProtocolHandle. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick R

[edk2-devel] [PATCH] MdeModulePkg/RegularExpressionDxe: Fix GCC build error

Fix GCC build error on AARCH64 system. Signed-off-by: Nickle Wang Cc: Jian J Wang Cc: Liming Gao Cc: Nick Ramirez --- .../Universal/RegularExpressionDxe/OnigurumaUefiPort.h | 5 + 1 file changed, 5 insertions(+) diff --git a/MdeModulePkg/Universal/RegularExpressionDxe/OnigurumaUefi

[edk2-devel] [edk2-staging][PATCH] edk2-staging/RedfishClientPkg: Fix typo

Fix typo in RedfishPlatformConfigImpl.c Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/RedfishPkg/RedfishPlatformConfigDxe

Re: [edk2-devel] [PATCH] MdeModulePkg/RegularExpressionDxe: Fix GCC build error

Hi, I see the following pattern in the RedfishPkg to cover all CPUs #if defined (MDE_CPU_X64) || defined (MDE_CPU_AARCH64) || defined (MDE_CPU_RISCV64) // // With GCC we would normally use SIXTY_FOUR_BIT_LONG, but MSVC needs // SIXTY_FOUR_BIT, because 'long' is 32-bit and only '

Re: [edk2-devel] [PATCH v7 1/6] CI: make Python version configurable

Hi Michael On Wed, Nov 30, 2022 at 3:13 PM Michael Kubacki wrote: > > This distributes the Python version (as a default value) across several > files - ">=3.10.6". For maintainability, we'd like to manage versioning > more centrally to reduce likelihood of misses on updates. > > You could potenti

Re: [edk2-devel] [PATCH v7 0/6] CI: Use Fedora 35 container for Linux jobs

Sean, Quoting Sean Brogan (2022-11-30 01:28:45) > Oliver, > > Thanks for this changeset and i think this is getting closer but over the past > few months there have been a few changes that I don't think this series takes > into account. > > A few comments i hope we can address quickly (since 18.0

[edk2-devel] [PATCH] ShellPkg/AcpiView: ERST Parser

Add a new parser for the Error Record Serialization Table. The ERST table describes how an OS can save and retrieve hardware error information to and from a persistent store. Signed-off-by: Jeshua Smith --- .../UefiShellAcpiViewCommandLib/AcpiParser.h | 22 ++ .../Parsers/Erst/ErstParse

[edk2-devel] TFTP download of 1.7 MB file generates 20GB Traffic under imperfect network conditions

Hi Team, I'm reaching out to you since I want to share an observation we have made while doing PXE boot of client notebooks. One of the first steps while doing Network Boot is to download an image by TFTP. This image has a size of 1.7 MB. While the client is downloading this we have observed 1Gbit/

Re: [edk2-devel] [PATCH v7 2/2] tools_def: add -fno-omit-frame-pointer to GCC48_{IA32,X64}_CC_FLAGS

Gerd, Sorry, gotta ask: does this make much difference in the size of the compiled code? That's a constraint on many real-hardware X64 platforms, especially for 32-bit code. Brian J. Johnson Original Message From: Gerd Hoffmann [mailto:kra...@redhat.com] Sent: Wednesday,

[edk2-devel] [PATCH v8 00/12] CI: Use Fedora 35 container for Linux jobs

Update CI, run all Linux (aka Ubuntu-GCC5) based jobs in custom containers. This decouples the CI environment from the virtual machine images that Azure DevOps provides. The currently used ubuntu-18.04 image has been deprecated for a while now and will finally be removed on Dec 1st 2022. The con

[edk2-devel] [PATCH v8 05/12] CI: Allow running in a container.

Add a parameter of the pr-gate-build-job template to specify a container image URL. If the value is not '' (default), then the jobs will be run inside a container based on that image. Signed-off-by: Oliver Steffen --- .azurepipelines/templates/pr-gate-build-job.yml | 4 1 file changed, 4 i

[edk2-devel] [PATCH v8 02/12] OvmfPkg: CI: use Python version from defaults template

Use the default Python version from the defaults template (.azurepipelines/templates/defaults.yml) in the Windows CI jobs. Previous changes to the CI job templates make it necessary to specify a version number, if Python shall be pulled at CI runtime. The Linux CI jobs will use Python from the co

[edk2-devel] [PATCH v8 03/12] EmulatorPkg: CI: use Python version from defaults template

Use the default Python version from the defaults template (.azurepipelines/templates/defaults.yml) in the Windows CI jobs. Previous changes to the CI job templates make it necessary to specify a version number, if Python shall be pulled at CI runtime. The Linux CI jobs will use Python from the co

[edk2-devel] [PATCH v8 07/12] ArmVirtPkg: CI: Use Fedora 35 container (Linux only)

Run all Linux based jobs in a container, using a custom Fedora 35 image (gcc 11). The image is hosted on ghcr.io and the Dockerfiles are here: https://github.com/tianocore/containers The version numbers of gcc, iasl, and nasm are pinned to avoid unintended upgrades during image rebuild. Do not run

[edk2-devel] [PATCH v8 01/12] CI: make Python version configurable

Add a new parameter "usePythonVersion" to the CI job templates. This makes it possible to specify the version of Python to use. The default value is '', in which case Python will not be downloaded at runtime and the one provided by the VM/container image will be used. Additionally, add a template

[edk2-devel] [PATCH v8 08/12] OvmfPkg: CI: Use Fedora 35 container (Linux only)

Run all Linux based jobs in a container, using a custom Fedora 35 image (gcc 11). The image is hosted on ghcr.io and the Dockerfiles are here: https://github.com/tianocore/containers The version numbers of gcc, iasl, and nasm are pinned to avoid unintended upgrades during image rebuild. Do not run

[edk2-devel] [PATCH v8 04/12] CI: add ~/.local/bin to PATH (Linux only)

Fix pip install under certain conditions. Signed-off-by: Oliver Steffen --- .azurepipelines/templates/platform-build-run-steps.yml | 6 ++ .azurepipelines/templates/pr-gate-steps.yml| 6 ++ 2 files changed, 12 insertions(+) diff --git a/.azurepipelines/templates/platform-bui

[edk2-devel] [PATCH v8 06/12] BaseTools: CI: Use Fedora 35 container (Linux only)

Run all Linux based jobs in a container, using a custom Fedora 35 image (gcc 11). The image is hosted on ghcr.io and the Dockerfiles are here: https://github.com/tianocore/containers The version numbers of gcc, iasl, and nasm are pinned to avoid unintended upgrades during image rebuild. Do not run

[edk2-devel] [PATCH v8 09/12] EmulatorPkg: CI: Use Fedora 35 container (Linux only)

Run all Linux based jobs in a container, using a custom Fedora 35 image (gcc 11). The image is hosted on ghcr.io and the Dockerfiles are here: https://github.com/tianocore/containers The version numbers of gcc, iasl, and nasm are pinned to avoid unintended upgrades during image rebuild. Use Python

[edk2-devel] [PATCH v8 12/12] CI: use latest vm_image (Linux only)

Switch over to `ubuntu-latest` as the vm_image for Linux CI jobs (EmulatorPkg, ArmVirtPkg, OvmfPkg). The previously used ubuntu-18.04 will not be available after Dec 1st 2022. Signed-off-by: Oliver Steffen --- ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 2 +- EmulatorPkg/PlatformCI/

[edk2-devel] [PATCH v8 11/12] .pytool: CISettings.py: don't add scopes for GCC

All ext_dep.yml files for gcc have been removed and gcc is expected to be installed on the system (GCC5_*_PREFIX may indicate the location). No need to adjust the toolchain scopes for Linux builds anymore. Signed-off-by: Oliver Steffen --- .pytool/CISettings.py | 9 - 1 file changed, 9 d

[edk2-devel] [PATCH v8 10/12] CI: Don't install cspell

cspell is already included in the container image. Signed-off-by: Oliver Steffen --- .azurepipelines/templates/spell-check-prereq-steps.yml | 4 1 file changed, 4 deletions(-) diff --git a/.azurepipelines/templates/spell-check-prereq-steps.yml b/.azurepipelines/templates/spell-check-prereq

Re: [edk2-devel] [PATCH v8 12/12] CI: use latest vm_image (Linux only)

I know we have run into issues before when using ubuntu-latest when a change was made to the latest image that broke CI. I would prefer to always set this to a specific version, so we can choose to move to a newer one with a PR that can run through CI. I am ok with selecting the highest version

[edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Print expected Status on ASSERT fail

Update the UnitTestAssertStatusEqual error message to print out the expected value in addition to the seen value. Signed-off-by: Jeshua Smith --- UnitTestFrameworkPkg/Library/UnitTestLib/AssertCmocka.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UnitTestFrameworkPkg/Libra

Re: [edk2-devel] [PATCH v8 10/12] CI: Don't install cspell

I apologize as I think I mislead you on this. I think we can only remove this operation for the builds using the container. I believe Windows builds will still require this step for the time being. The Windows pipeline on your PR is currently failing to find cspell. Sorry for not being clear on

Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Print expected Status on ASSERT fail

Hi Jeshuas, This is a good idea to show the expected value. %p was used on purpose because unit tests can be built for 32-bit or 64-bit and the EFI_STATUS is same as RETURN_STATUS which is same as UINTN. UINTN is 32-bits for 32-bit unit test apps and 64-bit for 64-bit unit test apps. %p prints

[edk2-devel] [Patch 1/1] UnitTestFrameworkPkg: Library classes private to public

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4178 * Change GoogleTestLib class from private to public. * Change UnitTestPersistenceLib class from private to public. Cc: Michael Kubacki Cc: Sean Brogan Cc: Ray Ni Cc: Zhiguang Liu Signed-off-by: Michael D Kinney --- .../Library/UnitTes

Re: [edk2-devel] [PATCH v8 10/12] CI: Don't install cspell

On Wed, Nov 30, 2022 at 9:45 PM Chris Fernald wrote: > > I apologize as I think I mislead you on this. I think we can only remove > this operation for the builds using the container. I believe Windows > builds will still require this step for the time being. The Windows > pipeline on your PR is cu

Re: [edk2-devel] [PATCH v8 12/12] CI: use latest vm_image (Linux only)

On Wed, Nov 30, 2022 at 9:39 PM Kinney, Michael D wrote: > > I know we have run into issues before when using ubuntu-latest when > a change was made to the latest image that broke CI. > > I would prefer to always set this to a specific version, so we can > choose to move to a newer one with a PR t

[edk2-devel] [PATCH v9 01/12] CI: make Python version configurable

Add a new parameter "usePythonVersion" to the CI job templates. This makes it possible to specify the version of Python to use. The default value is '', in which case Python will not be downloaded at runtime and the one provided by the VM/container image will be used. Additionally, add a template

[edk2-devel] [PATCH v9 02/12] OvmfPkg: CI: use Python version from defaults template

Use the default Python version from the defaults template (.azurepipelines/templates/defaults.yml) in the Windows CI jobs. Previous changes to the CI job templates make it necessary to specify a version number, if Python shall be pulled at CI runtime. The Linux CI jobs will use Python from the co

[edk2-devel] [PATCH v9 03/12] EmulatorPkg: CI: use Python version from defaults template

Use the default Python version from the defaults template (.azurepipelines/templates/defaults.yml) in the Windows CI jobs. Previous changes to the CI job templates make it necessary to specify a version number, if Python shall be pulled at CI runtime. The Linux CI jobs will use Python from the co

[edk2-devel] [PATCH v9 04/12] CI: add ~/.local/bin to PATH (Linux only)

Fix pip install under certain conditions. Signed-off-by: Oliver Steffen --- .azurepipelines/templates/platform-build-run-steps.yml | 6 ++ .azurepipelines/templates/pr-gate-steps.yml| 6 ++ 2 files changed, 12 insertions(+) diff --git a/.azurepipelines/templates/platform-bui

[edk2-devel] [PATCH v9 05/12] CI: Allow running in a container.

Add a parameter of the pr-gate-build-job template to specify a container image URL. If the value is not '' (default), then the jobs will be run inside a container based on that image. Signed-off-by: Oliver Steffen --- .azurepipelines/templates/pr-gate-build-job.yml | 4 1 file changed, 4 i

[edk2-devel] [PATCH v9 06/12] BaseTools: CI: Use Fedora 35 container (Linux only)

Run all Linux based jobs in a container, using a custom Fedora 35 image (gcc 11). The image is hosted on ghcr.io and the Dockerfiles are here: https://github.com/tianocore/containers The version numbers of gcc, iasl, and nasm are pinned to avoid unintended upgrades during image rebuild. Do not run

[edk2-devel] [PATCH v9 07/12] ArmVirtPkg: CI: Use Fedora 35 container (Linux only)

Run all Linux based jobs in a container, using a custom Fedora 35 image (gcc 11). The image is hosted on ghcr.io and the Dockerfiles are here: https://github.com/tianocore/containers The version numbers of gcc, iasl, and nasm are pinned to avoid unintended upgrades during image rebuild. Do not run

[edk2-devel] [PATCH v9 08/12] OvmfPkg: CI: Use Fedora 35 container (Linux only)

Run all Linux based jobs in a container, using a custom Fedora 35 image (gcc 11). The image is hosted on ghcr.io and the Dockerfiles are here: https://github.com/tianocore/containers The version numbers of gcc, iasl, and nasm are pinned to avoid unintended upgrades during image rebuild. Do not run

[edk2-devel] [PATCH v9 09/12] EmulatorPkg: CI: Use Fedora 35 container (Linux only)

Run all Linux based jobs in a container, using a custom Fedora 35 image (gcc 11). The image is hosted on ghcr.io and the Dockerfiles are here: https://github.com/tianocore/containers The version numbers of gcc, iasl, and nasm are pinned to avoid unintended upgrades during image rebuild. Use Python

[edk2-devel] [PATCH v9 10/12] .pytool: CISettings.py: don't add scopes for GCC

All ext_dep.yml files for gcc have been removed and gcc is expected to be installed on the system (GCC5_*_PREFIX may indicate the location). No need to adjust the toolchain scopes for Linux builds anymore. Signed-off-by: Oliver Steffen --- .pytool/CISettings.py | 9 - 1 file changed, 9 d

[edk2-devel] [PATCH v9 11/12] CI: use latest vm_image (Linux only)

Switch over to `ubuntu-latest` as the vm_image for Linux CI jobs (EmulatorPkg, ArmVirtPkg, OvmfPkg). The previously used ubuntu-18.04 will not be available after Dec 1st 2022. Signed-off-by: Oliver Steffen --- ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 2 +- EmulatorPkg/PlatformCI/

[edk2-devel] [PATCH v9 12/12] do not merge: modify *.dsc to trigger CI

Modify all *.dsc files to make sure all parts of the CI actually run. This is only needed to trigger the CI in the PR and shall not be merged. Signed-off-by: Oliver Steffen --- ArmPkg/ArmPkg.dsc | 1 + ArmPkg/Drivers/ArmCrashDumpDxe/ArmCrashDumpDxe.dsc

[edk2-devel] [PATCH v9 00/12] CI: Use Fedora 35 container for Linux jobs

Update CI, run all Linux (aka Ubuntu-GCC5) based jobs in custom containers. This decouples the CI environment from the virtual machine images that Azure DevOps provides. The currently used ubuntu-18.04 image has been deprecated for a while now and will finally be removed on Dec 1st 2022. The con

Re: [edk2-devel] [PATCH v9 12/12] do not merge: modify *.dsc to trigger CI

Please ignore this patch. I did not intend to send it. -Oliver On Wed, Nov 30, 2022 at 11:01 PM Oliver Steffen wrote: > > Modify all *.dsc files to make sure all parts of the CI actually run. > This is only needed to trigger the CI in the PR and shall not be merged. > > Signed-off-by: Oliver Ste

Re: [edk2-devel] [PATCH] UnitTestFrameworkPkg/UnitTestLib: Print expected Status on ASSERT fail

Hi Mike, Thanks for the explanation. That makes sense. I think Option 1 is the simplest in this case, and I'll resubmit the patch with that. Option 2 seems like an unnecessary workaround, since I can't think of a good reason to make the printed value a 64 bit value on 32-bit platforms. Option 3

[edk2-devel] [PATCH v2] UnitTestFrameworkPkg/UnitTestLib: Print expected Status on ASSERT fail

Update the UnitTestAssertStatusEqual error message to print out the expected value in addition to the seen value. Change-Id: Ic651584dcdbcf1f8cd8166ad8058744fc0587d72 Signed-off-by: Jeshua Smith --- UnitTestFrameworkPkg/Library/UnitTestLib/AssertCmocka.c | 2 +- 1 file changed, 1 insertion(+), 1

[edk2-devel] [PATCH v3] UnitTestFrameworkPkg/UnitTestLib: Print expected Status on ASSERT fail

Update the UnitTestAssertStatusEqual error message to print out the expected value in addition to the seen value. Signed-off-by: Jeshua Smith --- UnitTestFrameworkPkg/Library/UnitTestLib/AssertCmocka.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/UnitTestFrameworkPkg/Libra

Re: [edk2-devel] [PATCH v2] UnitTestFrameworkPkg/UnitTestLib: Print expected Status on ASSERT fail

Reviewed-by: Michael D Kinney Mike > -Original Message- > From: Jeshua Smith > Sent: Wednesday, November 30, 2022 2:59 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; > mikub...@linux.microsoft.com; sean.bro...@microsoft.com; Jeshua Smith > > Subject: [PATCH v2] UnitTestFramew

Re: [edk2-devel] [PATCH v3] UnitTestFrameworkPkg/UnitTestLib: Print expected Status on ASSERT fail

Reviewed-by: Michael Kubacki On 11/30/2022 6:02 PM, Jeshua Smith via groups.io wrote: Update the UnitTestAssertStatusEqual error message to print out the expected value in addition to the seen value. Signed-off-by: Jeshua Smith --- UnitTestFrameworkPkg/Library/UnitTestLib/AssertCmocka.c | 2

Re: [edk2-devel] [PATCH v9 11/12] CI: use latest vm_image (Linux only)

Hi Oliver, This patch is still touching several packages in one commit. Thanks, Michael On 11/30/2022 5:01 PM, Oliver Steffen wrote: Switch over to `ubuntu-latest` as the vm_image for Linux CI jobs (EmulatorPkg, ArmVirtPkg, OvmfPkg). The previously used ubuntu-18.04 will not be available after

Re: [edk2-devel] [PATCH v9 01/12] CI: make Python version configurable

I think you should update Ubuntu-GCC5.yml to use templates/defaults.yml in this commit since at this point in time containers are not used yet. Can you also add a copyright header to defaults.yml? Then it will be consistent with other yaml files and in place as the file grows in the future.

Re: [edk2-devel] [PATCH v9 10/12] .pytool: CISettings.py: don't add scopes for GCC

Not a big deal but I think it would be cleaner to remove the scopes in a commit before the ext_dep files are actually removed. For the changes in this patch: Reviewed-by: Michael Kubacki On 11/30/2022 5:01 PM, Oliver Steffen wrote: All ext_dep.yml files for gcc have been removed and gcc is e

Re: [edk2-devel] [PATCH v9 11/12] CI: use latest vm_image (Linux only)

Please update the commit message to `ubuntu-22.04` instead of `ubuntu-latest` since you updated in the image in the file from the original patch. Reviewed-by: Michael Kubacki On 11/30/2022 5:01 PM, Oliver Steffen wrote: Switch over to `ubuntu-latest` as the vm_image for Linux CI jobs (Emulat

Re: [edk2-devel] [PATCH v9 02/12] OvmfPkg: CI: use Python version from defaults template

Like patch v9 1/12, I suggest updating Ubuntu-GCC5.yml in OvmfPkg/PlatformCI/.azurepipelines to use the template in this patch. On 11/30/2022 5:01 PM, Oliver Steffen wrote: Use the default Python version from the defaults template (.azurepipelines/templates/defaults.yml) in the Windows CI jobs.

Re: [edk2-devel] [PATCH v9 03/12] EmulatorPkg: CI: use Python version from defaults template

Like patch v9 1/12 & v9 2/12, I suggest updating Ubuntu-GCC5.yml in EmulatorPkg/PlatformCI/.azurepipelines to use the template in this patch. On 11/30/2022 5:01 PM, Oliver Steffen wrote: Use the default Python version from the defaults template (.azurepipelines/templates/defaults.yml) in the Wi

Re: [edk2-devel] [PATCH v9 04/12] CI: add ~/.local/bin to PATH (Linux only)

Hi Oliver, I think the commit message is too vague. Can you please add a bit more context? With that: Reviewed-by: Michael Kubacki On 11/30/2022 5:01 PM, Oliver Steffen wrote: Fix pip install under certain conditions. Signed-off-by: Oliver Steffen --- .azurepipelines/templates/platform

Re: [edk2-devel] [PATCH v9 05/12] CI: Allow running in a container.

Reviewed-by: Michael Kubacki On 11/30/2022 5:01 PM, Oliver Steffen wrote: Add a parameter of the pr-gate-build-job template to specify a container image URL. If the value is not '' (default), then the jobs will be run inside a container based on that image. Signed-off-by: Oliver Steffen ---

Re: [edk2-devel] [PATCH v9 06/12] BaseTools: CI: Use Fedora 35 container (Linux only)

The changes in .azurepipelines and BaseTools need to be split up into separate patches. On 11/30/2022 5:01 PM, Oliver Steffen wrote: Run all Linux based jobs in a container, using a custom Fedora 35 image (gcc 11). The image is hosted on ghcr.io and the Dockerfiles are here: https://github.com/

Re: [edk2-devel] [edk2-staging][PATCH] edk2-staging/RedfishClientPkg: Fix GCC build error

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Wednesday, November 30, 2022 11:24 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-staging][PATCH] edk2-staging/RedfishClien

回复: [edk2-devel] [PATCH] MdeModulePkg: Disable PciDegrade support for LoongArch64

Reviewed-by: Liming Gao 发件人: devel@edk2.groups.io 代表 Chao Li 发送时间: 2022年11月21日 14:40 收件人: devel@edk2.groups.io; lic...@loongson.cn 抄送: " devel@edk2.groups.io " ; " qiandong...@loongson.cn " ; Jian J Wang ; Liming Gao ; Ray Ni ; Bo Zhu 主题: Re: [edk2-devel] [PATCH] MdeModulePkg: Disable Pci

Re: [edk2-devel] [edk2-staging][PATCH] edk2-staging/RedfishClientPkg: Fix GCC build error

Reviewed-by: Igor Kulchytskyy -Original Message- From: Chang, Abner Sent: Wednesday, November 30, 2022 7:53 PM To: Nickle Wang ; devel@edk2.groups.io Cc: Igor Kulchytskyy ; Nick Ramirez Subject: [EXTERNAL] RE: [edk2-staging][PATCH] edk2-staging/RedfishClientPkg: Fix GCC build error *

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Define default values for the DynamicEX PCDs

@jdzh...@kunluntech.com.cn Edk2 hardware freeze in unlock, Could you help send the Edk2 PR for it ? We can help to check in it to unlock the ECC failure. Thanks Gua From: Guo, Gua Sent: Friday, November 11, 2022 9:40 AM To: devel@edk2.groups.io; jdzh...@kunlunte

Re: [edk2-devel] [Patch 1/1] UnitTestFrameworkPkg: Library classes private to public

Reviewed-by: Ray Ni > -Original Message- > From: Kinney, Michael D > Sent: Thursday, December 1, 2022 5:20 AM > To: devel@edk2.groups.io > Cc: Michael Kubacki ; Sean Brogan > ; Ni, Ray ; Liu, Zhiguang > > Subject: [Patch 1/1] UnitTestFrameworkPkg: Library classes private to public > >

Re: [edk2-devel] [PATCH v8 09/12] EmulatorPkg: CI: Use Fedora 35 container (Linux only)

Acked-by: Ray Ni > -Original Message- > From: Oliver Steffen > Sent: Thursday, December 1, 2022 4:01 AM > To: devel@edk2.groups.io > Cc: Andrew Fish ; Ard Biesheuvel > ; Feng, Bob C ; Daniel > Schaefer ; Gerd Hoffmann ; > Yao, Jiewen ; Justen, Jordan L > ; Leif Lindholm ; > Gao, Liming ;

Re: [edk2-devel] [PATCH 0/3] Add reset support in Emulator/WinHost PEI

Andrew, Can you please help to review or ACK the 3 patches (url listed as below): https://edk2.groups.io/g/devel/message/96320 https://edk2.groups.io/g/devel/message/96319 https://edk2.groups.io/g/devel/message/96321 It's to support a need when some PEIMs want to reset the Emulator. Thanks, Ray

Re: [edk2-devel] Edk2 support MIPI SyS-T TraceHub Debug Library [TraceHubDebugLibSysT]

@Kinney, Michael D As we offline sync, there are below opens like below. Have any open, please also share for us. 1. Need to add TraceHub PCD into edk2/MdeModulePkg.uni at master * tianocore/edk2 * GitHub

[edk2-devel] [edk2-staging][PATCH V2] edk2-staging/RedfishClientPkg: Fix typo

Fix typo in RedfishPlatformConfigImpl.c Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigImpl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RedfishPkg/RedfishPlatformConfigDxe/

Re: [edk2-devel] [edk2-staging][PATCH V2] edk2-staging/RedfishClientPkg: Fix typo

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Nickle > Wang via groups.io > Sent: Thursday, December 1, 2022 11:29 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject:

Re: [edk2-devel] [PATCH] MdeModulePkg/RegularExpressionDxe: Fix GCC build error

Hi Mike, Thanks for your review. > Or it may be simpler to only check for 32-bit archs and assume all others are > 64-bit. I like this one. I will provide version 2 patch later. Regards, Nickle -Original Message- From: Kinney, Michael D Sent: Thursday, December 1, 2022 12:28 AM To:

[edk2-devel] Sct: SetDataFunction Check fail only occur when first run after by program Bios By DediProg Tool

[AMD Official Use Only - General] Hi Sir, I meet fail when do SetDataFunction Test and this only occurred on the first time after program Bios by DediProg The Function location : HIITest -> ConfigKeywordHandlerTest -> SetDataFunction I check the code flow and the result as below:

[edk2-devel] [PATCH ovmf 0/5] Enable AMD SEV-ES DebugSwap

This is to prevent #DB interception on SEV-ES VM with enabled DebugSwap feature, more details in 3/5. This is based on sha1 dd3ba82d31a6 and pushed out at https://github.com/aik/edk2/commits/debugswap The corresponding Linux change (HV and VM) is here: https://github.com/aik/linux/commits/debugsw

[edk2-devel] [PATCH ovmf 3/5] OvmfPkg: Add AMD SEV-ES DebugSwap feature support

The SEV-ES DebugSwap feature enables type B swaping of debug registers on #VMEXIT and makes #DB and DR7 intercepts unnecessary and unwanted. When DebugSwap is enabled, this stops booting if #VC for #DB or DB7 read/write occurs as this signals unwanted interaction from the HV. This adds new API wh

[edk2-devel] [PATCH ovmf 1/5] MdePkg/Register/Amd: Define all bits from MSR_SEV_STATUS_REGISTER

We will need soon DebugSwap but others likely too. Signed-off-by: Alexey Kardashevskiy --- MdePkg/Include/Register/Amd/Fam17Msr.h | 57 +++- 1 file changed, 56 insertions(+), 1 deletion(-) diff --git a/MdePkg/Include/Register/Amd/Fam17Msr.h b/MdePkg/Include/Register/Amd/Fam17Ms

[edk2-devel] [PATCH ovmf 5/5] OvmfPkf: Enable AMD SEV-ES DebugSwap for DXE

This writes the feature bit into PcdConfidentialComputingGuestAttr and enables DebugSwap for the DXE stage too. Signed-off-by: Alexey Kardashevskiy --- OvmfPkg/PlatformPei/AmdSev.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/OvmfPkg/PlatformPei/AmdSev.c b/O

[edk2-devel] [PATCH ovmf 4/5] UefiCpuPkg: Add AMD SEV-ES features support

CONFIDENTIAL_COMPUTING_GUEST_ATTR is not a simple SEV level anymore and includes a feature mask since a previous commit. This fixes AmdMemEncryptionAttrCheck to check the level and feature correctly and adds DebugSwap support. Since the actual feature flag is not set yet, this should cause no beh

[edk2-devel] [PATCH v2] IntelSiliconPkg/VTd: Use 256-bit invaildation queue descriptor

256-bit invaildation queue descriptor could be used for both abort DMA mode and legacy mode. Signed-off-by: Sheng Wei Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Jenny Huang Cc: Robert Kowalewski --- .../VTd/IntelVTdDmarPei/IntelVTdDmar.c| 179 - .../VTd/IntelVTdDmarPei/IntelV

[edk2-devel] [PATCH ovmf 2/5] MdePkg: Add AMD SEV features to PcdConfidentialComputingGuestAttr

PcdConfidentialComputingGuestAttr so far only contained an SEV mode bit but there are more other features which do not translate to levels such as DebugSwap or SecureTsc. This adds the features mask and the DebugSwap feature bit to a PCD. Signed-off-by: Alexey Kardashevskiy --- MdePkg/Include/C

Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/PlatformInitLib: Add check to NvVarStoreFV HeaderLength

Reviewed-by: Jiewen Yao > -Original Message- > From: Xu, Min M > Sent: Sunday, November 27, 2022 3:00 PM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Aktas, Erdem > ; James Bottomley ; Yao, > Jiewen ; Gerd Hoffmann ; > Tom Lendacky > Subject: [PATCH V1 1/1] OvmfPkg/PlatformInitLib: Add