Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib: Add option to follow Microsoft Recommendations

2022-10-07 Thread Sheng Lean Tan
Reminder for review, thanks. From: devel@edk2.groups.io on behalf of Sheng Lean Tan via groups.io Date: Monday, 3. October 2022 at 11:22 To: devel@edk2.groups.io , sean@starlabs.systems Cc: Sean Rhodes , Zhichao Gao , Ray Ni , Jian J Wang , Liming Gao , Dong, Guo , Guo, Gua Subject: Re: [

[edk2-devel] [PATCH v2 1/1] ArmPlatformPkg/PrePeiCore: Print the firmware version early in boot

2022-10-07 Thread Rebecca Cran
Copy code from PrePi to PrePeiCore that prints the firmware version and build date early in the boot process. Signed-off-by: Rebecca Cran --- ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf | 3 +++ ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf | 3 +++ ArmPlatformPkg/PrePeiCore/PrePeiCore.c

Re: [edk2-devel] [PATCH v2 1/1] ArmPlatformPkg/PrePeiCore: Print the firmware version early in boot

2022-10-07 Thread Sami Mujawar
Hi Rebecca, Thank you for this patch. On Fri, Oct 7, 2022 at 04:38 AM, Rebecca Cran wrote: > > + CharCount = AsciiSPrint ( > + Buffer, > + sizeof (Buffer), > + "UEFI firmware (version %s built at %a on %a)\n\r", > + (CHAR16 *)PcdGetPtr (PcdFirmwareVersionString), > + __TIME__, > + __DATE__ > +

[edk2-devel] [PATCH 1/2] SimicsOpenBoardPkg: Fix bug in DSDT

2022-10-07 Thread Guenzel, Robert
The DSDT had a syntax error that was not detected by older iasl versions. This commit fixes the Syntax error. Signed-off-by: Robert Guenzel --- Platform/Intel/SimicsOpenBoardPkg/AcpiTables/Dsdt.asl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/Intel/SimicsOpenBoa

[edk2-devel] [PATCH 2/2] SimicsOpenBoardPkg: Override additional Pcd

2022-10-07 Thread Guenzel, Robert
The Pcd gUefiCpuPkgTokenSpaceGuid.PcdSmmFeatureControlEnable is by default True in UefiCpuPkg. However, the Simics target does not have the MSRs whose access is guarded by this Pcd and hence runs into a GP fault. Consequently, we override the Pcd to be False. Signed-off-by: Robert Guenzel ---

[edk2-devel] Show platform-key fingerprint when secure boot is enabled

2022-10-07 Thread Simon Brand
Hello, when secure boot is enabled and a custom platform-key is used, please show the fingerprint of the platform-key in the UEFI interface and on the POST screen. This way a user can really verify, that only their signed EFI executables gets booted/executed. (And nobody tampered the device keys/d

Re: [edk2-devel] [PATCH v2 1/1] ArmPlatformPkg/PrePeiCore: Print the firmware version early in boot

2022-10-07 Thread Rebecca Cran
Ah, dangit! I completely forgot to run uncrustify. I'll send out a v3. -- Rebecca Cran On 10/7/22 06:34, Sami Mujawar wrote: Hi Rebecca, Thank you for this patch. On Fri, Oct 7, 2022 at 04:38 AM, Rebecca Cran wrote: + CharCount = AsciiSPrint ( + Buffer, + sizeof (Buffer), + "

Re: [edk2-devel] [PATCH 1/1] Platform/ARM: Bump Dsdt/Ssdt ACPI table revision

2022-10-07 Thread Sami Mujawar
Hi Pierre, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94811): https://edk2.groups.io/g/devel/message/94811 Mute This Topic:

Re: [edk2-devel] [PATCH v2 1/1] ArmPlatformPkg/PrePeiCore: Print the firmware version early in boot

2022-10-07 Thread Oliver Steffen
Quoting Rebecca Cran (2022-10-07 13:38:05) > Copy code from PrePi to PrePeiCore that prints the firmware version > and build date early in the boot process. > > Signed-off-by: Rebecca Cran > --- > ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf | 3 +++ > ArmPlatformPkg/PrePeiCore/PrePeiCoreUniC

Re: [edk2-devel] [edk2-platforms PATCH v2] Platform/RaspberryPi: fix pci DT node address in SyncPcie()

2022-10-07 Thread Jeremy Linton
Hi, On 10/6/22 12:46, Adrien Thierry wrote: To make sure the XHCI controller does not get reset by Linux in DT mode, we remove its pci parent node from the device tree. However, the pci node address has been updated in the Raspberry Pi 4 device tree [1] and no longer matches the one we are tryin

[edk2-devel] [[edk2-staging/HttpProxy PATCH v2] 0/6] Support HTTPS Proxy Server for HTTP Boot

2022-10-07 Thread Saloni Kasbekar
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3951 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4052 - Add CONNECT HTTP Method to create a tunnel through the Proxy Server - TLS adjustments to establish handshake with the Endpoint Server - Use multi-URI device path to support Proxy Ser

[edk2-devel] [[edk2-staging/HttpProxy PATCH v2] 1/6] MdeModulePkg/Library: Support multi-URI HTTP Boot device path

2022-10-07 Thread Saloni Kasbekar
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3951 Process device path with proxy server and endpoint server included. Update comment for sample HTTP Boot device path. Cc: Jian J Wang Cc: Liming Gao Signed-off-by: Saloni Kasbekar --- .../Library/UefiBootManagerLib/BmBoot.c | 28 ++

[edk2-devel] [[edk2-staging/HttpProxy PATCH v2] 2/6] MdePkg/Include: Add Proxy Server URL in EFI_HTTP_REQUEST_DATA

2022-10-07 Thread Saloni Kasbekar
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3951 Add Proxy Server URL to EFI_HTTP_REQUEST_DATA. This will be used when a Proxy Server URL is a part of the HTTP Boot device path. Cc: Zhiguang Liu Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Saloni Kasbekar --- MdePkg/Include/Pro

[edk2-devel] [[edk2-staging/HttpProxy PATCH v2] 3/6] NetworkPkg/HttpBootDxe: Update HTTP Boot Driver with parsed Proxy URL

2022-10-07 Thread Saloni Kasbekar
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3951 Add ProxyUri to HTTP_BOOT_PRIVATE_DATA Parse HTTP Boot Device path to process Proxy and EndPoint URLs Cc: Maciej Rabeda Cc: Wu Jiaxin Cc: Siyuan Fu Signed-off-by: Saloni Kasbekar --- NetworkPkg/HttpBootDxe/HttpBootClient.c | 30 -

[edk2-devel] [[edk2-staging/HttpProxy PATCH v2] 4/6] NetworkPkg: Add Proxy Support to HTTP_PROTOCOL

2022-10-07 Thread Saloni Kasbekar
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3951 Update HTTP Protocol with variables to support Proxy Use state machine to call HttpBootGetBootFile() Add switch/case for EfiHttpRequest request method Cc: Maciej Rabeda Cc: Wu Jiaxin Cc: Siyuan Fu Signed-off-by: Saloni Kasbekar --- Net

[edk2-devel] [[edk2-staging/HttpProxy PATCH v2] 6/6] NetworkPkg/HttpDxe: Support HTTPS EndPoint server with Proxy

2022-10-07 Thread Saloni Kasbekar
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3951 Add support for Proxy server to connect to a HTTPS EndPoint server. TLS Connection to be created during GET/HEAD after CONNECT method. Cc: Maciej Rabeda Cc: Wu Jiaxin Cc: Siyuan Fu Signed-off-by: Saloni Kasbekar --- NetworkPkg/HttpDxe/

[edk2-devel] [[edk2-staging/HttpProxy PATCH v2] 5/6] NetworkPkg: Add support for HTTP CONNECT Method

2022-10-07 Thread Saloni Kasbekar
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3951 Add support for the HTTP CONNECT method to request the Proxy Server to open a tunnel to the EndPoint Server Cc: Maciej Rabeda Cc: Wu Jiaxin Cc: Siyuan Fu Signed-off-by: Saloni Kasbekar --- NetworkPkg/HttpBootDxe/HttpBootClient.c| 1

Re: [edk2-devel] [PATCH 0/2] OvmfPkg/Microvm: support stateless secure boot

2022-10-07 Thread Ard Biesheuvel
Merged #3449 into master. On Thu, 6 Oct 2022 at 13:05, Gerd Hoffmann wrote: > > > > Gerd Hoffmann (2): > OvmfPkg/Microvm: add SECURE_BOOT_FEATURE_ENABLED > Revert "OvmfPkg/Microvm: no secure boot" > > OvmfPkg/Microvm/MicrovmX64.dsc | 31 ++- > OvmfPkg/Microvm/Micr

Re: [edk2-devel] [PATCH v2 0/4] OvmfPkg: make better use of physical address space.

2022-10-07 Thread Ard Biesheuvel
Merged #3449 into master. On Tue, 4 Oct 2022 at 15:47, Gerd Hoffmann wrote: > > For historical reasons ovmf is quite conservative on address space > usage, to play safe and avoid using more than 36 physical address bits > (the guaranteed minimum) if possible. With devices (specifically GPUs) > b

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: rename QemuBootOrderNNNN to VMMBootOrderNNNN

2022-10-07 Thread Ard Biesheuvel
Merged #3449 into master. On Tue, 4 Oct 2022 at 13:22, Gerd Hoffmann wrote: > > While the actual implementation (using qemu fw_cfg) is qemu-specific, > the idea to store the boot order as configured by the VMM in EFI > variables is not. So lets give the variables a more neutral name while > we s

Re: [edk2-devel] [PATCH] MdeModulePkg VariablePei: Add Variable state check when find variable in IndexTable.

2022-10-07 Thread Jiading Zhang
Hello, Can anyone please help to review the patch? Thanks very much! -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94824): https://edk2.groups.io/g/devel/message/94824 Mute This Topic: https://groups.io/mt/93965445/21656 Group Owner: de

回复: 回复: [edk2-devel] [RFC] Adoption of CodeQL in edk2

2022-10-07 Thread gaoliming via groups.io
Michael: I get your point to enable CodeQL rule step by step. This way doesn't impact normal PR process. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Michael > Kubacki > 发送时间: 2022年10月3日 22:29 > 收件人: gaoliming ; devel@edk2.groups.io; > michael.d.kin...@intel.com > 主题: Re: 回复:

回复: [edk2-devel] [PATCH] MdeModulePkg VariablePei: Add Variable state check when find variable in IndexTable.

2022-10-07 Thread gaoliming via groups.io
Jiading: I have gave my comment on https://edk2.groups.io/g/devel/message/94555 for this patch. Have you got it? Thanks Liming 发件人: devel@edk2.groups.io 代表 Jiading Zhang 发送时间: 2022年10月8日 8:21 收件人: Jiading Zhang ; devel@edk2.groups.io 主题: Re: [edk2-devel] [PATCH] MdeModulePkg VariablePei:

[edk2-devel] 回复: [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of the Logo

2022-10-07 Thread gaoliming via groups.io
Sean: Thanks for your update. I have one minor comment in below. Other change is good to me. Thanks Liming > -邮件原件- > 发件人: Sean Rhodes > 发送时间: 2022年9月26日 16:10 > 收件人: devel@edk2.groups.io > 抄送: Sean Rhodes ; Zhichao Gao > ; Ray Ni ; Jian J Wang > ; Liming Gao > 主题: [PATCH 2/3] MdeModu

[edk2-devel] 回复: [PATCH 1/3] MdeModulePkg/BootLogoLib: Add option to follow Microsoft Recommendations

2022-10-07 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: Sean Rhodes > 发送时间: 2022年9月26日 16:10 > 收件人: devel@edk2.groups.io > 抄送: Sean Rhodes ; Zhichao Gao > ; Ray Ni ; Jian J Wang > ; Liming Gao > 主题: [PATCH 1/3] MdeModulePkg/BootLogoLib: Add option to follow > Microsoft Recommendations > > Add an optio

回复: [edk2-devel] 回复: [edk2-devel] 回复: [edk2-devel] [edk2] [PATCH]MdeModulePkg\scsi: Coverity scan flags multiple issues in edk2-stable202205

2022-10-07 Thread gaoliming via groups.io
Please see below wiki pages. https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request Thanks Liming 发件人: devel@edk2.groups.io 代表 sivaparvathi C via groups.io

回复: [edk2-devel] 回复: [edk2-devel] [PATCH] [PATCH]MdeModulePkg/Ufs: Coverity scan flags multiple issues in edk2-stable202205 Signed-off-by: sivaparvat...@ami.com

2022-10-07 Thread gaoliming via groups.io
I have gave my reviewed-by https://edk2.groups.io/g/devel/message/93694. But, I can’t get this patch from the mail. Can you share this patch in Pull Request or your fork GitHub Edk2 repo branch? Thanks Liming 发件人: devel@edk2.groups.io 代表 sivaparvathi C via groups.io 发送时间: 2022年10月6日 16

Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of the Logo

2022-10-07 Thread Ni, Ray
Sean, I remember that I evaluated the BGRT requirement when designing the PlatformLogo protocol. So, I went back to got the code I wrote long time ago as below. I didn't try to understand them now. Does it make sense to you? Status = gBS->HandleProtocol (gST->ConsoleOutHandle, &gEfiGraphics

[edk2-devel] [PATCH V2 0/3] CryptoPkg: Extend Tls library

2022-10-07 Thread Li, Yi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3892 Review PR: https://github.com/tianocore/edk2/pull/3400 This patch sequence is used to extend Tls library, which are wrapped over OpenSSL. The implementation provides library functions for EFI DXE dirver and Protocol. All APIs passed unit te

[edk2-devel] [PATCH V2 1/3] MdePkg: Add Tls configuration related define

2022-10-07 Thread Li, Yi
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3892 Consumed by TlsSetEcCurve and TlsSetSignatureAlgoList. Cc: Jiewen Yao Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Yi Li --- MdePkg/Include/IndustryStandard/Tls1.h | 110 + 1 file changed, 74 insertions(+),

[edk2-devel] [PATCH V2 2/3] CryptoPkg: Extend Tls function library

2022-10-07 Thread Li, Yi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3892 1. TlsSetSignatureAlgoList(): Configure the list of TLS signature algorithms that should be used as part of the TLS session establishment. This is needed for some WLAN Supplicant connection establishment flows that allow only specific TLS si

[edk2-devel] [PATCH V2 3/3] CryptoPkg: Add new Tls APIs to DXE and protocol

2022-10-07 Thread Li, Yi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3892 The implementation provides new Tls library functions for Crypto EFI Driver and Protocol. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: Yi Li --- CryptoPkg/Driver/Crypto.c | 155 +

回复: [edk2-devel] [PATCH v3] remove GCC build warning

2022-10-07 Thread gaoliming via groups.io
Have you verified GCC5 and GCC49 tool chain? Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 JessyX Wu > 发送时间: 2022年10月4日 10:04 > 收件人: devel@edk2.groups.io > 抄送: JessyX Wu ; Bob Feng ; > Liming Gao ; Yuwei Chen > > 主题: [edk2-devel] [PATCH v3] remove GCC build warning > > Fix gcc:

回复: [edk2-devel] [PATCH v2 02/17] BaseTools: Remove duplicated words

2022-10-07 Thread gaoliming via groups.io
Pierre: If the whole serials have passed review, one of package maintainer can merge them together. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 > PierreGondois > 发送时间: 2022年10月3日 16:00 > 收件人: Feng, Bob C ; devel@edk2.groups.io > 抄送: Gao, Liming > 主题: Re: [edk2-devel] [PATCH

[edk2-devel] Updated Event: TianoCore edk2-test Bug Triage Meeting #cal-invite

2022-10-07 Thread Group Notification
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:Asia/Shanghai LAST-MODIFIED:20220816T024022Z TZURL:http://tzurl.org/zoneinfo-outlook/Asia/Shanghai X-LIC-LOCAT

Re: [edk2-devel] [Patch V2] UefiCpuPkg/CpuExceptionHandlerLib: Code optimization to allow bigger stack

2022-10-07 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Tan, Dun > Sent: Thursday, September 29, 2022 5:07 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R > Subject: [Patch V2] UefiCpuPkg/CpuExceptionHandlerLib: Code optimization > to allow bigger stack > > This co

Re: [edk2-devel] [PATCH v3 00/34] Add a new architecture called LoongArch in EDK II

2022-10-07 Thread Chao Li
Hi All, I have updated LoongArch repo, the CI has passed, please check again: https://dev.azure.com/kilaterlee/LoongArch_edk2/_build/results?buildId=77&view=results (https://link.getmailspring.com/link/f2807860-fe79-4500-aaac-a40889944...@getmailspring.com/0?redirect=https%3A%2F%2Fdev.azure.com%2

[edk2-devel] [PATCH v2 1/1] UefiCpuPkg: Reset a parameter when BSP Exit in CPU relaxed mode.

2022-10-07 Thread Li, Zhihao
From: Zhihao Li REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4083 In CPU relaxed mode, it doesn't reset the value of mSmmMpSyncData->AllApArrivedWithException when BSP exit smm mode. So this patch will reset this variable. Modified the flow of SmmCpuRendezvous to avoid enter SmmWaitForApA

Re: [edk2-devel] [PATCH v2 1/1] UefiCpuPkg: Reset a parameter when BSP Exit in CPU relaxed mode.

2022-10-07 Thread Ni, Ray
Can you please split the patch to 2 patches? > -Original Message- > From: Li, Zhihao > Sent: Saturday, October 8, 2022 1:58 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray > Subject: [PATCH v2 1/1] UefiCpuPkg: Reset a parameter when BSP Exit in > CPU relaxed mode. > > From: Zhi

Re: [edk2-devel] [PATCH v1 1/1] UefiCpuPkg: Reset a parameter when BSP Exit in CPU relaxed mode.

2022-10-07 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Li, Zhihao > Sent: Tuesday, September 27, 2022 8:58 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray > Subject: [PATCH v1 1/1] UefiCpuPkg: Reset a parameter when BSP Exit in > CPU relaxed mode. > > From: Zhihao Li > > REF: http