Michael: I get your point to enable CodeQL rule step by step. This way doesn't impact normal PR process.
Thanks Liming > -----邮件原件----- > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Michael > Kubacki > 发送时间: 2022年10月3日 22:29 > 收件人: gaoliming <gaolim...@byosoft.com.cn>; devel@edk2.groups.io; > michael.d.kin...@intel.com > 主题: Re: 回复: [edk2-devel] [RFC] Adoption of CodeQL in edk2 > > I believe you are asking, when CodeQL CI is enabled in the edk2 project, > how soon after will all of the issues be fixed so CI passes? > > The process that will be used to enable CodeQL in CI will follow what is > described in the "Enable One Query at a Time" section in the RFC > (https://github.com/tianocore/edk2/discussions/3258). > > As proposed in that section, there should not be a time when a new > CodeQL CLI query is enabled that does not pass. Queries will be enabled > one at a time. Each time a new query is enabled, the query enable and > the corresponding changes will be staged on a branch that get merged to > edk2 master in a single PR. > > CodeQL CI will run in that PR and it must pass for the PR to be completed. > > On 9/30/2022 2:33 AM, gaoliming wrote: > > Michael: > > > > Could you estimate when CodeQL CI check can pass after CodeQL > check > > is enabled? > > > > Thanks > > > > Liming > > > > *发件人:*devel@edk2.groups.io <devel@edk2.groups.io> *代表 *Michael > D Kinney > > *发送时间:*2022年9月30日9:03 > > *收件人:*devel@edk2.groups.io; mikub...@linux.microsoft.com; Kinney, > > Michael D <michael.d.kin...@intel.com> > > *主题:*Re: [edk2-devel] [RFC] Adoption of CodeQL in edk2 > > > > I just want to reiterate. If there are no concerns or objections raised > > by Oct 4, then the > > > > CodeQL static analysis will be phased into use in the edk2 repo and > > there will be code > > > > changes made to address the issues identified by COdeQL and all future > > code changes > > > > after a CodeQL check is enabled will be blocked until the CodeQL CI > > checks pass. > > > > This will impact all future code changes and all developers will have to > > learn how to > > > > interpret CodeQL reports and fix issues. > > > > Thanks, > > > > Mike > > > > *From:*devel@edk2.groups.io <mailto:devel@edk2.groups.io> > > <devel@edk2.groups.io <mailto:devel@edk2.groups.io>> *On Behalf Of > > *Michael Kubacki > > *Sent:* Thursday, September 29, 2022 5:05 PM > > *To:* Michael Kubacki <mikub...@linux.microsoft.com > > <mailto:mikub...@linux.microsoft.com>>; devel@edk2.groups.io > > <mailto:devel@edk2.groups.io> > > *Subject:* Re: [edk2-devel] [RFC] Adoption of CodeQL in edk2 > > > > If there's any further feedback on this RFC, please respond by Tuesday, > > October 4th. We plan to start implementing the changes later in the week. > > > > Thanks, > > Michael > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94825): https://edk2.groups.io/g/devel/message/94825 Mute This Topic: https://groups.io/mt/94193107/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
