Thanks.
For patch 3/4:
I don't think "TLS" is "public key related service". I suggest to change from
+ # 1) Platform needs ECC in public key related service, eg. Tls, X509, Pem.
to
+ # 1) Platform needs ECC in TLS, or asymmetric cryptography services such as
X509 certificate or PEM format data
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4082
This patch serial is to add more CryptoX509 functions.
Tested by:
1. https://github.com/tianocore/edk2-staging/tree/DeviceSecurity.
2. Unit test: CryptoPkg/Test/UnitTest/Library/BaseCryptLib/X509Tests.c
Review PR: https://github.com/tianoc
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4082
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Qi Zhang
---
CryptoPkg/Include/Library/BaseCryptLib.h | 374 +++
1 file changed, 374 insertions(+)
diff --git a/CryptoPkg/Include/Library
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4082
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Qi Zhang
---
CryptoPkg/Library/BaseCryptLib/Pk/CryptX509.c | 1036 +
.../Library/BaseCryptLib/Pk/CryptX509Null.c | 429 +++
.../BaseCry
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4082
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Qi Zhang
---
CryptoPkg/Driver/Crypto.c | 430 ++
.../Pcd/PcdCryptoServiceFamilyEnable.h| 34 +-
.../BaseCryptLibOnProtoco
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4082
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Qi Zhang
---
.../BaseCryptLib/BaseCryptLibUnitTests.c | 1 +
.../Library/BaseCryptLib/TestBaseCryptLib.h | 3 +
.../BaseCryptLib/TestBaseCryptLibHo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3828
Review PR: https://github.com/tianocore/edk2/pull/3398
This patch sequence is used to add CryptEc library, which are wrapped
over OpenSSL. The implementation provides library functions for EFI
BaseCrypt protocol and EFI BaseCrypt Configurati
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3828
The implementation provides CryptEc library functions
for EFI Driveer and EFI BaseCrypt Protocol.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Yi Li
---
CryptoPkg/CryptoPkg.dsc |
Describes the use cases under which ECC needs to be enabled,
and provides the impact on memory size for developers' reference.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Cc: Michael D Kinney
Signed-off-by: Yi Li
---
CryptoPkg/CryptoPkg.dec | 29 ++
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3828
This patch is used to add CryptEc library, which is wrapped
over OpenSSL.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Yi Li
---
CryptoPkg/Include/Library/BaseCryptLib.h | 424 ++
.../Libr
Add unit test for CryptoEc.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Yi Li
---
.../BaseCryptLib/UnitTestHostBaseCryptLib.inf | 2 +
CryptoPkg/Test/CryptoPkgHostUnitTest.dsc | 3 +
.../BaseCryptLib/BaseCryptLibUnitTests.c | 1 +
.../UnitTest
Hi Jiewen,
Can you take a look at this patch?
WPA3 Tls API fuzzing is blocked because of same pem API.
Thanks,
Yi
-Original Message-
From: devel@edk2.groups.io On Behalf Of yi1 li
Sent: Thursday, September 22, 2022 8:53 PM
To: devel@edk2.groups.io
Cc: Li, Yi1 ; Yao, Jiewen ; Wang, Jian
Thanks. The solution looks good.
I recommend to add more comments below:
// Because the function does not actually print anything to buf, it returns -1
as error.
// Otherwise, the consumer may think that the buf is valid and parse the buffer.
With comment change, reviewed-by: Jiewen Yao
>
From: Jason Lou
The code changes add unit tests based on current UnitTestFramework.
EdkiiPeiMpServices2PpiPeiUnitTest PEIM is used to test
EdkiiPeiMpServices2Ppi and EfiMpServiceProtocolDxeUnitTest DXE driver is
used to test EfiMpServiceProtocol.
Change-Id: I7c48249d5113c172655df5f39cfc254f48aed
Hi Christopher,
I tried this path and the build does break for GCC5 due to NASM source files
using some VS20xx specific section names.
We will keep the .S files for GCC5 compatibility.
I also noticed that your patches did not add the build of these optimized INFs
to the CryptoPkg DSC file.
I a
*Reminder: Tools, CI, Code base construction meeting series*
*When:*
09/26/2022
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://github.com/tianocore/edk2/discussions/2614
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1610029 )
*Description:*
TianoCore communit
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4075
Fake BIO_snprintf() does not actually print anything to buf,
it should return -1 as error.
0 will be considered a correct return value, the consumer may think that
the buf is valid and parse the buffer.
please refer to bugzilla link for deta
Hi, Experts:
I have 2 questions about python support in shell environment.
1. MicroPython not supported in udk github base anymore?
It seemed intel colleagures had developmented a sample MicroPython pkg in
edk2-staging github.
2. Will CPython be supported in shell environment?
Than
Merged https://github.com/tianocore/edk2/pull/3401
> -Original Message-
> From: Li, Yi1
> Sent: Monday, September 26, 2022 8:25 AM
> To: devel@edk2.groups.io
> Cc: Li, Yi1 ; Yao, Jiewen ; Wang,
> Jian J ; Lu, Xiaoyu1 ; Jiang,
> Guomin ; Yao, Jiewen
> Subject: [PATCH V2 1/1] CryptoPkg: Fi
Hi Tiger,
CPython is already supported, see edk2-libc.
Thanks,
Pedro
On Mon, 26 Sept 2022, 01:39 Tiger Liu(BJ-RD), wrote:
> Hi, Experts:
>
> I have 2 questions about python support in shell environment.
>
>
>
> 1. MicroPython not supported in udk github base anymore?
>
> It seemed intel c
Reviewed-by: Liming Gao
发件人: chao li
发送时间: 2022年9月23日 15:04
收件人: Liming Gao ; Michael D Kinney
; Guomin Jiang ; Wei6 Xu
抄送: devel@edk2.groups.io
主题: Re: [PATCH v2 04/34] FmpDevicePkg: Add LOONGARCH64 architecture for EDK2 CI.
Hi Liming, Mike, Guomin and Wei,
This patch has not been r
Reviewed-by: Liming Gao
发件人: chao li
发送时间: 2022年9月23日 15:24
收件人: Liming Gao ; Guomin Jiang
; Baoqi Zhang
抄送: devel@edk2.groups.io
主题: Re: [PATCH v2 32/34] MdeModulePkg/DxeIplPeim : LoongArch DxeIPL
implementation.
Hi Liming and Guomin,
This patch has not been reviewed, would you plea
Hi, Pedro:
Thanks for your reply!
How about UEFI MicroPython?
Is it deprecated? Or maintained in other github branch?
Thanks
发件人: Pedro Falcato
发送时间: 2022年9月26日 10:49
收件人: edk2-devel-groups-io ; Tiger Liu(BJ-RD)
主题: Re: [edk2-devel] Questions about MicroPython and CPython in shell
environment
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Konstantin
> Aladyshev
> 发送时间: 2022年8月30日 18:15
> 收件人: devel@edk2.groups.io
> 抄送: bob.c.f...@intel.com; gaolim...@byosoft.com.cn;
> yuwei.c...@intel.com; Konstantin Aladyshev
> 主题: [edk2-devel] [PATCH 3/6] BaseTools/VolInfo
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Konstantin
> Aladyshev
> 发送时间: 2022年8月30日 18:15
> 收件人: devel@edk2.groups.io
> 抄送: bob.c.f...@intel.com; gaolim...@byosoft.com.cn;
> yuwei.c...@intel.com; Konstantin Aladyshev
> 主题: [edk2-devel] [PATCH 4/6] BaseTools/VolInfo
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Konstantin
> Aladyshev
> 发送时间: 2022年8月30日 18:15
> 收件人: devel@edk2.groups.io
> 抄送: bob.c.f...@intel.com; gaolim...@byosoft.com.cn;
> yuwei.c...@intel.com; Konstantin Aladyshev
> 主题: [edk2-devel] [PATCH 5/6] BaseTools/VolInfo
Reviewed-by: Liming Gao
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Konstantin
> Aladyshev
> 发送时间: 2022年8月30日 18:15
> 收件人: devel@edk2.groups.io
> 抄送: bob.c.f...@intel.com; gaolim...@byosoft.com.cn;
> yuwei.c...@intel.com; Konstantin Aladyshev
> 主题: [edk2-devel] [PATCH 6/6] BaseTools/VolInfo
Hi Christopher,
I have the following PR that has some proposed ideas to combine all the
optimized opensll libs into one new INF. It also addresses some
missing CI test coverage and host based unit test coverage for this
optimized openssl lib
https://github.com/tianocore/edk2/pull/3402
Please
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3892
Consumed by TlsSetEcCurve and TlsSetSignatureAlgoList.
Cc: Jiewen Yao
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Yi Li
---
MdePkg/Include/IndustryStandard/Tls1.h | 110 +
1 file changed, 74 insertions(+),
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3892
Review PR: https://github.com/tianocore/edk2/pull/3400
This patch sequence is used to extend Tls library, which are wrapped
over OpenSSL. The implementation provides library functions for EFI
DXE dirver and Protocol.
All APIs passed unit te
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3892
The implementation provides new Tls library functions
for Crypto EFI Driver and Protocol.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Yi Li
---
CryptoPkg/Driver/Crypto.c | 155 +
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3892
1. TlsSetSignatureAlgoList(): Configure the list of TLS signature algorithms
that should be used as part of the TLS session establishment.
This is needed for some WLAN Supplicant connection establishment flows
that allow only specific TLS si
This change is good to me. Reviewed-by: Liming Gao
发件人: devel@edk2.groups.io 代表 Chao Li
发送时间: 2022年9月23日 15:02
收件人: Ray Ni
抄送: devel@edk2.groups.io
主题: Re: [edk2-devel] [PATCH v2 03/34] FatPkg: Add LOONGARCH64 architecture for
EDK2 CI.
Hi Ray,
This patch has not been reviewed, would y
Mike,
I don't see any change to process_files.pl in your PR, have you made these
changes by hand? We would either need changes to the perl script to support
generating the unified INF or an expectation that the INFs would be re-combined
manually whenever an update to OpenSSL is taken.
Regarding
34 matches
Mail list logo
