Merged https://github.com/tianocore/edk2/pull/3401
> -----Original Message----- > From: Li, Yi1 <yi1...@intel.com> > Sent: Monday, September 26, 2022 8:25 AM > To: devel@edk2.groups.io > Cc: Li, Yi1 <yi1...@intel.com>; Yao, Jiewen <jiewen....@intel.com>; Wang, > Jian J <jian.j.w...@intel.com>; Lu, Xiaoyu1 <xiaoyu1...@intel.com>; Jiang, > Guomin <guomin.ji...@intel.com>; Yao, Jiewen <jiewen....@intel.com> > Subject: [PATCH V2 1/1] CryptoPkg: Fix pem heap-buffer-overflow due to > BIO_snprintf() > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4075 > > Fake BIO_snprintf() does not actually print anything to buf, > it should return -1 as error. > 0 will be considered a correct return value, the consumer may think that > the buf is valid and parse the buffer. > please refer to bugzilla link for details. > > Cc: Jiewen Yao <jiewen....@intel.com> > Cc: Jian J Wang <jian.j.w...@intel.com> > Cc: Xiaoyu Lu <xiaoyu1...@intel.com> > Cc: Guomin Jiang <guomin.ji...@intel.com> > > Signed-off-by: Yi Li <yi1...@intel.com> > reviewed-by: Jiewen Yao <jiewen....@intel.com> > --- > CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c > b/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c > index c1fc33538f..b65d29485b 100644 > --- a/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c > +++ b/CryptoPkg/Library/BaseCryptLib/SysCall/CrtWrapper.c > @@ -494,7 +494,9 @@ BIO_snprintf ( > ... > ) > { > - return 0; > + // Because the function does not actually print anything to buf, it returns > -1 as error. > + // Otherwise, the consumer may think that the buf is valid and parse the > buffer. > + return -1; > } > > #ifdef __GNUC__ > -- > 2.31.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94299): https://edk2.groups.io/g/devel/message/94299 Mute This Topic: https://groups.io/mt/93918011/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
