[edk2-devel] [PATCH v3 0/2] UnitTestFrameworkPkg: Add code coverage support for GCC

2022-09-22 Thread Guo, Gua
From: Gua Guo V1: Add coverage option for GCC V2: Add ReadMe.md for how to generate coverage report V3: Add VS2019 and GCC code coverage support Gua Guo (2): UnitTestFrameworkPkg: Add code coverage support for GCC BaseTools/Plugin: Add coverage support for Unit Test .../HostBasedUnitTestRu

[edk2-devel] [PATCH v3 1/2] UnitTestFrameworkPkg: Add code coverage support for GCC

2022-09-22 Thread Guo, Gua
From: Gua Guo In order to collect code coverage after running executable file, generate *.gcda and *.gcno file that require by lcov tool to generate code coverage report. Cc: Michael D Kinney Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael Kubacki Signed-off-by: Gua Guo --- UnitTestFramework

[edk2-devel] [PATCH v3 2/2] BaseTools/Plugin: Add coverage support for Unit Test

2022-09-22 Thread Guo, Gua
From: Gua Guo For GCC, use lcov to generate Unit Test code coverage report For VS2019, use OpenCppCoverage to generate code coverage report Cc: Bob Feng Cc: Liming Gao Cc: Bret Barkelew Cc: Michael D Kinney Cc: Sean Brogan Signed-off-by: Gua Guo --- .../HostBasedUnitTestRunner.py

Re: [edk2-devel] [PATCH v3 0/2] UnitTestFrameworkPkg: Add code coverage support for GCC

2022-09-22 Thread Guo, Gua
It's PR based on the patch. Have any concern, please also share for me. https://github.com/tianocore/edk2/pull/3349 Thanks, Gua -Original Message- From: devel@edk2.groups.io On Behalf Of Guo, Gua Sent: Thursday, September 22, 2022 3:09 PM To: devel@edk2.groups.io Cc: Guo, Gua Subject: [

Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/UsbBusDxe: Avoid continuing on error path

2022-09-22 Thread Wu, Hao A
Hello, 1. For “"Avoid continuing on error path" - The reset can happen before PortState is zero'd, so running this at the start of the function ensures it will”: My take is that the execution flow is like: UsbEnumeratePort Status = HubApi->GetPortStatus (HubIf, Port, &PortState); Usb

[edk2-devel] [PATCH] SecurityPkg: Remove enforcement of final GoIdle transition for CRB commands

2022-09-22 Thread Rodrigo Gonzalez del Cueto
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4077 Following the design described in the TCG specification, the driver implementation of the CRB protocol does not require enforcing completing the transition to goIdle at the end of a command sequence. Signed-off-by: "Gonzalez Del Cueto, Rodr

Re: [edk2-devel] [PATCH] MdeModulePkg/TerminalDxe: add modes

2022-09-22 Thread Konstantin Aladyshev
> Is the issue that you are trying to solve supporting larger serial console > modes or just wanting to use the largest possible text mode at a given > graphics resolution? I spotted this issue when I wanted to use the largest possible text mode in UEFI shell at high graphics resolutions. Is it

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Edk2ToolsBuild: Fixing pipeline build due to path too long

2022-09-22 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Kun Qin Sent: Thursday, September 22, 2022 4:45 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming ; Chen, Christine ; Sean Brogan Subject: [PATCH v1 1/1] BaseTools: Edk2ToolsBuild: Fixing pipeline build due to path too long From

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Edk2ToolsBuild: Fixing pipeline build due to path too long

2022-09-22 Thread Bob Feng
Create PR https://github.com/tianocore/edk2/pull/3378 for merge. -Original Message- From: devel@edk2.groups.io On Behalf Of Bob Feng Sent: Thursday, September 22, 2022 7:11 PM To: Kun Qin ; devel@edk2.groups.io Cc: Gao, Liming ; Chen, Christine ; Sean Brogan Subject: Re: [edk2-devel] [P

[edk2-devel] File /Designs/2022/0923//How to add support for RISC-V in edk2 .pdf deleted #file-notice

2022-09-22 Thread Group Notification
The following files and folders have been deleted from the Files area of the devel@edk2.groups.io group. * /Designs/2022/0923//How to add support for RISC-V in edk2 .pdf *By:* Ni, Ray -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Onlin

Re: [edk2-devel] [PATCH] UsbNetworkPkg: add USB network devices support

2022-09-22 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] Thanks Richard. Please just send out the v2, I will give my feedback based on that. Please run PatchCheck and Uncrustify on your patch before sending it out. Also, it would be helpful if you can organize your patches on driver based instead of having everything

[edk2-devel] [PATCH 1/1] CryptoPkg: Fix pem heap-buffer-overflow due to BIO_snprintf()

2022-09-22 Thread yi1 li
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4075 Fake BIO_snprintf() need to return error status -1. 0 will be considered a correct return value, this may cause crash, please refer to bugzilla link for details. Signed-off-by: Yi Li Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guo

Re: [edk2-devel] [PATCH V2 1/3] CryptoPkg: Add EC support

2022-09-22 Thread yi1 li
Hi Mike, I have did some POC that seems existed structured PCD is hard to control binary size, Here is the previous discussion for reference. https://bugzilla.tianocore.org/show_bug.cgi?id=3679 https://edk2.groups.io/g/devel/topic/86257810#81814 https://bugzilla.tianocore.org/show_bug.cgi?id=1446

Re: [edk2-devel] [PATCH] MdeModulePkg/TerminalDxe: add modes

2022-09-22 Thread Michael D Kinney
If the goal is to support a mix of graphical and serial consoles both with high text resolutions, then your patch is appropriate. It looks like you are observing some unexpected limitations in the OVMF console management. Perhaps the OVMF maintainers can provide some advice on how to configure

Re: [edk2-devel] [PATCH v3 0/2] UnitTestFrameworkPkg: Add code coverage support for GCC

2022-09-22 Thread Michael D Kinney
This change adds a dependency on OpenCppCoverage. However, I do not see any updates to make sure OpenCppCovergae is installed. Is it installed by default in Azure Pipelines Windows agents? For local developer use cases in Windows, don’t we need to make sure stuart tools install OpenCppCoverage a

Re: [edk2-devel] [PATCH] MdeModulePkg/TerminalDxe: add modes

2022-09-22 Thread Konstantin Aladyshev
Yes, I use QEMU to run OVMF in Linux (actually in WSL). Here is a command that I use for launch: ``` qemu-system-x86_64 \ -drive if=pflash,format=raw,file=Build/OvmfX64/RELEASE_GCC5/FV/OVMF.fd \ -drive format=raw,file=fat:rw:~/UEFI_disk -vnc :1 ``` So nothing explicit about the UARTs. Best r

Re: [edk2-devel] [PATCH v3 0/2] UnitTestFrameworkPkg: Add code coverage support for GCC

2022-09-22 Thread Guo, Gua
Is it installed by default in Azure Pipelines Windows agents? Ans: I think no. For local developer use cases in Windows, don’t we need to make sure stuart tools install OpenCppCoverage as an external dependency? Ans: I don't find a good way to auto download and auto install OpenCppCoverage, so c

Re: [edk2-devel] [PATCH v3 0/2] UnitTestFrameworkPkg: Add code coverage support for GCC

2022-09-22 Thread Michael D Kinney
Gua, You may be able to use chocolatey to install opencppcoverage: https://community.chocolatey.org/packages/opencppcoverage We have used it for some other dependencies such as QEMU: https://github.com/tianocore/edk2/blob/b328bb54c6e5510bc687302e4b717694bd441891/OvmfPkg/Platfor

Re: [edk2-devel] [PATCH v3 0/2] UnitTestFrameworkPkg: Add code coverage support for GCC

2022-09-22 Thread Michael D Kinney
Gua, Also for the pip modules, do we want to add them to edk2/pip-requirements.txt so default config for local development includes these additional components that can be used when running unit tests based on edk2/UnitTestFrameworkPkg? Thanks, Mike > -Original Message- > From: Guo, Gua

Re: [edk2-devel] [PATCH] MdeModulePkg/TerminalDxe: add modes

2022-09-22 Thread Michael D Kinney
You can add the following to disable all UARTs -serial none That gives me a graphics only console. There is something strange with the Boot Maintenance Manager for OVMF. The console settings are not preserved across a reset. They are preserved for the current boot. If you go to the shell

Re: [edk2-devel] [PATCH 00/14] Introduce Lazy-accept for Tdx guest

2022-09-22 Thread Dionna Glaze via groups.io
I have a working stack with proposal 5. I was using a version of grub that didn't use Linux's EFI handover protocol, and I wasn't signalling the unaccepted memory behavior at the right place (before EBS). Many thanks to everyone who contributed to this discussion and brought some creative ideas to

[edk2-devel] [PATCH v5 0/3] DynamicTablesPkg: _CPC support

2022-09-22 Thread Jeff Brasen via groups.io
Add generator for creating the _CPC object for CPU nodes. If viewing this review by a pull request is helpful one exists here: https://github.com/NVIDIA/edk2/pull/12 Change Log: v1 - Initial Revision v2 - Added revision to object, improved error handling, changed to ACPI 6.4 structures. v3 - Min

[edk2-devel] [PATCH v5 1/3] DynamicTablesPkg: Add CM_ARM_CPC_INFO object

2022-09-22 Thread Jeff Brasen via groups.io
Introduce the CM_ARM_CPC_INFO CmObj in the ArmNameSpaceObjects. This allows to describe CPC information, as described in ACPI 6.4, s8.4.7.1 "_CPC (Continuous Performance Control)". Signed-off-by: Jeff Brasen --- .../Include/ArmNameSpaceObjects.h | 60 ++--- DynamicTablesP

[edk2-devel] [PATCH v5 2/3] DynamicTablesPkg: AML Code generation to add _CPC entries

2022-09-22 Thread Jeff Brasen via groups.io
_CPC entries can describe CPU performance information. The object is described in ACPI 6.4 s8.4.7.1. "_CPC (Continuous Performance Control)". Add AmlCreateCpcNode() helper function to add _CPC entries to an existing CPU object. Signed-off-by: Jeff Brasen --- .../Include/Library/AmlLib/

[edk2-devel] [PATCH v5 3/3] DynamicTablesPkg: SSDT CPU _CPC generator

2022-09-22 Thread Jeff Brasen via groups.io
Add code to use a token attached to GICC to generate _CPC object on cpus. Signed-off-by: Jeff Brasen --- .../SsdtCpuTopologyGenerator.c| 133 +- 1 file changed, 127 insertions(+), 6 deletions(-) diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTo

[edk2-devel] [PATCH v3] EmbeddedPkg/PrePiMemoryAllocationLib: Add check for space on offset allocation

2022-09-22 Thread Jeff Brasen via groups.io
Update check for enough space to occur prior to alignment offset. This prevents cases where EfiFreeMemoryTop < EfiFreeMemoryBottom. Change-Id: I58c5d378523c881a4afc655e7ace4c009130c781 --- .../MemoryAllocationLib.c | 48 --- 1 file changed, 21 insertions(

[edk2-devel] [PATCH 0/3] Add safe unaccepted memory behavior

2022-09-22 Thread Dionna Glaze via groups.io
These three patches build on the lazy-accept patch series "Introduce Lazy-accept for Tdx guest" by adding SEV-SNP support for the MemoryAccept protocol, and importantly making eager memory acceptance the default behavior. For unaccepted memory to be enabled, we must know that the booted image su

[edk2-devel] [PATCH 1/3] OvmfPkg: Realize EfiMemoryAcceptProtocol in AmdSevDxe

2022-09-22 Thread Dionna Glaze via groups.io
From: Sophia Wolf When a guest OS does not support unaccepted memory, the unaccepted memory must be accepted before returning a memory map to the caller. EfiMemoryAcceptProtocol is defined in MdePkg and is implementated / Installed in AmdSevDxe for AMD SEV-SNP memory acceptance. Cc: Gerd Hoffma

[edk2-devel] [PATCH 2/3] DxeMain accepts all memory at EBS if needed

2022-09-22 Thread Dionna Glaze via groups.io
With the addition of the EfiUnacceptedMemory memory type, it is possible the EFI-enlightened guests do not themselves support the new memory type. This commit adds a dynamic Pcd that can be set to enable unaccepted memory support before ExitBootServices is called. The expected usage is to set the

[edk2-devel] [PATCH v1 3/3] CryptoPkg/OpensslLib: Update generated files for native X64

2022-09-22 Thread Christopher Zurcher
Cc: Yi Li Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: Christopher Zurcher --- CryptoPkg/Library/OpensslLib/OpensslLibX64.inf| 53 CryptoPkg/Library/OpensslLib/OpensslLibX64Gcc.inf | 53 2 files changed, 106 insert

[edk2-devel] [PATCH v1 1/3] CryptoPkg/OpensslLib: Add native instruction support for IA32

2022-09-22 Thread Christopher Zurcher
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3654 Adding native instruction support for accelerated OpenSSL features for IA32 architecture, following the pattern set by the previous commits for X64 native support. Cc: Yi Li Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang

[edk2-devel] [PATCH v1 0/3] CryptoPkg/OpensslLib: Add native instruction support for IA32

2022-09-22 Thread Christopher Zurcher
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3654 PR: https://github.com/tianocore/edk2/pull/3352 This patch adds support for building the native instruction algorithms for the IA32 architecture in OpensslLib. The base variant has been tested with VS2019 and CLANGPDB toolchains, and a GCC v

[edk2-devel] [PATCH 3/3] MdeModulePkg: add EnableUnacceptedMemoryProtocol

2022-09-22 Thread Dionna Glaze via groups.io
Add a simple protocol that enables the use of the unaccepted memory type. Must be called before ExitBootServices to be effective. Cc: Gerd Hoffmann Cc: James Bottomley Cc: Jiewen Yao Cc: Tom Lendacky Cc: Ard Biesheuvel Signed-off-by: Dionna Glaze --- MdeModulePkg/Core/Dxe/DxeMain.h

Re: [edk2-devel] How to guard CAR's stack overflow

2022-09-22 Thread Brian J. Johnson
I've never tried protecting the stack like this, so I'm not sure exactly what you're running in to. The documentation says the base address is specified a bit differently for expand-down descriptors.  It needs to point to the page below the stack (lower addresses.)  The descriptors for the othe

[edk2-devel] OvmfPkgX64: PlatformInitLib.lib(IntelTdx.obj): in function `ValidateHobList': undefined reference to `memcpy' (CLANG38 NOOPT)

2022-09-22 Thread Rebecca Cran
I just noticed that edk2 master seems broken when building OvmfPkgX64.dsc with -t CLANG38 -b NOOPT (using Debian clang version 11.0.1-2). "clang" -o /home/rcran/src/upstream/uefi/edk2/Build/OvmfX64/NOOPT_CLANG38/X64/MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe/DEBUG/DiskIoDxe.dll -nostdlib

Re: [edk2-devel] OvmfPkgX64: PlatformInitLib.lib(IntelTdx.obj): in function `ValidateHobList': undefined reference to `memcpy' (CLANG38 NOOPT)

2022-09-22 Thread Ard Biesheuvel
On Thu, 22 Sept 2022 at 23:12, Rebecca Cran wrote: > > I just noticed that edk2 master seems broken when building OvmfPkgX64.dsc > with -t CLANG38 -b NOOPT (using Debian clang version 11.0.1-2). > > "clang" -o > /home/rcran/src/upstream/uefi/edk2/Build/OvmfX64/NOOPT_CLANG38/X64/MdeModulePkg/Unive

Re: [edk2-devel] [PATCH v3] EmbeddedPkg/PrePiMemoryAllocationLib: Add check for space on offset allocation

2022-09-22 Thread Ard Biesheuvel
On Thu, 22 Sept 2022 at 22:40, Jeff Brasen wrote: > > Update check for enough space to occur prior to alignment offset. > This prevents cases where EfiFreeMemoryTop < EfiFreeMemoryBottom. > > Change-Id: I58c5d378523c881a4afc655e7ace4c009130c781 Thanks for respinning this. Care to add a signed-off

Re: [edk2-devel] [PATCH V2 1/3] CryptoPkg: Add EC support

2022-09-22 Thread Michael D Kinney
Hi Yi, I agree EC is an important feature. I did some analysis of the size impact to the CryptoPkg modules on current trunk with EC on and off. Uncompressed size is important for PEI Phase. For DXE and SMM phase, the Crypto services can always be compressed. From the table below, building all t

Re: [edk2-devel] OvmfPkgX64: PlatformInitLib.lib(IntelTdx.obj): in function `ValidateHobList': undefined reference to `memcpy' (CLANG38 NOOPT)

2022-09-22 Thread Rebecca Cran
On 9/22/22 15:32, Ard Biesheuvel wrote: This appears to be due to the use of initializers for the arrays. Could you please check if the patch below makes the issue go away? diff --git a/OvmfPkg/Library/PlatformInitLib/IntelTdx.c b/OvmfPkg/Library/PlatformInitLib/IntelTdx.c index c6d7c8bb6e0e..0e

Re: [edk2-devel] How to guard CAR's stack overflow

2022-09-22 Thread Tiger Liu(BJ-RD)
Hi, Johnson: Thanks a lot. Usually stack locates on top of heap area, After swapping stack and heap’s location, your method seems ok. Thanks 发件人: Brian J. Johnson 发送时间: 2022年9月23日 5:07 收件人: Tiger Liu(BJ-RD) ; devel@edk2.groups.io; Ni, Ray 主题: Re: [edk2-devel] How to guard CAR's stack overflow

Re: [edk2-devel] [PATCH v1 1/2] SignedCapsulePkg: Add package CI YAML file

2022-09-22 Thread Michael Kubacki
Review reminder On 9/15/2022 3:36 PM, Michael Kubacki wrote: Hi Jian, Can you please provide a review for this patch? Mike Kinney has already given an R-b for [PATCH v1 2/2] so the series will be ready once this patch is reviewed. Thanks, Michael On 9/7/2022 1:05 AM, Michael Kubacki wrote:

Re: [edk2-devel] [PATCH v2 3/6] IntelFsp2Pkg: Add CI YAML file

2022-09-22 Thread Michael Kubacki
Review reminder On 9/15/2022 3:41 PM, Michael Kubacki wrote: Hi Chasel, Your CI YAML file feedback in v1 is addressed now in v2. Can you please provide your review on this patch and [PATCH v2 5/6]? Note that I updated the commit message for this patch to remove the info about the build being

[edk2-devel] [PATCH v2 0/5] CryptoPkg: Add HMAC-SHA384 cipher support.

2022-09-22 Thread Qi Zhang
HmacSha256 is already supported on Edk2. This patchset is to add HmacSha384 support. With this change, the size increase of BaseCyrptLib is about 7K bytes. HmacSha384 function is verifed by the Host UnitTest. And also it has been integratd in https://github.com/tianocore/edk2-staging/tree/DeviceSe

[edk2-devel] [PATCH v2 1/5] CryptoPkg: Add new hmac definition to cryptlib

2022-09-22 Thread Qi Zhang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4025 Signed-off-by: Qi Zhang Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Reviewed-by: Jiewen Yao --- CryptoPkg/Include/Library/BaseCryptLib.h | 188 .../Pcd/PcdCryptoServiceFamilyEnable.h| 1

[edk2-devel] [PATCH v2 2/5] CryptoPkg: Add HMAC-SHA384 cipher support.

2022-09-22 Thread Qi Zhang
Rename file from CryptHmacSha256 to CryptHmac and add HmacSha384 and HmacSha256All funcitons. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4025 Signed-off-by: Qi Zhang Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Reviewed-by: Jiewen Yao --- .../Library/BaseCryptLib/

[edk2-devel] [PATCH v2 3/5] CryptoPkg: Update CryptLib inf as the file name changed.

2022-09-22 Thread Qi Zhang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4025 Signed-off-by: Qi Zhang Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Reviewed-by: Jiewen Yao --- CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf | 2 +- CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf

[edk2-devel] [PATCH v2 4/5] CryptoPkg: Add new hmac SHA api to Crypto Service.

2022-09-22 Thread Qi Zhang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4025 Signed-off-by: Qi Zhang Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Reviewed-by: Jiewen Yao --- CryptoPkg/CryptoPkg.dsc | 3 + CryptoPkg/Driver/Crypto.c | 224 +

[edk2-devel] [PATCH v2 5/5] CryptoPkg: add Hmac Sha384 to host UnitTest.

2022-09-22 Thread Qi Zhang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4025 Signed-off-by: Qi Zhang Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Reviewed-by: Jiewen Yao --- .../BaseCryptLib/UnitTestHostBaseCryptLib.inf | 2 +- .../UnitTest/Library/BaseCryptLib/HmacTests.c | 19 ++

[edk2-devel] Now: EDKII Open Design Meeting - 09/23/2022 #cal-notice

2022-09-22 Thread Group Notification
*EDKII Open Design Meeting* *When:* 09/23/2022 9:30am to 10:00am (UTC+08:00) Asia/Shanghai *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_YWI4NDI4OGItOGM4OS00NDc0LWEzMDktOTExNjEzMDQ1ZGYy%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed4-8496-4ed7712e255d%22%2c%22Oid%22%3

Re: [edk2-devel] [PATCH] SecurityPkg: Remove enforcement of final GoIdle transition for CRB commands

2022-09-22 Thread Yao, Jiewen
Would you please describe: 1) What test you have done? Which TPM chips you have tested? 2) Which specific section/sentence you are following to remove the goIde? I would like to double check spec. Thank you Yao, Jiewen > -Original Message- > From: Gonzalez Del Cueto, Rodrigo > Sent: T

Re: [edk2-devel] [PATCH V2 1/3] CryptoPkg: Add EC support

2022-09-22 Thread yi1 li
Hi Mike, 1. Yes, it matches. By Intel side, 100+kb(20%+) FV size increase will be a big concern, please refer to another internal email. 2. Additional size is coming from modules may consumed EC APIs, eg. TLS PEM X509 ... If we added EC source to OpensslLib.inf and disabled macro OPENSSL_NO_E

Re: [edk2-devel] [PATCH v2 23/34] MdePkg/BaseLib: BaseLib for LOONGARCH64 architecture.

2022-09-22 Thread Chao Li
Hi Mike, In the V2, I removed the unaligned read/write functions in LoongArch library and used the generic implementation, can you review it again? Thanks, Chao On 9月 14 2022, at 5:41 下午, Chao Li wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053 > > Add LoongArch LOONGA

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Edk2ToolsBuild: Fixing pipeline build due to path too long

2022-09-22 Thread Kun Qin
Thanks for the help, Bob. It seems that one of the "Reviewed-by" tags are breaking the pipeline patchcheck: https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=62531&view=logs&j=12f1170f-54f2-53f3-20dd-22fc7dff55f9&t=9c939e41-62c2-5605-5e05-fc3554afc9f5 Would like me to send a v2 pat

Re: [edk2-devel] [PATCH v2 24/34] MdePkg/BaseCacheMaintenanceLib: LoongArch cache maintenance implementation.

2022-09-22 Thread Chao Li
Hi Mike, I have converted the cache opeartion to .S, the implementation please refer to the patch 0023, can you review it again? Thanks, Chao On 9月 14 2022, at 5:41 下午, Chao Li wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053 > > Implement LoongArch cache maintenance f

回复: [edk2-devel] [PATCH] UsbNetworkPkg: add USB network devices support

2022-09-22 Thread gaoliming via groups.io
Richard: We also verify USB RNDIS module with open BMC. It reports USB RNDIS device descriptor type is USB_DESC_TYPE_INTERFACE (0x04). It is not supported by Rndis module. But in UsbNetworkPkg\Include\Protocol\UsbEthernetProtocol.h, it defines CS_INTERFACE as 0x24. Rndis module only supports t

Re: [edk2-devel] [PATCH V2 1/3] CryptoPkg: Add EC support

2022-09-22 Thread Michael D Kinney
Hi Yi, I agree there are some complex interactions in the opensll sources. Since you are defining a family for EC, can we use the EC Family != 0 instead of PcdOpensslEcEnabled and remove PcdOpensslEcEnabled. I want to make sure developers do not run into strange build failures if they do not kee

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Store PageTablePool in TdxWorkArea

2022-09-22 Thread Gerd Hoffmann
On Thu, Sep 22, 2022 at 04:43:04AM +, Xu, Min M wrote: > Hi, Gerd > Do you have any comments on this patch? Looks ok to me. But I'm increasingly wondering whenever it actually was that a smart move to ditch the PEI phase for the IntelTdx builds. Anything which can't be handled in DXE must be

Re: 回复: [edk2-devel] [PATCH] UsbNetworkPkg: add USB network devices support

2022-09-22 Thread RichardHo [何明忠] via groups . io
Hi Liming, RNDIS specification is not defines this. We're follow the ECM (5.4 Ethernet Networking Functional Descriptor) and NCM (5.2.1 NCM Functional Descriptor)specification to implement RNDIS driver. If RNDIS device has other way to know the networking functional information. We could impleme

Re: [edk2-devel] [PATCH v2 08/34] MdePkg/Include: Add LOONGARCH related definitions EDK2 CI.

2022-09-22 Thread Chao Li
Hi Mike, In the V2, I updated the IANA URL link in Dhcp.h, can you review this patch again? Thanks, Chao On 9月 14 2022, at 5:36 下午, Chao Li wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053 > > HTTP/PXE boot LOONGARCH64 related definitions for EDK2 CI. > For the LOONGAR

[edk2-devel] [PATCH V2 0/4] CryptoPkg: Add Hkdf SHA384 support

2022-09-22 Thread Qi Zhang
Add Hkdf-SHA384 support and Hkdf-SHA256 extract and expand separately. With this change, the size increase of BaseCyrptLib is about 6K bytes. The new functions are verifed by the Host UnitTest. And also it has been integratd in https://github.com/tianocore/edk2-staging/tree/DeviceSecurity and been

[edk2-devel] [PATCH V2 1/4] CryptoPkg: add new Hkdf api definition in Crypt Lib.

2022-09-22 Thread Qi Zhang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4033 Signed-off-by: Qi Zhang Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Reviewed-by: Jiewen Yao --- CryptoPkg/Include/Library/BaseCryptLib.h | 129 .../Pcd/PcdCryptoServiceFamilyEnable.h|

[edk2-devel] [PATCH V2 2/4] CryptoPkg: add new Hkdf api in Crypt Lib.

2022-09-22 Thread Qi Zhang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4033 Signed-off-by: Qi Zhang Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Reviewed-by: Jiewen Yao --- .../Library/BaseCryptLib/Kdf/CryptHkdf.c | 362 +- .../Library/BaseCryptLib/Kdf/CryptHkdfNull.c |

[edk2-devel] [PATCH V2 3/4] CryptoPkg: add new Hkdf api to Crypto Service.

2022-09-22 Thread Qi Zhang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4033 Signed-off-by: Qi Zhang Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Reviewed-by: Jiewen Yao --- CryptoPkg/Driver/Crypto.c | 152 +- .../BaseCryptLibOnProtocolPpi/CryptLib.c |

[edk2-devel] [PATCH V2 4/4] CryptoPkg: add Hkdf UnitTest.

2022-09-22 Thread Qi Zhang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4033 Signed-off-by: Qi Zhang Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Reviewed-by: Jiewen Yao --- .../BaseCryptLib/BaseCryptLibUnitTests.c | 29 +-- .../UnitTest/Library/BaseCryptLib/HkdfTests.c | 202 +++

Re: [edk2-devel] [PATCH EDK2 v1 1/1] CryptoPkg/BaseCryptLib:Remove redundant init

2022-09-22 Thread Yao, Jiewen
Reviewed-by: Jiewen Yao Merged https://github.com/tianocore/edk2/pull/3356 > -Original Message- > From: Wenyi Xie > Sent: Thursday, September 15, 2022 5:26 PM > To: devel@edk2.groups.io; Yao, Jiewen ; Wang, Jian > J ; Lu, Xiaoyu1 ; Jiang, > Guomin > Cc: songdongku...@huawei.com; xiewen

[edk2-devel] [PATCH V2 0/4] CryptoPkg: add AeadAesGcm support.

2022-09-22 Thread Qi Zhang
Add AeadAesGcm Encrypt and Decrypt. With this change, the size increase of BaseCyrptLib is about 60K bytes. The new functions are verifed by the Host UnitTest. And also it has been integratd in https://github.com/tianocore/edk2-staging/tree/DeviceSecurity and been verified. All the code change is

[edk2-devel] [PATCH V2 1/4] CryptoPkg: add AeadAesGcm function() definition.

2022-09-22 Thread Qi Zhang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4036 Signed-off-by: Qi Zhang Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Reviewed-by: Jiewen Yao --- CryptoPkg/Include/Library/BaseCryptLib.h | 87 1 file changed, 87 insertions(+) diff --git a/C

[edk2-devel] [PATCH V2 2/4] CryptoPkg: add AeadAesGcm support.

2022-09-22 Thread Qi Zhang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4036 Signed-off-by: Qi Zhang Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Reviewed-by: Jiewen Yao --- .../Library/BaseCryptLib/BaseCryptLib.inf | 1 + .../BaseCryptLib/Cipher/CryptAeadAesGcm.c | 279 +

[edk2-devel] [PATCH V2 3/4] CryptoPkg: add AeadAesGcm to Crypto Service.

2022-09-22 Thread Qi Zhang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4036 Signed-off-by: Qi Zhang Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Reviewed-by: Jiewen Yao --- CryptoPkg/CryptoPkg.dsc | 2 + CryptoPkg/Driver/Crypto.c | 94 +++

[edk2-devel] [PATCH V2 4/4] CryptoPkg: add UnitTest for AeadAesGcm.

2022-09-22 Thread Qi Zhang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4036 Signed-off-by: Qi Zhang Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Reviewed-by: Jiewen Yao --- .../BaseCryptLib/UnitTestHostBaseCryptLib.inf | 1 + .../Library/BaseCryptLib/AeadAesGcmTests.c| 112 +

Re: [edk2-devel] [PATCH v2 22/34] MdePkg/Include: LoongArch definitions.

2022-09-22 Thread Chao Li
Hi Mike, In the V2, I added IANA, Microsoft and UEFI specification links in every patches that uses them. Associated patches: 0008-MdePkg-Include-Add-LOONGARCH-related-definitions-.patch 0015-BaseTools-BaseTools-changes-for-LoongArch-platfor.patch 0022-MdePkg-Include-LoongArch-definitions.patch(T

Re: [edk2-devel] [PATCH 0/5] CryptoPkg: Add HMAC-SHA384 cipher support.

2022-09-22 Thread Qi Zhang
Hi, Jiewen Thanks for review. I've sent out v2 patch set for HMAC-SHA384, Hkdf SHA384, AeadAesGcm with comments addressed. All the change is on PR https://github.com/tianocore/edk2/pull/3224. The merge order shall be HMAC-SHA384 -> Hkdf SHA384 -> AeadAesGcm. Thank you! Qi Zhang -Origina

[edk2-devel] How to set I2C host controller address/input clock frequency for MinnowBoard?

2022-09-22 Thread gordontcp
In 'MdeModulePkg\Bus\I2c\I2cDxe', since the following protocol is not installed: gEfiI2cMasterProtocolGuid gEfiI2cEnumerateProtocolGuid gEfiI2cBusConfigurationManagementProtocolGuid So I refer to the example of \edk2-platforms\Silicon\Marvell\Drivers\I2c\MvI2cDxe and add the following related i

Re: [edk2-devel] [PATCH v2 01/34] MdePkg: Added file of DebugSupport.h to MdePkg.ci.yaml

2022-09-22 Thread Chao Li
Hi Mike, Liming and Zhiguang, This patch has not been reviewed, would you please review it? Thanks, Chao On 9月 14 2022, at 5:35 下午, Chao Li wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053 > > DebugSupport.h is all defined by UEFI Spec, most of the code > doesn't fit ED