Thanks for the help, Bob. It seems that one of the "Reviewed-by" tags
are breaking the pipeline patchcheck:
https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=62531&view=logs&j=12f1170f-54f2-53f3-20dd-22fc7dff55f9&t=9c939e41-62c2-5605-5e05-fc3554afc9f5
Would like me to send a v2 patch?
Regards,
Kun
On 09/22/2022 04:26, Bob Feng wrote:
Create PR https://github.com/tianocore/edk2/pull/3378 for merge.
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Bob Feng
Sent: Thursday, September 22, 2022 7:11 PM
To: Kun Qin <kuqi...@gmail.com>; devel@edk2.groups.io
Cc: Gao, Liming <gaolim...@byosoft.com.cn>; Chen, Christine <yuwei.c...@intel.com>;
Sean Brogan <sean.bro...@microsoft.com>
Subject: Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Edk2ToolsBuild: Fixing
pipeline build due to path too long
Reviewed-by: Bob Feng <bob.c.f...@intel.com>
-----Original Message-----
From: Kun Qin <kuqi...@gmail.com>
Sent: Thursday, September 22, 2022 4:45 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C <bob.c.f...@intel.com>; Gao, Liming <gaolim...@byosoft.com.cn>; Chen,
Christine <yuwei.c...@intel.com>; Sean Brogan <sean.bro...@microsoft.com>
Subject: [PATCH v1 1/1] BaseTools: Edk2ToolsBuild: Fixing pipeline build due to
path too long
From: Sean Brogan <sean.bro...@microsoft.com>
Current implementation of looking up toolchain will _insert_ the findings from
vsvarsall.bat to existing path and potentially stuff the variable to exceed the
length of maximal path length accepted by Windows.
This change updated the logic to use the discovered shell varialbes to replace
the existing path, which is desirable in the specific use case.
Cc: Bob Feng <bob.c.f...@intel.com>
Cc: Liming Gao <gaolim...@byosoft.com.cn>
Cc: Yuwei Chen <yuwei.c...@intel.com>
Co-authored-by: Sean Brogan <sean.bro...@microsoft.com>
Signed-off-by: Kun Qin <kuqi...@gmail.com>
---
BaseTools/Edk2ToolsBuild.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/BaseTools/Edk2ToolsBuild.py b/BaseTools/Edk2ToolsBuild.py index
1ea8187de693..f862468ce275 100644
--- a/BaseTools/Edk2ToolsBuild.py
+++ b/BaseTools/Edk2ToolsBuild.py
@@ -122,7 +122,7 @@ class Edk2ToolsBuild(BaseAbstractInvocable):
for key in vc_vars.keys(): logging.debug(f"Var - {key}
= {vc_vars[key]}") if key.lower() == 'path':-
shell_env.insert_path(vc_vars[key])+ shell_env.set_path(vc_vars[key])
else: shell_env.set_shell_var(key, vc_vars[key]) --
2.37.1.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#94162): https://edk2.groups.io/g/devel/message/94162
Mute This Topic: https://groups.io/mt/93835889/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
