[edk2-devel] [RFC PATCH V2 02/19] MdePkg/MdePkg.dec: Add RISCV_EFI_BOOT_PROTOCOL GUID

RISC-V UEFI based platforms need to support RISCV_EFI_BOOT_PROTOCOL. Add this protocol GUID definition. Signed-off-by: Sunil V L --- MdePkg/MdePkg.dec | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index f1ebf9e251c1..8f1bcfdc3e97 100644 --- a/Mde

[edk2-devel] [RFC PATCH V2 03/19] MdePkg/Protocol: Add RiscVBootProtocol.h

RISC-V UEFI platforms need to implement RISCV_EFI_BOOT_PROTOCOL. Add header file with the definitions of this protocol. Signed-off-by: Sunil V L --- MdePkg/Include/Protocol/RiscVBootProtocol.h | 35 1 file changed, 35 insertions(+) diff --git a/MdePkg/Include/Protocol/RiscV

[edk2-devel] [RFC PATCH V2 04/19] MdeModulePkg/MdeModulePkg.dec: Add PCD variables for RISC-V

Add few PCD variables for RISC-V platforms to indicate the memory locations of the firmware volumes, temporary RAM etc. Signed-off-by: Sunil V L --- MdeModulePkg/MdeModulePkg.dec | 13 + 1 file changed, 13 insertions(+) diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeMo

[edk2-devel] [RFC PATCH V2 05/19] UefiCpuPkg.dec: Add PCD variable for RISC-V

RISC-V platforms need PCD variable to indicate the mtimer frequency which will be consumed by CpuDxe and TimerLib. Signed-off-by: Sunil V L --- UefiCpuPkg/UefiCpuPkg.dec | 3 +++ 1 file changed, 3 insertions(+) diff --git a/UefiCpuPkg/UefiCpuPkg.dec b/UefiCpuPkg/UefiCpuPkg.dec index 718323d9042

[edk2-devel] [RFC PATCH V2 06/19] MdePkg/BaseLib: RISC-V: Add generic CPU related functions

EDK2 in S-mode needs to use SSCRATCH register. Implement functions to set/get the SSCRATCH register. Signed-off-by: Sunil V L --- MdePkg/Library/BaseLib/BaseLib.inf | 1 + MdePkg/Include/Library/BaseLib.h| 10 ++ MdePkg/Library/BaseLib/RiscV64/CpuGen.S | 33

[edk2-devel] [RFC PATCH V2 07/19] MdePkg: Add ArchTimerLib library

This library implements the TimerLib.h functionality. This library is similar to CpuTimerLib but needs the library constructor. Signed-off-by: Sunil V L --- MdePkg/Library/ArchTimerLib/ArchTimerLib.inf | 40 +++ MdePkg/Library/ArchTimerLib/RiscV64/CpuTimerLib.c | 299

[edk2-devel] [RFC PATCH V2 08/19] MdePkg: Add RiscVSbiLib Library for RISC-V

This library is required to make SBI ecalls from the S-mode EDK2. Signed-off-by: Sunil V L --- MdePkg/Library/RiscVSbiLib/RiscVSbiLib.inf | 27 +++ MdePkg/Include/Library/RiscVSbiLib.h | 129 +++ MdePkg/Library/RiscVSbiLib/RiscVSbiLib.c | 228 3 files change

[edk2-devel] [RFC PATCH V2 09/19] UefiCpuPkg: Update Sources in DxeCpuExceptionHandlerLib.inf

Currently the common sources mean x86 only in this library. To add support for other architectures like RISC-V, we need to build these files only for x86. Signed-off-by: Sunil V L --- UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeCpuExceptionHandlerLib.inf | 6 -- 1 file changed, 4 insertion

[edk2-devel] [RFC PATCH V2 10/19] UefiCpuPkg: Add RISC-V support in DxeCpuExceptionHandlerLib

Add low level interfaces to register exception and interrupt handlers for RISC-V. Signed-off-by: Sunil V L --- UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeCpuExceptionHandlerLib.inf| 7 +- UefiCpuPkg/Library/CpuExceptionHandlerLib/RiscV64/CpuExceptionHandlerLib.h | 112

[edk2-devel] [RFC PATCH V2 11/19] MdePkg/Library: Add ResetSystemLib library

This library implements system reset interfaces like cold reboot, warm reboot etc. On RISC-V platforms, these are implemented using SBI calls. Signed-off-by: Sunil V L --- MdePkg/Library/ResetSystemLib/ResetSystemLib.inf | 35 ++ MdePkg/Library/ResetSystemLib/RiscV64/ResetSystemLib.c

[edk2-devel] [RFC PATCH V2 12/19] UefiCpuPkg/SecCore: Add SEC startup code for RISC-V

Generic RISC-V platforms will start in S-mode directly. Previous M-mode firmware like opensbi will branch to the entry point in this module. This module initializes the firmware context pointer and branches to the PEI phase. Signed-off-by: Sunil V L --- UefiCpuPkg/SecCore/SecCoreRiscV.inf | 5

[edk2-devel] [RFC PATCH V2 13/19] MdePkg: Add PlatformPeiLib library

This library is required in RISC-V to build the FDT Hob. The library can be leveraged by other architectures like ARM if required. Signed-off-by: Sunil V L --- MdePkg/Library/PlatformPeiLib/PlatformPeiLib.inf | 40 MdePkg/Include/Library/PlatformPeiLib.h| 15 ++

[edk2-devel] [RFC PATCH V2 14/19] MdeModulePkg/Universal: Add PlatformPei module for RISC-V

Thie PEIM is required to do platform specific initialization like detecting the permanent memory and install memory HOB, install the FDT Hob etc. Signed-off-by: Sunil V L --- MdeModulePkg/Universal/PlatformPei/PlatformPei.inf | 65 MdeModulePkg/Universal/PlatformPei/RiscV64/Platform.h

[edk2-devel] [RFC PATCH V2 15/19] UefiCpuPkg/CpuDxe: Refactor to allow other CPU architectures

Currently, CpuDxe driver is mostly x86 specific. Refactor the INF to allow other architectures like RISC-V. Signed-off-by: Sunil V L --- UefiCpuPkg/CpuDxe/CpuDxe.inf | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/UefiCpuPkg/CpuDxe/CpuDxe.inf b/UefiCpuPkg/CpuDxe/

[edk2-devel] [RFC PATCH V2 16/19] UefiCpuPkg/CpuDxe: Add RISC-V support in CpuDxe module

This DXE module initializes the RISC-V CPU by installing the CPU specific ARCH protocol handlers. This also initializes the RISCV_EFI_BOOT_PROTOCOL which is required on RISC-V platforms. Signed-off-by: Sunil V L --- UefiCpuPkg/CpuDxe/CpuDxe.inf | 16 +- UefiCpuPkg/CpuDxe/RiscV64/CpuDxe.h

[edk2-devel] [RFC PATCH V2 17/19] MdeModulePkg/Universal: Add TimerDxe module

This DXE module initializes the timer interrupt handler and installs the Arch Timer protocol. Signed-off-by: Sunil V L --- MdeModulePkg/Universal/TimerDxe/TimerDxe.inf| 52 MdeModulePkg/Universal/TimerDxe/RiscV64/Timer.h | 174 MdeModulePkg/Universal/TimerDxe/RiscV64/Timer

[edk2-devel] [RFC PATCH V2 18/19] RISC-V: Add Qemu Virt platform support

Add build infrastructure files to boot qemu virt machine. EDK2 will boot as S-mode payload of opensbi. There is no integrated opensbi (M-mode firmware) within EDK2 for virt machine. It relies on the RISC-V calling convention that M-mode firmware like opensbi will pass the BootHartId and the DTB t

Re: [edk2-devel] [RFC PATCH 16/17] UefiCpuPkg/CpuDxe: Add RISC-V support in CpuDxe module

[AMD Official Use Only - General] > -Original Message- > From: Sunil V L > Sent: Wednesday, September 7, 2022 7:22 PM > To: Chang, Abner > Cc: devel@edk2.groups.io; Jian J Wang ; Liming Gao > ; Eric Dong ; Ray Ni > ; Rahul Kumar ; Debkumar De > ; Catharine West ; > Daniel Schaefer ; Le

Re: [edk2-devel] [PATCH] BaseTools/GenFw AARCH64: Convert more types of explicit GOT references

Acked-by: Bob Feng -Original Message- From: Leif Lindholm Sent: Tuesday, September 6, 2022 7:54 PM To: Ard Biesheuvel ; Rebecca Cran Cc: devel@edk2.groups.io; Feng, Bob C ; Gao, Liming ; Kinney, Michael D Subject: Re: [edk2-devel] [PATCH] BaseTools/GenFw AARCH64: Convert more types

[edk2-devel] Pip edk2-basetools diverged from edk2/BaseTools (e.g. doesn't have "Revert "BaseTools: Fix DSC LibraryClass precedence rule"")

I've been running into a problem with CI that was fixed in edk2 BaseTools before the recent stable tag: ERROR - Compiler #3000 from /home/vsts/work/1/s/MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.inf(42): PCD [gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode] in [/home/vsts/w

Re: [edk2-devel] [edk2-platforms][PATCH v4 1/2] Ext4Pkg: Add symbolic links support

Hi Pedro, Thank you for your code-review. I answer to comments inline too. > On 30 Aug 2022, at 04:12, Pedro Falcato wrote: > > Hi Savva, > > Sorry for the huge delay. Comments inline. > > On Thu, Jul 28, 2022 at 4:26 PM Savva Mitrofanov > wrote: > BZ: https://bugz

[edk2-devel] [edk2-platforms][PATCH v5 0/2] Ext4Pkg: Add Symbolic Links support

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3677 Hi all, In the fifth version I corrected remarks from Pedro Falcato and Marvin Häuser. I moved symlink procedures into independent C file, corrected code style like debug messages macros and etc. This patchset adds symbolic links support wi

[edk2-devel] [edk2-platforms][PATCH v5 2/2] Ext4Pkg: Add base containing record macro for EXT4_FILE

We shouldn't use direct casts, because in the future it could break the code, so using BASE_CR would be safe against possible structure changes and rearrangements Cc: Marvin Häuser Cc: Pedro Falcato Cc: Vitaly Cheptsov Signed-off-by: Savva Mitrofanov Reviewed-by: Marvin Häuser --- Features/E

[edk2-devel] [edk2-platforms][PATCH v5 1/2] Ext4Pkg: Add symbolic links support

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3677 Provided support for symlink file type. Added routine which allows reading and following them through recursive open() call. As a security meausure implemented simple symlink loop check with nest level limit equal 8. Also this patch moves Ext

Re: [edk2-devel] [PATCH v2] OvmfPkg: Update I/O port related to ACPI devices for CloudHv

Hi Jiewen, After I looked into the UefiPayload example, I have a few questions on how to implement things in OvmfPkg: - Do you expect EFI_HOB_PLATFORM_INFO to be extended with two additional fields AcpiTimerAddress and AcpiShutdownAddress? Or do you think the ACPI_BOARD_INFO should be copied over

Re: [edk2-devel] [PATCH 0/5] Add UEFI-SCT test cases for RISCV_EFI_BOOT_PROTOCOL

On Thu, Jun 9, 2022 at 03:57 PM, Sunil V L wrote: > > RISCV_EFI_BOOT_PROTOCOL Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93425): https://edk2.groups.io/g/devel/message/93425 Mute This Topic: https://

Re: [edk2-devel] [PATCH 1/5] uefi-sct/SctPkg: Add header file for RISCV_EFI_BOOT_PROTOCOL

Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93426): https://edk2.groups.io/g/devel/message/93426 Mute This Topic: https://groups.io/mt/91642395/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [PATCH 2/5] uefi-sct/SctPkg: Add test cases for RISCV_EFI_BOOT_PROTOCOL

Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93427): https://edk2.groups.io/g/devel/message/93427 Mute This Topic: https://groups.io/mt/91642396/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [PATCH 3/5] uefi-sct/SctPkg: Build test cases of RISCV_EFI_BOOT_PROTOCOL

Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93428): https://edk2.groups.io/g/devel/message/93428 Mute This Topic: https://groups.io/mt/91642398/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [PATCH 4/5] uefi-sct/SctPkg: Install RISCV_EFI_BOOT_PROTOCOL test module

Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93429): https://edk2.groups.io/g/devel/message/93429 Mute This Topic: https://groups.io/mt/91642400/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [PATCH 5/5] uefi-sct/SctPkg: Add a category for RISCV_EFI_BOOT_PROTOCOL

Reviewed-by: G Edhaya Chandran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93430): https://edk2.groups.io/g/devel/message/93430 Mute This Topic: https://groups.io/mt/91642401/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

Re: [edk2-devel] [PATCH] EmbeddedPkg/PrePiMemoryAllocationLib: Add check for space on offset allocation

I'll post another version to fix the formatting issue in a bit, but before the patch the issue was we applied the alignment offset before we did a space check. -Jeff > -Original Message- > From: Ard Biesheuvel > Sent: Wednesday, September 7, 2022 2:34 AM > To: Jeff Brasen > Cc: devel@

Re: [edk2-devel] Pip edk2-basetools diverged from edk2/BaseTools (e.g. doesn't have "Revert "BaseTools: Fix DSC LibraryClass precedence rule"")

Yes. I'll sync the edk2-basetools. Thanks, Bob -Original Message- From: devel@edk2.groups.io On Behalf Of Rebecca Cran Sent: Wednesday, September 7, 2022 9:08 PM To: devel@edk2.groups.io; Leif Lindholm ; Kinney, Michael D ; Andrew Fish ; Michael Kubacki ; Sean Brogan ; Barkelew, Bret

Re: [edk2-devel] [PATCH v1 0/3] EmbeddedPkg: Enable CI

When would you like to have that discussion? The Tianocore Tool, CI, Codebase meeting is every week. In that meeting we've discussed getting all edk2 packages to at least run CI. https://github.com/tianocore/edk2/discussions/2614 If you prefer to have it here, that's fine as well. On 9/7/202

Re: [edk2-devel] [PATCH v2 1/2] ArmPkg: implement EFI_MP_SERVICES_PROTOCOL based on PSCI calls

Maintainers have two options for Spell Check as described in the Spell Check CI Plugin readme - https://github.com/tianocore/edk2/tree/master/.pytool/Plugin/SpellCheck 1. Set AuditOnly to "true" - Disables all spelling errors in the package from the failing the build entirely. 2. Extend the

[edk2-devel] [PATCH 3/3] DynamicTablesPkg: SSDT CPU _CPC generator

Add code to use a token attached to GICC to generate _CPC object on cpus. Signed-off-by: Jeff Brasen --- .../SsdtCpuTopologyGenerator.c| 211 +- 1 file changed, 206 insertions(+), 5 deletions(-) diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTo

[edk2-devel] [PATCH 1/3] DynamicTablesPkg: Add CM_ARM_CPC_INFO object

Introduce the CM_ARM_CPC_INFO CmObj in the ArmNameSpaceObjects. This allows to describe CPC information, as described in ACPI 6.4, s8.4.7.1 "_CPC (Continuous Performance Control)". Signed-off-by: Jeff Brasen --- .../Include/ArmNameSpaceObjects.h | 146 -- .../C

[edk2-devel] [PATCH 2/3] DynamicTablesPkg: AML Code generation to add _CPC entries

_CPC entries can describe CPU performance information. The object is described in ACPI 6.4 s8.4.7.1. "_CPC (Continuous Performance Control)". Add AmlCreateCpcNode() helper function to add _CPC entries to an existing CPU object. Signed-off-by: Jeff Brasen --- .../Include/Library/AmlLib/

[edk2-devel] [PATCH 0/3] DynamicTablesPkg: _CPC support

Add generator for creating the _CPC object for CPU nodes. If viewing this review by a pull request is helpful one exists here: https://github.com/NVIDIA/edk2/pull/12 Jeff Brasen (3): DynamicTablesPkg: Add CM_ARM_CPC_INFO object DynamicTablesPkg: AML Code generation to add _CPC entries Dynam

Re: [edk2-devel] [PATCH v1 0/3] EmbeddedPkg: Enable CI

On Wed, 7 Sept 2022 at 17:00, Michael Kubacki wrote: > > When would you like to have that discussion? > > The Tianocore Tool, CI, Codebase meeting is every week. In that meeting > we've discussed getting all edk2 packages to at least run CI. > > https://github.com/tianocore/edk2/discussions/2614 >

Re: [edk2-devel] [PATCH v2 1/2] ArmPkg: implement EFI_MP_SERVICES_PROTOCOL based on PSCI calls

On Wed, 7 Sept 2022 at 17:11, Michael Kubacki wrote: > > Maintainers have two options for Spell Check as described in the Spell > Check CI Plugin readme - > https://github.com/tianocore/edk2/tree/master/.pytool/Plugin/SpellCheck > > 1. Set AuditOnly to "true" - Disables all spelling errors in the

Re: [edk2-devel] [PATCH v2] OvmfPkg: Update I/O port related to ACPI devices for CloudHv

I had a quick try and I've realized OvmfPkg/Library/AcpiTimerLib/BaseRomAcpiTimerLib.c didn't have access to the EFI_HOB_PLATFORM_INFO. Is there an alternative? Thanks, Sebastien On Wed, 2022-09-07 at 16:23 +0200, Sebastien Boeuf wrote: > Hi Jiewen, > > After I looked into the UefiPayload exampl

[edk2-devel] [PATCH 1/1] pip-requirement: Upgrade the edk2-basetools version from 0.1.28 to 0.1.29

features and bug fixes: 1. Revert "BaseTools: Fix DSC LibraryClass precedence rule" Signed-off-by: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Cc: Rebecca Cran --- pip-requirements.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pip-requirements.txt b/pip-requirements.txt i

Re: [edk2-devel] [PATCH v2] OvmfPkg: Update I/O port related to ACPI devices for CloudHv

I see. The is hard to let a base lib access the HOB. I think we can integrate this patch at first to make it work, with known limitation. > -Original Message- > From: Boeuf, Sebastien > Sent: Wednesday, September 7, 2022 11:21 PM > To: Yao, Jiewen > Cc: kra...@redhat.com; Justen, Jord

Re: [edk2-devel] [PATCH v2] OvmfPkg: Update I/O port related to ACPI devices for CloudHv

Ok sounds good. Thanks, Sebastien From: Yao, Jiewen Sent: Wednesday, September 7, 2022 5:23 PM To: Boeuf, Sebastien Cc: kra...@redhat.com ; Justen, Jordan L ; devel@edk2.groups.io Subject: RE: [PATCH v2] OvmfPkg: Update I/O port related to ACPI devices for Clo

[edk2-devel] [PATCH] ArmPkg, ArmVirtPkg: put SpellCheck in AuditOnly mode

Don't allow spelling errors to break the CI build and inadvertently reject pull requests - spelling is important but not that important. Signed-off-by: Ard Biesheuvel --- ArmPkg/ArmPkg.ci.yaml | 2 +- ArmVirtPkg/ArmVirtPkg.ci.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)

Re: [edk2-devel] [PATCH v2 1/2] ArmPkg: implement EFI_MP_SERVICES_PROTOCOL based on PSCI calls

Please note that I already turned AuditOnly mode on for the EmbeddedPkg patch series. On 9/7/2022 11:21 AM, Ard Biesheuvel wrote: On Wed, 7 Sept 2022 at 17:11, Michael Kubacki wrote: Maintainers have two options for Spell Check as described in the Spell Check CI Plugin readme - https://githu

Re: [edk2-devel] [PATCH] ArmPkg, ArmVirtPkg: put SpellCheck in AuditOnly mode

Reviewed-by: Michael Kubacki On 9/7/2022 11:27 AM, Ard Biesheuvel wrote: Don't allow spelling errors to break the CI build and inadvertently reject pull requests - spelling is important but not that important. Signed-off-by: Ard Biesheuvel --- ArmPkg/ArmPkg.ci.yaml | 2 +- ArmVirtP

[edk2-devel] [PATCH v2] EmbeddedPkg/PrePiMemoryAllocationLib: Check for space on offset allocation

Update check for enough space to occur prior to alignment offset modification. This prevents a case where EfiFreeMemoryTop could be less than EfiFreeMemoryBottom Signed-off-by: Jeff Brasen --- .../MemoryAllocationLib.c | 53 +++ 1 file changed, 30 inser

Re: [edk2-devel] [PATCH 1/1] pip-requirement: Upgrade the edk2-basetools version from 0.1.28 to 0.1.29

Thanks. Reviewed-by: Rebecca Cran On 9/7/22 09:23, Bob Feng wrote: features and bug fixes: 1. Revert "BaseTools: Fix DSC LibraryClass precedence rule" Signed-off-by: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Cc: Rebecca Cran --- pip-requirements.txt | 2 +- 1 file changed, 1 insertion(+),

Re: [edk2-devel] [PATCH] ArmPkg, ArmVirtPkg: put SpellCheck in AuditOnly mode

Reviewed-by: Rebecca Cran On 9/7/22 09:27, Ard Biesheuvel wrote: Don't allow spelling errors to break the CI build and inadvertently reject pull requests - spelling is important but not that important. Signed-off-by: Ard Biesheuvel --- ArmPkg/ArmPkg.ci.yaml | 2 +- ArmVirtPkg/ArmVi

Re: [edk2-devel] [PATCH v2] EmbeddedPkg/PrePiMemoryAllocationLib: Check for space on offset allocation

On Wed, 7 Sept 2022 at 17:46, Jeff Brasen wrote: > > Update check for enough space to occur prior to alignment offset > modification. This prevents a case where EfiFreeMemoryTop could be > less than EfiFreeMemoryBottom > > Signed-off-by: Jeff Brasen Thanks for the respin. I have caught up in the

[edk2-devel] MdeModulePkg: Use configurable PCD for AHCI command retries

https://bugzilla.tianocore.org/show_bug.cgi?id=4011 AHCI commands are retried internally which prevents platform feature like drive password to process correctly entered password on subsequent attempts. PCD allows the platform to determine the number of retries. Signed-off-by: Baraneedharan Anbaz

Re: [edk2-devel] [PATCH v1 0/2] MM communicate functionality in variable policy

Hi Ard, No worries. Liming has helped to merge these patches here: MM communicate functionality in variable policy by lgao4 · Pull Request #2443 · tianocore/edk2 (github.com) . Thanks for checking back. Regards, Kun On 9/7/2022 1:27 AM, Ard Biesh

Re: [edk2-devel] [PATCH] UsbNetworkPkg: add USB network devices support

In theory, yes QEMU should be the standard USB RNDIS protocol, but I don't know what bugs are present in the implementation. -- Rebecca Cran On 9/6/22 23:31, RichardHo [何明忠] wrote: Hi Rebecca, We didn't check it in QEMU. Is QEMU report standard USB RNDIS protocol? We only test it in physical

[edk2-devel] [PATCH] IntelFsp2Pkg: Fix FspSecCoreI build failure.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4049 Link error occurred in certain compiling environment when building FspSecCoreI: unresolved external symbol _TempRamInitApi. Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Chasel Chiu --- IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryI.nasm |

Re: [edk2-devel] [PATCH v2] EmbeddedPkg/PrePiMemoryAllocationLib: Check for space on offset allocation

> -Original Message- > From: Ard Biesheuvel > Sent: Wednesday, September 7, 2022 10:16 AM > To: Jeff Brasen > Cc: devel@edk2.groups.io; ardb+tianoc...@kernel.org; > abner.ch...@amd.com; g...@danielschaefer.me; quic_llind...@quicinc.com > Subject: Re: [PATCH v2] EmbeddedPkg/PrePiMemoryAl

[edk2-devel] [PATCH v4 1/1] NetworkPkg/HttpBootDxe: Add Support for HTTPS Proxy Server for HTTP Boot

Add CONNECT HTTP command to create a tunnel from Proxy to EndPoint Server. Add support to connect through proxy server using multi-URI DevicePath sent to the Boot Manager. Cc: Maciej Rabeda Cc: Wu Jiaxin Cc: Siyuan Fu Cc: Jian J Wang Cc: Liming Gao Signed-off-by: Saloni Kasbekar --- .../Lib

Re: [edk2-devel] [RFC PATCH 2/2] Maintainers.txt: Add entry for new RiscVVirt

On 9/6/22 19:10, Sunil V L wrote: Signed-off-by: Sunil V L --- Maintainers.txt | 5 + 1 file changed, 5 insertions(+) Acked-by: Heinrich Schuchardt diff --git a/Maintainers.txt b/Maintainers.txt index a4a0e4b907..6fac3369dd 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -381,

Re: [edk2-devel] [RFC PATCH 1/2] RISC-V: Add Qemu Virt platform support

On 9/6/22 19:10, Sunil V L wrote: Add build infrastructure files to boot qemu virt machine. EDK2 will boot as S-mode payload of opensbi. There is no integrated opensbi (M-mode firmware) within EDK2 for virt machine. It relies on the RISC-V calling convention that M-mode firmware like opensbi

Re: [edk2-devel] [RFC PATCH 1/2] RISC-V: Add Qemu Virt platform support

On 9/6/22 19:10, Sunil V L wrote: Add build infrastructure files to boot qemu virt machine. EDK2 will boot as S-mode payload of opensbi. There is no integrated opensbi (M-mode firmware) within EDK2 for virt machine. It relies on the RISC-V calling convention that M-mode firmware like opensbi wi

Re: [edk2-devel] [PATCH v2 1/1] Features/Intel/OutOfBandManagement/AsfFeaturePkg: Add initial package

Reviewed-by: Isaac Oram Looks good, thank you. -Original Message- From: CrystalLee [李怡萱] Sent: Monday, September 5, 2022 5:15 AM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Gao, Liming ; DavidHsieh [謝坤智] ; CrystalLee [李怡萱] Subject: [P

Re: [edk2-devel] [PATCH v2 1/1] Features/Intel/OutOfBandManagement/AsfFeaturePkg: Add initial package

Pushed as a81614e456..341d41ac40 -Original Message- From: devel@edk2.groups.io On Behalf Of Isaac Oram Sent: Wednesday, September 7, 2022 3:37 PM To: CrystalLee [李怡萱] ; devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Desimone, Nathaniel L ; Gao, Liming ; DavidHsieh [謝坤智] Subject: Re: [

Re: [edk2-devel][edk2-platforms][PATCH v2 1/6] {Platform,Silicon}/Intel: Move PcdAcpiBaseAddress definition

Reviewed-by: Isaac Oram -Original Message- From: Benjamin Doron Sent: Tuesday, September 6, 2022 10:02 AM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Oram, Isaac W ; Desimone, Nathaniel L ; Sinha, Ankit ; Ni, Ray ; Chiu, Chasel ; Luo, Heng Subject: [edk2-devel][edk2-platfor

Re: [edk2-devel][edk2-platforms][PATCH v2 1/6] {Platform,Silicon}/Intel: Move PcdAcpiBaseAddress definition

Reviewed-by: Sai Chaganty -Original Message- From: Benjamin Doron Sent: Tuesday, September 06, 2022 10:02 AM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Oram, Isaac W ; Desimone, Nathaniel L ; Sinha, Ankit ; Ni, Ray ; Chiu, Chasel ; Luo, Heng Subject: [edk2-devel][edk2-plat

Re: [edk2-devel][edk2-platforms][PATCH v2 2/6] IntelSiliconPkg/Feature/SmmAccess: Implement PPI with chipset support

Reviewed-by: Isaac Oram -Original Message- From: Benjamin Doron Sent: Tuesday, September 6, 2022 10:02 AM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Sinha, Ankit ; Ni, Ray ; Chaganty, Rangasai V ; Oram, Isaac W Subject: [edk2-devel][edk2-platforms][PATCH v2 2/6] IntelSilic

Re: [edk2-devel][edk2-platforms][PATCH v2 3/6] IntelSiliconPkg/Feature/SmmControl: Implement PPI with chipset support

Reviewed-by: Isaac Oram -Original Message- From: Benjamin Doron Sent: Tuesday, September 6, 2022 10:02 AM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Sinha, Ankit ; Ni, Ray ; Chaganty, Rangasai V ; Oram, Isaac W Subject: [edk2-devel][edk2-platforms][PATCH v2 3/6] IntelSilic

Re: [edk2-devel] [PATCH V2 01/14] MdeModulePkg: Add PrePiHob.h

On September 7, 2022 1:31 PM, Gerd Hoffmann wrote: > On Sun, Sep 04, 2022 at 11:34:14AM +, Xu, Min M wrote: > > On September 1, 2022 11:48 PM, Gerd Hoffmann wrote: > > > Hi, > > > > > > > EFI_RESOURCE_MEMORY_UNACCEPTED is defined for unaccepted > memory. > > > > But this defitinion has not be

Re: [edk2-devel][edk2-platforms][PATCH v2 4/6] S3FeaturePkg: Implement working S3 resume

It seems like: UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationPei.inf UefiCpuPkg/PiSmmCommunication/PiSmmCommunicationSmm.inf MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf Are not S3 specific and belong with common stage 4 or 5 content. It seems many features could require them

Re: [edk2-devel] [PATCH V3 09/12] OvmfPkg: Update ConstructFwHobList for lazy accept

On September 7, 2022 1:42 PM, Gerd Hoffmann wrote: > Hi, > > > + // > > + // This memory region is split into 2 parts. The left part is > > accepted. > > + // > > + PhysicalEnd= MaxAcceptedMemoryAddress; > > + ResourceLength = PhysicalEnd - Physi

Re: [edk2-devel] [PATCH V3 08/12] OvmfPkg: Introduce lazy accept in PlatformInitLib and PlatformPei

On September 7, 2022 1:37 PM, Gerd Hoffmann wrote: > On Mon, Sep 05, 2022 at 04:35:02PM +0800, Min Xu wrote: > > From: Min M Xu > > > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937 > > > > There are below major changes in PlatformInitLib/PlatformPei 1. > > ProcessHobList > > The unac

Re: [edk2-devel] MdeModulePkg: Use configurable PCD for AHCI command retries

Thanks for the patch. Could you help to: 1. Add the information of this new PCD in MdeModulePkg.uni 2. Keep the macro AHCI_COMMAND_RETRIES in AhciMode.h and update its definition to: #define AHCI_COMMAND_RETRIES PcdGet32 (PcdAhciCommandRetryCount) Best Regards, Hao Wu From: devel@edk2.groups.i

Re: [edk2-devel] [PATCH v2] OvmfPkg: Update I/O port related to ACPI devices for CloudHv

Merged - https://github.com/tianocore/edk2/pull/3317 From: Boeuf, Sebastien Sent: Wednesday, September 7, 2022 11:25 PM To: Yao, Jiewen Cc: kra...@redhat.com; Justen, Jordan L ; devel@edk2.groups.io Subject: Re: [PATCH v2] OvmfPkg: Update I/O port related to ACPI devices for CloudHv Ok sounds

Re: [edk2-devel] [PATCH 1/1] pip-requirement: Upgrade the edk2-basetools version from 0.1.28 to 0.1.29

Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Bob Feng > Sent: Wednesday, September 7, 2022 8:24 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming > ; Chen, Christine ; > Rebecca Cran > Subject: [edk2-devel] [PATCH 1/1] pip-re

Re: [edk2-devel][edk2-platforms][PATCH v2 5/6] MinPlatformPkg: Implement working S3 resume

DSC and FDF should wrap performance PEIM with !if gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable == TRUE to be consistent with the MinPlatformPkg DSC implementations. Or you could take a look at what we did in WhitleyOpenBoardPkg/Include/Dsc/ EnablePerformanceMonitoringInfrastructure.dsc.

Re: [edk2-devel] [PATCH 1/1] pip-requirement: Upgrade the edk2-basetools version from 0.1.28 to 0.1.29

Pushed. -Original Message- From: Kinney, Michael D Sent: Thursday, September 8, 2022 10:23 AM To: devel@edk2.groups.io; Feng, Bob C ; Kinney, Michael D Cc: Gao, Liming ; Chen, Christine ; Rebecca Cran Subject: RE: [edk2-devel] [PATCH 1/1] pip-requirement: Upgrade the edk2-basetools

[edk2-devel][edk2-platforms][PATCH V1 2/2] PlatformPayloadFeaturePkg/Build: Use MinPlatform PCD include

Fix build issue from removed PCD and use MinPlatformFeaturesPcd.dsc.inc. Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Isaac Oram --- .../PlatformPayloadFeaturePkg.dsc | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/Features/Intel/Platfo

[edk2-devel][edk2-platforms][PATCH V1 0/2] Fix build issues

These commits fix some small build issues from various changes. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Isaac Oram Isaac Oram (2): MinPlatformPkg/Include: Add PEI DevicePathLib instance PlatformPayloadFeaturePkg/Build: Use MinPlatform PCD include .

[edk2-devel][edk2-platforms][PATCH V1 1/2] MinPlatformPkg/Include: Add PEI DevicePathLib instance

PEI DevicePathLib instance required by NvmExpressPei.inf due to recent change. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Isaac Oram --- Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/Platform/In

[edk2-devel] [PATCH v2] MdeModulePkg: Use configurable PCD for AHCI command retries

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4011 AHCI commands are retried internally which prevents platform feature like drive password to process correctly entered password on subsequent attempts. PCD allows the platform to determine the number of retries. Signed-off-by: Baraneedharan

[edk2-devel] [PATCH v1 00/34] Add a new architecture called LoongArch in EDK II

UEFI Spec V2.10 already supports LoongArch and all changes of this commit passwed Azure CI testing, so let's enable it in EDK2. This commit contains 35 patchs, with patch 0 is the cover and the rest being the LoongArch base code. Modified modules: FatPkg, FmpDevicePkg, NetworkPkg, NetworkPkg/HttpB

[edk2-devel] [PATCH v1 03/34] FatPkg: Add LOONGARCH64 architecture for EDK2 CI.

Add LOONGARCH64 architecture for EDK2 CI testing. Cc: Ray Ni Signed-off-by: Chao Li --- FatPkg/FatPkg.dsc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/FatPkg/FatPkg.dsc b/FatPkg/FatPkg.dsc index 6fa439e440..076b577972 100644 --- a/FatPkg/FatPkg.dsc +++ b/FatPkg/FatPkg

[edk2-devel] [PATCH v1 10/34] ShellPkg: Add LOONGARCH64 architecture for EDK2 CI.

Add LOONGARCH64 architecture to ShellPkg for EDK2 CI testing. Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Chao Li --- ShellPkg/ShellPkg.dsc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ShellPkg/ShellPkg.dsc b/ShellPkg/ShellPkg.dsc index 38fde3dc71..dd0d88603f 100644 ---

[edk2-devel] [PATCH v1 04/34] FmpDevicePkg: Add LOONGARCH64 architecture for EDK2 CI.

Add LOONGARCH64 architecture for EDK2 CI testing. Cc: Liming Gao Cc: Michael D Kinney Cc: Guomin Jiang Cc: Wei6 Xu Signed-off-by: Chao Li --- FmpDevicePkg/FmpDevicePkg.dsc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/FmpDevicePkg/FmpDevicePkg.dsc b/FmpDevicePkg/FmpD

[edk2-devel] [PATCH v1 02/34] MdePkg: Added LoongArch jump buffer register definition to MdePkg.ci.yaml

If the new Arch register is defined in BaseLib.h when running the CI tests, it will give an ECC check error. Add the LoongArch register defined in the IgnoreFiles field to make the CI ECC check pass. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Chao Li --- MdePkg/MdePk

[edk2-devel] [PATCH v1 05/34] NetworkPkg: Add LOONGARCH64 architecture for EDK2 CI.

Add LOONGARCH64 architecture for EDK2 CI testing. Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Signed-off-by: Chao Li --- NetworkPkg/NetworkPkg.dsc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/NetworkPkg/NetworkPkg.dsc b/NetworkPkg/NetworkPkg.dsc index 762134023d..6

[edk2-devel] [PATCH v1 08/34] MdePkg/Include: Add LOONGARCH related definitions EDK2 CI.

HTTP/PXE boot LOONGARCH64 related definitions for EDK2 CI. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Chao Li --- MdePkg/Include/IndustryStandard/Dhcp.h | 41 +++--- 1 file changed, 23 insertions(+), 18 deletions(-) diff --git a/MdePkg/Include/In

[edk2-devel] [PATCH v1 07/34] CryptoPkg: Add LOONGARCH64 architecture for EDK2 CI.

Add LOONGARCH64 architecture for EDK2 CI testing. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: Chao Li --- CryptoPkg/CryptoPkg.dsc | 3 ++- CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf | 6 +- CryptoPkg/L

[edk2-devel] [PATCH v1 06/34] NetworkPkg/HttpBootDxe: Add LOONGARCH64 architecture for EDK2 CI.

Add LOONGARCH architecture for EDK2 CI testing. Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Signed-off-by: Chao Li --- NetworkPkg/HttpBootDxe/HttpBootDhcp4.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/NetworkPkg/HttpBootDxe/HttpBootDhcp4.h b/NetworkPkg/HttpBootDxe/HttpBootDhcp

[edk2-devel] [PATCH v1 01/34] MdePkg: Added file of DebugSupport.h to MdePkg.ci.yaml

DebugSupport.h is all defined by UEFI Spec, most of the code doesn't fit EDKII coding style, add it to IgnoreFiles field to make CI ECC check pass. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Chao Li --- MdePkg/MdePkg.ci.yaml | 1 + 1 file changed, 1 insertion(+) dif

[edk2-devel] [PATCH v1 09/34] SecurityPkg: Add LOONGARCH64 architecture for EDK2 CI.

Add LOONGARCH64 architecture to SecurityPkg for EDK2 CI testing. Cc: Jiewen Yao Cc: Jian J Wang Signed-off-by: Chao Li --- SecurityPkg/SecurityPkg.dsc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/SecurityPkg/SecurityPkg.dsc b/SecurityPkg/SecurityPkg.dsc index f4818765

[edk2-devel] [PATCH v1 10/34] ShellPkg: Add LOONGARCH64 architecture for EDK2 CI.

Add LOONGARCH64 architecture to ShellPkg for EDK2 CI testing. Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Chao Li --- ShellPkg/ShellPkg.dsc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ShellPkg/ShellPkg.dsc b/ShellPkg/ShellPkg.dsc index 38fde3dc71..dd0d88603f 100644 ---

[edk2-devel] [PATCH v1 11/34] UnitTestFrameworkPkg: Add LOONGARCH64 architecture for EDK2 CI.

Add LOONGARCH64 architecture to UnitTestFramworkPkg for LOONGARCH64 EDK2 CI. Cc: Michael D Kinney Signed-off-by: Chao Li --- UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc b/Unit

[edk2-devel] [PATCH v1 12/34] MdePkg/DxeServicesLib: Add LOONGARCH64 architecture

Add LOONGARCH64 architecture to MdePkg/DxeServiceLib. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Chao Li --- MdePkg/Library/DxeServicesLib/DxeServicesLib.inf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdePkg/Library/DxeServicesLib/DxeServ

[edk2-devel] [PATCH v1 13/34] MdeModulePkg: Use LockBoxNullLib for LOONGARCH64

LoongArch doesn't have SMM by now. Cc: Jian J Wang Cc: Liming Gao Signed-off-by: Chao Li --- MdeModulePkg/MdeModulePkg.dsc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc index 45a8ec84ad..659482ab73 100644

[edk2-devel] [PATCH v1 14/34] .python/SpellCheck: Add "Loongson" and "LOONGARCH" to "words" section

Add Loongson and LOONGARCH to "words" section in cspell.base.yaml file to avoid spelling check error. Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Chao Li --- .pytool/Plugin/SpellCheck/cspell.base.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.pytool/Plugin

[edk2-devel] [PATCH v1 15/34] BaseTools: BaseTools changes for LoongArch platform.

C code changes for building EDK2 LoongArch platform. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Signed-off-by: Chao Li Co-authored-by: Dongyan Qian Co-authored-by: Baoqi Zhang Co-authored-by: Yang Zhou Co-authored-by: Xiaotian Wu --- BaseTools/Source/C/Common/BasePeCoff.c| 15 +-

[edk2-devel] [PATCH v1 16/34] BaseTools: BaseTools changes for LoongArch platform.

BaseTools define template files changes for building EDK2 LoongArch platform. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Signed-off-by: Chao Li Co-authored-by: Dongyan Qian Co-authored-by: Baoqi Zhang --- BaseTools/Conf/tools_def.template | 54 +++ 1 file change

[edk2-devel] [PATCH v1 17/34] BaseTools: BaseTools changes for LoongArch platform.

Python code changes for building EDK2 LoongArch platform. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Signed-off-by: Chao Li Co-authored-by: Baoqi Zhang --- BaseTools/Source/Python/Common/DataType.py| 21 ++-- .../Source/Python/UPT/Library/DataType.py | 24 +++

[edk2-devel] [PATCH v1 18/34] BaseTools: Enable LoongArch64 architecture for LoongArch64 EDK2 CI.

EDK CI for LoongArch64 architecture Enable LoongArch64 architecture for LoongArch64 EDK2 CI testing. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Signed-off-by: Chao Li --- ...gcc_loongarch64_unknown_linux_ext_dep.yaml | 22 + .../LinuxGcc5ToolChain/LinuxGcc5ToolChain.py | 31 +++

  1   2   >