When would you like to have that discussion?
The Tianocore Tool, CI, Codebase meeting is every week. In that meeting
we've discussed getting all edk2 packages to at least run CI.
https://github.com/tianocore/edk2/discussions/2614
If you prefer to have it here, that's fine as well.
On 9/7/2022 3:37 AM, Ard Biesheuvel wrote:
On Wed, 7 Sept 2022 at 04:37, <mikub...@linux.microsoft.com> wrote:
From: Michael Kubacki <michael.kuba...@microsoft.com>
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4046
Adds EmbeddedPkg to edk2 CI.
Due to a number of build errors (some intentional) such as
'BUILD_EPOCH' only being defined for GCC in
VirtualRealTimeClockLib.inf, the package is only run on GCC
build agents.
This still allows build to be verified and non-build CI checks
to be performed.
In the edk2 PR for this change, you can see that the package only
runs on GCC and CI passes with this configuration.
https://github.com/tianocore/edk2/pull/3299
Cc: Leif Lindholm <quic_llind...@quicinc.com>
Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org>
Cc: Abner Chang <abner.ch...@amd.com>
Cc: Daniel Schaefer <g...@danielschaefer.me>
Signed-off-by: Michael Kubacki <michael.kuba...@microsoft.com>
Michael Kubacki (3):
EmbeddedPkg/AcpiLib: Fix code formatting errors
EmbeddedPkg: Add CI YAML file
EmbeddedPkg: Only run in CI for GCC5
NAK until we have a discussion about strictness of CI and ways to
permit manual override of merge time CI restrictions.
EmbeddedPkg/Library/AcpiLib/AcpiLib.c | 88 +++++++++----------
.azurepipelines/templates/pr-gate-build-job.yml | 4 +
.pytool/CISettings.py | 1 +
EmbeddedPkg/EmbeddedPkg.ci.yaml | 89 ++++++++++++++++++++
EmbeddedPkg/EmbeddedPkg.dec | 8 ++
EmbeddedPkg/Include/Library/AcpiLib.h | 22 ++---
6 files changed, 158 insertions(+), 54 deletions(-)
create mode 100644 EmbeddedPkg/EmbeddedPkg.ci.yaml
--
2.28.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93433): https://edk2.groups.io/g/devel/message/93433
Mute This Topic: https://groups.io/mt/93517518/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
