[edk2-devel] [Patch V2] XhcCreateUsbHc: Check return value of XHC_PAGESIZE_OFFSET

2022-06-20 Thread Heng Luo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3954 Report error if reserved bits are not 0 for PageSize Cc: Ray Ni Cc: Hao Wu Signed-off-by: Heng Luo --- MdeModulePkg/Bus/Pci/XhciDxe/Xhci.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Bus/P

Re: [edk2-devel] [Patch V2] XhcCreateUsbHc: Check return value of XHC_PAGESIZE_OFFSET

2022-06-20 Thread Wu, Hao A
Reviewed-by: Hao A Wu Will wait some time to see if comments from other reviewers. Also, Will change the title a little bit to: MdeModulePkg/XhciDxe: Check return value of XHC_PAGESIZE_OFFSET Best Regards, Hao Wu > -Original Message- > From: Luo, Heng > Sent: Monday, June 20, 2022 3:0

[edk2-devel] [PATCH 1/1] UefiCpuPkg: Extend SMM CPU Service with rendezvous support.

2022-06-20 Thread Li, Zhihao
From: "Li, Zhihao" REF? https://bugzilla.tianocore.org/show_bug.cgi?id=3815 This patch define a new Protocol with the new services SmmWaitForAllProcessor(), which can be used by SMI handler to optionally wait for other APs to complete SMM rendezvous in relaxed AP mode. A new library SmmCpuRende

[edk2-devel] [PATCH 1/1] OvmfPkg: Add dependency of VariableSmm driver to make it work normally.

2022-06-20 Thread Li, Zhihao
From: Zhihao Li REF? https://bugzilla.tianocore.org/show_bug.cgi?id=3861 UefiCpuPkg define a new Protocol with the new services SmmWaitForAllProcessor(), which can be used by SMI handler to optionally wait for other APs to complete SMM rendezvous in relaxed AP mode. VariableSmm driver need use

[edk2-devel] [PATCH 1/1] MdePkg: Remove "assert" from SmmCpuRendevousLibNull.c

2022-06-20 Thread Li, Zhihao
From: Zhihao Li REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3931 Some drivers will break down when they use SmmWaitForAllProcessor() which from SmmCpuRendezvousLibNull.c. Removing the code "ASSERT(False)" will make consumer work normally if they keep default setting for sync mode. Cc: M

[edk2-devel] [PATCH v1 1/1] SecurityPkg: use SmmWaitForAllProcessor in TcgSmm and Tcg2Smm driver.

2022-06-20 Thread Li, Zhihao
From: Zhihao Li REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3855 In UefiCpuPkg, there are a new Protocol with the new service SmmWaitForAllProcessor(), which can be used by SMI handler to optionally wait for other APs to complete SMM rendezvous in relaxed AP mode. This patch use the new

[edk2-devel] [PATCH 1/1] MdePkg: add SmmCpuRendezvousLib.h and SmmCpuRendezvousLibNull implement.

2022-06-20 Thread Li, Zhihao
From: "Li, Zhihao" REF? https://bugzilla.tianocore.org/show_bug.cgi?id=3912 UefiCpuPkg define a new Protocol with the new services SmmWaitForAllProcessor(), which can be used by SMI handler to optionally wait for other APs to complete SMM rendezvous in relaxed AP mode. VariableSmm and VariableS

[edk2-devel] [PATCH v1 0/1] *** SUBJECT HERE ***

2022-06-20 Thread Li, Zhihao
*** BLURB HERE *** Zhihao Li (1): SecurityPkg: use SmmWaitForAllProcessor in TcgSmm and Tcg2Smm driver. SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c| 21 ++-- SecurityPkg/Tcg/TcgSmm/TcgSmm.c | 15 -- SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.h| 3 ++

[edk2-devel] [PATCH 1/1] UefiPayloadPkg: Add dependency of VariableSmm driver.

2022-06-20 Thread Li, Zhihao
From: "Li, Zhihao" REF? https://bugzilla.tianocore.org/show_bug.cgi?id=3882 UefiCpuPkg define a new Protocol with the new services SmmWaitForAllProcessor(), which can be used by SMI handler to optionally wait for other APs to complete SMM rendezvous in relaxed AP mode. VariableSmm driver need u

[edk2-devel] [PATCH 1/1] UefiPayloadPkg: Add dependency of VariableSmm driver.

2022-06-20 Thread Li, Zhihao
From: "Li, Zhihao" REF? https://bugzilla.tianocore.org/show_bug.cgi?id=3882 UefiCpuPkg define a new Protocol with the new services SmmWaitForAllProcessor(), which can be used by SMI handler to optionally wait for other APs to complete SMM rendezvous in relaxed AP mode. VariableSmm driver need u

[edk2-devel] [PATCH 1/1] UefiCpuPkg: Extend SMM CPU Service with rendezvous support.

2022-06-20 Thread Li, Zhihao
From: "Li, Zhihao" REF? https://bugzilla.tianocore.org/show_bug.cgi?id=3815 This patch define a new Protocol with the new services SmmWaitForAllProcessor(), which can be used by SMI handler to optionally wait for other APs to complete SMM rendezvous in relaxed AP mode. A new library SmmCpuRende

[edk2-devel] [PATCH 1/1] MdePkg: add SmmCpuRendezvousLib.h and SmmCpuRendezvousLibNull implement.

2022-06-20 Thread Li, Zhihao
From: "Li, Zhihao" REF? https://bugzilla.tianocore.org/show_bug.cgi?id=3912 UefiCpuPkg define a new Protocol with the new services SmmWaitForAllProcessor(), which can be used by SMI handler to optionally wait for other APs to complete SMM rendezvous in relaxed AP mode. VariableSmm and VariableS

[edk2-devel] [PATCH 1/1] OvmfPkg: Add dependency of VariableSmm driver to make it work normally.

2022-06-20 Thread Li, Zhihao
From: Zhihao Li REF? https://bugzilla.tianocore.org/show_bug.cgi?id=3861 UefiCpuPkg define a new Protocol with the new services SmmWaitForAllProcessor(), which can be used by SMI handler to optionally wait for other APs to complete SMM rendezvous in relaxed AP mode. VariableSmm driver need use

[edk2-devel] [PATCH 1/1] MdeModulePkg: Use SmmWaitForAllProcessor() in VariableSmm driver.

2022-06-20 Thread Li, Zhihao
From: Zhihao Li REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3854 In UefiCpuPkg, there are a new Protocol with the new service SmmWaitForAllProcessor(), which can be used by SMI handler to optionally wait for other APs to complete SMM rendezvous in relaxed AP mode. This patch use the new

[edk2-devel] [PATCH 1/1] MdePkg: Remove "assert" from SmmCpuRendevousLibNull.c

2022-06-20 Thread Li, Zhihao
From: Zhihao Li REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3931 Some drivers will break down when they use SmmWaitForAllProcessor() which from SmmCpuRendezvousLibNull.c. Removing the code "ASSERT(False)" will make consumer work normally if they keep default setting for sync mode. Cc: J

[edk2-devel] [PATCH v1 1/1] SecurityPkg: use SmmWaitForAllProcessor in TcgSmm and Tcg2Smm driver.

2022-06-20 Thread Li, Zhihao
From: Zhihao Li REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3855 In UefiCpuPkg, there are a new Protocol with the new service SmmWaitForAllProcessor(), which can be used by SMI handler to optionally wait for other APs to complete SMM rendezvous in relaxed AP mode. This patch use the new

Re: [edk2-devel] [PATCH v2] UefiPayloadPkg: Always split page table entry to 4K if it covers stack.

2022-06-20 Thread Gerd Hoffmann
On Fri, Jun 17, 2022 at 04:28:03PM +0800, Zhiguang Liu wrote: > We observed page fault in the following situation: > 1.PayloadEntry uses 2M entry in page table to cover DXE stack range. > 2.In DXE phase, image protection code needs to mark some sub-range in > this 2M entry as readonly. So the the 2

Re: [edk2-devel] [PATCH 3/3] OvmfPkg: Initialize NvVarStore with Configuration FV in Td guest

2022-06-20 Thread Gerd Hoffmann
> + UINT8 *CfvBase; > + UINT32CfvSize; > >DEBUG ((DEBUG_INFO, "EMU Variable FVB Started\n")); > > @@ -774,6 +776,23 @@ FvbInitialize ( > >mEmuVarsFvb.BufferPtr = Ptr; > > + // > + // In Tdx guest the VarNvStore content should be initialized by the

Re: [edk2-devel] [edk2][PATCH V1 1/1] ArmPlatformPkg/PrePeiCore: Explicitly invoke constructor for SEC phase

2022-06-20 Thread Rohit Mathew
Hi Ard, Apologies, I missed your response. On Tue, May 3, 2022 at 09:43 AM, Ard Biesheuvel wrote: > > (+ Rebecca) > > On Tue, 8 Mar 2022 at 12:55, Rohit Mathew wrote: > >> PrePeiCore's CEntry function calls DebugLib library's print API before >> the library is initialized. So, invoke the con

[edk2-devel] [edk2][PATCH V2 1/1] ArmPlatformPkg/PrePeiCore: Explicitly invoke constructor for SEC phase

2022-06-20 Thread Rohit Mathew
PrePeiCore's CEntry function calls DebugLib library's print API before the library is initialized. So, invoke the constructor in the SEC phase to call into initialization functions associated with libraries linked with this particular module. This change is essential to initialize uart for SEC. Si

[edk2-devel] [edk2-platforms][PATCH V2 0/2] Uart segregation patch series

2022-06-20 Thread Rohit Mathew
Changes since V1: - Rebased on top of latest master branch. - Updated copyright and date. This patch series aims at routing uart logs via different sets of uart ports, namely secure port for secure partition logs and non-secure port for all other logs. The first patch deals with removing redundan

[edk2-devel] [edk2-platforms][PATCH V2 2/2] Platform/Sgi: Route logs to different sets of consoles

2022-06-20 Thread Rohit Mathew
Route secure (from secure partition) and non-secure console messages to different sets of UART console ports. This aligns with the security state the PE is in when logs are put out. In addition, this allows consolidation of UART related macros across all the variants of Neoverse reference design pl

[edk2-devel] [edk2-platforms][PATCH V2 1/2] Platform/Sgi: Remove redundant platform description from DSDT

2022-06-20 Thread Rohit Mathew
Remove redundant platform descriptions (descriptions which are already part of SSDT) from DSDT for SGI-575 platform. Signed-off-by: Rohit Mathew --- Platform/ARM/SgiPkg/AcpiTables/Sgi575/Dsdt.asl | 66 +--- 1 file changed, 1 insertion(+), 65 deletions(-) diff --git a/Platform/AR

回复: [edk2-devel] [PATCH 1/1] MdePkg: Remove "assert" from SmmCpuRendevousLibNull.c

2022-06-20 Thread gaoliming
Zhihao: This change has been merged at b09ada6edc7f3f28d3b4f2ef09852ebd39f17920 in Edk2. Please check it. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Li, Zhihao > 发送时间: 2022年6月20日 17:36 > 收件人: devel@edk2.groups.io > 抄送: Michael D Kinney ; Liming Gao > > 主题: [edk2-devel] [PAT

Re: [edk2-devel] [edk2-platforms][PATCH V2 0/9] Upadate the ACPI tables for RD platforms

2022-06-20 Thread Pranav Madhu
Hi All, Could you please let me know if any updates are required for this series of patch? Regards, Pranav > -Original Message- > From: Thomas Abraham > Sent: Tuesday, April 19, 2022 1:40 AM > To: devel@edk2.groups.io; Pranav Madhu > Cc: Ard Biesheuvel ; Sami Mujawar > > Subject: Re:

Re: [edk2-devel] [edk2-platforms][PATCH V1 0/7] Fix ACPI Low Power Idle states for RD platforms

2022-06-20 Thread Pranav Madhu
Hi All, Could you please let me know if any updates required for this series of patch? Regards, Pranav From: Thomas Abraham Sent: Sunday, June 12, 2022 2:16 AM To: Pranav Madhu ; devel@edk2.groups.io Subject: Re: [edk2-devel] [edk2-platforms][PATCH V1 0/7] Fix ACPI Low Power Idle states for

Re: [edk2-devel] [edk2-platforms][PATCH V2 2/2] Platform/Sgi: Route logs to different sets of consoles

2022-06-20 Thread Thomas Abraham
Hi Rohit, On 20/06/2022 16:25, Rohit Mathew via groups.io wrote: Route secure (from secure partition) and non-secure console messages to different sets of UART console ports. This aligns with the security state the PE is in when logs are put out. In addition, this allows consolidation of UART re

[edk2-devel] Now: Tools, CI, Code base construction meeting series - 06/20/2022 #cal-notice

2022-06-20 Thread Group Notification
*Tools, CI, Code base construction meeting series* *When:* 06/20/2022 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://github.com/tianocore/edk2/discussions/2614 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1519384 ) *Description:* TianoCore community, Micros

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 06/21/2022 #cal-reminder

2022-06-20 Thread Group Notification
*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* 06/21/2022 6:30pm to 7:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed4-8496-4ed77

[edk2-devel] [edk2-staging][PATCH v2 0/5] Update Redfish Profile Simulator

2022-06-20 Thread Nickle Wang
Version 2 patch files and follow format by removing "From: " in the description. Update Redfish Profile Simulator in order to cooperating with Redfish feature driver. Computer system schema is updated to version 1.5.0 to include Boot.BootOrder attribute. "ETag" HTTP header is implemented to all R

[edk2-devel] [edk2-staging][PATCH v2 1/5] edk2-staging/RedfishClientPkg: Update requirements.txt

2022-06-20 Thread Nickle Wang
Updates the Python module dependency for Redfish Profile Simulator. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .../Tools/Redfish-Profile-Simulator/requirements.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/RedfishClientPkg/Tools/Redfis

[edk2-devel] [edk2-staging][PATCH v2 2/5] edk2-staging/RedfishClientPkg: Update computer system schema version

2022-06-20 Thread Nickle Wang
Update mock-up file and use computer system schema version 1.5.0 in order to support Boot.BootOrder attribute. Update UUID of 2M220101SL for working with Redfish Profile Simulator. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .../redfish/v1/Systems/2M220100SL/

[edk2-devel] [edk2-staging][PATCH v2 3/5] edk2-staging/RedfishClientPkg: Update patch method of computer system

2022-06-20 Thread Nickle Wang
Remove attribute check during patch of computer system and return content-type with JSON format in HTTP header. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .../v1sim/resource.py | 4 ++- .../v1sim/systems.py |

[edk2-devel] [edk2-staging][PATCH v2 4/5] edk2-staging/RedfishClientPkg: Add ETag support

2022-06-20 Thread Nickle Wang
Implement ETag support in HTTP header Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .../v1sim/resource.py | 10 +-- .../v1sim/systems.py | 28 +++ 2 files changed, 25 insertions(+), 13 deletio

[edk2-devel] [edk2-staging][PATCH v2 5/5] edk2-staging/RedfishClientPkg: Add missing module

2022-06-20 Thread Nickle Wang
Add missing module import for conditional, RfCollection, RfResource, RfResourceRaw, hashlib and OrderedDict Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .../Tools/Redfish-Profile-Simulator/v1sim/redfishURIs.py | 5 - .../Tools/Redfish-Profile-Simulator

Re: [edk2-devel] [PATCH] UefiPayloadPkg: UniversalPayloadBuild.py to support --pcd feature

2022-06-20 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Guo, Gua > Sent: Monday, June 20, 2022 9:56 AM > To: devel@edk2.groups.io > Cc: Guo, Gua ; Dong, Guo ; Ni, > Ray > Subject: [PATCH] UefiPayloadPkg: UniversalPayloadBuild.py to support --pcd > feature > > From: Gua Guo > > REF: https:/

Re: [edk2-devel] [edk2-staging][PATCH v2 1/5] edk2-staging/RedfishClientPkg: Update requirements.txt

2022-06-20 Thread Abner Chang
Reviewed-by: Abner Chang > -Original Message- > From: Wang, Nickle (Server BIOS) > Sent: Tuesday, June 21, 2022 9:45 AM > To: devel@edk2.groups.io > Cc: Wang, Nickle (Server BIOS) ; Chang, Abner (HPS > SW/FW Technologist) ; Yang Atom > ; Nick Ramirez > Subject: [edk2-staging][PATCH v2 1

Re: [edk2-devel] [edk2-staging][PATCH v2 2/5] edk2-staging/RedfishClientPkg: Update computer system schema version

2022-06-20 Thread Abner Chang
Reviewed-by: Abner Chang > -Original Message- > From: Wang, Nickle (Server BIOS) > Sent: Tuesday, June 21, 2022 9:46 AM > To: devel@edk2.groups.io > Cc: Wang, Nickle (Server BIOS) ; Chang, Abner (HPS > SW/FW Technologist) ; Yang Atom > ; Nick Ramirez > Subject: [edk2-staging][PATCH v2 2

Re: [edk2-devel] [edk2-staging][PATCH v2 3/5] edk2-staging/RedfishClientPkg: Update patch method of computer system

2022-06-20 Thread Abner Chang
Reviewed-by: Abner Chang > -Original Message- > From: Wang, Nickle (Server BIOS) > Sent: Tuesday, June 21, 2022 9:46 AM > To: devel@edk2.groups.io > Cc: Wang, Nickle (Server BIOS) ; Chang, Abner (HPS > SW/FW Technologist) ; Yang Atom > ; Nick Ramirez > Subject: [edk2-staging][PATCH v2 3

Re: [edk2-devel] [edk2-staging][PATCH v2 4/5] edk2-staging/RedfishClientPkg: Add ETag support

2022-06-20 Thread Abner Chang
Reviewed-by: Abner Chang > -Original Message- > From: Wang, Nickle (Server BIOS) > Sent: Tuesday, June 21, 2022 9:47 AM > To: devel@edk2.groups.io > Cc: Wang, Nickle (Server BIOS) ; Chang, Abner (HPS > SW/FW Technologist) ; Yang Atom > ; Nick Ramirez > Subject: [edk2-staging][PATCH v2 4

Re: [edk2-devel] [edk2-staging][PATCH v2 5/5] edk2-staging/RedfishClientPkg: Add missing module

2022-06-20 Thread Abner Chang
Reviewed-by: Abner Chang > -Original Message- > From: Wang, Nickle (Server BIOS) > Sent: Tuesday, June 21, 2022 9:48 AM > To: devel@edk2.groups.io > Cc: Wang, Nickle (Server BIOS) ; Chang, Abner (HPS > SW/FW Technologist) ; Yang Atom > ; Nick Ramirez > Subject: [edk2-staging][PATCH v2 5

[edk2-devel] Discussing how SystemTable and its Pointers should be treated in Rust

2022-06-20 Thread Ayush Singh
Hello everyone, I wanted to discuss and get ideas about how I should implement the various services (like allocator and stdin) for UEFI in Rust. I have come up with two approaches: 1. Initialize the pointers needed for a module to work early on and keep them local to the module. This will mean th