Judah,
Following interface has no non-Null version implemented.
Consider removing them completely.
ProtectedVariableLibGetStore()
ProtectedVariableLibReclaim()
ProtectedVariableLibGetDataInfo()
ProtectedVariableLibGetNextEx()
ProtectedVariableLibGetNext ()
Regards,
Jian
> -Original Message-
Judah,
One general comment: please add variable store provision/recovery flow and
explanations in the readme.
See my other inline comments below.
Regards,
Jian
> -Original Message-
> From: Vang, Judah
> Sent: Saturday, April 30, 2022 2:04 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian
Judah,
> -Original Message-
> From: Vang, Judah
> Sent: Saturday, April 30, 2022 2:04 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Yao, Jiewen ;
> Mistry, Nishant C
> Subject: [Patch v2 10/28] SecurityPkg: Add new KeyService types and defines
>
> REF: https://bugzilla.tianocore.o
Reviewed-by: Jian J Wang
Regards,
Jian
> -Original Message-
> From: Vang, Judah
> Sent: Saturday, April 30, 2022 2:04 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Yao, Jiewen ;
> Mistry, Nishant C
> Subject: [Patch v2 11/28] SecurityPkg: Update RPMC APIs with index
>
> REF: http
Judah,
Patch 11 is a library instance of RpmcLib which relies on changes introduced in
this patch (12).
You need to put this patch before patch 11.
Regards,
Jian
> -Original Message-
> From: Vang, Judah
> Sent: Saturday, April 30, 2022 2:04 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jia
Judah,
My comments below
> -Original Message-
> From: Vang, Judah
> Sent: Saturday, April 30, 2022 2:04 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Yao, Jiewen ;
> Mistry, Nishant C
> Subject: [Patch v2 13/28] SecurityPkg: Fix GetVariableKey API
>
> REF: https://bugzilla.tianoco
Judah,
My comments below
> -Original Message-
> From: Vang, Judah
> Sent: Saturday, April 30, 2022 2:04 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Yao, Jiewen ;
> Mistry, Nishant C
> Subject: [Patch v2 14/28] SecurityPkg: Add null encryption variable libs
>
> REF: https://bugzi
Reviewed-by: Jian J Wang
Regards,
Jian
> -Original Message-
> From: Ni, Ray
> Sent: Friday, May 20, 2022 10:16 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Wang, Jian J
> Subject: [PATCH 5/5] CpuException: Add InitializeSeparateExceptionStacks
>
> Today InitializeCpuExceptionHan
Hi Ray,
Both CpuDxe.c and CpuExceptionCommon.h have CPU_INTERRUPT_NUM defined.
I'd suggest to move it to a common place, such as BaseLib.h. I don't see any
issue
if they are defined to different value. It just gives me a feeling that it
might cause
potential problems sometimes in the future.
R
Reviewed-by: Jian J Wang
Regards,
Jian
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ni, Ray
> Sent: Friday, May 20, 2022 10:16 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric
> Subject: [edk2-devel] [PATCH 3/5] CpuException: Avoid allocating page but
> using
> globa
Reviewed-by: Jian J Wang
Regards,
Jian
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ni, Ray
> Sent: Friday, May 20, 2022 10:16 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric
> Subject: [edk2-devel] [PATCH 2/5] CpuException: Init global variables in-place
>
> Additi
Ray,
You changed "%rep 32" to "%rep 256" in Ia32/ExceptionHandlerAsm.nasm.
According to my understanding and your comments, this should be done
only to X64 code, right?
Regards,
Jian
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ni, Ray
> Sent: Friday, May 20, 2022 10:1
Writes TianoCore debug logs into the CBMEM console ringbuffer, from
where the user can retrieve them with the `cbmem` userspace utility.
The intention is to aid in debugging non-fatal issues even in release
builds, or simply make TianoCore's logs available to those interested.
Consequently, MDEPKG
Writes TianoCore debug logs into the CBMEM console ringbuffer, from
where the user can retrieve them with the `cbmem` userspace utility.
The intention is to aid in debugging non-fatal issues even in release
builds, or simply make TianoCore's logs available to those interested.
Consequently, MDEPKG
OvmfPkg will initially use this to hand off the secrets page address to
UefiCpuPkg, which will need this PCD to access the SEV-SNP secrets page
address. Define this as an MdePkg PCD so it can be accessed by other
packages alongside the secrets page struct defined in MdePkg/Include.
Signed-off-by:
This will be needed so that the AP Jump Table address can be stored for
use by the operating system later, and possibly for other things in the
future.
Signed-off-by: Michael Roth
---
MdePkg/Include/Register/Amd/SnpSecretsPage.h | 56
1 file changed, 56 insertions(+)
create
This needs to be set so that UefiCpuPkg can locate the SEV-SNP secrets
page later to set the AP Jump Table address.
Signed-off-by: Michael Roth
---
OvmfPkg/AmdSev/AmdSevX64.dsc| 3 +++
OvmfPkg/CloudHv/CloudHvX64.dsc | 3 +++
OvmfPkg/IntelTdx/IntelTdxX64.dsc| 3 +++
OvmfPkg/Micro
A full-featured SEV-SNP guest will not rely on the AP jump table, and
will instead use the AP Creation interface defined by the GHCB. However,
a guest is still allowed to use the AP jump table if desired.
However, unlike with SEV-ES guests, SEV-SNP guests should not
store/retrieve the jump table a
A full-featured SEV-SNP guest will not rely on the AP jump table, and
will instead use the AP Creation interface defined by the GHCB. However,
a guest is still allowed to use the AP jump table if desired.
However, unlike with SEV-ES guests, SEV-SNP guests should not
store/retrieve the jump table a
Hi, I am trying to debug OVMF as suggested in
https://retrage.github.io/2019/12/05/debugging-ovmf-en.html.
Almost every step seems to work fine.
I built edk2 as follow:
--
$ git clone g...@github.com:tianocore/edk2.git \
$ cd edk2$ git submodule update --init --recursi
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Groups.io Inc//Groups.io Calendar//EN
METHOD:CANCELLED
REFRESH-INTERVAL;VALUE=DURATION:PT1H
X-PUBLISHED-TTL:PT1H
CALSCALE:GREGORIAN
BEGIN:VTIMEZONE
TZID:America/Los_Angeles
LAST-MODIFIED:20220317T223602Z
TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angel
Hi All,
Are you still following this issue? I have been waiting for the best way, thank
you!
Thanks,
Chao
> -原始邮件-
> 发件人: "Michael Kubacki"
> 发送时间: 2022-05-17 00:12:51 (星期二)
> 收件人: devel@edk2.groups.io, lic...@loongson.cn, "Shenglei Zhang"
, "Bob Feng"
> 抄送: "michael.d.kin...@intel.
Hi Leif, Ard,
A gentle ping on this on behalf of Masami, since he left Linaro.
Thanks,
Masahisa Kojima
On Fri, 10 Dec 2021 at 15:51, Masami Hiramatsu
wrote:
>
> Add DBG2 table to ACPI tables. The COM1 uart port will be used
> for OS debug, and it is 16550 compatible.
>
> Signed-off-by: Masami
Kernel blobs include the kernel image, initrd, command line. These are
external inputs from host VMM. In some platforms,such as Tdx environment,
Host VMM is treated as un-trusted. So these external inputs should be
measured.
This patch-set imports a new library class (BlobMeasurementLib). It is
de
BlobMeasurementLib will be used to measure blobs fetching from QEMU's
firmware config (fw_cfg) in platforms which implments
EFI_CC_MEASUREMENT_PROTOCOL.
The null implementation BlobMeasurementLibNull always return EFI_SUCCESS.
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Ashish Kalra
Cc: Brijesh S
This prepares the ground for calling MeasureKernelBlob() in
QemuKernelLoaderFsDxe.
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Ashish Kalra
Cc: Brijesh Singh
Cc: Erdem Aktas
Cc: James Bottomley
Cc: Jiewen Yao
Cc: Tom Lendacky
Cc: Sami Mujawar
Cc: Gerd Hoffmann
Signed-off-by: Min Xu
---
Ar
OvmfPkg/IntelTdx/BlobMeasurementLibTdx is implemented for measurement
of Kernel blob. It calls EFI_CC_MEASUREMENT_PROTOCOL to do the
measurement.
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Ashish Kalra
Cc: Brijesh Singh
Cc: Erdem Aktas
Cc: James Bottomley
Cc: Jiewen Yao
Cc: Sami Mujawar
Cc:
In QemuKernelLoaderFsDxeEntrypoint we use FetchBlob to read the content
of the kernel/initrd/cmdline from the QEMU fw_cfg interface. Insert a
call to MeasureKernelBlob after fetching to allow BlobMeasurementLib
implementations to add a measurement step for these blobs.
This will allow confidentia
28 matches
Mail list logo
