Judah, My comments below
> -----Original Message----- > From: Vang, Judah <judah.v...@intel.com> > Sent: Saturday, April 30, 2022 2:04 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J <jian.j.w...@intel.com>; Yao, Jiewen <jiewen....@intel.com>; > Mistry, Nishant C <nishant.c.mis...@intel.com> > Subject: [Patch v2 13/28] SecurityPkg: Fix GetVariableKey API > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 > > Fix GetVariableKey API to match changes in header files. > > Cc: Jian J Wang <jian.j.w...@intel.com> > Cc: Jiewen Yao <jiewen....@intel.com> > Cc: Nishant C Mistry <nishant.c.mis...@intel.com> > Signed-off-by: Jian J Wang <jian.j.w...@intel.com> > Signed-off-by: Nishant C Mistry <nishant.c.mis...@intel.com> > Signed-off-by: Judah Vang <judah.v...@intel.com> > --- > SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c > b/SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c > index a08def767b5f..cfbad54ba106 100644 > --- a/SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c > +++ b/SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c > @@ -1,7 +1,7 @@ > /** @file > Null version of VariableKeyLib for build purpose. Don't use it in real > product. > > -Copyright (c) 2020, Intel Corporation. All rights reserved.<BR> > +Copyright (c) 2020 - 2022, Intel Corporation. All rights reserved.<BR> > SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > @@ -22,8 +22,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > EFI_STATUS > EFIAPI > GetVariableKey ( > - OUT VOID **VariableKey, > - IN OUT UINTN *VariableKeySize > + OUT VOID *VariableKey, > + IN UINTN VariableKeySize [JianJW] 'OUT' is removed here but the parameter description in function comments still declared as [in,out]. Please update the function comments in patch 12 as well. Regards, Jian > ) > { > ASSERT (FALSE); > -- > 2.35.1.windows.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#89936): https://edk2.groups.io/g/devel/message/89936 Mute This Topic: https://groups.io/mt/90781902/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
