Re: [edk2-devel] [PATCH 0/5] CryptoPkg/openssl: enable EC unconditionally.

2022-05-05 Thread Gerd Hoffmann
Hi, > However, I do have concern for crypto package to enable ECC *unconditionally*. > I am not convinced that "EC is hard requirement for EDKII" just because "EC > is a hard requirement for TLS 1.3". My reason below: > A) TLS1.3 is only for DXE, but enabling ECC unconditionally may impact > P

Re: [edk2-devel] [PATCH V2 1/1] OvmfPkg: Add README for TDVF

2022-05-05 Thread Gerd Hoffmann
On Wed, May 04, 2022 at 08:13:50AM +0800, Min Xu wrote: > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3249 > > Add README for TDVF. > > Cc: Brijesh Singh > Cc: Erdem Aktas > Cc: Gerd Hoffmann > Cc: James Bottomley > Cc: Jiewen Yao > Cc: Tom Lendacky > Signed-off-by: Min Xu Acked-b

Re: [edk2-devel] [rfc] Remove support for unsupported tool_chain_tags

2022-05-05 Thread Gerd Hoffmann
Hi, > currently only partially supported and needs some community effort.  The > GCC5 tag might need more clarity as I know this supports many different > versions so I am not sure how to correctly communicate what is the actual > supported version. It's basically gcc 5 & newer. I think all the

Re: [edk2-devel] [PATCH 0/5] CryptoPkg/openssl: enable EC unconditionally.

2022-05-05 Thread Gerd Hoffmann
Hi, > > I am not convinced that "EC is hard requirement for EDKII" just because "EC > > is a hard requirement for TLS 1.3". My reason below: > > A) TLS1.3 is only for DXE, but enabling ECC unconditionally may impact > > PEI/DXE. (Unless size of PEI/SMM is unchanged). > > Well, the PcdEcEnable

Re: [edk2-devel] [PATCH v3 05/10] MdePkg/CompilerIntrinsicsLib: copy over intrinsics from edk2-libc repo

2022-05-05 Thread Leif Lindholm
Apologies for late feedback. I'm super happy with this set, but... On Fri, Apr 29, 2022 at 12:20:14 +0200, Gerd Hoffmann wrote: > Copy over unmodified (except for running through uncrustify), from > https://github.com/tianocore/edk2-libc/tree/master/StdLib/LibC/CRT ...I think these files should

Re: [edk2-devel] [PATCH v3 05/10] MdePkg/CompilerIntrinsicsLib: copy over intrinsics from edk2-libc repo

2022-05-05 Thread Gerd Hoffmann
On Thu, May 05, 2022 at 10:50:27AM +0100, Leif Lindholm wrote: > Apologies for late feedback. > > I'm super happy with this set, but... > > On Fri, Apr 29, 2022 at 12:20:14 +0200, Gerd Hoffmann wrote: > > Copy over unmodified (except for running through uncrustify), from > > https://github.com/ti

Re: [edk2-devel] [PATCH v3 05/10] MdePkg/CompilerIntrinsicsLib: copy over intrinsics from edk2-libc repo

2022-05-05 Thread Leif Lindholm
On Thu, May 05, 2022 at 12:23:18 +0200, Gerd Hoffmann wrote: > On Thu, May 05, 2022 at 10:50:27AM +0100, Leif Lindholm wrote: > > Apologies for late feedback. > > > > I'm super happy with this set, but... > > > > On Fri, Apr 29, 2022 at 12:20:14 +0200, Gerd Hoffmann wrote: > > > Copy over unmodif

Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg: Save PcdConfidentialComputingGuestAttr in mCcGuestAttr

2022-05-05 Thread Min Xu
Thanks for the suggestion. I tried the solution and it does work. In a summary, the solution imports 2 CpuMpPei in OvmfPkgX64. Each CpuMpPei driver owns unique FILE_GUID so that both 2 drivers can be built into one image. A set of MpInitLibDepLib are imported. These libs are very simple and they

[edk2-devel] [PATCH 0/6] Support 2 CpuMpPei/CpuDxe in One image

2022-05-05 Thread Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3918 Above BZ reports an issue that commit 88da06ca triggers ASSERT in some scenario. This patch-set is to fix this issue. As commit 88da06ca describes TDVF BSP and APs are simplied and it can simply use MpInitLibUp instead of MpInitLib. To achie

[edk2-devel] [PATCH 1/6] UefiCpuPkg: Revert "UefiCpuPkg: Enable Tdx support in MpInitLib"

2022-05-05 Thread Min Xu
From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3918 This reverts commit 88da06ca763eb6514565c1867a801a427c1f3447. This commit triggers the ASSERT in Non-Td guest. Cc: Eric Dong Cc: Ray Ni Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Tom Lenda

[edk2-devel] [PATCH 2/6] OvmfPkg: Add MpInitLibDepLib related PPI/Protocol definitions

2022-05-05 Thread Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3918 MpInitLibDepLib is a set of libraries which depend on PPI/Protocol. This patch defines the related PPI/Protocols in OvmfPkg. Cc: Eric Dong Cc: Ray Ni Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Tom Lendacky

[edk2-devel] [PATCH 3/6] OvmfPkg: Add MpInitLibDepLib

2022-05-05 Thread Min Xu
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3918 There are 4 MpInitLibDepLib: - PeiMpInitLibMpDepLib: MpInitLib multi-processor dependency - PeiMpInitLibUpDepLib: MpInitLib unique-processor dependency - DxeMpInitLibMpDepLib: MpInitLib multi-processor dependency - DxeMpInitLibUp

[edk2-devel] [PATCH 4/6] OvmfPkg/Sec: Install MpInitLibDepLib PPIs in SecMain.c

2022-05-05 Thread Min Xu
From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3918 Td guest should use MpInitLibUp, other guest use the MpInitLib. So in SecMain.c different PPI is installed according to the working guest type. Cc: Eric Dong Cc: Ray Ni Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottoml

[edk2-devel] [PATCH 5/6] OvmfPkg/TdxDxe: Install MpInitLibDepLib protocols

2022-05-05 Thread Min Xu
From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3918 In Td guest CpuDxe driver uses the MpInitLibUp, the other guest type use the MpInitLib. So we install different Protocols according to the current working guest type. Cc: Eric Dong Cc: Ray Ni Cc: Brijesh Singh Cc: Erdem A

[edk2-devel] [PATCH 6/6] OvmfPkg: Enable 2 different CpuMpPei and CpuDxe drivers

2022-05-05 Thread Min Xu
From: Min M Xu BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3918 In OvmfPkgX64 we enable 2 different CpuMpPei and CpuDxe drivers. The difference between the drivers is the MpInitLib or MpInitLibUp. This is acomplished by adding a MpInitLibDepLib. In IntelTdxX64 we enable 2 versions of Cpu

[edk2-devel] Event: TianoCore Community Meeting - EMEA / NAMO - 05/05/2022 #cal-reminder

2022-05-05 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Community Meeting - EMEA / NAMO *When:* 05/05/2022 9:00am to 10:00am (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_N2UyMTVhZjUtOTk3Ni00MmI0LTg0NmItNzIwYTkyMGJhYzNh%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed4-84

[edk2-devel] Event: TianoCore Community Meeting - EMEA / NAMO - 05/05/2022 #cal-reminder

2022-05-05 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Community Meeting - EMEA / NAMO *When:* 05/05/2022 9:00am to 10:00am (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_N2UyMTVhZjUtOTk3Ni00MmI0LTg0NmItNzIwYTkyMGJhYzNh%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed4-84

[edk2-devel] TianoCore Community Meeting EMEA/NAMO 20220506

2022-05-05 Thread Demeter, Miki
# TianoCore Community Meeting **Highlights:** - Coverity update from Felix # Meeting Minutes: 1) **Event Updates (_5 minutes]** - **No Event Updates ** 2) [**Stable Tag Updates (_5 minutes_)** - Soft Freeze - 2022- - Hard freeze - 2022- - 2022- Release -** Stable Tag 20220225 released ** 3)

Re: 回复: [edk2-devel] [PATCH v5 0/8] Add Variable Flash Info HOB

2022-05-05 Thread Michael Kubacki
I still believe a long term design pattern deserves more focus and documentation than a quick modification to this series. Can you confirm that you envision MdePkg/MdeLibs.dsc.inc serving as a monolithic host of various other default library class instances? That somewhat inverts the package

[edk2-devel] Event: TianoCore Community Meeting - APAC/NAMO - 05/05/2022 #cal-reminder

2022-05-05 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Community Meeting - APAC/NAMO *When:* 05/05/2022 7:30pm to 8:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZWNiZWM1MzgtNWEzMy00MTgwLTgwNjAtNWQ1ZWUwZmQzNjVh%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed4-8496-

[edk2-devel] Event: TianoCore Community Meeting - APAC/NAMO - 05/05/2022 #cal-reminder

2022-05-05 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Community Meeting - APAC/NAMO *When:* 05/05/2022 7:30pm to 8:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZWNiZWM1MzgtNWEzMy00MTgwLTgwNjAtNWQ1ZWUwZmQzNjVh%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4ed4-8496-

Re: [edk2-devel] [PATCH 4/6] OvmfPkg/Sec: Install MpInitLibDepLib PPIs in SecMain.c

2022-05-05 Thread Ni, Ray
> -Original Message- > From: Xu, Min M > Sent: Thursday, May 5, 2022 10:43 PM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Dong, Eric ; Ni, Ray > ; Brijesh Singh > ; Aktas, Erdem ; James > Bottomley ; Yao, > Jiewen ; Tom Lendacky ; Gerd > Hoffmann > Subject: [PATCH 4/6] OvmfPkg/Sec:

Re: [edk2-devel] [PATCH 6/6] OvmfPkg: Enable 2 different CpuMpPei and CpuDxe drivers

2022-05-05 Thread Ni, Ray
> > +DEFINE MP_CPU_DXE_GUID = 2d73044a-1df3-415d-b054-17fe05765c3c Can you remove the above GUID definition? > +DEFINE MP_CPU_PEI_GUID = 3dd59561-e4ea-4846-b7c5-c7b74a061190 Can you remove the above GUID definition? > +DEFINE UP_CPU_PEI_GUID = 280251c4-1d09-4035-9062-839acb5f18c1 > + > +DEFIN