Re: [edk2-devel] [PATCH 1/2] Reconfigure OpensslLib to add elliptic curve chipher algorithms

Agree with that and I think the first issue is OPENSSL_NO_* be not cover every file related to some feature in openssl (like ec). Once those macro defines can cover everything, we can put all files in OpensslLib.inf [Source], and control macro defines in opensslconf.h by PCDs to do customization.

[edk2-devel] [PATCH 1/1] UEFI-SCT: SctPkg: Updated the check for monotonic count after restart

Updated the check for montonic count in the case of after restart >From the UEFI Spec: "The platform’s monotonic counter is comprised of two parts: the high 32 bits and the low 32 bits. The low 32-bit value is volatile and is reset to zero on every system reset. It is increased by 1 on every call

[edk2-devel] [PATCH] [PATCH v1] MdeModulePkg: Add bRefClkFreq card attribute programming support

When the UFS card comes out of Manufacturer, bRefClkFreq attribute is set to 1h on the UFS card as per the "MDV” (Manufacturer Default Value) specified by the spec JESD220*. However, depends on the UFS host system environment, it need to be set to correct value. Reference Clock Frequency value 0h:

Re: [edk2-devel] [PATCH v1 4/7] StandaloneMmPkg: Invoke GetPhysicalAddressBits() and remove the duplicated code

On Wed, 2 Mar 2022 at 09:20, Yu Pu wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3394 > > Invoke GetPhysicalAddressBits() defined in UefiCpuPkg for CPU physical address > mask calculation and remove the duplicated code in > StandaloneMmPkg\Library\StandaloneMmMemLib\X86StandaloneM

Re: [edk2-devel] [PATCH 1/2] Reconfigure OpensslLib to add elliptic curve chipher algorithms

I don't like OpensslEclib, it seems a workaround. We already have 5 INF under BaseCryptLib. It is complicated enough. And I am not sure how OpensslEclib can resolve size issue... > -Original Message- > From: Li, Yi1 > Sent: Thursday, March 3, 2022 4:43 PM > To: Yao, Jiewen ; Gerd Hoffma

Re: [edk2-devel] [PATCH v6 4/8] OvmfPkg: CloudHv: Remove VARS and CODE sections

On Wed, Mar 02, 2022 at 02:31:33PM +0100, sebastien.bo...@intel.com wrote: > From: Sebastien Boeuf > > CloudHv doesn't need any VARS store, and it doesn't need the CODE > section to be generated separately either. The only thing needed is to > generate a firmware binary that can be used by Cloud

Re: [edk2-devel] [PATCH v6 8/8] OvmfPkg: CloudHv: Add README

On Wed, Mar 02, 2022 at 02:31:37PM +0100, sebastien.bo...@intel.com wrote: > From: Sebastien Boeuf > > Add some documentation to the CloudHv target in order to clarify how to > use it and what to expect from it. > > Signed-off-by: Sebastien Boeuf Acked-by: Gerd Hoffmann -=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v6 5/8] OvmfPkg: Generate CloudHv as a PVH ELF binary

On Wed, Mar 02, 2022 at 02:31:34PM +0100, sebastien.bo...@intel.com wrote: > From: Sebastien Boeuf > > Following the model from the Xen target, CloudHv is generated as a PVH > ELF binary to take advantage of the PVH specification, which requires > less emulation from the VMM. > > The fdf include

Re: [edk2-devel] RFC: UefiCpuPkg for all processor archs

Hi Mike, Do you have any feedback on this? Or we just bring this topic to the design meeting? That would be good if any of you can give other thoughts, so I can have some POC code before the design meeting. Thanks Abner From: devel@edk2.groups.io on behalf of Ab

[edk2-devel] Event: TianoCore edk2-test Bug Triage Meeting - 03/03/2022 #cal-reminder

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:Asia/Shanghai LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/Asia/Shanghai X-LIC-LOCAT

[edk2-devel] Now: TianoCore edk2-test Bug Triage Meeting - 03/03/2022 #cal-notice

*TianoCore edk2-test Bug Triage Meeting* *When:* 03/03/2022 10:00pm to 11:00pm (UTC+08:00) Asia/Shanghai *Where:* https://armltd.zoom.us/j/93809865843?pwd=dU1hSzk4NHM2RGhaRDRyWWZxUzY5dz09&from=addon *Organizer:* Edhaya Chandran edhaya.chand...@arm.com ( edhaya.chand...@arm.com?subject=Re:%20Eve

Re: [edk2-devel] [PATCH edk2-platforms v2 1/1] Platform/VExpressPkg: Avoid overriding defines

Thanks. Pushed as c9e377b00fc0..958fc02b1593 Regards, Sami Mujawar On 28/02/2022 05:57 PM, patrik.bergl...@arm.com wrote: From: Patrik Berglund The definition of macros (e.g. SECURE_BOOT_ENABLE and others) in ArmVExpress.dsc.inc overrides the setting configured in the platform DSC file, th

Re: [edk2-devel] [PATCH v3] MdePkg/Include: Add ARM specific definitions for CPER

Hi Ming, Thank you for this patch. These changes look good to me. The reference to the USWG mantis for defining the Arm CPER Processor error types is https://mantis.uefi.org/mantis/view.php?id=2306 and the corresponding code first bugzilla ticket is at https://bugzilla.tianocore.org/show_bug.

Re: [edk2-devel] [PATCH] uefi-sct/SctPkg:Enhance BBTestReadKeyStrokeExFunctionAutoTestCheckpoint1()

Sorry for the late review. The change looks fine. However, I'm confused about the comment " Log the error here and return key states are not supported when high order bit of KeyToggleState is 0 or KeyState not touched". It looks like returning EFI_UNSUPPORTED won't log any error/failure in the

[edk2-devel] Cancelled Event: TianoCore Design Meeting - APAC/NAMO - Friday, March 4, 2022 #cal-cancelled

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCELLED REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:Asia/Shanghai LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/Asia/Shanghai X-LIC-LOC

Re: [edk2-devel] [PATCH V7 25/37] MdeModulePkg: EFER should not be changed in TDX

On March 3, 2022 11:12 AM, Wang Jian wrote: > > Hi Min, > > I think the PCD should not be dynamic. Dynamic PCD is used for those > features which can be changed at boot time. But, for Intel processor, it > should always stay as FALSE. So there's no need to make it dynamic. > FixedAtBuild should b

Re: [edk2-devel] [PATCH V7 26/37] MdeModulePkg: Add PcdTdxSharedBitMask

On March 3, 2022 11:27 AM, Wang, Jian wrote: > Hi Min, > > Similar to patch 25, I don't see the needs to make this PCD dynamic only. > Do you have any strong reasons? If not sure, maybe it'd be better to put it > under following section. > > [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic,

Re: [edk2-devel] [PATCH V7 25/37] MdeModulePkg: EFER should not be changed in TDX

Ok for me. Regards, Jian > -Original Message- > From: Xu, Min M > Sent: Friday, March 04, 2022 8:19 AM > To: Wang, Jian J ; devel@edk2.groups.io > Cc: Wu, Hao A ; Brijesh Singh ; > Aktas, Erdem ; James Bottomley > ; Yao, Jiewen ; Tom Lendacky > ; Gerd Hoffmann > Subject: RE: [PATCH V7 2

Re: [edk2-devel] [PATCH 1/2] Reconfigure OpensslLib to add elliptic curve chipher algorithms

Apologies, I am afraid as I may not be able to incorporate/address all the concerns expressed in the thread due to lack of my understanding in this space. But I have created a new PR which addresses Yi Li concerns about constraining the changes only to CryptoPkg. EDK2: PR to enable ECC Ciphers i

[edk2-devel] [PATCH v2] IntelSiliconPkg/BaseConfigBlockLib: Add function to iterate over Config Blocks

In BaseConfigBlockLib add function to get next config block from config blocks table in order to iterate over blocks of the same GUID. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3700 Cc: Ray Ni ray...@intel.com Cc: Rangasai V Chaganty rangasai.v.chaga...@intel.c

回复: [edk2-devel] Build edk2 fail

Please update nasm to 2.15.05 or later. Thanks Liming 发件人: devel@edk2.groups.io 代表 Yang, Lixiao 发送时间: 2022年3月3日 10:21 收件人: devel@edk2.groups.io 主题: [edk2-devel] Build edk2 fail Hi, I encountered a failure when trying to build edk2 on March 1st. Here is the failure: /build/lxy/edk2_t

Re: [edk2-devel] [PATCH v6 0/8] CloudHv: Rely on PVH boot specification

Series Reviewed-by: jiewen@intel.com. > -Original Message- > From: Boeuf, Sebastien > Sent: Wednesday, March 2, 2022 9:31 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Justen, Jordan L > ; kra...@redhat.com; Boeuf, Sebastien > > Subject: [PATCH v6 0/8] CloudHv: Rely on PVH boot s

Re: [edk2-devel] [PATCH v6 0/8] CloudHv: Rely on PVH boot specification

Pushed 26af69d..dd3b1f2 https://github.com/tianocore/edk2/pull/2584 > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewen > Sent: Friday, March 4, 2022 1:55 PM > To: Boeuf, Sebastien ; devel@edk2.groups.io > Cc: Justen, Jordan L ; kra...@redhat.com > Subject: Re: [edk

Re: [edk2-devel] [PATCH v4 1/1] CryptoPkg: Add new hash algorithm ParallelHash256HashAll in BaseCryptLib.

Thanks for the update. Comments below: 1) I don't think we should putting Keccak1600_Ctx in CrtLibSupport.h. It has nothing to do with CRT lib. 2) Same feedback to SHA3_absorb and SHA3_squeeze. They have nothing to do with CRT lib. 3) when you add new lib interfaces, you need add them to all

Re: [edk2-devel] [PATCH v1 4/7] StandaloneMmPkg: Invoke GetPhysicalAddressBits() and remove the duplicated code

Agree. Yu, can you please add the UefiCpuLib in [LibraryClasses.IA32, LibraryClasses.X64] instead of [LibraryClasses]? -Original Message- From: devel@edk2.groups.io On Behalf Of Ard Biesheuvel Sent: Thursday, March 3, 2022 5:58 PM To: Pu, Yu Cc: edk2-devel-groups-io ; Ard Biesheuvel ;