[edk2-devel] [PATCH v4] MdeModulePkg: Replace with UFS_UNIT_DESC to fix timeout problem

2021-12-17 Thread VincentX Ke
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3714 Replace with UFS_UNIT_DESC to fix response timeout problem. Cc: Hao A Wu Cc: Ray Ni Cc: Ian Chiu Cc: Maggie Chu Signed-off-by: VincentX Ke --- .../Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c | 20 +-- 1 file changed, 9 in

[edk2-devel] [PATCH v2] MdeModulePkg: Refactoring UFS DME request and fix timing problem

2021-12-17 Thread VincentX Ke
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3775 Refactoring UFS DME request function and retry up to 5 times. Cc: Hao A Wu Cc: Ray Ni Cc: Ian Chiu Cc: Maggie Chu Signed-off-by: VincentX Ke --- MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHci.c | 302 +++- 1 file changed, 17

[edk2-devel] [PATCH v2] MdeModulePkg: Put off UFS HCS.DP checking to fix timing problem

2021-12-17 Thread VincentX Ke
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3776 Put off UFS HCS.DP (Device Attached) checking until UfsDeviceDetection() to fix timing problem. Cc: Hao A Wu Cc: Ray Ni Cc: Ian Chiu Cc: Maggie Chu Signed-off-by: VincentX Ke --- MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsHci.c | 47 +++

[edk2-devel] [PATCH 1/1] Bhyve: fix tls-enabled build

2021-12-17 Thread Gerd Hoffmann
Path doesn't exist below OvmfPkg/Bhyve, use the OvmfPkg version instead. Fixes build with -D NETWORK_TLS_ENABLE. Signed-off-by: Gerd Hoffmann --- OvmfPkg/Bhyve/BhyveX64.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.ds

[edk2-devel] [PATCH edk2-platforms v1 0/3] Fix build breaks for SynQuacerEvalBoard

2021-12-17 Thread Sami Mujawar
This patch series fixes the build breaks in SynQuacerEvalBoard. Note: I have only tested that the build is fixed. I don't have a board to test the functionality. The changes can be seen at: https://github.com/samimujawar/edk2-platforms/tree/2015_fix_arm_plat_build_break_v1 Sami Mujawar (3): Pla

[edk2-devel] [PATCH edk2-platforms v1 1/3] Platform/Socionext: Fix build break for SynQuacerEvalBoard

2021-12-17 Thread Sami Mujawar
BdsDxe depends on VariablePolicyHelperLib, so move it out from VariableRuntimeDxe.inf and add it to LibraryClasses.DXE_DRIVER and LibraryClasses.DXE_RUNTIME_DRIVER. This is required to fix the build break in SynQuacerEvalBoard.dsc Signed-off-by: Sami Mujawar --- Platform/Socionext/SynQuacerEval

[edk2-devel] [PATCH edk2-platforms v1 3/3] Platform/Socionext/SynQuacerEvalBoard: Disable EbcDxe for AArch32 builds

2021-12-17 Thread Sami Mujawar
EbcDxe is not supported for AArch32 builds of the firmware. Therefore, move EbcDxe so that it is included only for AArch64 builds of the firmware. Signed-off-by: Sami Mujawar --- Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 4 +++- Platform/Socionext/SynQuacerEvalBoard/SynQuac

[edk2-devel] [PATCH edk2-platforms v1 2/3] Platform/Socionext/SynQuacerEvalBoard: Add missing ArmSoftFloatLib

2021-12-17 Thread Sami Mujawar
ArmSoftFloatLib is required for the AARCH32 build of the firmware for SynQuacerEvalBoard. Therefore, add the missing ArmSoftFloatLib to SynQuacerEvalBoard.dsc Signed-off-by: Sami Mujawar --- Platform/Socionext/SynQuacerEvalBoard/SynQuacerEvalBoard.dsc | 3 +++ 1 file changed, 3 insertions(+) d

Re: [edk2-devel] [PATCH edk2-platforms v1 03/10] Platform/ARM: Modify duplicated GUID in ArmVExpressLibSec

2021-12-17 Thread Sami Mujawar
Hi Pierre, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 24/11/2021 04:23 PM, pierre.gond...@arm.com wrote: From: Pierre Gondois The two following modules have the same GUID: - Platform/ARM/VExpressPkg/Library/ ArmVExpressLibRTSM/ArmVExpressLibSec.inf - Silicon/

Re: [edk2-devel] [PATCH edk2-platforms v1 01/10] Platform/ARM: Modify duplicated GUID in PciHostBridgeLib

2021-12-17 Thread Sami Mujawar
Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 24/11/2021 04:23 PM, pierre.gond...@arm.com wrote: From: Pierre Gondois The two following modules have the same GUID: - Platform/ARM/Morello/Library/PciHostBridgeLib/ PciHostBridgeLibFvp.inf - Plat

Re: [edk2-devel] [PATCH edk2-platforms v1 02/10] Platform/ARM: Modify duplicated GUID in ArmVExpressLib

2021-12-17 Thread Sami Mujawar
Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 24/11/2021 04:23 PM, pierre.gond...@arm.com wrote: From: Pierre Gondois The two following modules have the same GUID: - Platform/ARM/VExpressPkg/Library/ ArmVExpressLibRTSM/ArmVExpressLib.inf - Pla

Re: [edk2-devel] [PATCH edk2-platforms v1 04/10] Platform/ARM: Modify duplicated GUID in ArmVExpressPkg.dec

2021-12-17 Thread Sami Mujawar
Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 24/11/2021 04:23 PM, pierre.gond...@arm.com wrote: From: Pierre Gondois The two following packages have the same GUID: - Platform/ARM/VExpressPkg/ArmVExpressPkg.dec - edk2/ArmPlatformPkg/ArmPlatformPk

Re: [edk2-devel] [PATCH edk2-platforms v1 05/10] Platform/ARM: Fix Ecc error 1001

2021-12-17 Thread Sami Mujawar
Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 24/11/2021 04:23 PM, pierre.gond...@arm.com wrote: From: Pierre Gondois This patch fixes the following Ecc reported error: 'TAB' character is not allowed in source code, please replace each 'TAB' with

Re: [edk2-devel] [PATCH edk2-platforms v1 06/10] Platform/ARM: Fix Ecc error 1008

2021-12-17 Thread Sami Mujawar
Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 24/11/2021 04:23 PM, pierre.gond...@arm.com wrote: From: Pierre Gondois This patch fixes the following Ecc reported error: File has invalid Non-ACSII char. Signed-off-by: Pierre Gondois --- .../Dr

Re: [edk2-devel] [PATCH edk2-platforms v1 03/10] Platform/ARM: Modify duplicated GUID in ArmVExpressLibSec

2021-12-17 Thread PierreGondois
Hi Sami, You are correct, as stated in Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLibSec.inf: "Based on the files under ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibRTSM/" Thanks for updating the commit, Regards, Pierre On 12/17/21 2:59 PM, Sami Mujawar wrote: > H

Re: [edk2-devel] [PATCH edk2-platforms v1 07/10] Platform/ARM: Fix Ecc error 1012

2021-12-17 Thread Sami Mujawar
Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 24/11/2021 04:23 PM, pierre.gond...@arm.com wrote: From: Pierre Gondois This patch fixes the following Ecc reported error: There should be no trailing white space in one line. Signed-off-by: Pierre G

Re: [edk2-devel] [PATCH edk2-platforms v1 08/10] Platform/ARM: Fix Ecc error 3003

2021-12-17 Thread Sami Mujawar
Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 24/11/2021 04:23 PM, pierre.gond...@arm.com wrote: From: Pierre Gondois This patch fixes the following Ecc reported error: A comparison of any pointer to zero must be done via the NULL type Signed-of

Re: [edk2-devel] [PATCH edk2-platforms v1 09/10] Platform/ARM: Fix Ecc error 9005

2021-12-17 Thread Sami Mujawar
Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 24/11/2021 04:23 PM, pierre.gond...@arm.com wrote: From: Pierre Gondois This patch fixes the following Ecc reported error: Only Doxygen commands '@bug', '@todo', '@example', '@file', '@attention', '@p

Re: [edk2-devel] [PATCH edk2-platforms v1 10/10] Platform/ARM: Fix Ecc error 5005

2021-12-17 Thread Sami Mujawar
Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 24/11/2021 04:23 PM, pierre.gond...@arm.com wrote: From: Pierre Gondois This patch fixes the following Ecc reported error: The body of a function should be contained by open and close braces that must

Re: [edk2-devel] [PATCH] SecurityPkg: Debug code to audit BIOS TPM extend operations

2021-12-17 Thread Yao, Jiewen
Pushed: 8ed8568922be9b5f7111fc1297317106aba7ab52 > -Original Message- > From: Gonzalez Del Cueto, Rodrigo > Sent: Friday, December 17, 2021 10:47 AM > To: devel@edk2.groups.io > Cc: Gonzalez Del Cueto, Rodrigo ; Yao, > Jiewen ; Wang, Jian J > Subject: [PATCH] SecurityPkg: Debug code to a

Re: [edk2-devel] [PATCH] SecurityPkg: Reallocate TPM Active PCRs based on platform support

2021-12-17 Thread Yao, Jiewen
Pushed 195f0119731dbc4b93b4d485998dac3bbf8629a3 > -Original Message- > From: Gonzalez Del Cueto, Rodrigo > Sent: Friday, December 17, 2021 10:48 AM > To: devel@edk2.groups.io > Cc: Gonzalez Del Cueto, Rodrigo ; > Wang, Jian J ; Yao, Jiewen > Subject: [PATCH] SecurityPkg: Reallocate TPM A

Re: [edk2-devel] [PATCH] SecurityPkg: TPM must go to Idle state on CRB command completion

2021-12-17 Thread Yao, Jiewen
Pushed ab5ab2f60348138a4b7b1c95ad6f5d0954fb96f1 > -Original Message- > From: Gonzalez Del Cueto, Rodrigo > Sent: Friday, December 17, 2021 10:48 AM > To: devel@edk2.groups.io > Cc: Gonzalez Del Cueto, Rodrigo ; > Wang, Jian J ; Yao, Jiewen > Subject: [PATCH] SecurityPkg: TPM must go to I

Re: [edk2-devel] [PATCH v2 1/1] EmbeddedPkg/AcpiLib: Add more helper functions

2021-12-17 Thread Leif Lindholm
Hi Nhi, I have now pushed this patch as c63a10ecb7d6, and will get back to the rest of the Altra port. / Leif On Thu, Sep 09, 2021 at 00:02:36 +0700, Nhi Pham wrote: > Thanks Abner. > > I will correct the description for the function AcpiLocateTableBySignature > in the v3. > > Best regards

Re: [edk2-devel] [PATCH edk2-platforms v1 03/10] Platform/ARM: Modify duplicated GUID in ArmVExpressLibSec

2021-12-17 Thread Sami Mujawar
Hi Leif, Ard, Wenyi, Is it possible to review and provde feedback for this change, please? Regards, Sami Mujawar On 17/12/2021 02:15 PM, Pierre Gondois wrote: Hi Sami, You are correct, as stated in Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLibSec.inf: "Based on the file

Re: [edk2-devel] [PATCH edk2-platforms v1 03/10] Platform/ARM: Modify duplicated GUID in ArmVExpressLibSec

2021-12-17 Thread Ard Biesheuvel
On Fri, 17 Dec 2021 at 17:30, Sami Mujawar wrote: > > Hi Leif, Ard, Wenyi, > > Is it possible to review and provde feedback for this change, please? > I agree that this should be resolved, and I don't think it matters which one we change. The INF GUIDs of libraries are never used anyway, as far a

Re: [edk2-devel] [PATCH edk2-platforms v1 0/3] Fix build breaks for SynQuacerEvalBoard

2021-12-17 Thread Ard Biesheuvel
On Fri, 17 Dec 2021 at 14:46, Sami Mujawar wrote: > > This patch series fixes the build breaks in SynQuacerEvalBoard. > Note: I have only tested that the build is fixed. I don't have > a board to test the functionality. > > The changes can be seen at: > https://github.com/samimujawar/edk2-platform

Re: [edk2-devel] [PATCH edk2-platforms v1 03/10] Platform/ARM: Modify duplicated GUID in ArmVExpressLibSec

2021-12-17 Thread Sami Mujawar
Hi Ard, On 17/12/2021, 16:34, "Ard Biesheuvel" wrote: On Fri, 17 Dec 2021 at 17:30, Sami Mujawar wrote: > > Hi Leif, Ard, Wenyi, > > Is it possible to review and provde feedback for this change, please? > I agree that this should be resolved, and I don't think it

[edk2-devel] [PATCH] Maintainers.txt: Replace Pete with Jeremy as RPi reviewer

2021-12-17 Thread Jeremy Linton
First a huge thank you to Pete Batard for all the hard work landing the RPi code here, and keeping everyone in line. But, he has lots of commitments, and its time to give him a breather. As such, I will take over as a platform reviewer. Cc: Pete Batard Cc: Ard Biesheuvel Cc: Leif Lindholm Cc:

Re: [edk2-devel] [PATCH] Maintainers.txt: Replace Pete with Jeremy as RPi reviewer

2021-12-17 Thread Ard Biesheuvel
On Fri, 17 Dec 2021 at 17:52, Jeremy Linton wrote: > > First a huge thank you to Pete Batard for all the hard work > landing the RPi code here, and keeping everyone in line. > > But, he has lots of commitments, and its time to give him > a breather. As such, I will take over as a platform reviewer

Re: [edk2-devel] [PATCH 1/1] Bhyve: fix tls-enabled build

2021-12-17 Thread Ard Biesheuvel
On Fri, 17 Dec 2021 at 13:39, Gerd Hoffmann wrote: > > Path doesn't exist below OvmfPkg/Bhyve, use the OvmfPkg version > instead. Fixes build with -D NETWORK_TLS_ENABLE. > > Signed-off-by: Gerd Hoffmann > --- > OvmfPkg/Bhyve/BhyveX64.dsc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: [edk2-devel] [PATCH v3] OvmfPkg: Call PlatformInitializeConsole for GPU passthrough case

2021-12-17 Thread Ard Biesheuvel
On Fri, 17 Dec 2021 at 06:52, Gerd Hoffmann wrote: > > On Thu, Dec 16, 2021 at 09:41:40PM -0500, Stefan Berger wrote: > > For GPU passthrough support we have to initialize the console after > > EfiBootManagerDispatchDeferredImages() has loaded ROMs, so call it after > > this. This was the calling

Re: [edk2-devel] [PATCH] Maintainers.txt: Replace Pete with Jeremy as RPi reviewer

2021-12-17 Thread Pete Batard
Thanks Jeremy! On 2021.12.17 17:52, Jeremy Linton wrote: First a huge thank you to Pete Batard for all the hard work landing the RPi code here, and keeping everyone in line. But, he has lots of commitments, and its time to give him a breather. As such, I will take over as a platform reviewer.

Re: [edk2-devel] [PATCH v3 0/4] ArmPkg,ArmVirtPkg: Add support EFI_MP_SERVICES_PROTOCOL on AARCH64

2021-12-17 Thread Ard Biesheuvel
On Thu, 16 Dec 2021 at 04:46, Rebecca Cran wrote: > > Patch 1/4 is the start of addressing the issue that the Aff0 field of > the MPIDR is no longer guaranteed to be the core, and should be referred > to in a more generic way: for example it could be the thread, with Aff1 > being the core and Aff2

Re: [edk2-devel] [PATCH v3 0/4] ArmPkg,ArmVirtPkg: Add support EFI_MP_SERVICES_PROTOCOL on AARCH64

2021-12-17 Thread Rebecca Cran
On 12/17/21 11:08 AM, Ard Biesheuvel wrote: OK, this looks good to me in principe, and I am quite happy with the implementation of the MpInitLib and the new ability to dispatch execution to other cores. However, looking at ArmPkg/Include/Guid/ArmMpCoreInfo.h, I was seriously shocked at how much

Re: [edk2-devel] [PATCH v3] OvmfPkg: Call PlatformInitializeConsole for GPU passthrough case

2021-12-17 Thread Shivanshu Goyal
Hi, I'm asking on behalf of Arch Linux maintainers: are you planning on creating a new release with this patch, or should we apply this patch ourselves until a new version is released? Thank you, Shivanshu Goyal On Fri, Dec 17, 2021, 9:37 AM Ard Biesheuvel wrote: > On Fri, 17 Dec 2021 at 06:5

Re: [edk2-devel] [PATCH v3] OvmfPkg: Call PlatformInitializeConsole for GPU passthrough case

2021-12-17 Thread Ard Biesheuvel
On Fri, 17 Dec 2021 at 20:21, Shivanshu Goyal wrote: > > Hi, > > I'm asking on behalf of Arch Linux maintainers: are you planning on creating > a new release with this patch, or should we apply this patch ourselves until > a new version is released? > Tianocore doesn't do releases, there are on

[edk2-devel] [PATCH v2 0/2] ArmPkg: remove obsolete ARM_PROCESSOR_TABLE

2021-12-17 Thread Ard Biesheuvel
Remove the obsolete ARM_PROCESSOR_TABLE definition, and all the pieces that are related to it. Cc: Rebecca Cran Cc: Leif Lindholm Cc: Sami Mujawar Ard Biesheuvel (2): ArmPkg/MpInitLib: avoid ARM_PROCESSOR_TABLE ArmPkg/CpuDxe: drop ARM_PROCESSOR_TABLE pseudo-ACPI table ArmPkg/Drivers/CpuD

[edk2-devel] [PATCH v2 2/2] ArmPkg/CpuDxe: drop ARM_PROCESSOR_TABLE pseudo-ACPI table

2021-12-17 Thread Ard Biesheuvel
The ARM_PROCESSOR_TABLE pseudo-ACPI table (which carries a ACPI-table like header but is published as a EFI config table) is not described in any relevant spec, and is not known to be relied upon by any OS. Let's just get rid of it. Signed-off-by: Ard Biesheuvel --- ArmPkg/Drivers/CpuDxe/CpuDxe.

[edk2-devel] [PATCH v2 1/2] ArmPkg/MpInitLib: avoid ARM_PROCESSOR_TABLE

2021-12-17 Thread Ard Biesheuvel
Pass ARM_CORE_INFO[] directly into the MpInitLib init function so we don't need to rely on an obsolete and unrelated data structure. Signed-off-by: Ard Biesheuvel --- ArmPkg/Include/Library/MpInitLib.h | 2 +- ArmPkg/Drivers/CpuDxe/CpuMpInit.c | 10 -- ArmPkg/Library/MpInitLib/DxeMpL

Re: [edk2-devel] [PATCH v2 1/1] EmbeddedPkg/AcpiLib: Add more helper functions

2021-12-17 Thread Nhi Pham via groups.io
Hi Leif, Thanks so much for merging it. Happy Holidays! Best regards, Nhi On 17/12/2021 22:56, Leif Lindholm wrote: Hi Nhi, I have now pushed this patch as c63a10ecb7d6, and will get back to the rest of the Altra port. / Leif On Thu, Sep 09, 2021 at 00:02:36 +0700, Nhi Pham wrote: Th