On Fri, 17 Dec 2021 at 17:30, Sami Mujawar <sami.muja...@arm.com> wrote: > > Hi Leif, Ard, Wenyi, > > Is it possible to review and provde feedback for this change, please? >
I agree that this should be resolved, and I don't think it matters which one we change. The INF GUIDs of libraries are never used anyway, as far as I know. > > > On 17/12/2021 02:15 PM, Pierre Gondois wrote: > > Hi Sami, > > > > You are correct, as stated in > > Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLibSec.inf: > > > > "Based on the files under > > ArmPlatformPkg/ArmVExpressPkg/Library/ArmVExpressLibRTSM/" > > > > Thanks for updating the commit, > > > > Regards, > > > > Pierre > > > > > > > > On 12/17/21 2:59 PM, Sami Mujawar wrote: > >> Hi Pierre, > >> > >> Please find my response inline marked [SAMI]. > >> > >> Regards, > >> > >> Sami Mujawar > >> > >> > >> On 24/11/2021 04:23 PM, pierre.gond...@arm.com wrote: > >>> From: Pierre Gondois <pierre.gond...@arm.com> > >>> > >>> The two following modules have the same GUID: > >>> - Platform/ARM/VExpressPkg/Library/ > >>> ArmVExpressLibRTSM/ArmVExpressLibSec.inf > >>> - Silicon/Hisilicon/Library/ > >>> ArmPlatformLibHisilicon/ArmPlatformLibSec.inf > >>> > >>> The inf file in the Platform/ARM/ folder is based > >>> on the one in Silicon/Hisilicon/. Modify the one > >> [SAMI] I believe you want to say the inf file in Silicon/Hisilicon/is > >> based on the one in Platform/ARM and therefore you are modifying the inf > >> file in Silicon/Hisilicon. > >> Please let me know if this is correct, and I will update this in the > >> commit message before merging the change. > >> [/SAMI] > >>> in the Silicon/Hisilicon/. > >>> > >>> Signed-off-by: Pierre Gondois <pierre.gond...@arm.com> > >>> --- > >>> .../Library/ArmPlatformLibHisilicon/ArmPlatformLibSec.inf | 2 +- > >>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git > >>> a/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLibSec.inf > >>> b/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLibSec.inf > >>> index ac587deedfd8..7fd7b5183e5b 100644 > >>> --- > >>> a/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLibSec.inf > >>> +++ > >>> b/Silicon/Hisilicon/Library/ArmPlatformLibHisilicon/ArmPlatformLibSec.inf > >>> @@ -12,7 +12,7 @@ > >>> [Defines] > >>> INF_VERSION = 0x00010005 > >>> BASE_NAME = ArmPlatformLibSec > >>> - FILE_GUID = a79eed97-4b98-4974-9690-37b32d6a5b56 > >>> + FILE_GUID = ABF3B82B-892F-438F-901F-F148C2DF89E6 > >>> MODULE_TYPE = BASE > >>> VERSION_STRING = 1.0 > >>> LIBRARY_CLASS = ArmPlatformLib > >>> -- > >>> 2.25.1 > > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediately and do not disclose the > contents to any other person, use it for any purpose, or store or copy the > information in any medium. Thank you. > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#85076): https://edk2.groups.io/g/devel/message/85076 Mute This Topic: https://groups.io/mt/87284488/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
