Re: [edk2-devel] [PATCH] RedfishPkg: Update link to staging/RedfishClientPkg in Readme.md

2021-10-29 Thread Abner Chang
Looks good. Reviewed-by: Abner Chang From: Wang, Nickle (HPS SW) Sent: Friday, October 29, 2021 10:06 AM To: devel@edk2.groups.io Cc: Wang, Nickle (HPS SW) ; Chang, Abner (HPS SW/FW Technologist) ; Liming Gao Subject: [PATCH] RedfishPkg: Update link to staging/

Re: [edk2-devel] [PATCH V2 12/28] UefiCpuPkg/CpuExceptionHandler: Add base support for the #VE exception

2021-10-29 Thread Min Xu
On October 29, 2021 12:53 PM, Gerd Hoffmann wrote: > On Fri, Oct 29, 2021 at 12:17:05AM +, Yao, Jiewen wrote: > > I am OK to use EFI_CC_MEASUREMENT_PROTOCOL to replace > > EFI_TEE_MEASUREMENT_PROTOCOL. (much better than COCO) > > Looks good to me. The PCD uses the term ConfidentialComputing t

Re: [edk2-devel] [PATCH] edk2-staging/RedfishClientPkg: Add the helper library

2021-10-29 Thread Nickle Wang
Reviewed-by: Nickle Wang Thanks, Nickle -Original Message- From: Chang, Abner (HPS SW/FW Technologist) Sent: Thursday, October 28, 2021 10:02 PM To: devel@edk2.groups.io Cc: Chang, Abner (HPS SW/FW Technologist) ; Wang, Nickle (HPS SW) ; Liming Gao Subject: [PATCH] edk2-staging/Redfi

[edk2-devel] [PATCH] edk2-staging/EmulatorPkg: Enable network when REDFISH_ENABLE is TRUE

2021-10-29 Thread Abner Chang
Enable edk2 network settings when edk2 Redfish foundation is enabled Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Liming Gao Cc: Andrew Fish Cc: Ray Ni --- EmulatorPkg/EmulatorPkg.dsc | 10 ++ 1 file changed, 10 insertions(+) diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/

[edk2-devel] [PATCH] edk2-staging/EmulatorPkg: Add REDFISH_CLIENT macro

2021-10-29 Thread Abner Chang
Add REDFISH_CLIENT macro to control RedfishClientPkg modules. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Liming Gao Cc: Andrew Fish Cc: Ray Ni --- EmulatorPkg/EmulatorPkg.dsc | 3 +++ EmulatorPkg/EmulatorPkg.fdf | 1 + 2 files changed, 4 insertions(+) diff --git a/EmulatorPkg/EmulatorPk

[edk2-devel] [PATCH] edk2-staging/EmulatorPkg: Enable RedfishClientPkg on emulator

2021-10-29 Thread Abner Chang
Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Liming Gao Cc: Andrew Fish Cc: Ray Ni --- EmulatorPkg/EmulatorPkg.dsc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc index b53e24d6f57..e5cb3c3d8d2 100644 --- a/Emul

Re: [edk2-devel] [PATCH] edk2-staging/EmulatorPkg: Add a sample memory configuration HII driver

2021-10-29 Thread Abner Chang
This patch is sent in behalf of Nickle Wang who is the author of this change. Reviewed-by: Abner Chang > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Abner Chang > Sent: Friday, October 29, 2021 9:45 AM > To: devel@edk2.groups.io > Cc: Wa

Re: [edk2-devel] [PATCH] edk2-staging/EmulatorPkg: Build Redfish memory configuration HII sample driver

2021-10-29 Thread Abner Chang
This patch is sent in behalf of Nickle Wang who is the author of this change. Reviewed-by: Abner Chang > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Abner Chang > Sent: Friday, October 29, 2021 10:35 AM > To: devel@edk2.groups.io > Cc: Wan

Re: [edk2-devel] [PATCH] edk2-staging/RedfishClientPkg: Add Redfish memory edk2 modules to build

2021-10-29 Thread Abner Chang
This patch is sent in behalf of Nickle Wang who is the author of this change. Reviewed-by: Abner Chang > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Abner Chang > Sent: Friday, October 29, 2021 10:46 AM > To: devel@edk2.groups.io > Cc: Wan

Re: [edk2-devel] [PATCH] edk2-staging/EmulatorPkg: Enable network when REDFISH_ENABLE is TRUE

2021-10-29 Thread Abner Chang
This patch is sent in behalf of Nickle Wang who is the author of this change. Reviewed-by: Abner Chang > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Abner Chang > Sent: Friday, October 29, 2021 4:07 PM > To: devel@edk2.groups.io > Cc: Wang

Re: [edk2-devel] [PATCH] edk2-staging/EmulatorPkg: Enable RedfishPkg on emulator

2021-10-29 Thread Abner Chang
This patch is sent in behalf of Nickle Wang who is the author of this change. Reviewed-by: Abner Chang > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Abner Chang > Sent: Friday, October 29, 2021 10:56 AM > To: devel@edk2.groups.io > Cc: Wan

Re: [edk2-devel] [PATCH] edk2-staging/EmulatorPkg: Add REDFISH_CLIENT macro

2021-10-29 Thread Abner Chang
This patch is sent in behalf of Nickle Wang who is the author of this change. Reviewed-by: Abner Chang > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Abner Chang > Sent: Friday, October 29, 2021 4:31 PM > To: devel@edk2.groups.io > Cc: Wang

Re: [edk2-devel] [PATCH] edk2-staging/EmulatorPkg: Enable RedfishClientPkg on emulator

2021-10-29 Thread Abner Chang
This patch is sent in behalf of Nickle Wang who is the author of this change. Reviewed-by: Abner Chang > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Abner Chang > Sent: Friday, October 29, 2021 4:33 PM > To: devel@edk2.groups.io > Cc: Wang

Re: [edk2-devel] [PATCH v1 2/7] MdePkg: Remove PPTT ID type structure

2021-10-29 Thread Chris Jones
Hi Liming, Yes ACPI 6.3A deprecated the ID type structure and ACPI 6.4 fully removed it from the specification. Thanks, Chris From: gaoliming Sent: Friday, October 29, 2021 2:34 AM To: Christopher Jones ; devel@edk2.groups.io Cc: michael.d.kin...@intel.com ;

Re: [edk2-devel] [PATCH 0/2] Rename XenTimerDxe to LocalApicTimerDxe

2021-10-29 Thread Ard Biesheuvel
On Fri, 29 Oct 2021 at 08:51, Min Xu wrote: > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3711 > > XenTimerDxe is a local Apic timer driver and it has nothing to do > with Xen. So rename it to LocalApicTimerDxe. > > After renaming, LocalApicTimerDxe is used in OvmfPkg if CSM_ENABLE=FALSE.

Re: [edk2-devel] RFC: Replace FMMT Tool from C to Python Version

2021-10-29 Thread Bob Feng
Liming, Correct. PyFMMT does not depend on GenSec, GenFfs and GenFv. Yes. the future PyGenSec, PyGenFfs and PyGenFv can reuse code from PyFMMT. Thanks, Bob From: devel@edk2.groups.io On Behalf Of gaoliming Sent: Friday, October 29, 2021 10:16 AM To: Chen, Christine ; devel@edk2.groups.io; r.

Re: [edk2-devel] [PATCH 2/2] OvmfPkg: Switch timer in build time for OvmfPkg

2021-10-29 Thread Gerd Hoffmann
> --- a/OvmfPkg/AmdSev/AmdSevX64.dsc > +++ b/OvmfPkg/AmdSev/AmdSevX64.dsc > @@ -670,10 +670,9 @@ >} > >MdeModulePkg/Universal/EbcDxe/EbcDxe.inf > - OvmfPkg/8259InterruptControllerDxe/8259.inf >UefiCpuPkg/CpuIo2Dxe/CpuIo2Dxe.inf >UefiCpuPkg/CpuDxe/CpuDxe.inf > - OvmfPkg/8254Timer

Re: [edk2-devel] [PATCH V2 12/28] UefiCpuPkg/CpuExceptionHandler: Add base support for the #VE exception

2021-10-29 Thread Gerd Hoffmann
On Fri, Oct 29, 2021 at 07:51:13AM +, Xu, Min M wrote: > On October 29, 2021 12:53 PM, Gerd Hoffmann wrote: > > On Fri, Oct 29, 2021 at 12:17:05AM +, Yao, Jiewen wrote: > > > I am OK to use EFI_CC_MEASUREMENT_PROTOCOL to replace > > > EFI_TEE_MEASUREMENT_PROTOCOL. (much better than COCO) >

Re: [edk2-devel] [PATCH v11 00/32] Add AMD Secure Nested Paging (SEV-SNP) support

2021-10-29 Thread Yao, Jiewen
Hi Brijesh Have you got R-B from UefiCpuPkg maintainer? > -Original Message- > From: Brijesh Singh > Sent: Monday, October 25, 2021 7:54 AM > To: devel@edk2.groups.io; Yao, Jiewen > Cc: brijesh.si...@amd.com; James Bottomley ; Xu, Min M > ; Tom Lendacky ; Justen, > Jordan L ; Ard Biesh

Re: [edk2-devel] RFC: Replace FMMT Tool from C to Python Version

2021-10-29 Thread Marvin Häuser
Good day, Is there any information available on PyGenFv? It also handles ELF to PE conversion (who knows why...), is that planned to be ported to Python as well? For Project Amaranth, we are currently implementing a tool to replace the ELF to PE conversion (among other things) and decided to

Re: [edk2-devel] [PATCH v11 00/32] Add AMD Secure Nested Paging (SEV-SNP) support

2021-10-29 Thread Brijesh Singh via groups.io
Hi Jiewen, I have not heard anything back from UefiCpuPkg maintainer yet, I will send another gentle ping on Monday again and hope maintainer get to it. -Brijesh On 10/29/21 7:26 AM, Yao, Jiewen wrote: > Hi Brijesh > Have you got R-B from UefiCpuPkg maintainer? > > > >> -Original Message

Re: [edk2-rfc] [edk2-devel] RFC: Replace FMMT Tool from C to Python Version

2021-10-29 Thread Bob Feng
Marvin, The PyGen*** tools I mentioned below are not implemented yet. But we want to convert the BaseTools C tools to python tools so we can move all basetools from edk2 repo to edk2-basetools repo. For the edk2-basetools repo, please refer to the discussion https://edk2.groups.io/g/devel/top

Re: [edk2-devel] 回复: [PATCH] MdeModulePkg/DxeCapsuleLibFmp: Capsule on Disk file name capsule

2021-10-29 Thread Bob Morgan via groups.io
Hi Liming, BuildSg is supposed to mean 'Build Scatter-Gather'. Maybe 'BuildGather' would be a better goto label since it matches the comment and the function? Let me know. Thanks, -bob -Original Message- From: devel@edk2.groups.io On Behalf Of gaoliming via groups.io Sent: Thursda

Re: [edk2-devel] [edk2-libc Patch 1/1] AppPkg/Applications/Python: Remove py2.7.2 support from edk2-libc

2021-10-29 Thread Jayaprakash, N
Thanks Mike for the review comments. I have made the changes to readme files as you have suggested. Regards, JP -Original Message- From: Kinney, Michael D Sent: 29 October 2021 10:39 To: Jayaprakash, N ; devel@edk2.groups.io; Kinney, Michael D Cc: Rebecca Cran Subject: RE: [edk2-deve

Re: [edk2-devel] [PATCH] MdeModulePkg/DxeCapsuleLibFmp: Add runtime SetImage support

2021-10-29 Thread Bob Morgan via groups.io
Hi Liming, See inline below. > -Original Message- > From: gaoliming > Sent: Thursday, October 28, 2021 7:57 PM > To: devel@edk2.groups.io; Bob Morgan > Cc: 'Jian J Wang' ; 'Guomin Jiang' > > Subject: 回复: [edk2-devel] [PATCH] MdeModulePkg/DxeCapsuleLibFmp: > Add runtime SetImage support

Re: [edk2-devel] [PATCH] SecurityPkg: TPM must go to Idle state on CRB command completion.

2021-10-29 Thread Rodrigo Gonzalez del Cueto
Hi Jiewen, I have tested the proposed CRB protocol fix with three different TPM configurations I have available which support the CRB interface: Intel PTT, STMicro and Nuvoton. Under these CRB configurations I didn't observe any issues arising from the proposed change aligning with the TCG CRB

Re: [edk2-devel] [edk2-platforms] [PATCH v1 1/2] MinPlatformPkg: Update APIC Table based on mode

2021-10-29 Thread Nate DeSimone
Hi Abdul, Excellent! I checked with the Windows kernel team as well and they don't believe there should be any issues. Therefore, I am approving your patch series as it is. Thanks, Nate Reviewed-by: Nate DeSimone -Original Message- From: Attar, AbdulLateef (Abdul Lateef) Sent: Thur

Re: [edk2-devel] [PATCH v6 06/52] IntelSiliconPkg: Add PCH SPI PPI

2021-10-29 Thread Nate DeSimone
Hi Michael, Looking at your new patch series, now that we have the new PCH_SPI2_PPI, there is no longer any need for the existence of IntelSiliconPkg/Include/Ppi/Spi.h. The PCH_SPI_PPI will always be a silicon generation specific protocol. There is no need to promote that protocol to the multi-

Re: [edk2-devel] [PATCH v6 07/52] IntelSiliconPkg: Add PCH SPI Protocol

2021-10-29 Thread Nate DeSimone
Hi Michael, Looking at your new patch series, now that we have the new PCH_SPI2_PROTOCOL, there is no longer any need for the existence of IntelSiliconPkg/Include/Protocol/Spi.h. The PCH_SPI_PROTOCOL will always be a silicon generation specific protocol. There is no need to promote that protoco

Re: [edk2-devel] [PATCH v6 06/52] IntelSiliconPkg: Add PCH SPI PPI

2021-10-29 Thread Michael Kubacki
Hi Nate, I will send a separate patch series that removes the v1 PPI and Protocol. Thanks, Michael On 10/29/2021 6:22 PM, Nate DeSimone wrote: Hi Michael, Looking at your new patch series, now that we have the new PCH_SPI2_PPI, there is no longer any need for the existence of IntelSiliconPkg

Re: [edk2-devel] [edk2-discuss] [edk2-rfc] Inclusive Language RFC

2021-10-29 Thread Teng, Lynn L
Hello Marvin, Your concerns have been heard, but providing a list of every alternative for every scenario and how/when to use them would be unreasonable. We would expect developers to use their understanding of each term and the context of how it is being used, and to find an appropriate alter

Re: [edk2-devel] [PATCH] Reallocate TPM Active PCRs based on platform support.

2021-10-29 Thread Rodrigo Gonzalez del Cueto
Hi Jiewen, In the past most of the TPM devices supported SHA1 and SHA256 hashing algorithms, which we have also supported in BIOS for many years. What recently changed is the exposure to new TPM devices which support additional hashing algorithms (SHA384 and SM3) and will have such PCR banks ac

[edk2-devel] [PATCH] RedfishPkg: Add more information to Readme.md

2021-10-29 Thread Abner Chang
Add more information of network settings for EDK2 Redfish service on EmulatorPkg. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Liming Gao --- RedfishPkg/Readme.md | 16 1 file changed, 16 insertions(+) diff --git a/RedfishPkg/Readme.md b/RedfishPkg/Readme.md index 4e5f59850