Re: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Do not reconnect driver with form-update

2020-05-24 Thread Dandan Bi
Reviewed-by: Dandan Bi Thanks, Dandan > -Original Message- > From: Walon Li > Sent: Wednesday, May 20, 2020 12:25 PM > To: devel@edk2.groups.io > Cc: walon...@hpe.com; Bi, Dandan ; > nickle.w...@hpe.com; abner.ch...@hpe.com; sunnyw...@hpe.com > Subject: [PATCH] MdeModulePkg/SetupBrowser

Re: [edk2-devel] [PATCH edk2-platforms 10/16] Silicon/NXP: PciSegmentLib: Add ECAM config support for PCIe LS Controller

2020-05-24 Thread Wasim Khan (OSS)
> -Original Message- > From: Ard Biesheuvel > Sent: Friday, May 22, 2020 3:06 PM > To: Wasim Khan (OSS) ; devel@edk2.groups.io; > Meenakshi Aggarwal ; Vabhav Sharma > ; Varun Sethi ; > l...@nuviainc.com; j...@solid-run.com > Cc: Wasim Khan > Subject: Re: [PATCH edk2-platforms 10/16] Sil

Re: [edk2-devel] [PATCH edk2-platforms 09/16] Silicon/NXP: Implement PciSegmentLib for PCIe Layerscape Controller

2020-05-24 Thread Wasim Khan (OSS)
> -Original Message- > From: Ard Biesheuvel > Sent: Friday, May 22, 2020 3:00 PM > To: Wasim Khan (OSS) ; devel@edk2.groups.io; > Meenakshi Aggarwal ; Vabhav Sharma > ; Varun Sethi ; > l...@nuviainc.com; j...@solid-run.com > Cc: Wasim Khan > Subject: Re: [PATCH edk2-platforms 09/16] Sil

Re: [edk2-devel] [PATCH edk2-platforms 11/16] Silicon/NXP: PciSegmentLib: Add support PCIe LsGen4 Controller

2020-05-24 Thread Wasim Khan (OSS)
> -Original Message- > From: Ard Biesheuvel > Sent: Friday, May 22, 2020 3:08 PM > To: Wasim Khan (OSS) ; devel@edk2.groups.io; > Meenakshi Aggarwal ; Vabhav Sharma > ; Varun Sethi ; > l...@nuviainc.com; j...@solid-run.com > Cc: Wasim Khan > Subject: Re: [PATCH edk2-platforms 11/16] Sil

Re: [edk2-devel] [PATCH edk2-platforms 01/16] Silicon/NXP/NxpQoriqLs.dec: Add PCIe related PCDs.

2020-05-24 Thread Wasim Khan (OSS)
> -Original Message- > From: Ard Biesheuvel > Sent: Friday, May 22, 2020 2:42 PM > To: Wasim Khan (OSS) ; devel@edk2.groups.io; > Meenakshi Aggarwal ; Vabhav Sharma > ; Varun Sethi ; > l...@nuviainc.com; j...@solid-run.com > Cc: Wasim Khan > Subject: Re: [PATCH edk2-platforms 01/16] Sil

Re: [edk2-devel] [PATCH edk2-platforms 00/16] Add PCIe Support

2020-05-24 Thread Wasim Khan (OSS)
> -Original Message- > From: Leif Lindholm > Sent: Friday, May 22, 2020 4:29 PM > To: Ard Biesheuvel > Cc: Wasim Khan (OSS) ; devel@edk2.groups.io; > Meenakshi Aggarwal ; Vabhav Sharma > ; Varun Sethi ; jon@solid- > run.com; Wasim Khan > Subject: Re: [PATCH edk2-platforms 00/16] Add P

Re: [edk2-devel] [PATCH edk2-platforms 12/16] Silicon/NXP: PciSegmentLib: LsGen4Ctrl: Add Workaround for A-011264

2020-05-24 Thread Wasim Khan (OSS)
> -Original Message- > From: Ard Biesheuvel > Sent: Friday, May 22, 2020 3:10 PM > To: Wasim Khan (OSS) ; devel@edk2.groups.io; > Meenakshi Aggarwal ; Vabhav Sharma > ; Varun Sethi ; > l...@nuviainc.com; j...@solid-run.com > Cc: Wasim Khan > Subject: Re: [PATCH edk2-platforms 12/16] Sil

Re: [edk2-devel] [PATCH edk2-platforms 05/16] Silicon/NXP: PciHostBridgeLib: Setup PCIe LsGen4 Controller and ATU Windows

2020-05-24 Thread Wasim Khan (OSS)
> -Original Message- > From: Ard Biesheuvel > Sent: Friday, May 22, 2020 2:55 PM > To: Wasim Khan (OSS) ; devel@edk2.groups.io; > Meenakshi Aggarwal ; Vabhav Sharma > ; Varun Sethi ; > l...@nuviainc.com; j...@solid-run.com > Cc: Wasim Khan > Subject: Re: [PATCH edk2-platforms 05/16] Sil

[edk2-devel] [PATCH 3/3] OvmfwPkg: Don't exclude XCODE Modules

2020-05-24 Thread Andrew Fish via groups.io
With this BZ getting fixed we no longer need to special case XCODE. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Philippe Mathieu-Daudé Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=557 Signed-off-by: Andrew Fish Signed-off-by: Andrew Fish --- OvmfPkg/OvmfPkgIa32.dsc|

[edk2-devel] [PATCH 2/3] BaseTools: Add PE/COFF resource sections support for XCODE

2020-05-24 Thread Andrew Fish via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=557 Build a nul lib in [Hii-Binary-Package.UEFI_HII] so the makefile dependencies are satisfied. Add --rc to Genfw in [Dynamic-Library-File] to inject the *hii.rc data if it exists. Signed-off-by: Andrew Fish Cc: Bob Feng Cc: Liming Gao Sign

[edk2-devel] [PATCH 0/3] Add PE/COFF resource sections support for XCODE

2020-05-24 Thread Andrew Fish via groups.io
This patch series adds PE/COFF resource section support for XCODE. It should be possible to use the build_rule.template and GenFw.c changes on any toolchain. RVCT also has this issue so could be fixed. I test this on XCODE on the inject an extra section, and append to last section path. Andr

[edk2-devel] [PATCH 1/3] BaseTools/GenFv: Add PE/COFF resource sections injection to GenFw

2020-05-24 Thread Andrew Fish via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=557 The XCODE toolchain does not suport injecting resource sections via libraries so add --rc to GenFw to inject $(MODULE_NAME)hii.rc into the final PE/COFF image. Since moving exiting code around would break source level debugging we must reuse

[edk2-devel] SbsaQemu: Initial support for static ACPI tables

2020-05-24 Thread Tanmay Jagdale
Add the following static ACPI tables for the SBSA Qemu platform - DSDT - FADT - GTDT - MADT - MCFG - SPCR Currently we support 4 CPUs. Co-authored-by: Graeme Gregory Co-authored-by: Jonathan Cameron Co-authored-by: Tanmay Jagdale Signed-off-by: Tanmay Jagdale --- Platform/Qemu/Sb

Re: [edk2-devel] [PATCH 1/1] CryptoPkg: Fix VS2017 build problem for ARM/AARCH64

2020-05-24 Thread Guomin Jiang
Add comment inline > -Original Message- > From: devel@edk2.groups.io On Behalf Of Rebecca > Cran > Sent: Thursday, May 21, 2020 4:26 AM > To: devel@edk2.groups.io > Cc: Rebecca Cran ; Wang, Jian J > ; Lu, XiaoyuX > Subject: [edk2-devel] [PATCH 1/1] CryptoPkg: Fix VS2017 build problem for

Re: [edk2-devel] [PATCH v2 2/3] MdeModulePkg/CapsuleRuntimeDxe: Add RISCV64 arch.

2020-05-24 Thread Guomin Jiang
The patch is good to me. Reviewed-by: Guomin Jiang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Abner > Chang > Sent: Sunday, April 26, 2020 10:40 PM > To: devel@edk2.groups.io > Cc: abner.ch...@hpe.com; Gilbert Chen ; Leif > Lindholm ; Wu, Hao A ; > Gao, Liming > Subj

[edk2-devel] [PATCH 0/1] BaseTools: Turn on LTO for XCOODE

2020-05-24 Thread Andrew Fish via groups.io
SEC/PEI/DXE/FVMAIN_COMPACT size savings in % 31/42/21/10 To turn off for good source level debugging add this to your INF. [BuildOptions] XCODE:*_*_*_CC_FLAGS = -O0 -fno-lto Andrew Fish (1): BaseTools: Turn on Link Time Optimization (LTO) for XCOODE BaseTools/Conf/tools_def.template | 16 +

[edk2-devel] [PATCH 1/1] BaseTools: Turn on Link Time Optimization (LTO) for XCOODE

2020-05-24 Thread Andrew Fish via groups.io
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1202 Turn on LTO for XCODE. We need to pass -object_path_lto to the linker to keep source level debugging working. OVMF X64 before: SECFV [14%Full] 212992 total, 30224 used, 182768 free PEIFV [29%Full] 917504 total, 273256 used, 644248 free DXE

[edk2-devel] OVMF gdb seems to require "stone knives and bearskins" to debug code?

2020-05-24 Thread Andrew Fish via groups.io
The full Star Trek quote from Spock is: " I am endeavoring, ma'am, to construct a mnemonic memory circuit using stone knives and bearskins.", but I ran across this [1], and it felt like "stone knives and bearskins." vs my experience with lldb debugging EFI. So a few questions: 1) Is this Wiki

Re: [EXTERNAL] [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process

2020-05-24 Thread Andrew Fish via groups.io
> On May 21, 2020, at 10:48 PM, Bret Barkelew > wrote: > > “But we do have tools that insert the Bugzilla number in all the commits of > the series, assist with the squash, etc.” > > Are these internal-only, or are they something we could evaluate when we move > to the PR process? If not, ar

Re: [edk2-devel] [PATCH edk2-platforms 09/16] Silicon/NXP: Implement PciSegmentLib for PCIe Layerscape Controller

2020-05-24 Thread Jon Nettleton
On Sun, May 24, 2020 at 8:32 PM Wasim Khan (OSS) wrote: > > > > > -Original Message- > > From: Ard Biesheuvel > > Sent: Friday, May 22, 2020 3:00 PM > > To: Wasim Khan (OSS) ; devel@edk2.groups.io; > > Meenakshi Aggarwal ; Vabhav Sharma > > ; Varun Sethi ; > > l...@nuviainc.com; j...@soli