> -----Original Message----- > From: Ard Biesheuvel <ard.biesheu...@arm.com> > Sent: Friday, May 22, 2020 2:42 PM > To: Wasim Khan (OSS) <wasim.k...@oss.nxp.com>; devel@edk2.groups.io; > Meenakshi Aggarwal <meenakshi.aggar...@nxp.com>; Vabhav Sharma > <vabhav.sha...@nxp.com>; Varun Sethi <v.se...@nxp.com>; > l...@nuviainc.com; j...@solid-run.com > Cc: Wasim Khan <wasim.k...@nxp.com> > Subject: Re: [PATCH edk2-platforms 01/16] Silicon/NXP/NxpQoriqLs.dec: Add > PCIe related PCDs. > > On 5/22/20 1:02 AM, Wasim Khan wrote: > > From: Wasim Khan <wasim.k...@nxp.com> > > > > Add PCIe related PCDs. > > > > Signed-off-by: Vabhav Sharma <vabhav.sha...@nxp.com> > > Please drop this signoff. This is not the correct way to acknowledge (co- > )authorship.
Co-authored-by: Vabhav Sharma <vabhav.sha...@nxp.com> Co-authored-by: Wasim Khan <wasim.k...@nxp.com> Signed-off-by: Wasim Khan <wasim.k...@nxp.com> Is this OK ? > > > Signed-off-by: Wasim Khan <wasim.k...@nxp.com> > > --- > > Silicon/NXP/NxpQoriqLs.dec | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/Silicon/NXP/NxpQoriqLs.dec b/Silicon/NXP/NxpQoriqLs.dec > > index 0722f59ef4f6..bafdfd9f4298 100644 > > --- a/Silicon/NXP/NxpQoriqLs.dec > > +++ b/Silicon/NXP/NxpQoriqLs.dec > > @@ -27,3 +27,12 @@ [Guids.common] > > [PcdsFeatureFlag] > > > gNxpQoriqLsTokenSpaceGuid.PcdI2cErratumA009203|FALSE|BOOLEAN|0x0000 > 0315 > > > > > gNxpQoriqLsTokenSpaceGuid.PcdDcfgBigEndian|FALSE|BOOLEAN|0x00000316 > > + > > + > gNxpQoriqLsTokenSpaceGuid.PcdPciLutBigEndian|FALSE|BOOLEAN|0x0000031 > > + 7 > > + > > +[PcdsFixedAtBuild.common] > > + # Pcds for PCI Express > > + > gNxpQoriqLsTokenSpaceGuid.PcdPciExp1BaseAddr|0x0|UINT64|0x00000500 > > + gNxpQoriqLsTokenSpaceGuid.PcdNumPciController|0|UINT32|0x00000501 > > + gNxpQoriqLsTokenSpaceGuid.PcdPcieLutBase|0x0|UINT32|0x00000502 > > + gNxpQoriqLsTokenSpaceGuid.PcdPcieLutDbg|0x0|UINT32|0x00000503 > > + gNxpQoriqLsTokenSpaceGuid.PcdPciDebug|FALSE|BOOLEAN|0x00000504 > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#60193): https://edk2.groups.io/g/devel/message/60193 Mute This Topic: https://groups.io/mt/74395372/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-