Python http.server seems to FIN after the first HEAD request to size
the loaded file is completed and ACKed. What happens next is interesting.
On low latency connections, the GET request to download may get sent
after the server sends the FIN but before the client has a chance to
process it. The ne
Lijian,
Yeah. I might learn the CMOS/RTC from the same page you shared when I create
the two PCDs and the accordingly logic.
Just guess as what the page says.
I double checked the existing code.
RtcTimeFieldsValid() contains logic to check all date/time value read from
RTC HW and PcRtcInit() re-i
Hi Michael,
On 5/9/20 4:22 AM, Michael Kubacki wrote:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2707
Ecc fails with Python 3.8 because it uses the deprecated time.clock()
function - https://docs.python.org/3.7/library/time.html#time.clock
This change updates Ec
+Michael & Laszlo.
On 5/13/20 4:15 AM, Bob Feng wrote:
Reviewed-by: Bob Feng
-Original Message-
From: michael.kuba...@outlook.com
Sent: Saturday, May 9, 2020 10:23 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming
Subject: [PATCH v1 1/1] BaseTools/Ecc: Replace deprecated func
Hi Pete,
On 2/4/19 1:47 PM, Pete Batard wrote:
This is designed to be used on platforms where a a real RTC is not
available and relies on an RtcEpochSeconds variable having been set or,
if that is not the case, falls back to using the epoch embedded at
compilation time.
Note that, in order to k
Reviewed-by: Liming Gao
> -Original Message-
> From: Oleksiy Yakovlev
> Sent: Thursday, May 14, 2020 6:40 AM
> To: devel@edk2.groups.io
> Cc: Gao, Liming ; Kinney, Michael D
> ; Wang, Jian J ; Wu,
> Hao A ; Yao, Jiewen ; Zhang, Chao B
> ; fel...@ami.com;
> oleks...@ami.com
> Subject: [
Hi Phil,
It has been a policy from Microsoft contributors to not include a year
in the copyright header you will find this in many other existing files
in edk2, I am simply aligning to that practice.
Bob is the maintainer and as maintainer he chose to submit the patch (it
has been on the lis
Kvmtool is a virtual machine manager that can be used to launch
guest partitions. Kvmtool additionally supports emulation of
hardware like the RTC, CFI etc. essentially providing an
emulated platform for a Guest OS to run.
To boot a standards-based OS one would need UEFI. In this case
it is UEFI a
On some platforms the Serial 16550 UART is interfaced
over PCI. To support such platforms the Serial 16550
driver links with PciLib.
For platforms that do not interface the Serial 16550
UART over PCI, the driver still needs to link with a
PciLib library. Linking to the full implementation of
the P
Some virtual machine managers like kvmtool can relocate
the devices in the system memory map. The information
about the devices location in memory is described in the
device tree. Therefore, the CFI memory region and the
associated Non volatile storage variables need to be
adjusted accordingly.
To
Some device drivers perform copy operations on
device memory, e.g. device drivers for a Flash
device. On some architectures unaligned access
to device memory regions is not permitted. To
add to this if the device is virtualised then
there are further restrictions on the type of
load/store operation
Some virtual machine managers like kvmtool emulate the MC146818
RTC controller in the MMIO space so that architectures that do
not support I/O Mapped I/O can use the RTC. This patch adds MMIO
support to the RTC controller driver.
The PCD PcdRtcUseMmio has been added to select I/O or MMIO support.
NorFlashDxe must use aligned MMIO accesses to
read data from flash as this is device memory.
The AlignedCopyMem() was used to copy the flash
data which prevented unaligned access to device
memory. However, the compiler could optimize the
code to generate pre/post indexed or LDP
operations. This is
Kvmtool is a virtual machine manager that enables
hosting KVM guests. It essentially provides an
emulated platform for guest operating systems.
Kvmtool hands of a device tree containing the
current hardware configuration to the firmware.
A standards-based operating system would use
ACPI to consum
Kvmtool is a virtual machine manager that can be used
to launch guest partitions. It additionally emulates
some hardware components e.g. RTC, CFI etc. essentially
providing an emulated virtual platform for a guest
operating system (OS) to run.
A standards-based OS would need UEFI firmware support
Kvmtool places the base address of the CFI flash in
the device tree it passes to UEFI. This library
parses the kvmtool device tree to read the CFI base
address and initialise the PCDs use by the NOR flash
driver and the variable storage.
Signed-off-by: Sami Mujawar
---
ArmVirtPkg/Library/NorFlas
NorFlashDxe must use aligned MMIO accesses to
read data from flash as this is device memory.
The AlignedCopyMem() in NorFlashDxe was used to
copy the flash data which prevented unaligned
access to device memory. However, the compiler
could optimize the code to generate pre/post
indexed or LDP oper
Kvmtool is a virtual machine manager that enables hosting
KVM guests. Kvmtool emulates certain devices like serial
port, RTC, etc. essentially providing an emulated platform.
This patch adds support for kvmtool emulated platform.
Following is a brief description of the firmware
implementation cho
Kvmtool is a virtual machine manager that enables
hosting KVM guests. Kvmtool allows to vary the
hardware configuration of the emulated platform
it provides to the guest partition. It provides
the current hardware configuration to the firmware
by handing off a device tree containing the hardware
in
On 5/14/20 10:18 AM, Michael Kubacki wrote:
Hi Phil,
It has been a policy from Microsoft contributors to not include a year
in the copyright header you will find this in many other existing files
in edk2, I am simply aligning to that practice.
If you want an aligned codebase, we should first
NorFlashDxe must use aligned MMIO accesses to
read data from flash as this is device memory.
The AlignedCopyMem() in NorFlashDxe was used to
copy the flash data which prevented unaligned
access to device memory. However, the compiler
could optimize the code to generate pre/post
indexed or LDP oper
NorFlashDxe must use aligned MMIO accesses to
read data from flash as this is device memory.
The AlignedCopyMem() in NorFlashDxe was used to
copy the flash data which prevented unaligned
access to device memory. However, the compiler
could optimize the code to generate pre/post
indexed or LDP oper
NorFlashDxe must use aligned MMIO accesses to
read data from flash as this is device memory.
The AlignedCopyMem() in NorFlashDxe was used to
copy the flash data which prevented unaligned
access to device memory. However, the compiler
could optimize the code to generate pre/post
indexed or LDP oper
-Original Message-
From: devel@edk2.groups.io On Behalf Of Philippe
Mathieu-Daudé
Sent: Thursday, May 14, 2020 4:45 PM
To: Michael Kubacki ; devel@edk2.groups.io; Feng,
Bob C
Cc: Gao, Liming ; Kinney, Michael D
; Laszlo Ersek
Subject: Re: [edk2-devel] [PATCH v1 1/1] BaseTools/Ecc: R
Hi Sami,
On 5/14/20 10:40 AM, Sami Mujawar wrote:
Some device drivers perform copy operations on
device memory, e.g. device drivers for a Flash
device. On some architectures unaligned access
to device memory regions is not permitted. To
add to this if the device is virtualised then
there are fur
On 5/14/20 10:40 AM, Sami Mujawar wrote:
On some platforms the Serial 16550 UART is interfaced
over PCI. To support such platforms the Serial 16550
driver links with PciLib.
For platforms that do not interface the Serial 16550
UART over PCI, the driver still needs to link with a
PciLib library.
On 5/14/20 10:40 AM, Sami Mujawar wrote:
Some virtual machine managers like kvmtool emulate the MC146818
RTC controller in the MMIO space so that architectures that do
not support I/O Mapped I/O can use the RTC. This patch adds MMIO
support to the RTC controller driver.
The PCD PcdRtcUseMmio has
On 5/14/20 10:40 AM, Sami Mujawar wrote:
Some virtual machine managers like kvmtool can relocate
the devices in the system memory map. The information
about the devices location in memory is described in the
device tree. Therefore, the CFI memory region and the
associated Non volatile storage var
CC: Andrew Fish
CC: Ard Biesheuvel
CC: Bret Barkelew
CC: Brian J. Johnson
CC: Chasel Chiu
CC: Jordan Justen
CC: Laszlo Ersek
CC: Leif Lindholm
CC: Liming Gao
CC: Marvin Häuser
CC: Mike Kinney
CC: Vincent Zimmer
CC: Zhichao Gao
Current implementation of SafeString does not let one pars
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054
Runtime checks returned via status return code should not work as
assertions to permit parsing not trusted data with SafeString
interfaces.
CC: Andrew Fish
CC: Ard Biesheuvel
CC: Bret Barkelew
CC: Brian J. Johnson
CC: Chasel C
Retire below deprecated functions:
MD4, ARC4, TDES, AES ECB MODE, HMAC MD5, HMAC SHA1.
V2:
Seprate the MD5 and SHA1 changes to other patch set.
Change the deprecated function wrapper implementatuion in
EDKII_CRYPTO_PROTOCOL to call a dummy function to print debug
message and assert.
V3:
Remove th
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898
TDES is not secure any longer.
Remove the Tdes support from edk2.
Change the Tdes field name in EDKII_CRYPTO_PROTOCOL to indicate the
function is unsupported any longer.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Siyuan Fu
Cc: Michael D Kinney
C
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898
Aes Ecb mode is not secure any longer.
Remove the Aes Ecb mode support from edk2.
Change the Aes Ecb mode field name in EDKII_CRYPTO_PROTOCOL to indicate the
function is unsupported any longer.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Siyuan Fu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898
This patch is create by adding the setting "no_des" of
process_files.pl and running it thru perl.
It would remove the TDES from OpensslLib.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Siyuan Fu
Cc: Michael D Kinney
Cc: Jiewen Yao
Cc: Philippe Ma
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898
HMAC MD5 is not secure any longer.
Remove the HMAC MD5 support from edk2.
Change the HMAC MD5 field name in EDKII_CRYPTO_PROTOCOL to indicate the
function is unsupported any longer.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Siyuan Fu
Cc: Michael
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898
Add the unrequired aes_ecb files in process_files.pl and run it
thru perl.
It would remove the unrequired aes_ecb files from OpensslLib inf.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Siyuan Fu
Cc: Michael D Kinney
Cc: Jiewen Yao
Cc: Philippe M
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898
This patch is create by adding the setting "no_md4" of
process_files.pl and running it thru perl.
It would remove the MD4 from OpensslLib.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Siyuan Fu
Cc: Michael D Kinney
Cc: Jiewen Yao
Cc: Philippe Mat
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898
Add a internal worker function to indicate the deprecated functions.
It would print out debug messages and asserts to inform the consumer
they are using a deprecated function.
Change the Name of BaseCryptLibServciceNotEnabled to correct spel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898
The binary is totally changed, so update the Crypto Version to 7:
1. Retire below deprecated function:
MD4, ARC4, TDES, AES ECB MODE, HMAC MD5, HMAC SHA1
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Siyuan Fu
Cc: Michael D Kinney
Cc: Jiewen Yao
C
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898
HMAC SHA1 is not secure any longer.
Remove the HMAC SHA1 support from edk2.
Change the HMAC SHA1 field name in EDKII_CRYPTO_PROTOCOL to indicate the
function is unsupported any longer.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Siyuan Fu
Cc: Mich
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898
ARC4 is not secure any longer.
Remove the ARC4 support from edk2.
Change the ARC4 field name in EDKII_CRYPTO_PROTOCOL to indicate the
function is unsupported any longer.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Siyuan Fu
Cc: Michael D Kinney
C
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898
This patch is create by adding the setting "no_rc4" of
process_files.pl and running it thru perl.
It would remove the ARC4 from OpensslLib.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Siyuan Fu
Cc: Michael D Kinney
Cc: Jiewen Yao
Cc: Philippe Ma
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1898
MD4 is not secure any longer.
Remove the MD4 support from edk2.
Change the MD4 field name in EDKII_CRYPTO_PROTOCOL to indicate the
function is unsupported any longer.
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Siyuan Fu
Cc: Michael D Kinney
Cc:
On 5/14/20 10:40 AM, Sami Mujawar wrote:
Kvmtool is a virtual machine manager that enables
hosting KVM guests. Kvmtool allows to vary the
hardware configuration of the emulated platform
it provides to the guest partition. It provides
the current hardware configuration to the firmware
by handing o
On 5/14/20 10:40 AM, Sami Mujawar wrote:
Kvmtool is a virtual machine manager that enables
hosting KVM guests. It essentially provides an
emulated platform for guest operating systems.
Kvmtool hands of a device tree containing the
current hardware configuration to the firmware.
A standards-base
On 5/14/20 10:40 AM, Sami Mujawar wrote:
Kvmtool places the base address of the CFI flash in
the device tree it passes to UEFI. This library
parses the kvmtool device tree to read the CFI base
address and initialise the PCDs use by the NOR flash
driver and the variable storage.
Signed-off-by: Sa
On 5/14/20 10:40 AM, Sami Mujawar wrote:
Kvmtool is a virtual machine manager that enables hosting
KVM guests. Kvmtool emulates certain devices like serial
port, RTC, etc. essentially providing an emulated platform.
This patch adds support for kvmtool emulated platform.
Please use accurate te
On 05/14/20 00:11, Ard Biesheuvel wrote:
> Supreeth Venkatesh no longer works for ARM, and left before we had
> the chance of finding a successor. Edhaya is willing to take over SCT
> maintainership so let's make it official.
>
> Cc: Eric Jin
> Cc: G Edhaya Chandran
> Cc: Andrew Fish
> Cc: Lasz
On Thu, May 14, 2020 at 00:11:42 +0200, Ard Biesheuvel wrote:
> Supreeth Venkatesh no longer works for ARM, and left before we had
> the chance of finding a successor. Edhaya is willing to take over SCT
> maintainership so let's make it official.
>
> Cc: Eric Jin
> Cc: G Edhaya Chandran
> Cc: An
On 05/14/20 04:34, Rebecca Cran wrote:
> (cc Peter Grehan)
>
> On 5/12/20 3:28 AM, Laszlo Ersek wrote:
>
>>
>> If the bhyve community can *permanently* provide reviews /
>> regression-testing for such OVMF contributors that never use bhyve, that
>> would significantly increase the stability of bh
On 5/14/20 11:25 AM, Vitaly Cheptsov via groups.io wrote:
CC: Andrew Fish
CC: Ard Biesheuvel
CC: Bret Barkelew
CC: Brian J. Johnson
CC: Chasel Chiu
CC: Jordan Justen
CC: Laszlo Ersek
CC: Leif Lindholm
CC: Liming Gao
CC: Marvin Häuser
CC: Mike Kinney
CC: Vincent Zimmer
CC: Zhichao Gao
On 05/14/20 11:29, Ard Biesheuvel wrote:
> On 5/14/20 10:40 AM, Sami Mujawar wrote:
>> Kvmtool is a virtual machine manager that enables
>> hosting KVM guests. It essentially provides an
>> emulated platform for guest operating systems.
>>
>> Kvmtool hands of a device tree containing the
>> current
On 05/14/20 10:40, Sami Mujawar wrote:
> Kvmtool is a virtual machine manager that enables
> hosting KVM guests. Kvmtool allows to vary the
> hardware configuration of the emulated platform
> it provides to the guest partition. It provides
> the current hardware configuration to the firmware
> by h
On 5/14/20 2:12 PM, Laszlo Ersek wrote:
On 05/14/20 11:29, Ard Biesheuvel wrote:
On 5/14/20 10:40 AM, Sami Mujawar wrote:
Kvmtool is a virtual machine manager that enables
hosting KVM guests. It essentially provides an
emulated platform for guest operating systems.
Kvmtool hands of a device tr
On 05/14/20 11:32, Ard Biesheuvel wrote:
> On 5/14/20 10:40 AM, Sami Mujawar wrote:
>> Kvmtool places the base address of the CFI flash in
>> the device tree it passes to UEFI. This library
>> parses the kvmtool device tree to read the CFI base
>> address and initialise the PCDs use by the NOR flas
On 05/14/20 14:12, Laszlo Ersek wrote:
> On 05/14/20 11:29, Ard Biesheuvel wrote:
>> On 5/14/20 10:40 AM, Sami Mujawar wrote:
>>> Kvmtool is a virtual machine manager that enables
>>> hosting KVM guests. It essentially provides an
>>> emulated platform for guest operating systems.
>>>
>>> Kvmtool h
On 05/14/20 10:40, Sami Mujawar wrote:
> Kvmtool is a virtual machine manager that enables hosting
> KVM guests. Kvmtool emulates certain devices like serial
> port, RTC, etc. essentially providing an emulated platform.
>
> This patch adds support for kvmtool emulated platform.
>
> Following is a
On 05/14/20 10:40, Sami Mujawar wrote:
> NorFlashDxe must use aligned MMIO accesses to
> read data from flash as this is device memory.
>
> The AlignedCopyMem() in NorFlashDxe was used to
> copy the flash data which prevented unaligned
> access to device memory. However, the compiler
> could optim
On 05/14/20 10:40, Sami Mujawar wrote:
> Kvmtool is a virtual machine manager that can be used
> to launch guest partitions. It additionally emulates
> some hardware components e.g. RTC, CFI etc. essentially
> providing an emulated virtual platform for a guest
> operating system (OS) to run.
>
> A
Thanks Nate! I have resolved below issues and pushed:
f2cdb268ef04eeec51948b5d81eeca5cab5ed9af
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Thursday, May 14, 2020 1:06 PM
> To: devel@edk2.groups.io; Chiu, Chasel
> Cc: Ma, Maurice ; Zeng, Star
> Subject: RE: [edk2-devel]
Tom,
I just discussed with original CPU owner Jeff and went through how IDT is setup
in the boot flow.
Here is what I think you can do to avoid modifying the CpuExceptionHandlerLib.
1. SecPlatformMain() modifies IDT[29] to point to your VC handler. This step
helps to build the VC handler in whole
Hi Phil,
Not sure why this old 2019 patch suddenly appeared in your review inbox,
but this was integrated last year as
https://github.com/tianocore/edk2/commit/64a17fadcb79e2ce40524abb88a6863f47cbc0c7
Regards,
/Pete
On 2020.05.14 08:45, Philippe Mathieu-Daudé wrote:
Hi Pete,
On 2/4/19 1:4
> -Original Message-
> From: Leif Lindholm
> Sent: Tuesday, May 12, 2020 7:15 AM
> To: Ard Biesheuvel
> Cc: Samer El-Haj-Mahmoud ;
> devel@edk2.groups.io; Ray Ni ; Michael D Kinney
>
> Subject: Re: [edk2-platform][PATCH v1 0/4] Update ASIX USB Networking
> drivers
>
> On Mon, May 11,
On 05/14/20 11:25, Vitaly Cheptsov wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054
>
> Runtime checks returned via status return code should not work as
> assertions to permit parsing not trusted data with SafeString
> interfaces.
>
> CC: Andrew Fish
> CC: Ard Biesheuvel
> CC:
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Groups.io Inc//Groups.io Calendar//EN
METHOD:CANCELLED
CALSCALE:GREGORIAN
BEGIN:VEVENT
UID:g7lq.1578029159272351097.u...@groups.io
DTSTAMP:20200514T133840Z
ORGANIZER;CN=Ray Ni:mailto:ray...@intel.com
DTSTART:20200515T013000Z
DTEND:20200515T023000Z
SUMMARY:Tiano
On Wed, May 13, 2020 at 12:23:33PM +0200, Laszlo Ersek wrote:
> On 05/12/20 22:58, Roman Bolshakov wrote:
> > OVMF booting stops with the assert if built with Xcode on macOS:
> >
> > Loading driver at 0x0001FAB8000 EntryPoint=0x0001FABF249
> > LinuxInitrdDynamicShellCommand.efi
> > InstallPro
Hi Ray,
I read your comment from gitk.
I understand why you changed them to 1998 and 2097.
May I know why we don't read the Century value from CMOS in the beginning?
Some boards does not support? Or the RTC address may be different for
different boards?
Regards
Kai Yau
-Original Messa
Hi,
The current logic has two limitations:
1. it has to be 100 years apart (already mentioned in DEC file)
2. the century numbers have to be same in order to work. (19XX, 20XX will not
work) (20xx, 21xx will not work)
Since now is 2020, the value has to be 2000, 2099. But BIOS developers does no
There was a mistake in all previous v here.
I took it from original ECR and misted correction.
Now it is up to spec.
Regards, Oleksiy.
-Original Message-
From: Jiang, Guomin [mailto:guomin.ji...@intel.com]
Sent: Wednesday, May 13, 2020 11:43 PM
To: devel@edk2.groups.io; Oleksiy Yakovlev
C
OVMF booting stops with the assert if built with Xcode on macOS:
Loading driver at 0x0001FAB8000 EntryPoint=0x0001FABF249
LinuxInitrdDynamicShellCommand.efi
InstallProtocolInterface: BC62157E-3E33-4FEC-9920-2D3B36D750DF 1F218398
ProtectUefiImageCommon - 0x1F218140
- 0x1FAB8000 -
> -Original Message-
> From: Leif Lindholm
> Sent: Tuesday, May 12, 2020 9:03 AM
> To: Samer El-Haj-Mahmoud
> Cc: devel@edk2.groups.io; Ray Ni ; Ard Biesheuvel
> ; Michael D Kinney
>
> Subject: Re: [edk2-platform][PATCH v1 3/4] Silicon/AsixPkg: Add ASIX
> Ax88179 driver
>
> On Sun, May
Leif,
Thanks for the review. Most of these are cosmetic changes that I will take care
of in v2. There are a couple that may require some experiments to figure out
what works and what breaks.
> -Original Message-
> From: Leif Lindholm
> Sent: Tuesday, May 12, 2020 9:23 AM
> To: Samer
Any consensus on this? I can just rename AsixPkg.dsc/fdf to Asix.dsc/fdf (with
a matching PLATFORM_NAME ) if that is more consistent
> -Original Message-
> From: Ni, Ray
> Sent: Monday, May 11, 2020 1:18 AM
> To: Samer El-Haj-Mahmoud ;
> devel@edk2.groups.io; Kinney, Michael D
> Cc: Le
On 05/14/20 14:17, Ard Biesheuvel wrote:
> On 5/14/20 2:12 PM, Laszlo Ersek wrote:
>> On 05/14/20 11:29, Ard Biesheuvel wrote:
>>> On 5/14/20 10:40 AM, Sami Mujawar wrote:
Kvmtool is a virtual machine manager that enables
hosting KVM guests. It essentially provides an
emulated platfo
> On May 14, 2020, at 4:24 AM, Laszlo Ersek wrote:
>
> - The community not having any human resources permanently dedicated to
> bhyve regressions (testing, review, and post factum fixing) is fine, as
> long as the bhyve stakeholders can live with a matching frequency of
> regressions.
Yes, I
Sami,
Can the combination of BasePciLibPciExpress and BasePciExpressLib
be used for this use case?
Mike
> -Original Message-
> From: Sami Mujawar
> Sent: Thursday, May 14, 2020 1:40 AM
> To: devel@edk2.groups.io
> Cc: Sami Mujawar ;
> ard.biesheu...@arm.com; l...@nuviainc.com; Kinney,
>
Sami,
This does not seem right to me.
BaseMemoryLib is for memory operations.
IoLib for I/O port and MMIO operations.
The IoLib already supports aligned buffer read/write
APIs for MMIO. Why can’t the exiting IoLib APIs be
used for this use case.
MmioReadBuffer8()
MmioReadBuffer16()
Mmio
Why preserve the ASSERT()s for an a Unicode strings
that are not aligned in a 16-bit boundary?
This is essentially the same as an invalid pointer value
just like NULL. If NULL pointer returns an error code,
shouldn't and invalid pointer value?
Thanks,
Mike
> -Original Message-
> From:
You don't need do more. I will help merge this patch set.
> -Original Message-
> From: Robert Phelps
> Sent: Friday, May 15, 2020 12:36 AM
> To: Gao, Liming ; devel@edk2.groups.io; Oleksiy
> Yakovlev
> Cc: Kinney, Michael D ; Felix Polyudov
>
> Subject: RE: [edk2-devel] [PATCH v2 0/5
On 05/14/20 15:48, Roman Bolshakov wrote:
> OVMF booting stops with the assert if built with Xcode on macOS:
>
> Loading driver at 0x0001FAB8000 EntryPoint=0x0001FABF249
> LinuxInitrdDynamicShellCommand.efi
> InstallProtocolInterface: BC62157E-3E33-4FEC-9920-2D3B36D750DF 1F218398
> ProtectUe
On 5/14/20 11:22 AM, Ard Biesheuvel wrote:
Hi Sami,
On 5/14/20 10:40 AM, Sami Mujawar wrote:
Some device drivers perform copy operations on
device memory, e.g. device drivers for a Flash
device. On some architectures unaligned access
to device memory regions is not permitted. To
add to this if
On 5/14/20 6:05 PM, Laszlo Ersek wrote:
On 05/14/20 14:17, Ard Biesheuvel wrote:
On 5/14/20 2:12 PM, Laszlo Ersek wrote:
On 05/14/20 11:29, Ard Biesheuvel wrote:
On 5/14/20 10:40 AM, Sami Mujawar wrote:
Kvmtool is a virtual machine manager that enables
hosting KVM guests. It essentially provi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054
Runtime checks returned via status return code should not work as
assertions to permit parsing not trusted data with SafeString
interfaces.
CC: Andrew Fish
CC: Ard Biesheuvel
CC: Bret Barkelew
CC: Brian J. Johnson
CC: Chasel Chiu
CC: J
CC: Andrew Fish
CC: Ard Biesheuvel
CC: Bret Barkelew
CC: Brian J. Johnson
CC: Chasel Chiu
CC: Jordan Justen
CC: Laszlo Ersek
CC: Leif Lindholm
CC: Liming Gao
CC: Marvin Häuser
CC: Mike Kinney
CC: Vincent Zimmer
CC: Zhichao Gao
V7 addressed review comments (only documentation changes).
Mike,
Firstly, NULL check and odd-address checks are essentially different things:
— NULL address is basically «no object», «optional argument» (e.g. failed
allocation).
— Odd address is memory corruption, as there is no way to craft such address
anyhow else.
For this reason the implementation i
I really don't agree with this direction.
Adding another platform to a core repository that might or might not
work at any given time is a burden to all core contributors and doesn't
bring value to the core project.
The direction I would like to see is a new repo created at
github.com/tianoc
Vitaly,
Why do you think there is no way to craft an odd address
without memory corruption.
UINT8 ByteArray[100];
CHAR16 *String
String = (CHAR16 *)(&Array[3]);
The reason I raised the question of these other ASSERT()s
is that I thought the use case was using these safe string
APIs from a U
On 5/14/20 8:10 AM, Ni, Ray wrote:
> Tom,
Hi Ray,
> I just discussed with original CPU owner Jeff and went through how IDT is
> setup in the boot flow.
> Here is what I think you can do to avoid modifying the CpuExceptionHandlerLib.
> 1. SecPlatformMain() modifies IDT[29] to point to your VC han
On 5/14/20 11:48 AM, Sean Brogan wrote:
Adding another platform to a core repository that might or might not
work at any given time is a burden to all core contributors and
doesn't bring value to the core project.
The direction I would like to see is a new repo created at
github.com/tianocor
Rebecca,
I think hosting open platforms outside the tianocore org is great too.
This gives the maintainers even more freedom to run their own project
and this scenario is actually how nearly all edk2 consumers do it.
Today, edk2 just doesn't have the infrastructure to allow them to report
bac
> On May 14, 2020, at 12:47 PM, Sean wrote:.
>
> Is there interest in setting it up to "consume" edk2 as is rather than be a
> fork?
I’m not sure if we’ll switch to having edk2 be a submodule, but I intend to
keep master be the same as upstream master, and regularly integrate changes
into
Mike,
The code you posted may inflict undefined behaviour is not valid C for several
reasons. The compiler is free to do whatever it desires. Please refer to
ISO/IEC 9899 for more details.
If applications cast raw pointers to typed pointers without checking their
alignment, well, god bless the
On 5/14/20 8:59 PM, Vitaly Cheptsov via groups.io wrote:
Mike,
The code you posted may inflict undefined behaviour is not valid C for
several reasons. The compiler is free to do whatever it desires. Please
refer to ISO/IEC 9899 for more details.
If applications cast raw pointers to typed poi
Add bitmask to structure which gives a binary-inspectable mechanism to
determine if a capsule contains an authentication section or depex section.
(UEFI 2.8 errata a, mantis 2026)
Signed-off-by: Oleksiy Yakovlev
Reviewed-by: Wei6 Xu
---
MdeModulePkg/Application/CapsuleApp/CapsuleDump.c | 7 +
Following patches add/update structures/definitions, that were
introduced/modified by UEFI Spec v.2.8 errata a from Feb 14.
Oleksiy Yakovlev (6):
MdePkg: Add new CPER Notification types
MdePkg: Fix OUT parameters marked as IN OUT
MdePkg: Add EFI_RT_PROPERTIES_TABLE
MdePkg: Add FMP Capsule
Add SEA, SEI, and PEI CPER Notification types defined in UEFI 2.8 errata a.
(UEFI 2.8 errata a, mantis 2026)
Signed-off-by: Oleksiy Yakovlev
Reviewed-by: Liming Gao
---
MdePkg/Include/Guid/Cper.h | 15 +++
MdePkg/MdePkg.dec | 9 +
2 files changed, 24 insertions(+)
Add bitmask to structure which gives a binary-inspectable mechanism to
determine if a capsule contains an authentication section or depex section.
(UEFI 2.8 errata a, mantis 2026)
Signed-off-by: Oleksiy Yakovlev
Reviewed-by: Wei6 Xu
Reviewed-by: Chao Zhang
---
.../RecoveryModuleLoadPei/Recove
Add bitmask to structure which gives a binary-inspectable mechanism to
determine if a capsule contains an authentication section or depex section.
(UEFI 2.8 errata a, mantis 2026)
Signed-off-by: Oleksiy Yakovlev
Reviewed-by: Liming Gao
---
MdePkg/Include/Guid/FmpCapsule.h | 11 ++-
1 f
Define Guid & data structure for EFI_RT_PROPERTIES_TABLE, designed
to be published by a platform if it no longer supports all EFI
runtime services once ExitBootServices() has been called by the OS.
(UEFI 2.8 errata a, mantis 2049)
Signed-off-by: Oleksiy Yakovlev
Reviewed-by: Liming Gao
---
Mde
Some OUT parameters in the specification were mistakenly marked as IN OUT.
"IN OUT" replaced with "OUT" in the following interfaces
EFI_BOOT_SERVICES.GetMemoryMap():MemoryMap
EFI_BOOT_SERVICES.LocateHandleBuffer():NoHandles
EFI_SIMPLE_POINTER_PROTOCOL.GetState():State
EFI_ABSOLUTE_POINTER_PROTOCOL
1 - 100 of 151 matches
Mail list logo