Re: [edk2-devel] [PATCH 1/2] MdeModulePkg: Add a pcd to set the OS indications bit

2019-06-03 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Gao, Zhichao > Sent: Monday, June 3, 2019 2:44 PM > To: devel@edk2.groups.io > Cc: Bret Barkelew ; Wang, Jian J > ; Wu, Hao A ; Ni, Ray > ; Zeng, Star ; Gao, Liming > ; Sean Brogan ; > Michael Turner > Subject: [PATCH 1/2] MdeModulePkg: A

Re: [edk2-devel] [PATCH 2/2] MdeModulePkg/BdsDxe: Use a pcd to control PlatformRecovery

2019-06-03 Thread Gao, Zhichao
> -Original Message- > From: Ni, Ray > Sent: Monday, June 3, 2019 2:59 PM > To: Gao, Zhichao ; devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Zeng, Star ; Gao, Liming ; > Sean Brogan ; Michael Turner > ; Bret Barkelew > > Subject: RE: [PATCH 2/2] MdeModulePkg/BdsDxe: Use a pcd

Re: [edk2-devel] [PATCH 2/2] MdeModulePkg/BdsDxe: Use a pcd to control PlatformRecovery

2019-06-03 Thread Ni, Ray
> -Original Message- > From: Gao, Zhichao > Sent: Monday, June 3, 2019 3:13 PM > To: Ni, Ray ; devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Zeng, Star ; Gao, Liming ; > Sean Brogan ; Michael Turner > ; Bret Barkelew > > Subject: RE: [PATCH 2/2] MdeModulePkg/BdsDxe: Use a pcd

Re: [edk2-devel] [PATCH 2/2] MdeModulePkg/BdsDxe: Use a pcd to control PlatformRecovery

2019-06-03 Thread Gao, Zhichao
> -Original Message- > From: Ni, Ray > Sent: Monday, June 3, 2019 3:27 PM > To: Gao, Zhichao ; devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Zeng, Star ; Gao, Liming ; > Sean Brogan ; Michael Turner > ; Bret Barkelew > > Subject: RE: [PATCH 2/2] MdeModulePkg/BdsDxe: Use a pcd

Re: [edk2-devel] [PATCH] MdeModulePkg/CapsulePei: Optimize the CapsulePei

2019-06-03 Thread Gao, Zhichao
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Leif Lindholm > Sent: Saturday, June 1, 2019 12:44 AM > To: devel@edk2.groups.io; Gao, Zhichao > Cc: Bret Barkelew ; Wang, Jian J > ; Wu, Hao A ; Ni, Ray > ; Zeng, Star ; Gao, Liming > ; Sean

Re: [edk2-devel] [PATCH v2 00/10] Duplicate required CSM components for OVMF

2019-06-03 Thread Laszlo Ersek
On 05/29/19 03:12, Wu, Hao A wrote: > Also, do you expect such BZ dependencies setup should be done by the > submitters (if they are aware of such dependencies) when they files a BZ > tracker? It's best to capture the BZ dependencies as soon as someone realizes that such dependencies exist. If th

[edk2-devel] [PATCH v1 1/1] CryptoPkg: Fix build problem with XCODE

2019-06-03 Thread Xiaoyu Lu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 When building CryptoPkg with XCODE, blow error may result * usr/lib/clang/9.0.0/include/stdatomic.h:105:17: error: unknown type name 'wchar_t' Since the C native atomics are C11 feature we can explicitly use C99 to work around it. add -std

Re: [edk2-devel] [PATCH] MdeModulePkg/CapsulePei: Optimize the CapsulePei

2019-06-03 Thread Leif Lindholm
On Mon, Jun 03, 2019 at 08:18:03AM +, Gao, Zhichao wrote: > > > > -Original Message- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Leif Lindholm > > Sent: Saturday, June 1, 2019 12:44 AM > > To: devel@edk2.groups.io; Gao, Zhichao > > Cc: Bret Barkelew

Re: [edk2-devel] [PATCH 0/4] Define SERIAL_DXE_FILE_GUID only once

2019-06-03 Thread Anthony PERARD
On Sat, Jun 01, 2019 at 05:00:37PM +, Kinney, Michael D wrote: > I am curious. I agree that a GUID can be defined in DEC file and > in an include file that is used as a Vendor GUID in a device path. > > Is there any reason that the FILE_GUID for the module needs to be > the same GUID value?

Re: [edk2-devel] [PATCH v1 1/1] DynamicTablesPkg: Add ACPI 6.3 SPE support to MADT generator

2019-06-03 Thread Alexei . Fedorov
Reviewed-by: Alexei Fedorov alexei.fedo...@arm.com -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41807): https://edk2.groups.io/g/devel/message/41807 Mute This Topic: https://groups.io/mt/31641494/21656 Group Owner: devel+ow...@edk2.grou

Re: [edk2-devel] [PATCH v1 0/3] Detect duplicate field values in ACPI tables

2019-06-03 Thread Alexei . Fedorov
Reviewed-by: Alexei Fedorov alexei.fedo...@arm.com ( alexei.fedo...@arm.com ) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41808): https://edk2.groups.io/g/devel/message/41808 Mute This Topic: https://groups.io/mt/31639036/21656 Group O

Re: [edk2-devel] [PATCH v1 1/1] DynamicTablesPkg: Add dynamic PPTT table generation support

2019-06-03 Thread Alexei . Fedorov
Reviewed-by: Alexei Fedorov alexei.fedo...@arm.com ( alexei.fedo...@arm.com ) -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41809): https://edk2.groups.io/g/devel/message/41809 Mute This Topic: https://groups.io/mt/31743739/21656 Group O

Re: [edk2-devel] [PATCH for-edk2-stable201905 6/6] OvmfPkg/PlatformPei: set 32-bit UC area at PciBase / PciExBarBase (pc/q35)

2019-06-03 Thread Philippe Mathieu-Daudé
On 5/29/19 5:12 PM, Laszlo Ersek wrote: > (This is a replacement for commit 39b9a5ffe661 ("OvmfPkg/PlatformPei: fix > MTRR for low-RAM sizes that have many bits clear", 2019-05-16).) > > Reintroduce the same logic as seen in commit 39b9a5ffe661 for the pc > (i440fx) board type. > > For q35, the s

Re: [edk2-devel] [PATCH v5 0/9] Crypto: Upgrade OpenSSL to 1.1.1b

2019-06-03 Thread Laszlo Ersek
On 06/03/19 02:48, Wang, Jian J wrote: > Pushed > 6fcc3d68eb02aa798ef572c94867a03d0c1fedf2...acfb90911840c38a0beb9bcfe0065668244d2b4d Thank you all. The proper commit range to mention here is: 371e7001e8d5..acfb90911840. (371e7001e8d5 is the parent of 6fcc3d68eb02.) Because, the LHS of such a

Re: [edk2-devel] [PATCH 0/4] Define SERIAL_DXE_FILE_GUID only once

2019-06-03 Thread Laszlo Ersek
On 06/01/19 19:00, Kinney, Michael D wrote: > Anthony, > > I am curious. I agree that a GUID can be defined in DEC file and > in an include file that is used as a Vendor GUID in a device path. > > Is there any reason that the FILE_GUID for the module needs to be > the same GUID value? Is there

Re: [edk2-devel] [PATCH 0/2] Fix GP fault issue and enhance code about ProcTrace

2019-06-03 Thread Laszlo Ersek
Hi Star, On 06/01/19 10:08, Star Zeng wrote: > This patch series mainly fixes GP fault issue about ProcTrace for > https://bugzilla.tianocore.org/show_bug.cgi?id=1808. > It aslo enhances code about ProcTrace for > https://bugzilla.tianocore.org/show_bug.cgi?id=1809. > > Please check the individua

Re: [edk2-devel] Hard Feature Freeze starts now for edk2-stable201905

2019-06-03 Thread Laszlo Ersek
Hi, On 06/03/19 06:02, Gao, Liming wrote: > Hi, all > Openssl1.1.1 update has been resolved. So, we enter into Hard Feature > Freeze phase until edk2-stable201905 tag is created at 2019-06-06. In this > phase, there is no feature to be pushed. The bug fix is still allowed. Below > is the upda

[edk2-devel] [PATCH 1/1] FmpDevicePkg: Add TimerLib to DSC file

2019-06-03 Thread Xiaoyu Lu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1089 FmpDevicePkg use OpensslLib and when OpenSSL upgrade to 1.1.1b, TimerLib is required by OpensslLib in CryptoPkg(commit 456dd8b99f, CryptoPkg: Upgrade OpenSSL to 1.1.1b) So add TimerLib to DSC file. Cc: Liming Gao Cc: Michael D Kinney Sig

Re: [edk2-devel] Hard Feature Freeze starts now for edk2-stable201905

2019-06-03 Thread Liming Gao
Laszlo: I agree this is a real functional bug fix. I am OK to add it for edk2-stable201905. Thanks Liming > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Laszlo > Ersek > Sent: Monday, June 3, 2019 8:29 PM > To: Gao, Liming ; devel@edk2.grou

Re: [edk2-devel] [RFC PATCH 1/2] BaseTools: add centralized location for git config files

2019-06-03 Thread Laszlo Ersek
On 05/30/19 17:59, Leif Lindholm wrote: > Before adding the git environment initialization script, add the > following files that will be pointed to after running said script: > > - BaseTools/Conf/diff.order > - BaseTools/Conf/gitattributes > > Signed-off-by: Leif Lindholm > --- > BaseTools/Con

Re: [edk2-devel] [RFC PATCH 2/2] BaseTools: add script to configure local git options

2019-06-03 Thread Laszlo Ersek
On 05/30/19 17:59, Leif Lindholm wrote: > Patch contribution and review is greatly simplified by following the > steps described in "Laszlo's unkempt guide": > https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers > but there are a lo

Re: [edk2-devel] [RFC PATCH 1/2] BaseTools: add centralized location for git config files

2019-06-03 Thread Leif Lindholm
On Mon, Jun 03, 2019 at 02:43:23PM +0200, Laszlo Ersek wrote: > On 05/30/19 17:59, Leif Lindholm wrote: > > Before adding the git environment initialization script, add the > > following files that will be pointed to after running said script: > > > > - BaseTools/Conf/diff.order > > - BaseTools/Co

Re: [edk2-devel] [RFC PATCH 2/2] BaseTools: add script to configure local git options

2019-06-03 Thread Leif Lindholm
On Mon, Jun 03, 2019 at 02:56:42PM +0200, Laszlo Ersek wrote: > On 05/30/19 17:59, Leif Lindholm wrote: > > Patch contribution and review is greatly simplified by following the > > steps described in "Laszlo's unkempt guide": > > https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkemp

Re: [edk2-devel] [PATCH 0/2] Fix GP fault issue and enhance code about ProcTrace

2019-06-03 Thread Zeng, Star
Laszlo, > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Monday, June 3, 2019 8:03 PM > To: Zeng, Star > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Chandana C ; Li, Kevin Y > ; edk2-devel-groups-io > Subject: Re: [PATCH 0/2] Fix GP fault issue and enhance code about

Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg: Fix build problem with XCODE

2019-06-03 Thread Wang, Jian J
Reviewed-by: Jian J Wang > -Original Message- > From: Lu, XiaoyuX > Sent: Monday, June 03, 2019 5:53 PM > To: devel@edk2.groups.io > Cc: Lu, XiaoyuX ; Wang, Jian J ; > Ye, Ting > Subject: [PATCH v1 1/1] CryptoPkg: Fix build problem with XCODE > > REF: https://bugzilla.tianocore.org/show

Re: [edk2-devel] [PATCH 0/4] Define SERIAL_DXE_FILE_GUID only once

2019-06-03 Thread Michael D Kinney
Laszlo, We can keep compatibility. The value of the GUID in the DEC/Include files can be the current SerialDxe FFS FILE_GUID. Then the device path can use the GUID defined in the DEC/Include file and it will have the same value as today. In the future, the SerialDxe FILE_GUID can be changed as

Re: [edk2-devel] [PATCH 1/1] FmpDevicePkg: Add TimerLib to DSC file

2019-06-03 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io > [mailto:devel@edk2.groups.io] On Behalf Of Xiaoyu Lu > Sent: Monday, June 3, 2019 5:34 AM > To: devel@edk2.groups.io > Cc: Lu, XiaoyuX ; Wang, Jian J > ; Gao, Liming > ; Kinney, Michael D > > Subject: [edk2

Re: [edk2-devel] [PATCH 1/1] FmpDevicePkg: Add TimerLib to DSC file

2019-06-03 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Xiaoyu > Lu > Sent: Monday, June 3, 2019 8:34 PM > To: devel@edk2.groups.io > Cc: Lu, XiaoyuX ; Wang, Jian J ; > Gao, Liming ; Kinney, Michael D > > Subject: [edk2-devel

Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Decrease NumApsExecuting only for ApInitConfig

2019-06-03 Thread Laszlo Ersek
Hi Ray, On 05/31/19 11:42, Ni, Ray wrote: > The patch fixes the bug that the memory under 1MB is modified by > firmware in S3 boot. > > Root cause is a racing condition in MpInitLib: > 1. BSP: WakeUpByInitSipiSipi is set by NotifyOnS3SmmInitDonePpi() > 2. BSP: WakeUpAP() wakes all APs to run cert

[edk2-devel] [PATCH v3] MdeModulePkg/CapsulePei: Optimize the CapsulePei

2019-06-03 Thread Gao, Zhichao
From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1853 Change form Mu repo: https://github.com/microsoft/mu_basecore/blob/release/201903/ MdeModulePkg/Universal/CapsulePei/UefiCapsule.c#L801 Minor changes on it: 1. Change the AreCapsulesStaged: directly return the BOOLEAN

Re: [edk2-devel] [RFC PATCH 1/2] BaseTools: add centralized location for git config files

2019-06-03 Thread Laszlo Ersek
On 06/03/19 15:02, Leif Lindholm wrote: > On Mon, Jun 03, 2019 at 02:43:23PM +0200, Laszlo Ersek wrote: >> On 05/30/19 17:59, Leif Lindholm wrote: >>> Before adding the git environment initialization script, add the >>> following files that will be pointed to after running said script: >>> >>> - Ba

[edk2-devel] [PATCH] CryptoPkg CLANG35: add -std=c99 to dodge OpenSSL C atomics issue

2019-06-03 Thread Ard Biesheuvel
Commit c51f8bae7cabe ("CryptoPkg: Fix possible build problem with Clang") added -std=c99 to the compiler command line of packages that incorporate parts of OpenSSL, to ensure that the new C atomics code used by OpenSSL for refcounting (which we don't care about) does not pull in system C library he

Re: [edk2-devel] [PATCH] CryptoPkg CLANG35: add -std=c99 to dodge OpenSSL C atomics issue

2019-06-03 Thread Wang, Jian J
Reviewed-by: Jian J Wang > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Tuesday, June 04, 2019 12:25 AM > To: devel@edk2.groups.io > Cc: leif.lindh...@linaro.org; ler...@redhat.com; Kinney, Michael D > ; Gao, Liming ; Ard > Biesheuvel ; Wang, Jia

Re: [edk2-devel] [PATCH] CryptoPkg CLANG35: add -std=c99 to dodge OpenSSL C atomics issue

2019-06-03 Thread Leif Lindholm
On Mon, Jun 03, 2019 at 06:24:42PM +0200, Ard Biesheuvel wrote: > Commit c51f8bae7cabe ("CryptoPkg: Fix possible build problem with > Clang") added -std=c99 to the compiler command line of packages > that incorporate parts of OpenSSL, to ensure that the new C atomics > code used by OpenSSL for refc

Re: [edk2-devel] [PATCH 0/4] Define SERIAL_DXE_FILE_GUID only once

2019-06-03 Thread Laszlo Ersek
On 06/03/19 16:50, Kinney, Michael D wrote: > Laszlo, > > We can keep compatibility. > > The value of the GUID in the DEC/Include files can be the > current SerialDxe FFS FILE_GUID. Then the device path can > use the GUID defined in the DEC/Include file and it will > have the same value as today

Re: [edk2-devel] [PATCH] CryptoPkg CLANG35: add -std=c99 to dodge OpenSSL C atomics issue

2019-06-03 Thread Ard Biesheuvel
On Mon, 3 Jun 2019 at 18:32, Leif Lindholm wrote: > > On Mon, Jun 03, 2019 at 06:24:42PM +0200, Ard Biesheuvel wrote: > > Commit c51f8bae7cabe ("CryptoPkg: Fix possible build problem with > > Clang") added -std=c99 to the compiler command line of packages > > that incorporate parts of OpenSSL, to

Re: [edk2-devel] [PATCH v3] MdeModulePkg/CapsulePei: Optimize the CapsulePei

2019-06-03 Thread Leif Lindholm
On Mon, Jun 03, 2019 at 11:42:02PM +0800, Zhichao Gao wrote: > From: Bret Barkelew > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1853 > > Change form Mu repo: > https://github.com/microsoft/mu_basecore/blob/release/201903/ > MdeModulePkg/Universal/CapsulePei/UefiCapsule.c#L801 > > Min

[edk2-devel] [PATCH 1/2] KabylakeSiliconPkg: Support DefaultPolicyInit PPI.

2019-06-03 Thread Chiu, Chasel
From: "Chasel, Chiu" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1870 FSP in dispatch mode will produce DefaultPolicyInit PPI for boot loader to consume and install policy with default settings built-in by FSP. Boot loader then may patch policy with per-board settings and then install Po

[edk2-devel] [PATCH 0/2] Kabylake*Pkg: Support DefaultPolicyInit PPI.

2019-06-03 Thread Chiu, Chasel
FSP in dispatch mode will produce DefaultPolicyInit PPI for boot loader to consume and install policy with default settings built-in by FSP. Boot loader then may patch policy with per-board settings and then install PolicyReady PPI to start silicon initialization (policy consumer code) 0001-Kabyla

[edk2-devel] [PATCH 2/2] KabylakeOpenBoardPkg: Support DefaultPolicyInit PPI.

2019-06-03 Thread Chiu, Chasel
From: "Chasel, Chiu" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1870 Basing on FSP modes the Fsp*WrapperPeim may not have dependency on PolicyPpi, instead it should report FSP-M or FPS-S FV to dispatcher so FSP can produce DefaultPolicyInit PPIs. A PEI policy update library was created

Re: [edk2-devel] Hard Feature Freeze starts now for edk2-stable201905

2019-06-03 Thread Laszlo Ersek
On 06/03/19 14:38, Liming Gao wrote: > Laszlo: > I agree this is a real functional bug fix. I am OK to add it for > edk2-stable201905. Thanks! Laszlo >> -Original Message- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Laszlo >> Ersek >> Sent: Monday, June 3,

Re: [edk2-devel] [PATCH 0/4] Define SERIAL_DXE_FILE_GUID only once

2019-06-03 Thread Michael D Kinney
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] > On Behalf Of Laszlo Ersek > Sent: Monday, June 3, 2019 9:32 AM > To: Kinney, Michael D ; > devel@edk2.groups.io; anthony.per...@citrix.com > Cc: Wang, Jian J ; Ni, Ray > ; Ard Biesheuvel > ; Zeng, Star > ; Wu,

Re: [edk2-devel] [PATCH for-edk2-stable201905 0/6] work around a QEMU issue triggered by the original TianoCore#1814 fix

2019-06-03 Thread Laszlo Ersek
On 05/29/19 17:12, Laszlo Ersek wrote: > Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1859 > Repo: https://github.com/lersek/edk2.git > Branch: exbar_mtrr_bz_1859 > > The fix (commit range 3b7a897cd8e3..39b9a5ffe661) for > is

Re: [edk2-devel] [PATCH 1/1] FmpDevicePkg: Add TimerLib to DSC file

2019-06-03 Thread Liming Gao
Push @4ff8b6b1d8b74c72fecc7bedb4d791d537eb0310 >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Liming Gao >Sent: Monday, June 03, 2019 10:55 PM >To: devel@edk2.groups.io; Lu, XiaoyuX >Cc: Wang, Jian J ; Kinney, Michael D > >Subject: Re: [edk2-de

Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg: Fix build problem with XCODE

2019-06-03 Thread Liming Gao
Push @466c66341a996fd05f5aae7f084fb344d89fd60f >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Wang, Jian J >Sent: Monday, June 03, 2019 10:46 PM >To: Lu, XiaoyuX ; devel@edk2.groups.io >Cc: Ye, Ting >Subject: Re: [edk2-devel] [PATCH v1 1/1] Cry

[edk2-devel] [PATCH 1/2] Intel/MinPlatformPkg: Support DXE drivers in FSP 2.1.

2019-06-03 Thread Chiu, Chasel
From: "Chasel, Chiu" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1873 In dispatch mode FSP-S contains DXE drivers so needs to BuildFvHob for DXE dispatcher to dispatch this FV. Test: FSP API mode still boots successfully without impact. Cc: Michael Kubacki Cc: Nate DeSimone Cc: Limin

[edk2-devel] [PATCH 0/2] Support DXE drivers in FSP 2.1.

2019-06-03 Thread Chiu, Chasel
In dispatch mode FSP-S contains DXE drivers to be dispatched by boot loader dispatcher. 0001-Intel/MinPlatformPkg: Report FSP-S to DXE dispatcher 0002-KabylakeOpenBoardPkg: Skip FspWrapperNotifyDxe Cc: Michael Kubacki Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Chasel Chiu Chasel, Chiu (

[edk2-devel] [PATCH 2/2] KabylakeOpenBoardPkg: Support DXE drivers in FSP 2.1.

2019-06-03 Thread Chiu, Chasel
From: "Chasel, Chiu" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1873 In dispatch mode since FSP DXE drivers will be dispatched directly by boot loader dispatcher, FspWrapperNotifyDxe driver should be skipped. Test: FSP API mode still boots successfully without impact. Cc: Michael Kuba

[edk2-devel] [PATCH V3 2/2] MdeModulePkg/BdsDxe: Use a pcd to control PlatformRecovery

2019-06-03 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1678 Use the PcdPlatformRecoverySupport to control the function of platform recovery in BDS. First, set the variable's ("OsIndicationsSupported") EFI_OS_INDICATIONS_START_PLATFORM_RECOVERY bit base on the pcd. It would affect the variable "OsIndi

[edk2-devel] [PATCH V3 0/2] Use a pcd to control Platform Recovery behavior

2019-06-03 Thread Gao, Zhichao
V1: Add a pcd PcdPlatformRecoverySupport to control the variable PlatformRecovery and the EFI_OS_INDICATIONS_START_PLATFORM_RECOVERY bit of variable "OsIndicationsSupported". V2: While PcdPlatformRecoverySupport is FALSE, do not set a PlatformRecovery Variable. But remain boot from a defau

[edk2-devel] [PATCH V3 1/2] MdeModulePkg: Add a pcd to set the OS indications bit

2019-06-03 Thread Gao, Zhichao
From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1678 Add a pcd PcdPlatformRecoverySupport to conditionally set an OS indications bit and set the 'PlatformRecovery' variable. This pcd would also control whether the BDS support platform recovery or not. Cc: Jian J Wang

[edk2-devel] [PATCH 0/2] Switch to FSP Dispatch mode.

2019-06-03 Thread Chiu, Chasel
KabylakeOpenBoardPkg is switched to build Dispatch mode as default. For building API mode: "py -2 build_bios.py --platform KabylakeRvp3 --fspapi" 0001-Platform/Intel: Separate FspBinPkg support. 0002-KabylakeOpenBoardPkg: Switch to dispatch mode. Cc: Michael Kubacki Cc: Nate DeSimone Cc: Liming

[edk2-devel] [PATCH 2/2] KabylakeOpenBoardPkg: Switch to FSP Dispatch mode.

2019-06-03 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1874 Now KabylakeOpenBoardPkg is building in FSP Dispatch mode as default. Test: Both FSP API and Dispatch mode can boot to Windows. Cc: Michael Kubacki Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Chasel Chiu --- Platform/Intel/K

[edk2-devel] [PATCH 1/2] Platform/Intel: Switch to FSP Dispatch mode.

2019-06-03 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1874 Build configuration is updated to support different *FspBinPkg between FSP wrapper API and Dispatch modes. Default will be Dispatch mode and to build FSP wrapper for API mode: "py -2 build_bios.py --platform KabylakeRvp3 --fspapi" Cc: Mich

Re: [edk2-devel] [PATCH V3 2/2] MdeModulePkg/BdsDxe: Use a pcd to control PlatformRecovery

2019-06-03 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Gao, Zhichao > Sent: Tuesday, June 4, 2019 9:05 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Ni, Ray ; Zeng, Star ; Gao, Liming > ; Sean Brogan ; > Michae

Re: [edk2-devel] [PATCH V3 1/2] MdeModulePkg: Add a pcd to set the OS indications bit

2019-06-03 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Gao, Zhichao > Sent: Tuesday, June 4, 2019 9:05 AM > To: devel@edk2.groups.io > Cc: Bret Barkelew ; Wang, Jian J > ; Wu, Hao A ; Ni, Ray > ; Zeng, Star ; Gao, Liming > ; Sean