On Mon, Jun 03, 2019 at 11:42:02PM +0800, Zhichao Gao wrote: > From: Bret Barkelew <bret.barke...@microsoft.com> > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1853 > > Change form Mu repo: > https://github.com/microsoft/mu_basecore/blob/release/201903/ > MdeModulePkg/Universal/CapsulePei/UefiCapsule.c#L801 > > Minor changes on it: > 1. Change the AreCapsulesStaged: directly return the BOOLEAN result. > 2. In GetScatterGatherHeadEntries: using allocate memory instead of > the fixed template array. While the SG list is larger then the > pre-allocate buffer, enlarge the buffer. > > Optimize some function in CapsulePei to make it easier > to maintain. > 1. Separate the capsule check function form GetCapsuleDescriptors. > The original logic is unclear. > 2. Avoid querying the capsule variable twice. First time to count > the number of SG list and allocate a buffer to save SG list data. > Second time to save the SG list data to the buffer. Modified: > Using a template buffer to save the SG list data. After query, > we get the number of SG list, then allocate memory and copy > data form template buffer to the allocated memory. > 3. Using MemoryAllocationLib instead of memory function in Pei > services.
OK, sounds to me like a subsantial modification. This is not ideal to do as part of moving a patch from one repository to another. Usually, the kind of modifications done at that point are just things like "rebase to latest master", "adjust to updated API".. Could you import the original patch in its original form as a separate patch and then provide your changes on top of that in the subsequent patch? This also removes any ambiguity w.r.t. copyright. Best Regards, Leif -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41834): https://edk2.groups.io/g/devel/message/41834 Mute This Topic: https://groups.io/mt/31911796/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
