Re: [edk2-devel] [Patch v3 0/3] [edk2-platform] Add modules to BoardModulePkg.

2019-05-28 Thread Dong, Eric
Liming, Thanks for your comments. Will update them when I push the changes. Thanks, Eric > -Original Message- > From: Gao, Liming > Sent: Wednesday, May 29, 2019 1:23 PM > To: devel@edk2.groups.io; Dong, Eric > Subject: RE: [edk2-devel] [Patch v3 0/3] [edk2-platform]

Re: [edk2-devel] [Patch v3 0/3] [edk2-platform] Add modules to BoardModulePkg.

2019-05-28 Thread Liming Gao
Eric: 1. Don't need to include version change message in the commit message. Change version is in cover letter only. 2. BoardModulePkg DEC/DSC still describe AdvancedFeaturePkg. Please fix them. With those changes, Reviewed-by: Liming Gao Thanks Liming >-Original Message- >From: