Liming, Thanks for your comments. Will update them when I push the changes.
Thanks, Eric > -----Original Message----- > From: Gao, Liming > Sent: Wednesday, May 29, 2019 1:23 PM > To: devel@edk2.groups.io; Dong, Eric <eric.d...@intel.com> > Subject: RE: [edk2-devel] [Patch v3 0/3] [edk2-platform] Add modules to > BoardModulePkg. > > Eric: > 1. Don't need to include version change message in the commit message. > Change version is in cover letter only. > 2. BoardModulePkg DEC/DSC still describe AdvancedFeaturePkg. Please fix > them. > > With those changes, Reviewed-by: Liming Gao <liming....@intel.com> > > Thanks > Liming > >-----Original Message----- > >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > >Dong, Eric > >Sent: Tuesday, May 28, 2019 4:12 PM > >To: devel@edk2.groups.io > >Subject: [edk2-devel] [Patch v3 0/3] [edk2-platform] Add modules to > >BoardModulePkg. > > > >V3 change: > >1. Fix file path typo. > > > >V2 change: > >1. Add platform DSC file to enable build for this package. > >2. Add BZ link for the related changes. > > > >V1 change: > >Add new package BoardModulePkg in Platform/Intel folder. This folder > >used to keep the board generic modules, such as Cmos, BiosId. > > > >Add Cmos and BiosId related modules to BoardModulePkg. > > > > > >Eric Dong (3): > > Maintainers.txt: Add BoardModulePkg in Platform/Intel/ folder. > > Platform/Intel: Add Cmos related modules to BoardModulePkg > > Platform/Intel/BoardModulePkg: Add BiosId Module. > > > > Maintainers.txt | 4 + > > .../Intel/BoardModulePkg/BoardModulePkg.dec | 38 ++ > > .../BoardModulePkg/Include/Guid/BiosId.h | 59 +++ > > .../Include/Library/BiosIdLib.h | 57 ++ > > .../Include/Library/CmosAccessLib.h | 106 ++++ > > .../Include/Library/PlatformCmosAccessLib.h | 68 +++ > > .../Library/BiosIdLib/DxeBiosIdLib.c | 175 +++++++ > > .../Library/BiosIdLib/DxeBiosIdLib.inf | 42 ++ > > .../Library/BiosIdLib/PeiBiosIdLib.c | 191 +++++++ > > .../Library/BiosIdLib/PeiBiosIdLib.inf | 42 ++ > > .../Library/CmosAccessLib/CmosAccessLib.c | 486 ++++++++++++++++++ > > .../Library/CmosAccessLib/CmosAccessLib.inf | 28 + > > .../CmosAccessLib/CmosAccessLibInternal.h | 35 ++ > > .../PlatformCmosAccessLibNull.c | 39 ++ > > .../PlatformCmosAccessLibNull.inf | 23 + > > 15 files changed, 1393 insertions(+) > > create mode 100644 > Platform/Intel/BoardModulePkg/BoardModulePkg.dec > > create mode 100644 > Platform/Intel/BoardModulePkg/Include/Guid/BiosId.h > > create mode 100644 > >Platform/Intel/BoardModulePkg/Include/Library/BiosIdLib.h > > create mode 100644 > >Platform/Intel/BoardModulePkg/Include/Library/CmosAccessLib.h > > create mode 100644 > >Platform/Intel/BoardModulePkg/Include/Library/PlatformCmosAccessLib.h > > create mode 100644 > >Platform/Intel/BoardModulePkg/Library/BiosIdLib/DxeBiosIdLib.c > > create mode 100644 > >Platform/Intel/BoardModulePkg/Library/BiosIdLib/DxeBiosIdLib.inf > > create mode 100644 > >Platform/Intel/BoardModulePkg/Library/BiosIdLib/PeiBiosIdLib.c > > create mode 100644 > >Platform/Intel/BoardModulePkg/Library/BiosIdLib/PeiBiosIdLib.inf > > create mode 100644 > >Platform/Intel/BoardModulePkg/Library/CmosAccessLib/CmosAccessLib.c > > create mode 100644 > >Platform/Intel/BoardModulePkg/Library/CmosAccessLib/CmosAccessLib.inf > > create mode 100644 > >Platform/Intel/BoardModulePkg/Library/CmosAccessLib/CmosAccessLibInt > er > >nal.h > > create mode 100644 > >Platform/Intel/BoardModulePkg/Library/PlatformCmosAccessLibNull/Platf > or > >mCmosAccessLibNull.c > > create mode 100644 > >Platform/Intel/BoardModulePkg/Library/PlatformCmosAccessLibNull/Platf > or > >mCmosAccessLibNull.inf > > > >-- > >2.21.0.windows.1 > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41569): https://edk2.groups.io/g/devel/message/41569 Mute This Topic: https://groups.io/mt/31819524/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-