Re: [edk2-devel] [PATCH v1 00/29] Enable LoongArch virtual machine in edk2

2023-11-03 Thread maobibo
On 2023/11/3 下午4:09, Chao Li wrote: Hi Bibo, Yes, you are right, MpInitLib is most used on the physical machines, but in LoongArch, this library is a public library, so it is the minimum requirement that it can worke on physical machines and virtual machines. This library has been tested o

Re: [edk2-devel] [PATCH v1 00/29] Enable LoongArch virtual machine in edk2

2023-11-03 Thread Chao Li
Hi Bibo, Yes, you are right, MpInitLib is most used on the physical machines, but in LoongArch, this library is a public library, so it is the minimum requirement that it can worke on physical machines and virtual machines. This library has been tested on the actual and virtual machines to en

Re: [edk2-devel] [PATCH v1 00/29] Enable LoongArch virtual machine in edk2

2023-11-03 Thread maobibo
On 2023/11/3 下午3:08, Chao Li wrote: Hi Ray, Thanks for review. I think the MpInitLib is necessary, because this library will serve PEI and DEX phases. In LoongArch, the MP initialization function will be called first in the PEI phase. It will wake up all of AP, collect accurate online c

Re: [edk2-devel] [PATCH v1 00/29] Enable LoongArch virtual machine in edk2

2023-11-03 Thread Laszlo Ersek
On 11/3/23 08:32, Chao Li wrote: > Hi Laszlo, > > Sorry, the reason of some mail is not under cover letter is found, I > will fix it at the V2. > > I don't think the code is **duplicated** since most code is architecture > related, and maybe some code is referenced from others ARCH. As  the > cov

Re: [edk2-devel] [PATCH v1 00/29] Enable LoongArch virtual machine in edk2

2023-11-03 Thread Chao Li
Hi Laszlo, Sorry, the reason of some mail is not under cover letter is found, I will fix it at the V2. I don't think the code is **duplicated** since most code is architecture related, and maybe some code is referenced from others ARCH. As  the cover letter saied, most code is distributed in

Re: [edk2-devel] [PATCH v1 00/29] Enable LoongArch virtual machine in edk2

2023-11-03 Thread Chao Li
Hi Ray, Thanks for review. I think the MpInitLib is necessary, because this library will serve PEI and DEX phases. In LoongArch, the MP initialization function will be  called first in the PEI phase. It will wake up all of AP, collect accurate online cores, and all APs will fill in their sel

Re: [edk2-devel] [PATCH v1 00/29] Enable LoongArch virtual machine in edk2

2023-11-03 Thread Laszlo Ersek
On 11/3/23 02:03, Chao Li wrote: > This patch set will enable LoongArch virtual machine in edk2, the new > LoongArch virtual machine is located in OvmfPkg/LoongArchVirt/, it is a > generic platform that dose not require any actual hardware. > > Patch1-Patch14: Submit the common library and driver

Re: [edk2-devel] [PATCH v1 00/29] Enable LoongArch virtual machine in edk2

2023-11-02 Thread Ni, Ray
Chao, MpInitLib is to avoid code duplication between CpuMpPeim and CpuDxe. If you only need MP protocol but not MP PPI, do you still need to add MpInitLib? Can MpInitLib code be included in CpuDxe folder? Thanks, Ray From: Chao Li Sent: Friday, November 3, 2023 9: