Hi Laszlo,
Sorry, the reason of some mail is not under cover letter is found, I
will fix it at the V2.
I don't think the code is **duplicated** since most code is architecture
related, and maybe some code is referenced from others ARCH. As the
cover letter saied, most code is distributed in MdePkg, UefiCpuPkg,
OvmfPkg. MdePkg is added some help functions for LoongArch. UefCpuPkg is
added CpuTimerLib, CpuExceptionLib, CpuMmuLib, MpInitLib, CpuDxe. Each
library and driver is not small. OvmfPkg adds the private code for
LoongArch QEMU virtual machine instances, it override some architecture
related library that cannot use the publice libraries, mostly for the
PEI phase.
Thanks,
Chao
在 2023/11/3 15:07, Laszlo Ersek 写道:
On 11/3/23 02:03, Chao Li wrote:
This patch set will enable LoongArch virtual machine in edk2, the new
LoongArch virtual machine is located in OvmfPkg/LoongArchVirt/, it is a
generic platform that dose not require any actual hardware.
Patch1-Patch14: Submit the common library and driver for LoongArch
virtual machine and real hardware. Such as base help functions,
exception handel, MMU library, multiprocessor library etc.
Patch15-Patch16: Add PrePiCpuIoSize for LoongArch64. and move ArmVirtPkg
two PCDs into OvmfPkg for easier use by other architectures.
Patch17-Patch29: LoongArch virtual machine private code, include SEC and
PEI phase code, some library and drivers.
Modfied modues: MdePkg, UefiCpuPkg, EmbeddedPkg, ArmVirtPkg, OvmfPkg.
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=4584
[...]
127 files changed, 18478 insertions(+), 84 deletions(-)
18478 lines seem overkill... Probably too much code added / duplicated
under UefiCpuPkg, as Ray says.
Also:
- Please make sure you post the patches with the "sendemail.thread" git
config item set to "true". "BaseTools/Scripts/SetupGit.py" takes care of
that. Otherwise, just as it has now happened, your patches are not
threaded under the cover letter; they fly apart as independent messages.
- Whenever you post a (new or initial) version of a patch set, please
link the URL of the cover letter (from the mailing list archive) into
the Bugzilla ticket, in a new comment.
Thanks
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110613): https://edk2.groups.io/g/devel/message/110613
Mute This Topic: https://groups.io/mt/102355705/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
