Re: [edk2-devel] [PATCH v1 0/8] Remove redundant forward declarations in acpiview

2019-07-18 Thread Gao, Zhichao
I am reviewing your previous patch "Add security checks in the Acpiview table parsers". That takes times and I didn't finish reviewing them yet. You do a pretty good separation. That makes the review more easier. I would give some comments on your previous one 10/10 patches to help your further w

Re: [edk2-devel] [PATCH v1 0/8] Remove redundant forward declarations in acpiview

2019-07-18 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey Thanks -Jaben > -Original Message- > From: Krzysztof Koch [mailto:krzysztof.k...@arm.com] > Sent: Thursday, July 18, 2019 3:05 AM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > Gao, Zhichao ; sami.muja...@arm.com; > matteo.carl...@arm.com; n...@arm

Re: [edk2-devel] [PATCH v1 0/8] Remove redundant forward declarations in acpiview

2019-07-18 Thread Sami Mujawar
Reviewed-by: Sami Mujawar -Original Message- From: Krzysztof Koch Sent: 18 July 2019 11:05 AM To: devel@edk2.groups.io Cc: jaben.car...@intel.com; ray...@intel.com; zhichao@intel.com; Sami Mujawar ; Matteo Carlini ; nd Subject: [PATCH v1 0/8] Remove redundant forward declaration