Reviewed-by: Jaben Carsey <jaben.car...@intel.com> Thanks -Jaben
> -----Original Message----- > From: Krzysztof Koch [mailto:krzysztof.k...@arm.com] > Sent: Thursday, July 18, 2019 3:05 AM > To: devel@edk2.groups.io > Cc: Carsey, Jaben <jaben.car...@intel.com>; Ni, Ray <ray...@intel.com>; > Gao, Zhichao <zhichao....@intel.com>; sami.muja...@arm.com; > matteo.carl...@arm.com; n...@arm.com > Subject: [PATCH v1 0/8] Remove redundant forward declarations in acpiview > > This patch series removes forward static function declarations in the > acpiview table parsers. After repositioning blocks of code, these forward > declarations are no longer needed and they increase the code size. > > What is more, some of the existing ACPI table parsers don't have these > duplicate declarations, so this set of patches makes the code structure > consistent across all acpiview parsers. > > Changes can be seen at: > https://github.com/KrzysztofKoch1/edk2/tree/612_remove_forward_decl_ > v1 > > Krzysztof Koch (8): > ShellPkg: acpiview: RSDP: Remove redundant forward declarations > ShellPkg: acpiview: FADT: Remove redundant forward declarations > ShellPkg: acpiview: SPCR: Remove redundant forward declaration > ShellPkg: acpiview: SRAT: Remove redundant forward declarations > ShellPkg: acpiview: MADT: Remove redundant forward declarations > ShellPkg: acpiview: IORT: Remove redundant forward declarations > ShellPkg: acpiview: GTDT: Remove redundant forward declarations > ShellPkg: acpiview: DBG2: Remove redundant forward declarations > > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2Parser.c > | 62 +++------- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c > | 113 ++++++------------- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c > | 91 ++++++--------- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c | > 58 +++------- > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser. > c | 118 ++++++++------------ > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rsdp/RsdpParser.c > | 116 +++++++------------ > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Spcr/SpcrParser.c > | 98 ++++++---------- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c | > 64 +++-------- > 8 files changed, 236 insertions(+), 484 deletions(-) > > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#43945): https://edk2.groups.io/g/devel/message/43945 Mute This Topic: https://groups.io/mt/32513487/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
