Re: [edk2-devel] [PATCH v1 0/3] EmbeddedPkg: Enable CI

2022-09-23 Thread Michael D Kinney
Of Ard Biesheuvel > Sent: Friday, September 23, 2022 4:47 AM > To: Michael Kubacki > Cc: Kinney, Michael D ; devel@edk2.groups.io; > Leif Lindholm ; Ard Biesheuvel > ; Abner Chang ; Daniel > Schaefer > Subject: Re: [edk2-devel] [PATCH v1 0/3] EmbeddedPkg: Enable CI > > On Fr

Re: [edk2-devel] [PATCH v1 0/3] EmbeddedPkg: Enable CI

2022-09-23 Thread Ard Biesheuvel
Biesheuvel > >> Sent: Thursday, September 15, 2022 2:03 PM > >> To: Kinney, Michael D > >> Cc: Michael Kubacki ; devel@edk2.groups.io; > >> Leif Lindholm ; Ard > >> Biesheuvel ; Abner Chang ; > >> Daniel Schaefer > >> Subject: R

Re: [edk2-devel] [PATCH v1 0/3] EmbeddedPkg: Enable CI

2022-09-15 Thread Michael D Kinney
; To: Kinney, Michael D > Cc: Michael Kubacki ; devel@edk2.groups.io; > Leif Lindholm ; Ard > Biesheuvel ; Abner Chang ; > Daniel Schaefer > Subject: Re: [edk2-devel] [PATCH v1 0/3] EmbeddedPkg: Enable CI > > On Thu, 15 Sept 2022 at 22:52, Kinney, Michael D > wrote: >

Re: [edk2-devel] [PATCH v1 0/3] EmbeddedPkg: Enable CI

2022-09-15 Thread Ard Biesheuvel
On Thu, 15 Sept 2022 at 22:52, Kinney, Michael D wrote: > > Ard, > > Why would you want to do that? The whole point of CI is to establish a > minimum quality level for all code in the project. > > They can be disabled with updates to the YAML file. Checks can be disabled > completely and may o

Re: [edk2-devel] [PATCH v1 0/3] EmbeddedPkg: Enable CI

2022-09-15 Thread Michael D Kinney
age- > From: Ard Biesheuvel > Sent: Thursday, September 15, 2022 1:47 PM > To: Michael Kubacki > Cc: devel@edk2.groups.io; Leif Lindholm ; Ard > Biesheuvel ; Abner Chang > ; Daniel Schaefer ; Kinney, > Michael D > Subject: Re: [edk2-devel] [PATCH v1 0/3] EmbeddedPkg

Re: [edk2-devel] [PATCH v1 0/3] EmbeddedPkg: Enable CI

2022-09-15 Thread Ard Biesheuvel
On Thu, 15 Sept 2022 at 21:46, Michael Kubacki wrote: > > Hi Ard, > > I haven't seen any action items for the v1 series. > > Can you please check the series again and let me know if you have any > further concerns? > The only thing I'd like to know is how I can override the CI and merge a PR that

Re: [edk2-devel] [PATCH v1 0/3] EmbeddedPkg: Enable CI

2022-09-15 Thread Michael Kubacki
Hi Ard, I haven't seen any action items for the v1 series. Can you please check the series again and let me know if you have any further concerns? Thanks, Michael On 9/7/2022 11:16 AM, Ard Biesheuvel wrote: On Wed, 7 Sept 2022 at 17:00, Michael Kubacki wrote: When would you like to have

Re: [edk2-devel] [PATCH v1 0/3] EmbeddedPkg: Enable CI

2022-09-07 Thread Ard Biesheuvel
On Wed, 7 Sept 2022 at 17:00, Michael Kubacki wrote: > > When would you like to have that discussion? > > The Tianocore Tool, CI, Codebase meeting is every week. In that meeting > we've discussed getting all edk2 packages to at least run CI. > > https://github.com/tianocore/edk2/discussions/2614 >

Re: [edk2-devel] [PATCH v1 0/3] EmbeddedPkg: Enable CI

2022-09-07 Thread Michael Kubacki
When would you like to have that discussion? The Tianocore Tool, CI, Codebase meeting is every week. In that meeting we've discussed getting all edk2 packages to at least run CI. https://github.com/tianocore/edk2/discussions/2614 If you prefer to have it here, that's fine as well. On 9/7/202

Re: [edk2-devel] [PATCH v1 0/3] EmbeddedPkg: Enable CI

2022-09-07 Thread Ard Biesheuvel
On Wed, 7 Sept 2022 at 04:37, wrote: > > From: Michael Kubacki > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4046 > > Adds EmbeddedPkg to edk2 CI. > > Due to a number of build errors (some intentional) such as > 'BUILD_EPOCH' only being defined for GCC in > VirtualRealTimeClockLib.inf, t