Ray ; devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Chaganty, Rangasai V
>
> Subject: RE: [edk2-devel] [PATCH V3 0/8] Update SMBIOS 3.3.0
>
> Hi Ray,
>
> I have tried to convert all the magic number to the MACROs/enums. But
> during that work, many ma
er to enums?
Thanks,
Zhichao
> -Original Message-
> From: Ni, Ray
> Sent: Friday, November 8, 2019 11:25 AM
> To: devel@edk2.groups.io; Gao, Zhichao
> Cc: Kinney, Michael D ; Gao, Liming
> ; Chaganty, Rangasai V
>
> Subject: RE: [edk2-devel] [PATCH V3 0/8] Upd
Zhichao,
I took a look at the patch 5/8.
Given the value is already defined in MdePkg header file, can you please
update the implementation to avoid using magic number?
I suggest you do the code change in two parts: one patch to modify existing
magic numbers to use macros/enums defined in MdePkg,
