Hi Ray, I have tried to convert all the magic number to the MACROs/enums. But during that work, many magic numbers don't have the related MARCOs or enums. So can we just keep on reviewing this patch and then add a new BZ to add the missing enums to Smbios.h then convert all the magic number to enums?
Thanks, Zhichao > -----Original Message----- > From: Ni, Ray <ray...@intel.com> > Sent: Friday, November 8, 2019 11:25 AM > To: devel@edk2.groups.io; Gao, Zhichao <zhichao....@intel.com> > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Gao, Liming > <liming....@intel.com>; Chaganty, Rangasai V > <rangasai.v.chaga...@intel.com> > Subject: RE: [edk2-devel] [PATCH V3 0/8] Update SMBIOS 3.3.0 > > Zhichao, > I took a look at the patch 5/8. > Given the value is already defined in MdePkg header file, can you please > update > the implementation to avoid using magic number? > > I suggest you do the code change in two parts: one patch to modify existing > magic numbers to use macros/enums defined in MdePkg, the other patch to add > new mappings without using magic numbers. > > I didn't check the other patches after 5/8. If there are magic numbers as > well, > can you please update them as well? > > Thanks, > Ray > > -----Original Message----- > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Gao, > > Zhichao > > Sent: Thursday, November 7, 2019 8:52 AM > > To: devel@edk2.groups.io > > Cc: Kinney, Michael D <michael.d.kin...@intel.com>; Gao, Liming > > <liming....@intel.com>; Ni, Ray <ray...@intel.com>; Chaganty, Rangasai > > V <rangasai.v.chaga...@intel.com> > > Subject: [edk2-devel] [PATCH V3 0/8] Update SMBIOS 3.3.0 > > > > The following changes were made to version 3.2.0 of the document to > > produce this > > version: > > System Slots (Type 9): > > Add PCI Express Gen 4 values > > Clarify bus number usage for PCI Express Memory Device (Type 17): > > Add new memory device type value (HBM) and new form factor value > > (Die) Update the string for Intel persistent memory Various: > > Add support for RISC-V processors, add structure type 44 (processor- > > additional information) add support for CXL Flexbus > > > > V2: > > Add the new definition to MdePkg/Smbios.h. > > > > V3: > > Avoid change the enum name to casue the incompatible issue. > > Add the comment instead change the enum define name. > > > > Notes: > > Clarify bus number usage for PCI Express - Update the spec no code > > change requirement Add support for RISC-V processors, add structure > > type 44 (processor-additional information) - Already done at > > https://bugzilla.tianocore.org/show_bug.cgi?id=2202 > > > > Cc: Michael D Kinney <michael.d.kin...@intel.com> > > Cc: Liming Gao <liming....@intel.com> > > Cc: Ray Ni <ray...@intel.com> > > Cc: Sai Chaganty <rangasai.v.chaga...@intel.com> > > Signed-off-by: Zhichao Gao <zhichao....@intel.com> > > > > Zhichao Gao (8): > > MdePkg/Smbios.h: SMBIOS 3.3.0 add PCI gen4 values for type 9 > > MdePkg/Smbios.h: SMBIOS 3.3.0 add support for CXL Flexbus > > MdePkg/Smbios.h: SMBIOS 3.3.0 Add value HBM and Die for type 17 > > MdePkg/Smbios.h: SMBIOS 3.3.0 Update Intel Persistent Memory string > > ShellPkg/SmbiosView: SMBIOS 3.3.0 add PCI gen4 values for type 9 > > ShellPkg/SmbiosView: SMBIOS 3.3.0 add support for CXL Flexbus > > ShellPkg/SmbiosView: SMBIOS 3.3.0 Add value HBM and Die for type 17 > > ShellPkg/SmbiosView: SMBIOS 3.3.0 Update "Intel persistent memory" > > > > MdePkg/Include/IndustryStandard/SmBios.h | 25 ++++++++--- > > .../SmbiosView/QueryTable.c | 48 > > +++++++++++++++++++++- > > 2 files changed, 66 insertions(+), 7 deletions(-) > > > > -- > > 2.16.2.windows.1 > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#50393): https://edk2.groups.io/g/devel/message/50393 Mute This Topic: https://groups.io/mt/44839633/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
