Re: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in MpInitLib

2020-02-28 Thread Duran, Leo
> > > > > -Original Message- > > From: Duran, Leo > > Sent: Friday, February 28, 2020 2:17 AM > > To: Ni, Ray ; Laszlo Ersek ; > > devel@edk2.groups.io; Wu, Hao A ; Fu, Siyuan > > > > Cc: Dong, Eric > > Subject: RE: [edk2-de

Re: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in MpInitLib

2020-02-28 Thread Duran, Leo
nts in the MpInitLib patch I just submitted) > > > -Original Message- > > From: Duran, Leo > > Sent: Thursday, February 27, 2020 1:52 AM > > To: Laszlo Ersek ; Ni, Ray ; > > devel@edk2.groups.io; Wu, Hao A ; Fu, Siyuan > > > > Cc: Dong, Eric &g

Re: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in MpInitLib

2020-02-27 Thread Ni, Ray
17 AM > To: Ni, Ray ; Laszlo Ersek ; > devel@edk2.groups.io; Wu, Hao A ; Fu, Siyuan > > Cc: Dong, Eric > Subject: RE: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in MpInitLib > > > > > -Original Message- > > From: Ni, Ray [mailto:ray...@inte

Re: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in MpInitLib

2020-02-26 Thread Ni, Ray
, Ray > -Original Message- > From: Duran, Leo > Sent: Thursday, February 27, 2020 1:52 AM > To: Laszlo Ersek ; Ni, Ray ; > devel@edk2.groups.io; Wu, Hao A > ; Fu, Siyuan > Cc: Dong, Eric > Subject: RE: [edk2-devel] [PATCH 0/2] UefiCpuPkg/

Re: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in MpInitLib

2020-02-26 Thread Duran, Leo
Ray ; > >> devel@edk2.groups.io; Wu, Hao A ; Fu, Siyuan > >> > >> Cc: Dong, Eric > >> Subject: Re: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in > >> MpInitLib > >> > >> On 02/26/20 16:46, Duran, Leo wrote: > >>> BT

Re: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in MpInitLib

2020-02-26 Thread Duran, Leo
; -Original Message- > From: Duran, Leo > Sent: Wednesday, February 26, 2020 11:40 AM > To: Laszlo Ersek ; Ni, Ray ; > devel@edk2.groups.io; Wu, Hao A ; Fu, Siyuan > > Cc: Dong, Eric > Subject: RE: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in > MpInitLib &

Re: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in MpInitLib

2020-02-26 Thread Duran, Leo
D > ; af...@apple.com > Subject: Re: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in > MpInitLib > > Hi Leo, > > On 02/26/20 16:11, Duran, Leo wrote: > > > > > >> -Original Message- > >> From: Gao, Liming [mailto:liming@intel.

Re: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in MpInitLib

2020-02-26 Thread Duran, Leo
> -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, February 26, 2020 11:21 AM > To: Duran, Leo ; Ni, Ray ; > devel@edk2.groups.io; Wu, Hao A ; Fu, Siyuan > > Cc: Dong, Eric > Subject: Re: [edk2-devel] [PATCH 0/2] UefiCp

Re: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in MpInitLib

2020-02-26 Thread Laszlo Ersek
> Cc: Dong, Eric >> Subject: Re: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in >> MpInitLib >> >> On 02/26/20 16:46, Duran, Leo wrote: >>> BTW, >>> >>> I also considered adding a flag to CPU_MP_DATA to make the usage of

Re: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in MpInitLib

2020-02-26 Thread Duran, Leo
D > ; af...@apple.com; Gao, Liming > > Subject: RE: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in > MpInitLib > > Leo: > Now, we enter into Hard Feature Freeze phase until edk2-stable202002 tag > is created at 2020-02-28. Only critical bug fix is still allowed.

Re: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in MpInitLib

2020-02-26 Thread Duran, Leo
sday, February 26, 2020 10:25 AM > To: Ni, Ray ; Laszlo Ersek ; > devel@edk2.groups.io; Wu, Hao A ; Fu, Siyuan > > Cc: Dong, Eric > Subject: RE: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in > MpInitLib > > > > > -Original Message- > > Fro

Re: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in MpInitLib

2020-02-26 Thread Duran, Leo
> -Original Message- > From: Ni, Ray [mailto:ray...@intel.com] > Sent: Wednesday, February 26, 2020 2:57 AM > To: Laszlo Ersek ; devel@edk2.groups.io; Duran, Leo > ; Wu, Hao A ; Fu, Siyuan > > Cc: Dong, Eric > Subject: RE: [edk2-devel] [PATCH 0/2] UefiCp

Re: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in MpInitLib

2020-02-26 Thread Laszlo Ersek
t;> ; Fu, Siyuan >> Cc: Dong, Eric ; l...@nuviainc.com; Kinney, Michael D >> ; af...@apple.com; Gao, Liming >> >> Subject: RE: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in >> MpInitLib >> >> Leo: >> Now, we enter into Hard Feature Free

Re: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in MpInitLib

2020-02-26 Thread Laszlo Ersek
On 02/26/20 16:46, Duran, Leo wrote: > BTW, > > I also considered adding a flag to CPU_MP_DATA to make the usage of > PlatformId a bit more explicit. > E.g., something like CpuMpData->CpuData[ProcessorNumber].IsValidPlatformId... > So the init code would look like this: > > // > // NOTE: Pl

Re: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in MpInitLib

2020-02-26 Thread Liming Gao
Subject: Re: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in MpInitLib > > Leo, > > > > BTW, reading the PlatformId MSR was already being done by > > > MicrocodeDetect(), > > > but it never affected AMD-based platforms as the flow never gets that > > &

Re: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in MpInitLib

2020-02-25 Thread Ni, Ray
Leo, > > BTW, reading the PlatformId MSR was already being done by MicrocodeDetect(), > > but it never affected AMD-based platforms as the flow never gets that far, > > since > > the Detect routine bails out early when it finds the size of the patch is > > zero. You are saying that PlatformId M

Re: [edk2-devel] [PATCH 0/2] UefiCpuPkg/Library: Fix bug in MpInitLib

2020-02-25 Thread Laszlo Ersek
Hi Leo, On 02/25/20 20:39, Leo Duran wrote: > This patch set fixes an issue introduced recently in MpInitLib, where we read > a PlatformId MSR that is not implemented on AMD processors. > > The proposed solution is to export the StandardSignatureIsAuthenticAMD > function > from LocalApicLib, so